[GitHub] [flink] RyanSkraba commented on a diff in pull request #23345: [FLINK-33010][table] GREATEST/LEAST should work with other functions as input

["RyanSkraba (via GitHub)" <gi...@apache.org>]

RyanSkraba commented on code in PR #23345:
URL: https://github.com/apache/flink/pull/23345#discussion_r1319870722


##########
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/codegen/calls/ScalarOperatorGens.scala:
##########
@@ -1369,11 +1369,12 @@ object ScalarOperatorGens {
       }
     }
 
-    val elementsCode = elements
+    val elementsCode = elements.zipWithIndex
       .map {
-        element =>
+        case (element, index) =>

Review Comment:
   Is index unused here?  Why was the zipWithIndex modification added?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org