You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Dariusz Nejbauer <d....@samsung.com> on 2013/12/04 17:09:29 UTC
Review Request 16002: [CLOUDSTACK-3932] EN: Truncation issue occurred in
secondary storage URL.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16002/
-----------------------------------------------------------
Review request for cloudstack.
Bugs: CLOUDSTACK-3932
https://issues.apache.org/jira/browse/CLOUDSTACK-3932
Repository: cloudstack-git
Description
-------
Wrong layout format in Secondary Storage QuickView: https://issues.apache.org/jira/secure/attachment/12594894/Truncation.jpg
Problem with layout occurs when quick-view displays details field from json data. In table body, row has the same class as the parent div.
Diffs
-----
ui/scripts/ui/widgets/detailView.js b0ebaa9b27947f3720e2068471361004bce02f7a
Diff: https://reviews.apache.org/r/16002/diff/
Testing
-------
Tested locally on:
1. DevCloud setup
2. Win 7-Chrome
3. Win 7-Firefox 22.0
4. Win 7-IE9
5. Ubuntu 12.04-Firefox 25.0.1
QuickView after change:
https://drive.google.com/file/d/0Bxp-rsbufeAzZEtlakxKTEwyaGM/edit?usp=sharing
Thanks,
Dariusz Nejbauer
Re: Review Request 16002: CLOUDSTACK-3932 UI: Truncation issue occurred in
secondary storage URL.
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16002/#review42190
-----------------------------------------------------------
Commit 259ce3b59c6a8633fc77a7eac88fbefd915107e2 in cloudstack's branch refs/heads/4.4-forward from Dariusz Nejbauer
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=259ce3b ]
CLOUDSTACK-3932: UI: Fix Truncation issue in secondary storage URL
Signed-off-by: Brian Federle <br...@citrix.com>
- ASF Subversion and Git Services
On Dec. 6, 2013, 5:08 p.m., Dariusz Nejbauer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16002/
> -----------------------------------------------------------
>
> (Updated Dec. 6, 2013, 5:08 p.m.)
>
>
> Review request for cloudstack, Brian Federle and Jessica Wang.
>
>
> Bugs: CLOUDSTACK-3932
> https://issues.apache.org/jira/browse/CLOUDSTACK-3932
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Wrong layout format in Secondary Storage QuickView: https://issues.apache.org/jira/secure/attachment/12594894/Truncation.jpg
>
> Problem with layout occurs when quick-view displays details field from json data. In table body, row has the same class as the parent div.
>
>
> Diffs
> -----
>
> ui/scripts/ui/widgets/detailView.js b0ebaa9b27947f3720e2068471361004bce02f7a
>
> Diff: https://reviews.apache.org/r/16002/diff/
>
>
> Testing
> -------
>
> Tested locally on:
> 1. DevCloud setup
> 2. Win 7-Chrome
> 3. Win 7-Firefox 22.0
> 4. Win 7-IE9
> 5. Ubuntu 12.04-Firefox 25.0.1
>
> QuickView after change:
> https://drive.google.com/file/d/0Bxp-rsbufeAzZEtlakxKTEwyaGM/edit?usp=sharing
>
>
> Thanks,
>
> Dariusz Nejbauer
>
>
Re: Review Request 16002: CLOUDSTACK-3932 UI: Truncation issue occurred in
secondary storage URL.
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16002/#review42191
-----------------------------------------------------------
Commit e28948ccc3f16a6c9c956fc773a26fcfbd58014b in cloudstack's branch refs/heads/4.4 from Dariusz Nejbauer
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=e28948c ]
CLOUDSTACK-3932: UI: Fix Truncation issue in secondary storage URL
Signed-off-by: Brian Federle <br...@citrix.com>
- ASF Subversion and Git Services
On Dec. 6, 2013, 5:08 p.m., Dariusz Nejbauer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16002/
> -----------------------------------------------------------
>
> (Updated Dec. 6, 2013, 5:08 p.m.)
>
>
> Review request for cloudstack, Brian Federle and Jessica Wang.
>
>
> Bugs: CLOUDSTACK-3932
> https://issues.apache.org/jira/browse/CLOUDSTACK-3932
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Wrong layout format in Secondary Storage QuickView: https://issues.apache.org/jira/secure/attachment/12594894/Truncation.jpg
>
> Problem with layout occurs when quick-view displays details field from json data. In table body, row has the same class as the parent div.
>
>
> Diffs
> -----
>
> ui/scripts/ui/widgets/detailView.js b0ebaa9b27947f3720e2068471361004bce02f7a
>
> Diff: https://reviews.apache.org/r/16002/diff/
>
>
> Testing
> -------
>
> Tested locally on:
> 1. DevCloud setup
> 2. Win 7-Chrome
> 3. Win 7-Firefox 22.0
> 4. Win 7-IE9
> 5. Ubuntu 12.04-Firefox 25.0.1
>
> QuickView after change:
> https://drive.google.com/file/d/0Bxp-rsbufeAzZEtlakxKTEwyaGM/edit?usp=sharing
>
>
> Thanks,
>
> Dariusz Nejbauer
>
>
Re: Review Request 16002: CLOUDSTACK-3932 UI: Truncation issue occurred in
secondary storage URL.
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16002/#review42189
-----------------------------------------------------------
Commit 41684505d6626bc77d422017b5d7956a90a047e6 in cloudstack's branch refs/heads/master from Dariusz Nejbauer
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=4168450 ]
CLOUDSTACK-3932: UI: Fix Truncation issue in secondary storage URL
Signed-off-by: Brian Federle <br...@citrix.com>
- ASF Subversion and Git Services
On Dec. 6, 2013, 5:08 p.m., Dariusz Nejbauer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16002/
> -----------------------------------------------------------
>
> (Updated Dec. 6, 2013, 5:08 p.m.)
>
>
> Review request for cloudstack, Brian Federle and Jessica Wang.
>
>
> Bugs: CLOUDSTACK-3932
> https://issues.apache.org/jira/browse/CLOUDSTACK-3932
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Wrong layout format in Secondary Storage QuickView: https://issues.apache.org/jira/secure/attachment/12594894/Truncation.jpg
>
> Problem with layout occurs when quick-view displays details field from json data. In table body, row has the same class as the parent div.
>
>
> Diffs
> -----
>
> ui/scripts/ui/widgets/detailView.js b0ebaa9b27947f3720e2068471361004bce02f7a
>
> Diff: https://reviews.apache.org/r/16002/diff/
>
>
> Testing
> -------
>
> Tested locally on:
> 1. DevCloud setup
> 2. Win 7-Chrome
> 3. Win 7-Firefox 22.0
> 4. Win 7-IE9
> 5. Ubuntu 12.04-Firefox 25.0.1
>
> QuickView after change:
> https://drive.google.com/file/d/0Bxp-rsbufeAzZEtlakxKTEwyaGM/edit?usp=sharing
>
>
> Thanks,
>
> Dariusz Nejbauer
>
>
Re: Review Request 16002: CLOUDSTACK-3932 UI: Truncation issue occurred in
secondary storage URL.
Posted by Brian Federle <br...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16002/#review42188
-----------------------------------------------------------
Ship it!
Ship It!
- Brian Federle
On Dec. 6, 2013, 5:08 p.m., Dariusz Nejbauer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16002/
> -----------------------------------------------------------
>
> (Updated Dec. 6, 2013, 5:08 p.m.)
>
>
> Review request for cloudstack, Brian Federle and Jessica Wang.
>
>
> Bugs: CLOUDSTACK-3932
> https://issues.apache.org/jira/browse/CLOUDSTACK-3932
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Wrong layout format in Secondary Storage QuickView: https://issues.apache.org/jira/secure/attachment/12594894/Truncation.jpg
>
> Problem with layout occurs when quick-view displays details field from json data. In table body, row has the same class as the parent div.
>
>
> Diffs
> -----
>
> ui/scripts/ui/widgets/detailView.js b0ebaa9b27947f3720e2068471361004bce02f7a
>
> Diff: https://reviews.apache.org/r/16002/diff/
>
>
> Testing
> -------
>
> Tested locally on:
> 1. DevCloud setup
> 2. Win 7-Chrome
> 3. Win 7-Firefox 22.0
> 4. Win 7-IE9
> 5. Ubuntu 12.04-Firefox 25.0.1
>
> QuickView after change:
> https://drive.google.com/file/d/0Bxp-rsbufeAzZEtlakxKTEwyaGM/edit?usp=sharing
>
>
> Thanks,
>
> Dariusz Nejbauer
>
>
Re: Review Request 16002: CLOUDSTACK-3932 UI: Truncation issue occurred in
secondary storage URL.
Posted by Dariusz Nejbauer <d....@samsung.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16002/
-----------------------------------------------------------
(Updated Dec. 6, 2013, 5:08 p.m.)
Review request for cloudstack, Brian Federle and Jessica Wang.
Summary (updated)
-----------------
CLOUDSTACK-3932 UI: Truncation issue occurred in secondary storage URL.
Bugs: CLOUDSTACK-3932
https://issues.apache.org/jira/browse/CLOUDSTACK-3932
Repository: cloudstack-git
Description
-------
Wrong layout format in Secondary Storage QuickView: https://issues.apache.org/jira/secure/attachment/12594894/Truncation.jpg
Problem with layout occurs when quick-view displays details field from json data. In table body, row has the same class as the parent div.
Diffs
-----
ui/scripts/ui/widgets/detailView.js b0ebaa9b27947f3720e2068471361004bce02f7a
Diff: https://reviews.apache.org/r/16002/diff/
Testing
-------
Tested locally on:
1. DevCloud setup
2. Win 7-Chrome
3. Win 7-Firefox 22.0
4. Win 7-IE9
5. Ubuntu 12.04-Firefox 25.0.1
QuickView after change:
https://drive.google.com/file/d/0Bxp-rsbufeAzZEtlakxKTEwyaGM/edit?usp=sharing
Thanks,
Dariusz Nejbauer
Re: Review Request 16002: CLOUDSTACK-3932 EN: Truncation issue occurred in
secondary storage URL.
Posted by Dariusz Nejbauer <d....@samsung.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16002/
-----------------------------------------------------------
(Updated Dec. 5, 2013, 10:36 a.m.)
Review request for cloudstack.
Summary (updated)
-----------------
CLOUDSTACK-3932 EN: Truncation issue occurred in secondary storage URL.
Bugs: CLOUDSTACK-3932
https://issues.apache.org/jira/browse/CLOUDSTACK-3932
Repository: cloudstack-git
Description
-------
Wrong layout format in Secondary Storage QuickView: https://issues.apache.org/jira/secure/attachment/12594894/Truncation.jpg
Problem with layout occurs when quick-view displays details field from json data. In table body, row has the same class as the parent div.
Diffs
-----
ui/scripts/ui/widgets/detailView.js b0ebaa9b27947f3720e2068471361004bce02f7a
Diff: https://reviews.apache.org/r/16002/diff/
Testing
-------
Tested locally on:
1. DevCloud setup
2. Win 7-Chrome
3. Win 7-Firefox 22.0
4. Win 7-IE9
5. Ubuntu 12.04-Firefox 25.0.1
QuickView after change:
https://drive.google.com/file/d/0Bxp-rsbufeAzZEtlakxKTEwyaGM/edit?usp=sharing
Thanks,
Dariusz Nejbauer