You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Dan Burkert (Code Review)" <ge...@cloudera.org> on 2017/05/11 23:34:29 UTC
[kudu-CR] Bump glog to 0.3.5
Hello Adar Dembo,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/6871
to review the following change.
Change subject: Bump glog to 0.3.5
......................................................................
Bump glog to 0.3.5
Change-Id: I9f638970abfd1aa214cf0032b46064ff7edf4dc4
---
M thirdparty/download-thirdparty.sh
D thirdparty/patches/glog-cda16b3443e2d6ef88cdbbe10b9a11adea6f33fe.patch
M thirdparty/vars.sh
3 files changed, 2 insertions(+), 97 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/71/6871/1
--
To view, visit http://gerrit.cloudera.org:8080/6871
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9f638970abfd1aa214cf0032b46064ff7edf4dc4
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
[kudu-CR] Bump glog to 0.3.5
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: Bump glog to 0.3.5
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/6871
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9f638970abfd1aa214cf0032b46064ff7edf4dc4
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] Bump glog to 0.3.5
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has submitted this change and it was merged.
Change subject: Bump glog to 0.3.5
......................................................................
Bump glog to 0.3.5
Change-Id: I9f638970abfd1aa214cf0032b46064ff7edf4dc4
Reviewed-on: http://gerrit.cloudera.org:8080/6871
Tested-by: Kudu Jenkins
Reviewed-by: Dan Burkert <da...@apache.org>
---
M thirdparty/download-thirdparty.sh
D thirdparty/patches/glog-cda16b3443e2d6ef88cdbbe10b9a11adea6f33fe.patch
M thirdparty/vars.sh
3 files changed, 2 insertions(+), 97 deletions(-)
Approvals:
Dan Burkert: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/6871
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9f638970abfd1aa214cf0032b46064ff7edf4dc4
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] Bump glog to 0.3.5
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: Bump glog to 0.3.5
......................................................................
Patch Set 2: Code-Review+2
Carrying over Adar's +2, failure was due to a weird interaction with not having rebased over the proto3 patchset.
--
To view, visit http://gerrit.cloudera.org:8080/6871
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9f638970abfd1aa214cf0032b46064ff7edf4dc4
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No