You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/06/06 18:54:03 UTC
[GitHub] [arrow] dominicbarnes opened a new pull request, #13322: go: update testify to get security patch for gopkg.in/yaml.v3
dominicbarnes opened a new pull request, #13322:
URL: https://github.com/apache/arrow/pull/13322
This PR updates the github.com/stretchr/testify dependency to get a security patch for gopkg.in/yaml.v3 which has a DoS exploit. See https://github.com/stretchr/testify/pull/1192 for more details.
I'm unsure how this project handles security patches for appears to be older versions. I'm here because I have dependencies that rely on v7, so that's what is bringing me here to make this very particular change. It looks like v6.0.0 and v6.0.1 tags exist, so I expect merging this here and tagging v7.0.1 would be the path forward. If not, let me know what would be preferred.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] dominicbarnes commented on pull request #13322: ARROW-16759: [Go] update testify to get security patch for gopkg.in/yaml.v3 (v7)
Posted by GitBox <gi...@apache.org>.
dominicbarnes commented on PR #13322:
URL: https://github.com/apache/arrow/pull/13322#issuecomment-1182479286
@kou see the linked PRs above, let me know if this is what you were expecting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #13322: ARROW-16759: [Go] update testify to get security patch for gopkg.in/yaml.v3 (v7)
Posted by GitBox <gi...@apache.org>.
kou commented on PR #13322:
URL: https://github.com/apache/arrow/pull/13322#issuecomment-1181341877
@dominicbarnes @zeroshade Could you create pull requests against `maint-6.0.x`, `main-7.0.x` and `maint-8.0.x` to release 6.0.2, 7.0.1 and 8.0.1? (I tried it against `maint-6.0.x` but it causes a conflict.)
We can reuse ARROW-16759 for them. We will add `6.0.2`, `7.0.1` and `8.0.1` to the `Fixed version/s` field.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] dominicbarnes commented on pull request #13322: ARROW-16759: [Go] update testify to get security patch for gopkg.in/yaml.v3 (v7)
Posted by GitBox <gi...@apache.org>.
dominicbarnes commented on PR #13322:
URL: https://github.com/apache/arrow/pull/13322#issuecomment-1154147685
@zeroshade thanks for getting this merged! How can I help getting the fix backported?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade closed pull request #13322: ARROW-16759: [Go] update testify to get security patch for gopkg.in/yaml.v3 (v7)
Posted by GitBox <gi...@apache.org>.
zeroshade closed pull request #13322: ARROW-16759: [Go] update testify to get security patch for gopkg.in/yaml.v3 (v7)
URL: https://github.com/apache/arrow/pull/13322
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #13322: go: update testify to get security patch for gopkg.in/yaml.v3
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13322:
URL: https://github.com/apache/arrow/pull/13322#issuecomment-1147779636
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
If this is not a [minor PR](https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW
Opening JIRAs ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename pull request title in the following format?
ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
See also:
* [Other pull requests](https://github.com/apache/arrow/pulls/)
* [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #13322: ARROW-16759: [Go] update testify to get security patch for gopkg.in/yaml.v3 (v7)
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #13322:
URL: https://github.com/apache/arrow/pull/13322#issuecomment-1152545747
['Python', 'R'] benchmarks have high level of regressions.
[ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/d628aede0c624b95b7d7ad95ba8034b7...e07f07ea50574f258e0137274ac0c1f4/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] dominicbarnes commented on pull request #13322: ARROW-16759: [Go] update testify to get security patch for gopkg.in/yaml.v3 (v7)
Posted by GitBox <gi...@apache.org>.
dominicbarnes commented on PR #13322:
URL: https://github.com/apache/arrow/pull/13322#issuecomment-1151593191
@zeroshade I've rebased the PR, which seems to have included some JS changes during the process, though once I've completed there are no longer changes to JS.
Once merged, I'll send that email and start the process of getting this patch backported.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #13322: ARROW-16759: [Go] update testify to get security patch for gopkg.in/yaml.v3 (v7)
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #13322:
URL: https://github.com/apache/arrow/pull/13322#issuecomment-1152545616
Benchmark runs are scheduled for baseline = 1de30af020ebcfd006b4b5cd56dadf07635286ab and contender = 6af8b472237203b0371b347e6efd3a383d36ffca. 6af8b472237203b0371b347e6efd3a383d36ffca is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/9d9961dbdc324d739379f1ab708fc384...9009c98574c04fb7b25ba3efbb705e18/)
[Failed :arrow_down:0.66% :arrow_up:0.07%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/681a5e432e5c4acb9ae86a1932270d49...6057c31b49e941618fcd3bcf52b002ec/)
[Finished :arrow_down:0.71% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/d628aede0c624b95b7d7ad95ba8034b7...e07f07ea50574f258e0137274ac0c1f4/)
[Finished :arrow_down:0.6% :arrow_up:0.26%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/931646b124ae43dea26a7f1d7ec52dfa...f45733a3b8d34dcaab05f0b3dccce7a1/)
Buildkite builds:
[Finished] [`6af8b472` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/930)
[Finished] [`6af8b472` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/930)
[Finished] [`6af8b472` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/920)
[Finished] [`6af8b472` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/933)
[Finished] [`1de30af0` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/929)
[Failed] [`1de30af0` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/929)
[Finished] [`1de30af0` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/919)
[Finished] [`1de30af0` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/932)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #13322: ARROW-16759: update testify to get security patch for gopkg.in/yaml.v3
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13322:
URL: https://github.com/apache/arrow/pull/13322#issuecomment-1147951175
https://issues.apache.org/jira/browse/ARROW-16759
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade commented on pull request #13322: ARROW-16759: [Go] update testify to get security patch for gopkg.in/yaml.v3 (v7)
Posted by GitBox <gi...@apache.org>.
zeroshade commented on PR #13322:
URL: https://github.com/apache/arrow/pull/13322#issuecomment-1152409312
@dominicbarnes Perfect, i'll merge this and reply to the email to help start the process of backporting the patch. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade commented on pull request #13322: ARROW-16759: [Go] update testify to get security patch for gopkg.in/yaml.v3 (v7)
Posted by GitBox <gi...@apache.org>.
zeroshade commented on PR #13322:
URL: https://github.com/apache/arrow/pull/13322#issuecomment-1151442679
@dominicbarnes Please run `go mod tidy` in the directory so that it properly updates the `go.sum` file also and add that to this PR. You can also change this to merge to master, and we can cherry-pick the change into the other tagged release branches for those patch releases.
As for backporting the change to the previous versions, can you send an email to the arrow dev mailing list to propose patch releases of v6.0.2, v7.0.1, and v8.0.1? Link this PR in the email please. Unfortunately the release process, even for patch releases like this, is still a manual process that needs to get approved by the PMC, so the best route here would be to bring the discussion up there and then we can move forward. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #13322: ARROW-16759: update testify to get security patch for gopkg.in/yaml.v3
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13322:
URL: https://github.com/apache/arrow/pull/13322#issuecomment-1147951197
:warning: Ticket **has not been started in JIRA**, please click 'Start Progress'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org