You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@lens.apache.org by Himanshu Gahlaut <ga...@gmail.com> on 2014/12/25 18:34:36 UTC

Review Request 29422: LENS-151: Fix for promotion of select expression to group by failing when column aliases have spaces

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29422/
-----------------------------------------------------------

Review request for lens.


Repository: lens


Description
-------

getExpressionWithoutAlias in GroupbyResolver.class is unable to handle aliases with spaces in them. 


Diffs
-----

  lens-cube/pom.xml 1bcb4dc 
  lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java c2fef7e 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java ad4abcf 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryRewrite.java fd939e9 
  lens-cube/src/test/resources/log4j.properties 9729de0 

Diff: https://reviews.apache.org/r/29422/diff/


Testing
-------

Added a unit test case for the same.


Thanks,

Himanshu Gahlaut

Re: Review Request 29422: LENS-151: Fix for promotion of select expression to group by failing when column aliases have spaces

Posted by Himanshu Gahlaut <ga...@gmail.com>.


> On Dec. 25, 2014, 5:45 p.m., Jaideep dhok wrote:
> > lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java, line 739
> > <https://reviews.apache.org/r/29422/diff/1/?file=800741#file800741line739>
> >
> >     Can you use the twoDaysRange or some other time range for the where clause, I think hardcoded dates might not work as partitions are added dynamically during test setup.
> >     
> >     For comparing queries too, there is a utility method in CubeTestSetup
> 
> Himanshu Gahlaut wrote:
>     Test case is passing with constant input dates in queries. I might be missing something. Please help me in understanding when will the test case not work with constant dates. Focus of the test case is testing promotion, which is getting achieved with the written test case. Wanted to keep the dependencies of test case as less as possible and also keep it as simple as possible so that it is easier to understand. Also since assertEquals is working, what is the advantage in using compareQueries and increasing dependency in test case ?

Seems like test case is passing now but would keep passing and become meaningless in future because only recent partitions are dynamically registered. Not clear of the motivation behind using dynamic partitions. Have created a lastHourTimeRange and used it to keep the test case useful with dynamic partitions. Have uploaded new diff for it. Jaideep, Please review again.


- Himanshu


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29422/#review66101
-----------------------------------------------------------


On Dec. 25, 2014, 8:02 p.m., Himanshu Gahlaut wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29422/
> -----------------------------------------------------------
> 
> (Updated Dec. 25, 2014, 8:02 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> (1) getExpressionWithoutAlias in GroupbyResolver.class is unable to handle aliases with spaces in them. Fixed the same.
> (2) Also improved log4j.properties of lens-cube to send logs to both console appender and test log files. 
> (3) Used Slf4j annotation in Test classes for getting a reference to Slf4j logger. Added required dependencies in lens-cube/pom.xml to facilitate the same.
> 
> 
> Diffs
> -----
> 
>   lens-cube/pom.xml 1bcb4dc 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java c2fef7e 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java f515df1 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java ad4abcf 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryRewrite.java fd939e9 
>   lens-cube/src/test/resources/log4j.properties 9729de0 
> 
> Diff: https://reviews.apache.org/r/29422/diff/
> 
> 
> Testing
> -------
> 
> Added a unit test case for the same.
> 
> 
> Thanks,
> 
> Himanshu Gahlaut
> 
>

Re: Review Request 29422: LENS-151: Fix for promotion of select expression to group by failing when column aliases have spaces

Posted by Himanshu Gahlaut <ga...@gmail.com>.


> On Dec. 25, 2014, 5:45 p.m., Jaideep dhok wrote:
> > lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java, line 739
> > <https://reviews.apache.org/r/29422/diff/1/?file=800741#file800741line739>
> >
> >     Can you use the twoDaysRange or some other time range for the where clause, I think hardcoded dates might not work as partitions are added dynamically during test setup.
> >     
> >     For comparing queries too, there is a utility method in CubeTestSetup

Test case is passing with constant input dates in queries. I might be missing something. Please help me in understanding when will the test case not work with constant dates. Focus of the test case is testing promotion, which is getting achieved with the written test case. Wanted to keep the dependencies of test case as less as possible and also keep it as simple as possible so that it is easier to understand. Also since assertEquals is working, what is the advantage in using compareQueries and increasing dependency in test case ?


- Himanshu


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29422/#review66101
-----------------------------------------------------------


On Dec. 25, 2014, 5:40 p.m., Himanshu Gahlaut wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29422/
> -----------------------------------------------------------
> 
> (Updated Dec. 25, 2014, 5:40 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> (1) getExpressionWithoutAlias in GroupbyResolver.class is unable to handle aliases with spaces in them. Fixed the same.
> (2) Also improved log4j.properties of lens-cube to send logs to both console appender and test log files. 
> (3) Used Slf4j annotation in Test classes for getting a reference to Slf4j logger. Added required dependencies in lens-cube/pom.xml to facilitate the same.
> 
> 
> Diffs
> -----
> 
>   lens-cube/pom.xml 1bcb4dc 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java c2fef7e 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java ad4abcf 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryRewrite.java fd939e9 
>   lens-cube/src/test/resources/log4j.properties 9729de0 
> 
> Diff: https://reviews.apache.org/r/29422/diff/
> 
> 
> Testing
> -------
> 
> Added a unit test case for the same.
> 
> 
> Thanks,
> 
> Himanshu Gahlaut
> 
>

Re: Review Request 29422: LENS-151: Fix for promotion of select expression to group by failing when column aliases have spaces

Posted by Jaideep dhok <ja...@inmobi.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29422/#review66101
-----------------------------------------------------------



lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java
<https://reviews.apache.org/r/29422/#comment109440>

    Can you use the twoDaysRange or some other time range for the where clause, I think hardcoded dates might not work as partitions are added dynamically during test setup.
    
    For comparing queries too, there is a utility method in CubeTestSetup


- Jaideep dhok


On Dec. 25, 2014, 5:40 p.m., Himanshu Gahlaut wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29422/
> -----------------------------------------------------------
> 
> (Updated Dec. 25, 2014, 5:40 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> (1) getExpressionWithoutAlias in GroupbyResolver.class is unable to handle aliases with spaces in them. Fixed the same.
> (2) Also improved log4j.properties of lens-cube to send logs to both console appender and test log files. 
> (3) Used Slf4j annotation in Test classes for getting a reference to Slf4j logger. Added required dependencies in lens-cube/pom.xml to facilitate the same.
> 
> 
> Diffs
> -----
> 
>   lens-cube/pom.xml 1bcb4dc 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java c2fef7e 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java ad4abcf 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryRewrite.java fd939e9 
>   lens-cube/src/test/resources/log4j.properties 9729de0 
> 
> Diff: https://reviews.apache.org/r/29422/diff/
> 
> 
> Testing
> -------
> 
> Added a unit test case for the same.
> 
> 
> Thanks,
> 
> Himanshu Gahlaut
> 
>

Re: Review Request 29422: LENS-151: Fix for promotion of select expression to group by failing when column aliases have spaces

Posted by Laxman Ch <la...@huawei.com>.


> On Dec. 27, 2014, 12:09 p.m., Laxman Ch wrote:
> > lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java, line 163
> > <https://reviews.apache.org/r/29422/diff/4/?file=801695#file801695line163>
> >
> >     nit. few more sysouts missed to port to log
> 
> Himanshu Gahlaut wrote:
>     There are 266 occurences of System.out in Lens Code (Pasted below). We can park a new Jira to port them. Objective here was not to port them all but do a beginning to start removing them. Hence only ported a few of them. Thanks for bringing up the discussion though.
>     
>     
>     lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java:    System.out.println("@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@");
>     lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java:    System.out.println("@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@");
>     lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java:    System.out.println("@@PERSISTENT_RESULT_TEST-------------");
>     lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java:      System.out.println("@@ RESULT " + result);
>     lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java:    System.out.println("@@END_PERSISTENT_RESULT_TEST-------------");
>     lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java:    System.out.println("@@START_FINISHED_PURGED_RESULT_TEST-------------");
>     lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java:      System.out.println("@@ RESULT " + result);
>     lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java:    System.out.println("@@END_FINISHED_PURGED_RESULT_TEST-------------");
>     lens-cube/src/main/java/org/apache/lens/cube/metadata/SchemaGraph.java:      System.out.println("**Cube " + cube.getName() + " Out egdes");
>     lens-cube/src/main/java/org/apache/lens/cube/metadata/SchemaGraph.java:      System.out.println("--Out Graph-Nodes=" + graph.size());
>     lens-cube/src/main/java/org/apache/lens/cube/metadata/SchemaGraph.java:        System.out.println(tab.getName() + "::" + graph.get(tab));
>     lens-cube/src/main/java/org/apache/lens/cube/metadata/SchemaGraph.java:    System.out.println("**Dim only outgraph");
>     lens-cube/src/main/java/org/apache/lens/cube/metadata/SchemaGraph.java:    System.out.println("--Out Graph-Nodes=" + dimOnlyOutGraph.size());
>     lens-cube/src/main/java/org/apache/lens/cube/metadata/SchemaGraph.java:      System.out.println(tab.getName() + "::" + dimOnlyOutGraph.get(tab));
>     lens-cube/src/main/java/org/apache/lens/cube/metadata/SchemaGraph.java:      System.out.println("**Cube " + cube.getName() + " In egdes");
>     lens-cube/src/main/java/org/apache/lens/cube/metadata/SchemaGraph.java:      System.out.println("--In Graph-Nodes=" + graph.size());
>     lens-cube/src/main/java/org/apache/lens/cube/metadata/SchemaGraph.java:        System.out.println(tab.getName() + "::" + graph.get(tab));
>     lens-cube/src/main/java/org/apache/lens/cube/metadata/SchemaGraph.java:    System.out.println("**Dim only Ingraph");
>     lens-cube/src/main/java/org/apache/lens/cube/metadata/SchemaGraph.java:    System.out.println("--In Graph-Nodes=" + dimOnlyInGraph.size());
>     lens-cube/src/main/java/org/apache/lens/cube/metadata/SchemaGraph.java:      System.out.println(tab.getName() + "::" + dimOnlyInGraph.get(tab));
>     lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java:      System.out.println("Rewritten HQL:" + hql);
>     lens-cube/src/main/java/org/apache/lens/cube/parse/CubeSemanticAnalyzer.java:    // System.out.println(sinkOp.toString());
>     lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java:    System.out.println();
>     lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java:      System.out.println(" {");
>     lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java:          System.out.println("NON ASTNode");
>     lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java:        System.out.println();
>     lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java:    System.out.println("Test twodaysBack:" + twodaysBack);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java:    System.out.println("Test twoMonthsBack:" + twoMonthsBack);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java:    System.out.println("--" + label + "--AST--");
>     lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java:    System.out.println("--query- " + query);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestAggregateResolver.java:      System.out.println("hql[" + i + "]:" + hql);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java:    //System.out.println("HQL:" + hqlQuery);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java:    //System.out.println("Expected:" + expected);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestBetweenTimeRangeWriter.java:    System.out.println("Expected :" + StorageUtil.getWherePartClause("dt", "test", parts));
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:    System.out.println("Non existing parts:" + rewrittenQuery.getNonExistingParts());
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:    System.out.println("Non existing parts:" + rewrittenQuery.getNonExistingParts());
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:      System.out.println("Union hql query:" + hqlQuery);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:      System.out.println("union query:" + hqlQuery);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:    System.out.println("Query With process time col:" + hqlQuery);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:    System.out.println("Query With process time col:" + hqlQuery);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:    System.out.println("Query With process time col:" + hqlQuery);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:    System.out.println("Query With process time col:" + hqlQuery);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:    System.out.println("Query With process time col:" + hqlQuery);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:    System.out.println("Query With process time col:" + hqlQuery);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:    System.out.println("@@ Joins disabled? " + testConf.get(CubeQueryConfUtil.DISABLE_AUTO_JOINS));
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:      System.out.println("TestJoinPathTimeRange: " + context.toHQL());
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:      System.out.println("@@ hql: " + hql);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:    System.out.println("@@" + hql);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:    System.out.println("@@2 " + hql);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:      System.out.println("@@HQL " + hql);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:    System.out.println("##testDimAttributeQueryWithFact " + rewrittenQuery);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:      System.out.println("@@ HQL = " + hql);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java:    System.out.println("HQL query:" + hqlQuery);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java:    System.out.println("HQL query:" + hqlQuery);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java:    System.out.println("HQL query:" + hqlQuery);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java:    System.out.println("HQL query:" + hqlQuery);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java:    System.out.println("HQL query:" + hqlQuery);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    System.out.println("###Actual order by:" + HQLParser.getString(orderby).trim());
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    System.out.println("reconstructed clause ");
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    System.out.println(selectStr);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    System.out.println("reconstructed clause 2");
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    System.out.println(selectStr);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    System.out.println("reconstructed clause ");
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    System.out.println(selectStr);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    System.out.println("reconstructed clause 2");
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    System.out.println(selectStr);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    System.out.println(whereStr);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    System.out.println(whereStr);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    System.out.println(whereStr);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    System.out.println(whereStr);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    System.out.println(whereStr);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    System.out.println(selectStr);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    System.out.println(whereStr);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    System.out.println(whereStr);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    System.out.println("RECONSTRUCTED0:" + reconstructed);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    System.out.println("RECONSTRUCTED1:" + reconstructed);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    System.out.println("RECONSTRUCTED2:" + reconstructed);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    System.out.println("RECONSTRUCTED3:" + reconstructed);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    System.out.println(selectStr);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    System.out.println(selectStr);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    System.out.println(selectStr);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    System.out.println(selectStr);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    System.out.println("genQuery1: " + genQuery);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    System.out.println("genQuery2: " + genQuery2);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("@@ " + source + " ==> " + target + " paths =");
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:      System.out.println(++i + " " + jp.getEdges());
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("--Graph-Nodes=" + graph.size());
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:      System.out.println(tab.getName() + "::" + graph.get(tab));
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("testAutoJoinResolverauto join HQL:" + hql);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("testAutoJoinResolver@@Resolved join chain:[" + getAutoResolvedFromString(rewrittenQu
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("testAutoJoinResolverExpected1" + expectedClauses);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("testAutoJoinResolverActual1" + actualClauses);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("testAutoJoinResolverauto join HQL:" + hql);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("testAutoJoinResolver@@Resolved join chain:[" + getAutoResolvedFromString(rewrittenQu
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("testAutoJoinResolverExpected2" + expectedClauses);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("testAutoJoinResolverActual2" + actualClauses);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("testPartialJoinResolver Partial join hql: " + hql);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("@Resolved join clause " + joinClause);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("@@Set join type to " + hconf.get(CubeQueryConfUtil.JOIN_TYPE_KEY));
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("testJoinTypeConf@@Resolved join clause1 - " + getAutoResolvedFromString(ctx));
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("@@Set join type to " + hconf.get(CubeQueryConfUtil.JOIN_TYPE_KEY));
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("testJoinTypeConf@@Resolved join clause2 - " + getAutoResolvedFromString(ctx));
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("testPreserveTableAlias@@HQL:" + hql);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("testPreserveTableAlias@@Resolved join clause - " + getAutoResolvedFromString(ctx));
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("testDimOnlyQuery@@@HQL:" + hql);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("testDimOnlyQuery@@@Resolved join clause: " + getAutoResolvedFromString(ctx));
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("testDimOnlyQuery@@@HQL2:" + hql);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("##1 hql " + hql);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("##1 " + getAutoResolvedFromString(context));
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("##2 hql " + hql);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("##2 " + getAutoResolvedFromString(context));
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("##3 hql " + hql);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("##3 " + getAutoResolvedFromString(context));
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("testAutoJoinResolverauto join HQL:" + hql);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("testAutoJoinResolver@@Resolved join chain:[" + getAutoResolvedFromString(rewrittenQu
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("testDimOnlyJoinChainExpected1 : " + expectedClauses);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("testDimOnlyJoinChainActual1 : " + actualClauses);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("testAutoJoinResolverauto join HQL:" + hql);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("testAutoJoinResolver@@Resolved join chain:[" + getAutoResolvedFromString(rewrittenQu
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("testDimOnlyJoinChainExpected1 : " + expectedClauses);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("testDimOnlyJoinChainActual1 : " + actualClauses);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("testAutoJoinResolverauto join HQL:" + hql);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("testAutoJoinResolver@@Resolved join chain:[" + getAutoResolvedFromString(rewrittenQu
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("testDimOnlyJoinChainExpected1 : " + expectedClauses);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("testDimOnlyJoinChainActual1 : " + actualClauses);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestMaxUpdateInterval.java:        System.out.println(pairs[i].toString());
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestORTimeRangeWriter.java:    System.out.println("Expected :" + StorageUtil.getWherePartClause("dt", "test", parts));
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestORTimeRangeWriter.java:    System.out.println("Expected :" + StorageUtil.getWherePartClause("dt", "test", parts));
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestORTimeRangeWriter.java:    System.out.println("Expected :" + StorageUtil.getWherePartClause("dt", "test", parts));
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestStorageUtil.java:    System.out.println("results:" + result);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestStorageUtil.java:    System.out.println("results:" + result);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestStorageUtil.java:    System.out.println("results:" + result);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestStorageUtil.java:    System.out.println("results:" + result);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestStorageUtil.java:    System.out.println("results:" + result);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestStorageUtil.java:    System.out.println("results:" + result);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestStorageUtil.java:    System.out.println("results:" + result);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeExtractor.java:    System.out.println("###");
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java:    System.out.println("HQL:" + hqlQuery);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java:    System.out.println("HQL:" + hqlQuery);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java:    System.out.println("HQL:" + hqlQuery);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java:    System.out.println("HQL:" + hqlQuery);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java:    System.out.println("HQL:" + hqlQuery);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java:    System.out.println("HQL:" + hqlQuery);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java:    System.out.println("HQL:" + hqlQuery);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java:    System.out.println("HQL:" + hqlQuery);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java:    System.out.println("HQL:" + hqlQuery);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java:    System.out.println("HQL:" + hqlQuery);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java:    System.out.println("HQL:" + hqlQuery);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java:    System.out.println("HQL:" + hqlQuery);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java:    System.out.println("HQL:" + hqlQuery);
>     lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java:    System.out.println("###HADOOP_PATH " + System.getProperty("hadoop.bin.path"));
>     lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java:    System.out.println("TestHiveDriver created");
>     lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java:    System.out.println("Hadoop Location: " + System.getProperty("hadoop.bin.path"));
>     lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java:    System.out.println("Hadoop Location: " + System.getProperty("hadoop.bin.path"));
>     lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java:      System.out.println("Progress:" + ctx.getDriverStatus().getProgressMessage());
>     lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java:      System.out.println("Error:" + ctx.getDriverStatus().getErrorMessage());
>     lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java:      System.out.println("Status:" + ctx.getDriverStatus().getStatusMessage());
>     lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java:          System.out.println("Actual:" + line);
>     lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java:      System.out.println("#W Waiting for query " + ctx.getQueryHandle() + " status: "
>     lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java:      System.out.println("Progress:" + ctx.getDriverStatus().getProgressMessage());
>     lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java:    System.out.println("Tables:" + plan.getTablesQueried());
>     lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java:    System.out.println("Parts:" + plan.getPartitions());
>     lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java:    System.out.println("TestRemoteHiveDriver created");
>     lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java:    System.out.println("@@@@ start_persistence_test");
>     lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java:      System.out.println("@@ Adding partition " + i);
>     lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java:    System.out.println("@@ partitions" + plan.getPartitions());
>     lens-driver-impala/src/test/java/org/apache/lens/driver/impala/it/ITImpalaDriver.java:      System.out.println("Row1" + row);
>     lens-driver-impala/src/test/java/org/apache/lens/driver/impala/it/ITImpalaDriver.java:      System.out.println("Row2" + row);
>     lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java:    System.out.println("Created table : " + table);
>     lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java:    System.out.println(joinTreeBeforeRewrite);
>     lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java:    System.out.println(joinTreeAfterRewrite);
>     lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java:    System.out.println(joinTreeBeforeRewrite);
>     lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java:    System.out.println(joinTreeAfterRewrite);
>     lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java:    System.out.println("default case: " + joinTreeAfterRewrite);
>     lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java:    System.out.println("Created table " + table);
>     lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJDBCFinal.java:    System.out.println("Driver configured!");
>     lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJDBCFinal.java:    System.out.println("Driver closed!");
>     lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJDBCFinal.java:        System.out.println(rowObjects);
>     lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJDBCFinal.java:        System.out.println(rowObjects);
>     lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java:      System.out.println("Error : " + ex);
>     lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java:    System.out.println("@@@ Test_execute_async:" + context.getQueryHandle());
>     lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java:        System.out.println("@@@@ Query is complete " + handle);
>     lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java:      System.out.println("Query: " + handle + " Status: " + context.getDriverStatus());
>     lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java:      System.out.println("Matched metadata");
>     lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java:        System.out.println("Matched exception");
>     lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java:      System.out.println("@@@@ QUERY " + (i + 1));
>     lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java:    System.out.println("@@@ Submitting valid query");
>     lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java:      System.out.println("@@@@ QUERY " + (i + 1));
>     lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java:    System.out.println("@@@ Submitting query after pool quota used");
>     lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java:    System.out.println("@@@ test_cancel:" + context.getQueryHandle());
>     lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java:      System.out.println("Query: " + handle + " Status: " + ctx.getDriverStatus());
>     lens-examples/src/main/java/org/apache/lens/examples/PopulateSampleMetastore.java:      System.out.println("Adding partition from:dim1-local-part.xml failed");
>     lens-examples/src/main/java/org/apache/lens/examples/PopulateSampleMetastore.java:      System.out.println("Added partition from:dim1-local-part.xml");
>     lens-examples/src/main/java/org/apache/lens/examples/PopulateSampleMetastore.java:      System.out.println("Adding partition from:dim2-local-part.xml failed");
>     lens-examples/src/main/java/org/apache/lens/examples/PopulateSampleMetastore.java:      System.out.println("Added partition from:dim2-local-part.xml");
>     lens-examples/src/main/java/org/apache/lens/examples/PopulateSampleMetastore.java:      System.out.println("Adding partition from:dim4-local-part.xml failed");
>     lens-examples/src/main/java/org/apache/lens/examples/PopulateSampleMetastore.java:      System.out.println("Added partition from:dim4-local-part.xml");
>     lens-examples/src/main/java/org/apache/lens/examples/PopulateSampleMetastore.java:      System.out.println("Created DB storages for dim_table3 and dim_table4");
>     lens-examples/src/main/java/org/apache/lens/examples/PopulateSampleMetastore.java:      System.out.println("Creating DB storage failed for dim_table3 and dim_table4");
>     lens-examples/src/main/java/org/apache/lens/examples/PopulateSampleMetastore.java:      System.out.println("Adding partition from:" + fileName + " failed");
>     lens-examples/src/main/java/org/apache/lens/examples/PopulateSampleMetastore.java:      System.out.println("Added partition from:" + fileName);
>     lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java:        System.out.println("Creating cube from:sample-cube.xml failed");
>     lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java:        System.out.println("Creating dimension from:sample-dimension.xml failed");
>     lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java:        System.out.println("Creating dimension from:sample-dimension2.xml failed");
>     lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java:        System.out.println("Creating dimension from:sample-db-only-dimension.xml failed");
>     lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java:        System.out.println("Creating storage from:" + fileName + " failed");
>     lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java:        System.out.println("Creating dim table from: dim_table.xml and dim1-storage-tables.xml failed");
>     lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java:        System.out.println("Creating dim table from: dim_table2.xml and dim2-storage-tables.xml failed");
>     lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java:        System.out.println("Creating dim table from: dim_table3.xml and dim3-storage-tables.xml failed");
>     lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java:        System.out.println("Creating dim table from: dim_table4.xml and dim4-storage-tables.xml failed");
>     lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java:        System.out.println("Creating fact table from: fact1.xml and fact1-storage-tables.xml failed");
>     lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java:        System.out.println("Creating fact table from: fact2.xml and fact2-storage-tables.xml failed");
>     lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java:        System.out.println("Creating fact table from: rawfact.xml and rawfact-storage-tables.xml failed");
>     lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java:      System.out.println("Created sample metastore!");
>     lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java:      System.out.println("Database:" + metastore.metaClient.getCurrentDatabase());;
>     lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java:      System.out.println("Storages:" + metastore.metaClient.getAllStorages());;
>     lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java:      System.out.println("Cubes:" + metastore.metaClient.getAllCubes());;
>     lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java:      System.out.println("Dimensions:" + metastore.metaClient.getAllDimensions());;
>     lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java:      System.out.println("Fact tables:" + metastore.metaClient.getAllFactTables());;
>     lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java:      System.out.println("Dimension tables:" + metastore.metaClient.getAllDimensionTables());
>     lens-examples/src/main/java/org/apache/lens/examples/SampleQueries.java:    System.out.println("Successful queries " + success + " out of " + total + "queries");
>     lens-examples/src/main/java/org/apache/lens/examples/SampleQueries.java:      System.out.println("Query:" + query);
>     lens-examples/src/main/java/org/apache/lens/examples/SampleQueries.java:      System.out.println("Status:" + queryClient.getQuery().getStatus());
>     lens-examples/src/main/java/org/apache/lens/examples/SampleQueries.java:      System.out.println("Total time in millis:"
>     lens-examples/src/main/java/org/apache/lens/examples/SampleQueries.java:      System.out.println("Driver run time in millis:"
>     lens-examples/src/main/java/org/apache/lens/examples/SampleQueries.java:          System.out.println("Result:");
>     lens-examples/src/main/java/org/apache/lens/examples/SampleQueries.java:              System.out.println(StringUtils.join(row.getValues(), "\t"));
>     lens-examples/src/main/java/org/apache/lens/examples/SampleQueries.java:            System.out.println("Result stored at " + persistentQueryResult.getPersistedURI());
>     lens-examples/src/main/java/org/apache/lens/examples/SampleQueries.java:      System.out.println("--------------------");
>     lens-ml-lib/src/main/java/org/apache/lens/ml/task/MLTask.java:    System.out.println(builder.toString());
>     lens-ml-lib/src/main/java/org/apache/lens/ml/task/MLTask.java:    System.out.println(builder.toString());
>     lens-ml-lib/src/main/java/org/apache/lens/rdd/LensRDDClient.java:      System.out.println("@@@@ COL " + rc.getName() + " TYPE " + toHiveType(rc.getType()));
>     lens-query-lib/src/main/java/org/apache/lens/lib/query/ZipFileFormatter.java:    System.out.println("Setup outputs done");
>     lens-query-lib/src/test/java/org/apache/lens/lib/query/TestFilePersistentFormatter.java:    System.out.println("Actual rows:" + actual);
>     lens-query-lib/src/test/java/org/apache/lens/lib/query/TestFilePersistentFormatter.java:    System.out.println("Actual rows:" + actual);
>     lens-server/src/main/java/org/apache/lens/server/LensServletContextListener.java:        System.out.println("Application BasePath:" + basePath);
>     lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java:    System.out.println("Remote hive server started!");
>     lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java:    System.out.println("Lens services started!");
>     lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java:    System.out.println("Lens services stopped!");
>     lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java:    System.out.println("Remote hive server stopped!");
>     lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java:    System.out.println("Final report");
>     lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java:    System.out.println("Lens services stopped!");
>     lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java:    System.out.println("Lens services restarted!");
>     lens-server/src/test/java/org/apache/lens/server/TestIndexResource.java:    System.out.println("target path:" + target.getUri());
>     lens-server/src/test/java/org/apache/lens/server/TestServerMode.java:        System.out.println("Create databse not allowed in mode:" + mode);
>     lens-server/src/test/java/org/apache/lens/server/TestServerMode.java:        System.out.println("Drop databse not allowed in mode:" + mode);
>     lens-server/src/test/java/org/apache/lens/server/TestServerMode.java:        System.out.println("Launching query not allowed in mode:" + mode);
>     lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java:    System.out.println("### Test session restart");
>     lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java:    System.out.println("Session params:" + sessionParams.getElements());
>     lens-server/src/test/java/org/apache/lens/server/TestStaticFileResource.java:    System.out.println("@@@@ " + target().path("index.html").getUri());
>     lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java:    System.out.println("ALL DBs:" + allDbs.getElements());
>     lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java:      System.out.println("Attributes:" + dim.getAttributes());
>     lens-server/src/test/java/org/apache/lens/server/query/TestEventService.java:    System.out.println("@@@ testQueryStatusLogger");
>     lens-server/src/test/java/org/apache/lens/server/query/TestEventService.java:        System.out.println("@@@@ Got Event: Type= " + event.getClass().getName() + " obj = " + event);
>     lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java:    System.out.println("@@ State = " + queryContext.getStatus().getStatus().name());
>     lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java:    System.out.println("%% " + failedQueries);
>     lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java:      System.out.println("%% query " + ctx.getQueryHandle() + " status:" + stat);
>     lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java:    System.out.println("%% " + metricsSvc.getTotalFailedQueries());
>     lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java:    // System.out.println("query JSON:" + responseJSON);
>     lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java:    System.out.println("query XML:" + queryXML);
>     lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java:    System.out.println("PERSISTED RESULT:" + presultset);
>     lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java:    System.out.println("Session params:" + sessionParams.getElements());
>     lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java:    System.out.println("Session params:" + sessionParams.getElements());
>     lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java:    System.out.println("Session params:" + sessionParams.getElements());
>     lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java:    System.out.println("Session params:" + sessionParams.getElements());
>     lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java:      System.out.println("sessionParams:" + sessionParams.getElements());

Agreed. We should have a separate jira. Do you mind to file one?


- Laxman


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29422/#review66178
-----------------------------------------------------------


On Dec. 27, 2014, 10:55 a.m., Himanshu Gahlaut wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29422/
> -----------------------------------------------------------
> 
> (Updated Dec. 27, 2014, 10:55 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> (1) getExpressionWithoutAlias in GroupbyResolver.class is unable to handle aliases with spaces in them. Fixed the same.
> (2) Also improved log4j.properties of lens-cube to send logs to both console appender and test log files. 
> (3) Used Slf4j annotation in Test classes for getting a reference to Slf4j logger. Added required dependencies in lens-cube/pom.xml to facilitate the same.
> 
> 
> Diffs
> -----
> 
>   lens-cube/pom.xml 1bcb4dc 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java c2fef7e 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 8e41830 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java f515df1 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java ad4abcf 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryRewrite.java fd939e9 
>   lens-cube/src/test/resources/log4j.properties 9729de0 
> 
> Diff: https://reviews.apache.org/r/29422/diff/
> 
> 
> Testing
> -------
> 
> Added new unit test cases for the changes.
> All existing Unit Test Cases passed.
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [14.068s]
> [INFO] Lens .............................................. SUCCESS [5.717s]
> [INFO] Lens API .......................................... SUCCESS [9.369s]
> [INFO] Lens API for server and extensions ................ SUCCESS [8.624s]
> [INFO] Lens Cube ......................................... SUCCESS [7:10.440s]
> [INFO] Lens DB storage ................................... SUCCESS [23.631s]
> [INFO] Lens Query Library ................................ SUCCESS [9.386s]
> [INFO] Lens Hive Driver .................................. SUCCESS [3:34.922s]
> [INFO] Lens Driver for Cloudera Impala ................... SUCCESS [10.798s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [36.429s]
> [INFO] Lens Server ....................................... SUCCESS [14:29.334s]
> [INFO] Lens client ....................................... SUCCESS [45.711s]
> [INFO] Lens CLI .......................................... SUCCESS [3:10.102s]
> [INFO] Lens Examples ..................................... SUCCESS [3.064s]
> [INFO] Lens Distribution ................................. SUCCESS [11.315s]
> [INFO] Lens Client Distribution .......................... SUCCESS [7.496s]
> [INFO] Lens ML Lib ....................................... SUCCESS [2:32.231s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 34:03.600s
> [INFO] Finished at: Fri Dec 26 18:21:01 IST 2014
> [INFO] Final Memory: 100M/332M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Himanshu Gahlaut
> 
>

Re: Review Request 29422: LENS-151: Fix for promotion of select expression to group by failing when column aliases have spaces

Posted by Laxman Ch <la...@gmail.com>.


> On Dec. 27, 2014, 5:39 p.m., Laxman Ch wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java, line 163
> > <https://reviews.apache.org/r/29422/diff/4/?file=801693#file801693line163>
> >
> >     Please clarify
> >     
> >     - getNonMsrNonAggSelExprsWithoutAlias is a subset of selectExprs. That means we are promoting a subset. What happens to the rest? No need to promote.
> >      
> >     - Does this scenario doesn't occur with group by aliases having space? Can we have a testcase for the same.
> 
> Himanshu Gahlaut wrote:
>     For point 1, the old logic was to not promote the rest, hence have kept the same. 
>     For your second point, it is a bit unclear to me but it is looking interesting. could you provide me a input user query and expected HQL query, so that i can be clear about this thought and also test it ?
> 
> Laxman Ch wrote:
>     not sure about HQL. we need to seek some hql expert's help here.
>     but i can provide one in rdbms world
>     
>     select count(empno) "head count" from employee group by deptno;
> 
> Himanshu Gahlaut wrote:
>     select count(empno) "head count" from employee group by deptno;
>     
>     This kind of query will not require empno to be promoted to group by because an aggregate is applied on empno. Any other query ?
> 
> Amareshwari Sriramadasu wrote:
>     getNonMsrNonAggSelExprsWithoutAlias is a subset of selectExprs. That means we are promoting a subset. What happens to the rest? No need to promote.
>     >> Yes
>     
>     Does this scenario doesn't occur with group by aliases having space? Can we have a testcase for the same.
>     >> There cannot be aliases in group by clause
> 
> Himanshu Gahlaut wrote:
>     @Laxman, Has Amareshwari's reply clarified the doubt ?

Clear now. clsoing the issue.


- Laxman


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29422/#review66178
-----------------------------------------------------------


On Dec. 28, 2014, 11:12 a.m., Himanshu Gahlaut wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29422/
> -----------------------------------------------------------
> 
> (Updated Dec. 28, 2014, 11:12 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> (1) getExpressionWithoutAlias in GroupbyResolver.class is unable to handle aliases with spaces in them. Fixed the same.
> (2) Also improved log4j.properties of lens-cube to send logs to both console appender and test log files. 
> (3) Used Slf4j annotation in Test classes for getting a reference to Slf4j logger. Added required dependencies in lens-cube/pom.xml to facilitate the same.
> 
> 
> Diffs
> -----
> 
>   lens-cube/pom.xml 1bcb4dc 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java c2fef7e 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 8e41830 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java f515df1 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java ad4abcf 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryRewrite.java fd939e9 
>   lens-cube/src/test/resources/log4j.properties 9729de0 
> 
> Diff: https://reviews.apache.org/r/29422/diff/
> 
> 
> Testing
> -------
> 
> Added new unit test cases for the changes.
> All existing Unit Test Cases passed.
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [14.068s]
> [INFO] Lens .............................................. SUCCESS [5.717s]
> [INFO] Lens API .......................................... SUCCESS [9.369s]
> [INFO] Lens API for server and extensions ................ SUCCESS [8.624s]
> [INFO] Lens Cube ......................................... SUCCESS [7:10.440s]
> [INFO] Lens DB storage ................................... SUCCESS [23.631s]
> [INFO] Lens Query Library ................................ SUCCESS [9.386s]
> [INFO] Lens Hive Driver .................................. SUCCESS [3:34.922s]
> [INFO] Lens Driver for Cloudera Impala ................... SUCCESS [10.798s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [36.429s]
> [INFO] Lens Server ....................................... SUCCESS [14:29.334s]
> [INFO] Lens client ....................................... SUCCESS [45.711s]
> [INFO] Lens CLI .......................................... SUCCESS [3:10.102s]
> [INFO] Lens Examples ..................................... SUCCESS [3.064s]
> [INFO] Lens Distribution ................................. SUCCESS [11.315s]
> [INFO] Lens Client Distribution .......................... SUCCESS [7.496s]
> [INFO] Lens ML Lib ....................................... SUCCESS [2:32.231s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 34:03.600s
> [INFO] Finished at: Fri Dec 26 18:21:01 IST 2014
> [INFO] Final Memory: 100M/332M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Himanshu Gahlaut
> 
>

Re: Review Request 29422: LENS-151: Fix for promotion of select expression to group by failing when column aliases have spaces

Posted by Himanshu Gahlaut <ga...@gmail.com>.

> On Dec. 27, 2014, 12:09 p.m., Laxman Ch wrote:
> > lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java, line 163
> > <https://reviews.apache.org/r/29422/diff/4/?file=801695#file801695line163>
> >
> >     nit. few more sysouts missed to port to log

There are 266 occurences of System.out in Lens Code (Pasted below). We can park a new Jira to port them. Objective here was not to port them all but do a beginning to start removing them. Hence only ported a few of them. Thanks for bringing up the discussion though.

lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java:    System.out.println("@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@");
lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java:    System.out.println("@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@");
lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java:    System.out.println("@@PERSISTENT_RESULT_TEST-------------");
lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java:      System.out.println("@@ RESULT " + result);
lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java:    System.out.println("@@END_PERSISTENT_RESULT_TEST-------------");
lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java:    System.out.println("@@START_FINISHED_PURGED_RESULT_TEST-------------");
lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java:      System.out.println("@@ RESULT " + result);
lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java:    System.out.println("@@END_FINISHED_PURGED_RESULT_TEST-------------");
lens-cube/src/main/java/org/apache/lens/cube/metadata/SchemaGraph.java:      System.out.println("**Cube " + cube.getName() + " Out egdes");
lens-cube/src/main/java/org/apache/lens/cube/metadata/SchemaGraph.java:      System.out.println("--Out Graph-Nodes=" + graph.size());
lens-cube/src/main/java/org/apache/lens/cube/metadata/SchemaGraph.java:        System.out.println(tab.getName() + "::" + graph.get(tab));
lens-cube/src/main/java/org/apache/lens/cube/metadata/SchemaGraph.java:    System.out.println("**Dim only outgraph");
lens-cube/src/main/java/org/apache/lens/cube/metadata/SchemaGraph.java:    System.out.println("--Out Graph-Nodes=" + dimOnlyOutGraph.size());
lens-cube/src/main/java/org/apache/lens/cube/metadata/SchemaGraph.java:      System.out.println(tab.getName() + "::" + dimOnlyOutGraph.get(tab));
lens-cube/src/main/java/org/apache/lens/cube/metadata/SchemaGraph.java:      System.out.println("**Cube " + cube.getName() + " In egdes");
lens-cube/src/main/java/org/apache/lens/cube/metadata/SchemaGraph.java:      System.out.println("--In Graph-Nodes=" + graph.size());
lens-cube/src/main/java/org/apache/lens/cube/metadata/SchemaGraph.java:        System.out.println(tab.getName() + "::" + graph.get(tab));
lens-cube/src/main/java/org/apache/lens/cube/metadata/SchemaGraph.java:    System.out.println("**Dim only Ingraph");
lens-cube/src/main/java/org/apache/lens/cube/metadata/SchemaGraph.java:    System.out.println("--In Graph-Nodes=" + dimOnlyInGraph.size());
lens-cube/src/main/java/org/apache/lens/cube/metadata/SchemaGraph.java:      System.out.println(tab.getName() + "::" + dimOnlyInGraph.get(tab));
lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java:      System.out.println("Rewritten HQL:" + hql);
lens-cube/src/main/java/org/apache/lens/cube/parse/CubeSemanticAnalyzer.java:    // System.out.println(sinkOp.toString());
lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java:    System.out.println();
lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java:      System.out.println(" {");
lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java:          System.out.println("NON ASTNode");
lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java:        System.out.println();
lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java:    System.out.println("Test twodaysBack:" + twodaysBack);
lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java:    System.out.println("Test twoMonthsBack:" + twoMonthsBack);
lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java:    System.out.println("--" + label + "--AST--");
lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java:    System.out.println("--query- " + query);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestAggregateResolver.java:      System.out.println("hql[" + i + "]:" + hql);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java:    //System.out.println("HQL:" + hqlQuery);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java:    //System.out.println("Expected:" + expected);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestBetweenTimeRangeWriter.java:    System.out.println("Expected :" + StorageUtil.getWherePartClause("dt", "test", parts));
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:    System.out.println("Non existing parts:" + rewrittenQuery.getNonExistingParts());
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:    System.out.println("Non existing parts:" + rewrittenQuery.getNonExistingParts());
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:      System.out.println("Union hql query:" + hqlQuery);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:      System.out.println("union query:" + hqlQuery);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:    System.out.println("Query With process time col:" + hqlQuery);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:    System.out.println("Query With process time col:" + hqlQuery);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:    System.out.println("Query With process time col:" + hqlQuery);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:    System.out.println("Query With process time col:" + hqlQuery);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:    System.out.println("Query With process time col:" + hqlQuery);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:    System.out.println("Query With process time col:" + hqlQuery);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:    System.out.println("@@ Joins disabled? " + testConf.get(CubeQueryConfUtil.DISABLE_AUTO_JOINS));
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:      System.out.println("TestJoinPathTimeRange: " + context.toHQL());
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:      System.out.println("@@ hql: " + hql);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:    System.out.println("@@" + hql);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:    System.out.println("@@2 " + hql);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:      System.out.println("@@HQL " + hql);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:    System.out.println("##testDimAttributeQueryWithFact " + rewrittenQuery);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:      System.out.println("@@ HQL = " + hql);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java:    System.out.println("HQL query:" + hqlQuery);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java:    System.out.println("HQL query:" + hqlQuery);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java:    System.out.println("HQL query:" + hqlQuery);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java:    System.out.println("HQL query:" + hqlQuery);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java:    System.out.println("HQL query:" + hqlQuery);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    System.out.println("###Actual order by:" + HQLParser.getString(orderby).trim());
lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    System.out.println("reconstructed clause ");
lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    System.out.println(selectStr);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    System.out.println("reconstructed clause 2");
lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    System.out.println(selectStr);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    System.out.println("reconstructed clause ");
lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    System.out.println(selectStr);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    System.out.println("reconstructed clause 2");
lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    System.out.println(selectStr);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    System.out.println(whereStr);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    System.out.println(whereStr);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    System.out.println(whereStr);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    System.out.println(whereStr);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    System.out.println(whereStr);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    System.out.println(selectStr);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    System.out.println(whereStr);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    System.out.println(whereStr);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    System.out.println("RECONSTRUCTED0:" + reconstructed);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    System.out.println("RECONSTRUCTED1:" + reconstructed);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    System.out.println("RECONSTRUCTED2:" + reconstructed);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    System.out.println("RECONSTRUCTED3:" + reconstructed);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    System.out.println(selectStr);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    System.out.println(selectStr);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    System.out.println(selectStr);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    System.out.println(selectStr);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    System.out.println("genQuery1: " + genQuery);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    System.out.println("genQuery2: " + genQuery2);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("@@ " + source + " ==> " + target + " paths =");
lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:      System.out.println(++i + " " + jp.getEdges());
lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("--Graph-Nodes=" + graph.size());
lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:      System.out.println(tab.getName() + "::" + graph.get(tab));
lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("testAutoJoinResolverauto join HQL:" + hql);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("testAutoJoinResolver@@Resolved join chain:[" + getAutoResolvedFromString(rewrittenQu
lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("testAutoJoinResolverExpected1" + expectedClauses);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("testAutoJoinResolverActual1" + actualClauses);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("testAutoJoinResolverauto join HQL:" + hql);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("testAutoJoinResolver@@Resolved join chain:[" + getAutoResolvedFromString(rewrittenQu
lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("testAutoJoinResolverExpected2" + expectedClauses);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("testAutoJoinResolverActual2" + actualClauses);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("testPartialJoinResolver Partial join hql: " + hql);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("@Resolved join clause " + joinClause);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("@@Set join type to " + hconf.get(CubeQueryConfUtil.JOIN_TYPE_KEY));
lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("testJoinTypeConf@@Resolved join clause1 - " + getAutoResolvedFromString(ctx));
lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("@@Set join type to " + hconf.get(CubeQueryConfUtil.JOIN_TYPE_KEY));
lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("testJoinTypeConf@@Resolved join clause2 - " + getAutoResolvedFromString(ctx));
lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("testPreserveTableAlias@@HQL:" + hql);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("testPreserveTableAlias@@Resolved join clause - " + getAutoResolvedFromString(ctx));
lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("testDimOnlyQuery@@@HQL:" + hql);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("testDimOnlyQuery@@@Resolved join clause: " + getAutoResolvedFromString(ctx));
lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("testDimOnlyQuery@@@HQL2:" + hql);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("##1 hql " + hql);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("##1 " + getAutoResolvedFromString(context));
lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("##2 hql " + hql);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("##2 " + getAutoResolvedFromString(context));
lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("##3 hql " + hql);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("##3 " + getAutoResolvedFromString(context));
lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("testAutoJoinResolverauto join HQL:" + hql);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("testAutoJoinResolver@@Resolved join chain:[" + getAutoResolvedFromString(rewrittenQu
lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("testDimOnlyJoinChainExpected1 : " + expectedClauses);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("testDimOnlyJoinChainActual1 : " + actualClauses);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("testAutoJoinResolverauto join HQL:" + hql);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("testAutoJoinResolver@@Resolved join chain:[" + getAutoResolvedFromString(rewrittenQu
lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("testDimOnlyJoinChainExpected1 : " + expectedClauses);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("testDimOnlyJoinChainActual1 : " + actualClauses);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("testAutoJoinResolverauto join HQL:" + hql);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("testAutoJoinResolver@@Resolved join chain:[" + getAutoResolvedFromString(rewrittenQu
lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("testDimOnlyJoinChainExpected1 : " + expectedClauses);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("testDimOnlyJoinChainActual1 : " + actualClauses);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestMaxUpdateInterval.java:        System.out.println(pairs[i].toString());
lens-cube/src/test/java/org/apache/lens/cube/parse/TestORTimeRangeWriter.java:    System.out.println("Expected :" + StorageUtil.getWherePartClause("dt", "test", parts));
lens-cube/src/test/java/org/apache/lens/cube/parse/TestORTimeRangeWriter.java:    System.out.println("Expected :" + StorageUtil.getWherePartClause("dt", "test", parts));
lens-cube/src/test/java/org/apache/lens/cube/parse/TestORTimeRangeWriter.java:    System.out.println("Expected :" + StorageUtil.getWherePartClause("dt", "test", parts));
lens-cube/src/test/java/org/apache/lens/cube/parse/TestStorageUtil.java:    System.out.println("results:" + result);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestStorageUtil.java:    System.out.println("results:" + result);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestStorageUtil.java:    System.out.println("results:" + result);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestStorageUtil.java:    System.out.println("results:" + result);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestStorageUtil.java:    System.out.println("results:" + result);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestStorageUtil.java:    System.out.println("results:" + result);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestStorageUtil.java:    System.out.println("results:" + result);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeExtractor.java:    System.out.println("###");
lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java:    System.out.println("HQL:" + hqlQuery);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java:    System.out.println("HQL:" + hqlQuery);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java:    System.out.println("HQL:" + hqlQuery);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java:    System.out.println("HQL:" + hqlQuery);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java:    System.out.println("HQL:" + hqlQuery);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java:    System.out.println("HQL:" + hqlQuery);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java:    System.out.println("HQL:" + hqlQuery);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java:    System.out.println("HQL:" + hqlQuery);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java:    System.out.println("HQL:" + hqlQuery);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java:    System.out.println("HQL:" + hqlQuery);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java:    System.out.println("HQL:" + hqlQuery);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java:    System.out.println("HQL:" + hqlQuery);
lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java:    System.out.println("HQL:" + hqlQuery);
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java:    System.out.println("###HADOOP_PATH " + System.getProperty("hadoop.bin.path"));
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java:    System.out.println("TestHiveDriver created");
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java:    System.out.println("Hadoop Location: " + System.getProperty("hadoop.bin.path"));
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java:    System.out.println("Hadoop Location: " + System.getProperty("hadoop.bin.path"));
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java:      System.out.println("Progress:" + ctx.getDriverStatus().getProgressMessage());
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java:      System.out.println("Error:" + ctx.getDriverStatus().getErrorMessage());
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java:      System.out.println("Status:" + ctx.getDriverStatus().getStatusMessage());
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java:          System.out.println("Actual:" + line);
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java:      System.out.println("#W Waiting for query " + ctx.getQueryHandle() + " status: "
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java:      System.out.println("Progress:" + ctx.getDriverStatus().getProgressMessage());
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java:    System.out.println("Tables:" + plan.getTablesQueried());
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java:    System.out.println("Parts:" + plan.getPartitions());
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java:    System.out.println("TestRemoteHiveDriver created");
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java:    System.out.println("@@@@ start_persistence_test");
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java:      System.out.println("@@ Adding partition " + i);
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java:    System.out.println("@@ partitions" + plan.getPartitions());
lens-driver-impala/src/test/java/org/apache/lens/driver/impala/it/ITImpalaDriver.java:      System.out.println("Row1" + row);
lens-driver-impala/src/test/java/org/apache/lens/driver/impala/it/ITImpalaDriver.java:      System.out.println("Row2" + row);
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java:    System.out.println("Created table : " + table);
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java:    System.out.println(joinTreeBeforeRewrite);
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java:    System.out.println(joinTreeAfterRewrite);
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java:    System.out.println(joinTreeBeforeRewrite);
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java:    System.out.println(joinTreeAfterRewrite);
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java:    System.out.println("default case: " + joinTreeAfterRewrite);
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java:    System.out.println("Created table " + table);
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJDBCFinal.java:    System.out.println("Driver configured!");
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJDBCFinal.java:    System.out.println("Driver closed!");
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJDBCFinal.java:        System.out.println(rowObjects);
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJDBCFinal.java:        System.out.println(rowObjects);
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java:      System.out.println("Error : " + ex);
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java:    System.out.println("@@@ Test_execute_async:" + context.getQueryHandle());
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java:        System.out.println("@@@@ Query is complete " + handle);
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java:      System.out.println("Query: " + handle + " Status: " + context.getDriverStatus());
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java:      System.out.println("Matched metadata");
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java:        System.out.println("Matched exception");
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java:      System.out.println("@@@@ QUERY " + (i + 1));
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java:    System.out.println("@@@ Submitting valid query");
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java:      System.out.println("@@@@ QUERY " + (i + 1));
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java:    System.out.println("@@@ Submitting query after pool quota used");
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java:    System.out.println("@@@ test_cancel:" + context.getQueryHandle());
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java:      System.out.println("Query: " + handle + " Status: " + ctx.getDriverStatus());
lens-examples/src/main/java/org/apache/lens/examples/PopulateSampleMetastore.java:      System.out.println("Adding partition from:dim1-local-part.xml failed");
lens-examples/src/main/java/org/apache/lens/examples/PopulateSampleMetastore.java:      System.out.println("Added partition from:dim1-local-part.xml");
lens-examples/src/main/java/org/apache/lens/examples/PopulateSampleMetastore.java:      System.out.println("Adding partition from:dim2-local-part.xml failed");
lens-examples/src/main/java/org/apache/lens/examples/PopulateSampleMetastore.java:      System.out.println("Added partition from:dim2-local-part.xml");
lens-examples/src/main/java/org/apache/lens/examples/PopulateSampleMetastore.java:      System.out.println("Adding partition from:dim4-local-part.xml failed");
lens-examples/src/main/java/org/apache/lens/examples/PopulateSampleMetastore.java:      System.out.println("Added partition from:dim4-local-part.xml");
lens-examples/src/main/java/org/apache/lens/examples/PopulateSampleMetastore.java:      System.out.println("Created DB storages for dim_table3 and dim_table4");
lens-examples/src/main/java/org/apache/lens/examples/PopulateSampleMetastore.java:      System.out.println("Creating DB storage failed for dim_table3 and dim_table4");
lens-examples/src/main/java/org/apache/lens/examples/PopulateSampleMetastore.java:      System.out.println("Adding partition from:" + fileName + " failed");
lens-examples/src/main/java/org/apache/lens/examples/PopulateSampleMetastore.java:      System.out.println("Added partition from:" + fileName);
lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java:        System.out.println("Creating cube from:sample-cube.xml failed");
lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java:        System.out.println("Creating dimension from:sample-dimension.xml failed");
lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java:        System.out.println("Creating dimension from:sample-dimension2.xml failed");
lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java:        System.out.println("Creating dimension from:sample-db-only-dimension.xml failed");
lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java:        System.out.println("Creating storage from:" + fileName + " failed");
lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java:        System.out.println("Creating dim table from: dim_table.xml and dim1-storage-tables.xml failed");
lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java:        System.out.println("Creating dim table from: dim_table2.xml and dim2-storage-tables.xml failed");
lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java:        System.out.println("Creating dim table from: dim_table3.xml and dim3-storage-tables.xml failed");
lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java:        System.out.println("Creating dim table from: dim_table4.xml and dim4-storage-tables.xml failed");
lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java:        System.out.println("Creating fact table from: fact1.xml and fact1-storage-tables.xml failed");
lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java:        System.out.println("Creating fact table from: fact2.xml and fact2-storage-tables.xml failed");
lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java:        System.out.println("Creating fact table from: rawfact.xml and rawfact-storage-tables.xml failed");
lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java:      System.out.println("Created sample metastore!");
lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java:      System.out.println("Database:" + metastore.metaClient.getCurrentDatabase());;
lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java:      System.out.println("Storages:" + metastore.metaClient.getAllStorages());;
lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java:      System.out.println("Cubes:" + metastore.metaClient.getAllCubes());;
lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java:      System.out.println("Dimensions:" + metastore.metaClient.getAllDimensions());;
lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java:      System.out.println("Fact tables:" + metastore.metaClient.getAllFactTables());;
lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java:      System.out.println("Dimension tables:" + metastore.metaClient.getAllDimensionTables());
lens-examples/src/main/java/org/apache/lens/examples/SampleQueries.java:    System.out.println("Successful queries " + success + " out of " + total + "queries");
lens-examples/src/main/java/org/apache/lens/examples/SampleQueries.java:      System.out.println("Query:" + query);
lens-examples/src/main/java/org/apache/lens/examples/SampleQueries.java:      System.out.println("Status:" + queryClient.getQuery().getStatus());
lens-examples/src/main/java/org/apache/lens/examples/SampleQueries.java:      System.out.println("Total time in millis:"
lens-examples/src/main/java/org/apache/lens/examples/SampleQueries.java:      System.out.println("Driver run time in millis:"
lens-examples/src/main/java/org/apache/lens/examples/SampleQueries.java:          System.out.println("Result:");
lens-examples/src/main/java/org/apache/lens/examples/SampleQueries.java:              System.out.println(StringUtils.join(row.getValues(), "\t"));
lens-examples/src/main/java/org/apache/lens/examples/SampleQueries.java:            System.out.println("Result stored at " + persistentQueryResult.getPersistedURI());
lens-examples/src/main/java/org/apache/lens/examples/SampleQueries.java:      System.out.println("--------------------");
lens-ml-lib/src/main/java/org/apache/lens/ml/task/MLTask.java:    System.out.println(builder.toString());
lens-ml-lib/src/main/java/org/apache/lens/ml/task/MLTask.java:    System.out.println(builder.toString());
lens-ml-lib/src/main/java/org/apache/lens/rdd/LensRDDClient.java:      System.out.println("@@@@ COL " + rc.getName() + " TYPE " + toHiveType(rc.getType()));
lens-query-lib/src/main/java/org/apache/lens/lib/query/ZipFileFormatter.java:    System.out.println("Setup outputs done");
lens-query-lib/src/test/java/org/apache/lens/lib/query/TestFilePersistentFormatter.java:    System.out.println("Actual rows:" + actual);
lens-query-lib/src/test/java/org/apache/lens/lib/query/TestFilePersistentFormatter.java:    System.out.println("Actual rows:" + actual);
lens-server/src/main/java/org/apache/lens/server/LensServletContextListener.java:        System.out.println("Application BasePath:" + basePath);
lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java:    System.out.println("Remote hive server started!");
lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java:    System.out.println("Lens services started!");
lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java:    System.out.println("Lens services stopped!");
lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java:    System.out.println("Remote hive server stopped!");
lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java:    System.out.println("Final report");
lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java:    System.out.println("Lens services stopped!");
lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java:    System.out.println("Lens services restarted!");
lens-server/src/test/java/org/apache/lens/server/TestIndexResource.java:    System.out.println("target path:" + target.getUri());
lens-server/src/test/java/org/apache/lens/server/TestServerMode.java:        System.out.println("Create databse not allowed in mode:" + mode);
lens-server/src/test/java/org/apache/lens/server/TestServerMode.java:        System.out.println("Drop databse not allowed in mode:" + mode);
lens-server/src/test/java/org/apache/lens/server/TestServerMode.java:        System.out.println("Launching query not allowed in mode:" + mode);
lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java:    System.out.println("### Test session restart");
lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java:    System.out.println("Session params:" + sessionParams.getElements());
lens-server/src/test/java/org/apache/lens/server/TestStaticFileResource.java:    System.out.println("@@@@ " + target().path("index.html").getUri());
lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java:    System.out.println("ALL DBs:" + allDbs.getElements());
lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java:      System.out.println("Attributes:" + dim.getAttributes());
lens-server/src/test/java/org/apache/lens/server/query/TestEventService.java:    System.out.println("@@@ testQueryStatusLogger");
lens-server/src/test/java/org/apache/lens/server/query/TestEventService.java:        System.out.println("@@@@ Got Event: Type= " + event.getClass().getName() + " obj = " + event);
lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java:    System.out.println("@@ State = " + queryContext.getStatus().getStatus().name());
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java:    System.out.println("%% " + failedQueries);
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java:      System.out.println("%% query " + ctx.getQueryHandle() + " status:" + stat);
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java:    System.out.println("%% " + metricsSvc.getTotalFailedQueries());
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java:    // System.out.println("query JSON:" + responseJSON);
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java:    System.out.println("query XML:" + queryXML);
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java:    System.out.println("PERSISTED RESULT:" + presultset);
lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java:    System.out.println("Session params:" + sessionParams.getElements());
lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java:    System.out.println("Session params:" + sessionParams.getElements());
lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java:    System.out.println("Session params:" + sessionParams.getElements());
lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java:    System.out.println("Session params:" + sessionParams.getElements());
lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java:      System.out.println("sessionParams:" + sessionParams.getElements());

- Himanshu

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29422/#review66178
-----------------------------------------------------------

On Dec. 27, 2014, 10:55 a.m., Himanshu Gahlaut wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29422/
> -----------------------------------------------------------
> 
> (Updated Dec. 27, 2014, 10:55 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> (1) getExpressionWithoutAlias in GroupbyResolver.class is unable to handle aliases with spaces in them. Fixed the same.
> (2) Also improved log4j.properties of lens-cube to send logs to both console appender and test log files. 
> (3) Used Slf4j annotation in Test classes for getting a reference to Slf4j logger. Added required dependencies in lens-cube/pom.xml to facilitate the same.
> 
> 
> Diffs
> -----
> 
>   lens-cube/pom.xml 1bcb4dc 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java c2fef7e 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 8e41830 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java f515df1 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java ad4abcf 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryRewrite.java fd939e9 
>   lens-cube/src/test/resources/log4j.properties 9729de0 
> 
> Diff: https://reviews.apache.org/r/29422/diff/
> 
> 
> Testing
> -------
> 
> Added new unit test cases for the changes.
> All existing Unit Test Cases passed.
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [14.068s]
> [INFO] Lens .............................................. SUCCESS [5.717s]
> [INFO] Lens API .......................................... SUCCESS [9.369s]
> [INFO] Lens API for server and extensions ................ SUCCESS [8.624s]
> [INFO] Lens Cube ......................................... SUCCESS [7:10.440s]
> [INFO] Lens DB storage ................................... SUCCESS [23.631s]
> [INFO] Lens Query Library ................................ SUCCESS [9.386s]
> [INFO] Lens Hive Driver .................................. SUCCESS [3:34.922s]
> [INFO] Lens Driver for Cloudera Impala ................... SUCCESS [10.798s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [36.429s]
> [INFO] Lens Server ....................................... SUCCESS [14:29.334s]
> [INFO] Lens client ....................................... SUCCESS [45.711s]
> [INFO] Lens CLI .......................................... SUCCESS [3:10.102s]
> [INFO] Lens Examples ..................................... SUCCESS [3.064s]
> [INFO] Lens Distribution ................................. SUCCESS [11.315s]
> [INFO] Lens Client Distribution .......................... SUCCESS [7.496s]
> [INFO] Lens ML Lib ....................................... SUCCESS [2:32.231s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 34:03.600s
> [INFO] Finished at: Fri Dec 26 18:21:01 IST 2014
> [INFO] Final Memory: 100M/332M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Himanshu Gahlaut
> 
>

Re: Review Request 29422: LENS-151: Fix for promotion of select expression to group by failing when column aliases have spaces

Posted by Himanshu Gahlaut <ga...@gmail.com>.


> On Dec. 27, 2014, 12:09 p.m., Laxman Ch wrote:
> > lens-cube/src/test/resources/log4j.properties, line 31
> > <https://reviews.apache.org/r/29422/diff/4/?file=801698#file801698line31>
> >
> >     I prefer %-5p only. More readable.
> 
> Himanshu Gahlaut wrote:
>     What is the difference between %p and %-5p ? p is for priority and output for priority  remains the same with or without -5.

Got it. Fixed. Thanks for the suggestion.


- Himanshu


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29422/#review66178
-----------------------------------------------------------


On Dec. 27, 2014, 10:55 a.m., Himanshu Gahlaut wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29422/
> -----------------------------------------------------------
> 
> (Updated Dec. 27, 2014, 10:55 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> (1) getExpressionWithoutAlias in GroupbyResolver.class is unable to handle aliases with spaces in them. Fixed the same.
> (2) Also improved log4j.properties of lens-cube to send logs to both console appender and test log files. 
> (3) Used Slf4j annotation in Test classes for getting a reference to Slf4j logger. Added required dependencies in lens-cube/pom.xml to facilitate the same.
> 
> 
> Diffs
> -----
> 
>   lens-cube/pom.xml 1bcb4dc 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java c2fef7e 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 8e41830 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java f515df1 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java ad4abcf 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryRewrite.java fd939e9 
>   lens-cube/src/test/resources/log4j.properties 9729de0 
> 
> Diff: https://reviews.apache.org/r/29422/diff/
> 
> 
> Testing
> -------
> 
> Added new unit test cases for the changes.
> All existing Unit Test Cases passed.
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [14.068s]
> [INFO] Lens .............................................. SUCCESS [5.717s]
> [INFO] Lens API .......................................... SUCCESS [9.369s]
> [INFO] Lens API for server and extensions ................ SUCCESS [8.624s]
> [INFO] Lens Cube ......................................... SUCCESS [7:10.440s]
> [INFO] Lens DB storage ................................... SUCCESS [23.631s]
> [INFO] Lens Query Library ................................ SUCCESS [9.386s]
> [INFO] Lens Hive Driver .................................. SUCCESS [3:34.922s]
> [INFO] Lens Driver for Cloudera Impala ................... SUCCESS [10.798s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [36.429s]
> [INFO] Lens Server ....................................... SUCCESS [14:29.334s]
> [INFO] Lens client ....................................... SUCCESS [45.711s]
> [INFO] Lens CLI .......................................... SUCCESS [3:10.102s]
> [INFO] Lens Examples ..................................... SUCCESS [3.064s]
> [INFO] Lens Distribution ................................. SUCCESS [11.315s]
> [INFO] Lens Client Distribution .......................... SUCCESS [7.496s]
> [INFO] Lens ML Lib ....................................... SUCCESS [2:32.231s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 34:03.600s
> [INFO] Finished at: Fri Dec 26 18:21:01 IST 2014
> [INFO] Final Memory: 100M/332M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Himanshu Gahlaut
> 
>

Re: Review Request 29422: LENS-151: Fix for promotion of select expression to group by failing when column aliases have spaces

Posted by Himanshu Gahlaut <ga...@gmail.com>.


> On Dec. 27, 2014, 12:09 p.m., Laxman Ch wrote:
> > lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java, line 188
> > <https://reviews.apache.org/r/29422/diff/4/?file=801695#file801695line188>
> >
> >     nit again. can we have this inline with other variables. avoid setter and assign variable directly after get.

I would have chosen that approach, if the variables were getting assigned in Constructor. This would have also helped me to keep the variable final. Since the code is in an init method, I can't make the variables final and in such cases a preferred abstraction way of setting the variable leads to more reusable code. Thanks for bringing the attention here, this has given rise to another thought in me to make the method private.


- Himanshu


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29422/#review66178
-----------------------------------------------------------


On Dec. 27, 2014, 10:55 a.m., Himanshu Gahlaut wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29422/
> -----------------------------------------------------------
> 
> (Updated Dec. 27, 2014, 10:55 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> (1) getExpressionWithoutAlias in GroupbyResolver.class is unable to handle aliases with spaces in them. Fixed the same.
> (2) Also improved log4j.properties of lens-cube to send logs to both console appender and test log files. 
> (3) Used Slf4j annotation in Test classes for getting a reference to Slf4j logger. Added required dependencies in lens-cube/pom.xml to facilitate the same.
> 
> 
> Diffs
> -----
> 
>   lens-cube/pom.xml 1bcb4dc 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java c2fef7e 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 8e41830 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java f515df1 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java ad4abcf 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryRewrite.java fd939e9 
>   lens-cube/src/test/resources/log4j.properties 9729de0 
> 
> Diff: https://reviews.apache.org/r/29422/diff/
> 
> 
> Testing
> -------
> 
> Added new unit test cases for the changes.
> All existing Unit Test Cases passed.
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [14.068s]
> [INFO] Lens .............................................. SUCCESS [5.717s]
> [INFO] Lens API .......................................... SUCCESS [9.369s]
> [INFO] Lens API for server and extensions ................ SUCCESS [8.624s]
> [INFO] Lens Cube ......................................... SUCCESS [7:10.440s]
> [INFO] Lens DB storage ................................... SUCCESS [23.631s]
> [INFO] Lens Query Library ................................ SUCCESS [9.386s]
> [INFO] Lens Hive Driver .................................. SUCCESS [3:34.922s]
> [INFO] Lens Driver for Cloudera Impala ................... SUCCESS [10.798s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [36.429s]
> [INFO] Lens Server ....................................... SUCCESS [14:29.334s]
> [INFO] Lens client ....................................... SUCCESS [45.711s]
> [INFO] Lens CLI .......................................... SUCCESS [3:10.102s]
> [INFO] Lens Examples ..................................... SUCCESS [3.064s]
> [INFO] Lens Distribution ................................. SUCCESS [11.315s]
> [INFO] Lens Client Distribution .......................... SUCCESS [7.496s]
> [INFO] Lens ML Lib ....................................... SUCCESS [2:32.231s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 34:03.600s
> [INFO] Finished at: Fri Dec 26 18:21:01 IST 2014
> [INFO] Final Memory: 100M/332M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Himanshu Gahlaut
> 
>

Re: Review Request 29422: LENS-151: Fix for promotion of select expression to group by failing when column aliases have spaces

Posted by Himanshu Gahlaut <ga...@gmail.com>.


> On Dec. 27, 2014, 12:09 p.m., Laxman Ch wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java, line 163
> > <https://reviews.apache.org/r/29422/diff/4/?file=801693#file801693line163>
> >
> >     Please clarify
> >     
> >     - getNonMsrNonAggSelExprsWithoutAlias is a subset of selectExprs. That means we are promoting a subset. What happens to the rest? No need to promote.
> >      
> >     - Does this scenario doesn't occur with group by aliases having space? Can we have a testcase for the same.

For point 1, the old logic was to not promote the rest, hence have kept the same. 
For your second point, it is a bit unclear to me but it is looking interesting. could you provide me a input user query and expected HQL query, so that i can be clear about this thought and also test it ?


- Himanshu


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29422/#review66178
-----------------------------------------------------------


On Dec. 27, 2014, 10:55 a.m., Himanshu Gahlaut wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29422/
> -----------------------------------------------------------
> 
> (Updated Dec. 27, 2014, 10:55 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> (1) getExpressionWithoutAlias in GroupbyResolver.class is unable to handle aliases with spaces in them. Fixed the same.
> (2) Also improved log4j.properties of lens-cube to send logs to both console appender and test log files. 
> (3) Used Slf4j annotation in Test classes for getting a reference to Slf4j logger. Added required dependencies in lens-cube/pom.xml to facilitate the same.
> 
> 
> Diffs
> -----
> 
>   lens-cube/pom.xml 1bcb4dc 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java c2fef7e 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 8e41830 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java f515df1 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java ad4abcf 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryRewrite.java fd939e9 
>   lens-cube/src/test/resources/log4j.properties 9729de0 
> 
> Diff: https://reviews.apache.org/r/29422/diff/
> 
> 
> Testing
> -------
> 
> Added new unit test cases for the changes.
> All existing Unit Test Cases passed.
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [14.068s]
> [INFO] Lens .............................................. SUCCESS [5.717s]
> [INFO] Lens API .......................................... SUCCESS [9.369s]
> [INFO] Lens API for server and extensions ................ SUCCESS [8.624s]
> [INFO] Lens Cube ......................................... SUCCESS [7:10.440s]
> [INFO] Lens DB storage ................................... SUCCESS [23.631s]
> [INFO] Lens Query Library ................................ SUCCESS [9.386s]
> [INFO] Lens Hive Driver .................................. SUCCESS [3:34.922s]
> [INFO] Lens Driver for Cloudera Impala ................... SUCCESS [10.798s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [36.429s]
> [INFO] Lens Server ....................................... SUCCESS [14:29.334s]
> [INFO] Lens client ....................................... SUCCESS [45.711s]
> [INFO] Lens CLI .......................................... SUCCESS [3:10.102s]
> [INFO] Lens Examples ..................................... SUCCESS [3.064s]
> [INFO] Lens Distribution ................................. SUCCESS [11.315s]
> [INFO] Lens Client Distribution .......................... SUCCESS [7.496s]
> [INFO] Lens ML Lib ....................................... SUCCESS [2:32.231s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 34:03.600s
> [INFO] Finished at: Fri Dec 26 18:21:01 IST 2014
> [INFO] Final Memory: 100M/332M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Himanshu Gahlaut
> 
>

Re: Review Request 29422: LENS-151: Fix for promotion of select expression to group by failing when column aliases have spaces

Posted by Himanshu Gahlaut <ga...@gmail.com>.


> On Dec. 27, 2014, 12:09 p.m., Laxman Ch wrote:
> > lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java, line 163
> > <https://reviews.apache.org/r/29422/diff/4/?file=801695#file801695line163>
> >
> >     nit. few more sysouts missed to port to log
> 
> Himanshu Gahlaut wrote:
>     There are 266 occurences of System.out in Lens Code (Pasted below). We can park a new Jira to port them. Objective here was not to port them all but do a beginning to start removing them. Hence only ported a few of them. Thanks for bringing up the discussion though.
>     
>     
>     lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java:    System.out.println("@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@");
>     lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java:    System.out.println("@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@");
>     lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java:    System.out.println("@@PERSISTENT_RESULT_TEST-------------");
>     lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java:      System.out.println("@@ RESULT " + result);
>     lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java:    System.out.println("@@END_PERSISTENT_RESULT_TEST-------------");
>     lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java:    System.out.println("@@START_FINISHED_PURGED_RESULT_TEST-------------");
>     lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java:      System.out.println("@@ RESULT " + result);
>     lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java:    System.out.println("@@END_FINISHED_PURGED_RESULT_TEST-------------");
>     lens-cube/src/main/java/org/apache/lens/cube/metadata/SchemaGraph.java:      System.out.println("**Cube " + cube.getName() + " Out egdes");
>     lens-cube/src/main/java/org/apache/lens/cube/metadata/SchemaGraph.java:      System.out.println("--Out Graph-Nodes=" + graph.size());
>     lens-cube/src/main/java/org/apache/lens/cube/metadata/SchemaGraph.java:        System.out.println(tab.getName() + "::" + graph.get(tab));
>     lens-cube/src/main/java/org/apache/lens/cube/metadata/SchemaGraph.java:    System.out.println("**Dim only outgraph");
>     lens-cube/src/main/java/org/apache/lens/cube/metadata/SchemaGraph.java:    System.out.println("--Out Graph-Nodes=" + dimOnlyOutGraph.size());
>     lens-cube/src/main/java/org/apache/lens/cube/metadata/SchemaGraph.java:      System.out.println(tab.getName() + "::" + dimOnlyOutGraph.get(tab));
>     lens-cube/src/main/java/org/apache/lens/cube/metadata/SchemaGraph.java:      System.out.println("**Cube " + cube.getName() + " In egdes");
>     lens-cube/src/main/java/org/apache/lens/cube/metadata/SchemaGraph.java:      System.out.println("--In Graph-Nodes=" + graph.size());
>     lens-cube/src/main/java/org/apache/lens/cube/metadata/SchemaGraph.java:        System.out.println(tab.getName() + "::" + graph.get(tab));
>     lens-cube/src/main/java/org/apache/lens/cube/metadata/SchemaGraph.java:    System.out.println("**Dim only Ingraph");
>     lens-cube/src/main/java/org/apache/lens/cube/metadata/SchemaGraph.java:    System.out.println("--In Graph-Nodes=" + dimOnlyInGraph.size());
>     lens-cube/src/main/java/org/apache/lens/cube/metadata/SchemaGraph.java:      System.out.println(tab.getName() + "::" + dimOnlyInGraph.get(tab));
>     lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java:      System.out.println("Rewritten HQL:" + hql);
>     lens-cube/src/main/java/org/apache/lens/cube/parse/CubeSemanticAnalyzer.java:    // System.out.println(sinkOp.toString());
>     lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java:    System.out.println();
>     lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java:      System.out.println(" {");
>     lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java:          System.out.println("NON ASTNode");
>     lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java:        System.out.println();
>     lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java:    System.out.println("Test twodaysBack:" + twodaysBack);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java:    System.out.println("Test twoMonthsBack:" + twoMonthsBack);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java:    System.out.println("--" + label + "--AST--");
>     lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java:    System.out.println("--query- " + query);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestAggregateResolver.java:      System.out.println("hql[" + i + "]:" + hql);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java:    //System.out.println("HQL:" + hqlQuery);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java:    //System.out.println("Expected:" + expected);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestBetweenTimeRangeWriter.java:    System.out.println("Expected :" + StorageUtil.getWherePartClause("dt", "test", parts));
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:    System.out.println("Non existing parts:" + rewrittenQuery.getNonExistingParts());
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:    System.out.println("Non existing parts:" + rewrittenQuery.getNonExistingParts());
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:      System.out.println("Union hql query:" + hqlQuery);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:      System.out.println("union query:" + hqlQuery);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:    System.out.println("Query With process time col:" + hqlQuery);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:    System.out.println("Query With process time col:" + hqlQuery);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:    System.out.println("Query With process time col:" + hqlQuery);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:    System.out.println("Query With process time col:" + hqlQuery);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:    System.out.println("Query With process time col:" + hqlQuery);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:    System.out.println("Query With process time col:" + hqlQuery);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:    System.out.println("@@ Joins disabled? " + testConf.get(CubeQueryConfUtil.DISABLE_AUTO_JOINS));
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:      System.out.println("TestJoinPathTimeRange: " + context.toHQL());
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:      System.out.println("@@ hql: " + hql);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:    System.out.println("@@" + hql);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:    System.out.println("@@2 " + hql);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:      System.out.println("@@HQL " + hql);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:    System.out.println("##testDimAttributeQueryWithFact " + rewrittenQuery);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:      System.out.println("@@ HQL = " + hql);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java:    System.out.println("HQL query:" + hqlQuery);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java:    System.out.println("HQL query:" + hqlQuery);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java:    System.out.println("HQL query:" + hqlQuery);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java:    System.out.println("HQL query:" + hqlQuery);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java:    System.out.println("HQL query:" + hqlQuery);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    System.out.println("###Actual order by:" + HQLParser.getString(orderby).trim());
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    System.out.println("reconstructed clause ");
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    System.out.println(selectStr);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    System.out.println("reconstructed clause 2");
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    System.out.println(selectStr);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    System.out.println("reconstructed clause ");
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    System.out.println(selectStr);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    System.out.println("reconstructed clause 2");
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    System.out.println(selectStr);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    System.out.println(whereStr);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    System.out.println(whereStr);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    System.out.println(whereStr);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    System.out.println(whereStr);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    System.out.println(whereStr);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    System.out.println(selectStr);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    System.out.println(whereStr);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    System.out.println(whereStr);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    System.out.println("RECONSTRUCTED0:" + reconstructed);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    System.out.println("RECONSTRUCTED1:" + reconstructed);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    System.out.println("RECONSTRUCTED2:" + reconstructed);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    System.out.println("RECONSTRUCTED3:" + reconstructed);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    System.out.println(selectStr);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    System.out.println(selectStr);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    System.out.println(selectStr);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    System.out.println(selectStr);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    System.out.println("genQuery1: " + genQuery);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    System.out.println("genQuery2: " + genQuery2);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("@@ " + source + " ==> " + target + " paths =");
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:      System.out.println(++i + " " + jp.getEdges());
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("--Graph-Nodes=" + graph.size());
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:      System.out.println(tab.getName() + "::" + graph.get(tab));
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("testAutoJoinResolverauto join HQL:" + hql);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("testAutoJoinResolver@@Resolved join chain:[" + getAutoResolvedFromString(rewrittenQu
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("testAutoJoinResolverExpected1" + expectedClauses);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("testAutoJoinResolverActual1" + actualClauses);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("testAutoJoinResolverauto join HQL:" + hql);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("testAutoJoinResolver@@Resolved join chain:[" + getAutoResolvedFromString(rewrittenQu
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("testAutoJoinResolverExpected2" + expectedClauses);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("testAutoJoinResolverActual2" + actualClauses);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("testPartialJoinResolver Partial join hql: " + hql);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("@Resolved join clause " + joinClause);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("@@Set join type to " + hconf.get(CubeQueryConfUtil.JOIN_TYPE_KEY));
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("testJoinTypeConf@@Resolved join clause1 - " + getAutoResolvedFromString(ctx));
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("@@Set join type to " + hconf.get(CubeQueryConfUtil.JOIN_TYPE_KEY));
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("testJoinTypeConf@@Resolved join clause2 - " + getAutoResolvedFromString(ctx));
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("testPreserveTableAlias@@HQL:" + hql);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("testPreserveTableAlias@@Resolved join clause - " + getAutoResolvedFromString(ctx));
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("testDimOnlyQuery@@@HQL:" + hql);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("testDimOnlyQuery@@@Resolved join clause: " + getAutoResolvedFromString(ctx));
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("testDimOnlyQuery@@@HQL2:" + hql);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("##1 hql " + hql);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("##1 " + getAutoResolvedFromString(context));
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("##2 hql " + hql);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("##2 " + getAutoResolvedFromString(context));
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("##3 hql " + hql);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("##3 " + getAutoResolvedFromString(context));
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("testAutoJoinResolverauto join HQL:" + hql);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("testAutoJoinResolver@@Resolved join chain:[" + getAutoResolvedFromString(rewrittenQu
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("testDimOnlyJoinChainExpected1 : " + expectedClauses);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("testDimOnlyJoinChainActual1 : " + actualClauses);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("testAutoJoinResolverauto join HQL:" + hql);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("testAutoJoinResolver@@Resolved join chain:[" + getAutoResolvedFromString(rewrittenQu
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("testDimOnlyJoinChainExpected1 : " + expectedClauses);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("testDimOnlyJoinChainActual1 : " + actualClauses);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("testAutoJoinResolverauto join HQL:" + hql);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("testAutoJoinResolver@@Resolved join chain:[" + getAutoResolvedFromString(rewrittenQu
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("testDimOnlyJoinChainExpected1 : " + expectedClauses);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("testDimOnlyJoinChainActual1 : " + actualClauses);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestMaxUpdateInterval.java:        System.out.println(pairs[i].toString());
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestORTimeRangeWriter.java:    System.out.println("Expected :" + StorageUtil.getWherePartClause("dt", "test", parts));
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestORTimeRangeWriter.java:    System.out.println("Expected :" + StorageUtil.getWherePartClause("dt", "test", parts));
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestORTimeRangeWriter.java:    System.out.println("Expected :" + StorageUtil.getWherePartClause("dt", "test", parts));
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestStorageUtil.java:    System.out.println("results:" + result);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestStorageUtil.java:    System.out.println("results:" + result);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestStorageUtil.java:    System.out.println("results:" + result);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestStorageUtil.java:    System.out.println("results:" + result);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestStorageUtil.java:    System.out.println("results:" + result);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestStorageUtil.java:    System.out.println("results:" + result);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestStorageUtil.java:    System.out.println("results:" + result);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeExtractor.java:    System.out.println("###");
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java:    System.out.println("HQL:" + hqlQuery);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java:    System.out.println("HQL:" + hqlQuery);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java:    System.out.println("HQL:" + hqlQuery);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java:    System.out.println("HQL:" + hqlQuery);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java:    System.out.println("HQL:" + hqlQuery);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java:    System.out.println("HQL:" + hqlQuery);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java:    System.out.println("HQL:" + hqlQuery);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java:    System.out.println("HQL:" + hqlQuery);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java:    System.out.println("HQL:" + hqlQuery);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java:    System.out.println("HQL:" + hqlQuery);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java:    System.out.println("HQL:" + hqlQuery);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java:    System.out.println("HQL:" + hqlQuery);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java:    System.out.println("HQL:" + hqlQuery);
>     lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java:    System.out.println("###HADOOP_PATH " + System.getProperty("hadoop.bin.path"));
>     lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java:    System.out.println("TestHiveDriver created");
>     lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java:    System.out.println("Hadoop Location: " + System.getProperty("hadoop.bin.path"));
>     lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java:    System.out.println("Hadoop Location: " + System.getProperty("hadoop.bin.path"));
>     lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java:      System.out.println("Progress:" + ctx.getDriverStatus().getProgressMessage());
>     lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java:      System.out.println("Error:" + ctx.getDriverStatus().getErrorMessage());
>     lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java:      System.out.println("Status:" + ctx.getDriverStatus().getStatusMessage());
>     lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java:          System.out.println("Actual:" + line);
>     lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java:      System.out.println("#W Waiting for query " + ctx.getQueryHandle() + " status: "
>     lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java:      System.out.println("Progress:" + ctx.getDriverStatus().getProgressMessage());
>     lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java:    System.out.println("Tables:" + plan.getTablesQueried());
>     lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java:    System.out.println("Parts:" + plan.getPartitions());
>     lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java:    System.out.println("TestRemoteHiveDriver created");
>     lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java:    System.out.println("@@@@ start_persistence_test");
>     lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java:      System.out.println("@@ Adding partition " + i);
>     lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java:    System.out.println("@@ partitions" + plan.getPartitions());
>     lens-driver-impala/src/test/java/org/apache/lens/driver/impala/it/ITImpalaDriver.java:      System.out.println("Row1" + row);
>     lens-driver-impala/src/test/java/org/apache/lens/driver/impala/it/ITImpalaDriver.java:      System.out.println("Row2" + row);
>     lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java:    System.out.println("Created table : " + table);
>     lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java:    System.out.println(joinTreeBeforeRewrite);
>     lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java:    System.out.println(joinTreeAfterRewrite);
>     lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java:    System.out.println(joinTreeBeforeRewrite);
>     lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java:    System.out.println(joinTreeAfterRewrite);
>     lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java:    System.out.println("default case: " + joinTreeAfterRewrite);
>     lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java:    System.out.println("Created table " + table);
>     lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJDBCFinal.java:    System.out.println("Driver configured!");
>     lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJDBCFinal.java:    System.out.println("Driver closed!");
>     lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJDBCFinal.java:        System.out.println(rowObjects);
>     lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJDBCFinal.java:        System.out.println(rowObjects);
>     lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java:      System.out.println("Error : " + ex);
>     lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java:    System.out.println("@@@ Test_execute_async:" + context.getQueryHandle());
>     lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java:        System.out.println("@@@@ Query is complete " + handle);
>     lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java:      System.out.println("Query: " + handle + " Status: " + context.getDriverStatus());
>     lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java:      System.out.println("Matched metadata");
>     lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java:        System.out.println("Matched exception");
>     lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java:      System.out.println("@@@@ QUERY " + (i + 1));
>     lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java:    System.out.println("@@@ Submitting valid query");
>     lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java:      System.out.println("@@@@ QUERY " + (i + 1));
>     lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java:    System.out.println("@@@ Submitting query after pool quota used");
>     lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java:    System.out.println("@@@ test_cancel:" + context.getQueryHandle());
>     lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java:      System.out.println("Query: " + handle + " Status: " + ctx.getDriverStatus());
>     lens-examples/src/main/java/org/apache/lens/examples/PopulateSampleMetastore.java:      System.out.println("Adding partition from:dim1-local-part.xml failed");
>     lens-examples/src/main/java/org/apache/lens/examples/PopulateSampleMetastore.java:      System.out.println("Added partition from:dim1-local-part.xml");
>     lens-examples/src/main/java/org/apache/lens/examples/PopulateSampleMetastore.java:      System.out.println("Adding partition from:dim2-local-part.xml failed");
>     lens-examples/src/main/java/org/apache/lens/examples/PopulateSampleMetastore.java:      System.out.println("Added partition from:dim2-local-part.xml");
>     lens-examples/src/main/java/org/apache/lens/examples/PopulateSampleMetastore.java:      System.out.println("Adding partition from:dim4-local-part.xml failed");
>     lens-examples/src/main/java/org/apache/lens/examples/PopulateSampleMetastore.java:      System.out.println("Added partition from:dim4-local-part.xml");
>     lens-examples/src/main/java/org/apache/lens/examples/PopulateSampleMetastore.java:      System.out.println("Created DB storages for dim_table3 and dim_table4");
>     lens-examples/src/main/java/org/apache/lens/examples/PopulateSampleMetastore.java:      System.out.println("Creating DB storage failed for dim_table3 and dim_table4");
>     lens-examples/src/main/java/org/apache/lens/examples/PopulateSampleMetastore.java:      System.out.println("Adding partition from:" + fileName + " failed");
>     lens-examples/src/main/java/org/apache/lens/examples/PopulateSampleMetastore.java:      System.out.println("Added partition from:" + fileName);
>     lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java:        System.out.println("Creating cube from:sample-cube.xml failed");
>     lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java:        System.out.println("Creating dimension from:sample-dimension.xml failed");
>     lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java:        System.out.println("Creating dimension from:sample-dimension2.xml failed");
>     lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java:        System.out.println("Creating dimension from:sample-db-only-dimension.xml failed");
>     lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java:        System.out.println("Creating storage from:" + fileName + " failed");
>     lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java:        System.out.println("Creating dim table from: dim_table.xml and dim1-storage-tables.xml failed");
>     lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java:        System.out.println("Creating dim table from: dim_table2.xml and dim2-storage-tables.xml failed");
>     lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java:        System.out.println("Creating dim table from: dim_table3.xml and dim3-storage-tables.xml failed");
>     lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java:        System.out.println("Creating dim table from: dim_table4.xml and dim4-storage-tables.xml failed");
>     lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java:        System.out.println("Creating fact table from: fact1.xml and fact1-storage-tables.xml failed");
>     lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java:        System.out.println("Creating fact table from: fact2.xml and fact2-storage-tables.xml failed");
>     lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java:        System.out.println("Creating fact table from: rawfact.xml and rawfact-storage-tables.xml failed");
>     lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java:      System.out.println("Created sample metastore!");
>     lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java:      System.out.println("Database:" + metastore.metaClient.getCurrentDatabase());;
>     lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java:      System.out.println("Storages:" + metastore.metaClient.getAllStorages());;
>     lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java:      System.out.println("Cubes:" + metastore.metaClient.getAllCubes());;
>     lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java:      System.out.println("Dimensions:" + metastore.metaClient.getAllDimensions());;
>     lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java:      System.out.println("Fact tables:" + metastore.metaClient.getAllFactTables());;
>     lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java:      System.out.println("Dimension tables:" + metastore.metaClient.getAllDimensionTables());
>     lens-examples/src/main/java/org/apache/lens/examples/SampleQueries.java:    System.out.println("Successful queries " + success + " out of " + total + "queries");
>     lens-examples/src/main/java/org/apache/lens/examples/SampleQueries.java:      System.out.println("Query:" + query);
>     lens-examples/src/main/java/org/apache/lens/examples/SampleQueries.java:      System.out.println("Status:" + queryClient.getQuery().getStatus());
>     lens-examples/src/main/java/org/apache/lens/examples/SampleQueries.java:      System.out.println("Total time in millis:"
>     lens-examples/src/main/java/org/apache/lens/examples/SampleQueries.java:      System.out.println("Driver run time in millis:"
>     lens-examples/src/main/java/org/apache/lens/examples/SampleQueries.java:          System.out.println("Result:");
>     lens-examples/src/main/java/org/apache/lens/examples/SampleQueries.java:              System.out.println(StringUtils.join(row.getValues(), "\t"));
>     lens-examples/src/main/java/org/apache/lens/examples/SampleQueries.java:            System.out.println("Result stored at " + persistentQueryResult.getPersistedURI());
>     lens-examples/src/main/java/org/apache/lens/examples/SampleQueries.java:      System.out.println("--------------------");
>     lens-ml-lib/src/main/java/org/apache/lens/ml/task/MLTask.java:    System.out.println(builder.toString());
>     lens-ml-lib/src/main/java/org/apache/lens/ml/task/MLTask.java:    System.out.println(builder.toString());
>     lens-ml-lib/src/main/java/org/apache/lens/rdd/LensRDDClient.java:      System.out.println("@@@@ COL " + rc.getName() + " TYPE " + toHiveType(rc.getType()));
>     lens-query-lib/src/main/java/org/apache/lens/lib/query/ZipFileFormatter.java:    System.out.println("Setup outputs done");
>     lens-query-lib/src/test/java/org/apache/lens/lib/query/TestFilePersistentFormatter.java:    System.out.println("Actual rows:" + actual);
>     lens-query-lib/src/test/java/org/apache/lens/lib/query/TestFilePersistentFormatter.java:    System.out.println("Actual rows:" + actual);
>     lens-server/src/main/java/org/apache/lens/server/LensServletContextListener.java:        System.out.println("Application BasePath:" + basePath);
>     lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java:    System.out.println("Remote hive server started!");
>     lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java:    System.out.println("Lens services started!");
>     lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java:    System.out.println("Lens services stopped!");
>     lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java:    System.out.println("Remote hive server stopped!");
>     lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java:    System.out.println("Final report");
>     lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java:    System.out.println("Lens services stopped!");
>     lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java:    System.out.println("Lens services restarted!");
>     lens-server/src/test/java/org/apache/lens/server/TestIndexResource.java:    System.out.println("target path:" + target.getUri());
>     lens-server/src/test/java/org/apache/lens/server/TestServerMode.java:        System.out.println("Create databse not allowed in mode:" + mode);
>     lens-server/src/test/java/org/apache/lens/server/TestServerMode.java:        System.out.println("Drop databse not allowed in mode:" + mode);
>     lens-server/src/test/java/org/apache/lens/server/TestServerMode.java:        System.out.println("Launching query not allowed in mode:" + mode);
>     lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java:    System.out.println("### Test session restart");
>     lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java:    System.out.println("Session params:" + sessionParams.getElements());
>     lens-server/src/test/java/org/apache/lens/server/TestStaticFileResource.java:    System.out.println("@@@@ " + target().path("index.html").getUri());
>     lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java:    System.out.println("ALL DBs:" + allDbs.getElements());
>     lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java:      System.out.println("Attributes:" + dim.getAttributes());
>     lens-server/src/test/java/org/apache/lens/server/query/TestEventService.java:    System.out.println("@@@ testQueryStatusLogger");
>     lens-server/src/test/java/org/apache/lens/server/query/TestEventService.java:        System.out.println("@@@@ Got Event: Type= " + event.getClass().getName() + " obj = " + event);
>     lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java:    System.out.println("@@ State = " + queryContext.getStatus().getStatus().name());
>     lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java:    System.out.println("%% " + failedQueries);
>     lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java:      System.out.println("%% query " + ctx.getQueryHandle() + " status:" + stat);
>     lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java:    System.out.println("%% " + metricsSvc.getTotalFailedQueries());
>     lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java:    // System.out.println("query JSON:" + responseJSON);
>     lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java:    System.out.println("query XML:" + queryXML);
>     lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java:    System.out.println("PERSISTED RESULT:" + presultset);
>     lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java:    System.out.println("Session params:" + sessionParams.getElements());
>     lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java:    System.out.println("Session params:" + sessionParams.getElements());
>     lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java:    System.out.println("Session params:" + sessionParams.getElements());
>     lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java:    System.out.println("Session params:" + sessionParams.getElements());
>     lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java:      System.out.println("sessionParams:" + sessionParams.getElements());
> 
> Laxman Ch wrote:
>     Agreed. We should have a separate jira. Do you mind to file one?

Was creating one. Here is the link: https://issues.apache.org/jira/browse/LENS-171


- Himanshu


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29422/#review66178
-----------------------------------------------------------


On Dec. 27, 2014, 10:55 a.m., Himanshu Gahlaut wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29422/
> -----------------------------------------------------------
> 
> (Updated Dec. 27, 2014, 10:55 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> (1) getExpressionWithoutAlias in GroupbyResolver.class is unable to handle aliases with spaces in them. Fixed the same.
> (2) Also improved log4j.properties of lens-cube to send logs to both console appender and test log files. 
> (3) Used Slf4j annotation in Test classes for getting a reference to Slf4j logger. Added required dependencies in lens-cube/pom.xml to facilitate the same.
> 
> 
> Diffs
> -----
> 
>   lens-cube/pom.xml 1bcb4dc 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java c2fef7e 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 8e41830 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java f515df1 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java ad4abcf 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryRewrite.java fd939e9 
>   lens-cube/src/test/resources/log4j.properties 9729de0 
> 
> Diff: https://reviews.apache.org/r/29422/diff/
> 
> 
> Testing
> -------
> 
> Added new unit test cases for the changes.
> All existing Unit Test Cases passed.
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [14.068s]
> [INFO] Lens .............................................. SUCCESS [5.717s]
> [INFO] Lens API .......................................... SUCCESS [9.369s]
> [INFO] Lens API for server and extensions ................ SUCCESS [8.624s]
> [INFO] Lens Cube ......................................... SUCCESS [7:10.440s]
> [INFO] Lens DB storage ................................... SUCCESS [23.631s]
> [INFO] Lens Query Library ................................ SUCCESS [9.386s]
> [INFO] Lens Hive Driver .................................. SUCCESS [3:34.922s]
> [INFO] Lens Driver for Cloudera Impala ................... SUCCESS [10.798s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [36.429s]
> [INFO] Lens Server ....................................... SUCCESS [14:29.334s]
> [INFO] Lens client ....................................... SUCCESS [45.711s]
> [INFO] Lens CLI .......................................... SUCCESS [3:10.102s]
> [INFO] Lens Examples ..................................... SUCCESS [3.064s]
> [INFO] Lens Distribution ................................. SUCCESS [11.315s]
> [INFO] Lens Client Distribution .......................... SUCCESS [7.496s]
> [INFO] Lens ML Lib ....................................... SUCCESS [2:32.231s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 34:03.600s
> [INFO] Finished at: Fri Dec 26 18:21:01 IST 2014
> [INFO] Final Memory: 100M/332M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Himanshu Gahlaut
> 
>

Re: Review Request 29422: LENS-151: Fix for promotion of select expression to group by failing when column aliases have spaces

Posted by Laxman Ch <la...@huawei.com>.


> On Dec. 27, 2014, 12:09 p.m., Laxman Ch wrote:
> > lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java, line 163
> > <https://reviews.apache.org/r/29422/diff/4/?file=801695#file801695line163>
> >
> >     nit. few more sysouts missed to port to log
> 
> Himanshu Gahlaut wrote:
>     There are 266 occurences of System.out in Lens Code (Pasted below). We can park a new Jira to port them. Objective here was not to port them all but do a beginning to start removing them. Hence only ported a few of them. Thanks for bringing up the discussion though.
>     
>     
>     lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java:    System.out.println("@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@");
>     lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java:    System.out.println("@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@");
>     lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java:    System.out.println("@@PERSISTENT_RESULT_TEST-------------");
>     lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java:      System.out.println("@@ RESULT " + result);
>     lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java:    System.out.println("@@END_PERSISTENT_RESULT_TEST-------------");
>     lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java:    System.out.println("@@START_FINISHED_PURGED_RESULT_TEST-------------");
>     lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java:      System.out.println("@@ RESULT " + result);
>     lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java:    System.out.println("@@END_FINISHED_PURGED_RESULT_TEST-------------");
>     lens-cube/src/main/java/org/apache/lens/cube/metadata/SchemaGraph.java:      System.out.println("**Cube " + cube.getName() + " Out egdes");
>     lens-cube/src/main/java/org/apache/lens/cube/metadata/SchemaGraph.java:      System.out.println("--Out Graph-Nodes=" + graph.size());
>     lens-cube/src/main/java/org/apache/lens/cube/metadata/SchemaGraph.java:        System.out.println(tab.getName() + "::" + graph.get(tab));
>     lens-cube/src/main/java/org/apache/lens/cube/metadata/SchemaGraph.java:    System.out.println("**Dim only outgraph");
>     lens-cube/src/main/java/org/apache/lens/cube/metadata/SchemaGraph.java:    System.out.println("--Out Graph-Nodes=" + dimOnlyOutGraph.size());
>     lens-cube/src/main/java/org/apache/lens/cube/metadata/SchemaGraph.java:      System.out.println(tab.getName() + "::" + dimOnlyOutGraph.get(tab));
>     lens-cube/src/main/java/org/apache/lens/cube/metadata/SchemaGraph.java:      System.out.println("**Cube " + cube.getName() + " In egdes");
>     lens-cube/src/main/java/org/apache/lens/cube/metadata/SchemaGraph.java:      System.out.println("--In Graph-Nodes=" + graph.size());
>     lens-cube/src/main/java/org/apache/lens/cube/metadata/SchemaGraph.java:        System.out.println(tab.getName() + "::" + graph.get(tab));
>     lens-cube/src/main/java/org/apache/lens/cube/metadata/SchemaGraph.java:    System.out.println("**Dim only Ingraph");
>     lens-cube/src/main/java/org/apache/lens/cube/metadata/SchemaGraph.java:    System.out.println("--In Graph-Nodes=" + dimOnlyInGraph.size());
>     lens-cube/src/main/java/org/apache/lens/cube/metadata/SchemaGraph.java:      System.out.println(tab.getName() + "::" + dimOnlyInGraph.get(tab));
>     lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java:      System.out.println("Rewritten HQL:" + hql);
>     lens-cube/src/main/java/org/apache/lens/cube/parse/CubeSemanticAnalyzer.java:    // System.out.println(sinkOp.toString());
>     lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java:    System.out.println();
>     lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java:      System.out.println(" {");
>     lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java:          System.out.println("NON ASTNode");
>     lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java:        System.out.println();
>     lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java:    System.out.println("Test twodaysBack:" + twodaysBack);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java:    System.out.println("Test twoMonthsBack:" + twoMonthsBack);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java:    System.out.println("--" + label + "--AST--");
>     lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java:    System.out.println("--query- " + query);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestAggregateResolver.java:      System.out.println("hql[" + i + "]:" + hql);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java:    //System.out.println("HQL:" + hqlQuery);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java:    //System.out.println("Expected:" + expected);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestBetweenTimeRangeWriter.java:    System.out.println("Expected :" + StorageUtil.getWherePartClause("dt", "test", parts));
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:    System.out.println("Non existing parts:" + rewrittenQuery.getNonExistingParts());
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:    System.out.println("Non existing parts:" + rewrittenQuery.getNonExistingParts());
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:      System.out.println("Union hql query:" + hqlQuery);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:      System.out.println("union query:" + hqlQuery);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:    System.out.println("Query With process time col:" + hqlQuery);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:    System.out.println("Query With process time col:" + hqlQuery);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:    System.out.println("Query With process time col:" + hqlQuery);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:    System.out.println("Query With process time col:" + hqlQuery);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:    System.out.println("Query With process time col:" + hqlQuery);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:    System.out.println("Query With process time col:" + hqlQuery);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:    System.out.println("@@ Joins disabled? " + testConf.get(CubeQueryConfUtil.DISABLE_AUTO_JOINS));
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:      System.out.println("TestJoinPathTimeRange: " + context.toHQL());
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:      System.out.println("@@ hql: " + hql);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:    System.out.println("@@" + hql);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:    System.out.println("@@2 " + hql);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:      System.out.println("@@HQL " + hql);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:    System.out.println("##testDimAttributeQueryWithFact " + rewrittenQuery);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:      System.out.println("@@ HQL = " + hql);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java:    System.out.println("HQL query:" + hqlQuery);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java:    System.out.println("HQL query:" + hqlQuery);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java:    System.out.println("HQL query:" + hqlQuery);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java:    System.out.println("HQL query:" + hqlQuery);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java:    System.out.println("HQL query:" + hqlQuery);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    System.out.println("###Actual order by:" + HQLParser.getString(orderby).trim());
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    System.out.println("reconstructed clause ");
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    System.out.println(selectStr);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    System.out.println("reconstructed clause 2");
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    System.out.println(selectStr);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    System.out.println("reconstructed clause ");
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    System.out.println(selectStr);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    System.out.println("reconstructed clause 2");
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    System.out.println(selectStr);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    System.out.println(whereStr);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    System.out.println(whereStr);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    System.out.println(whereStr);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    System.out.println(whereStr);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    System.out.println(whereStr);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    System.out.println(selectStr);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    System.out.println(whereStr);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    System.out.println(whereStr);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    System.out.println("RECONSTRUCTED0:" + reconstructed);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    System.out.println("RECONSTRUCTED1:" + reconstructed);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    System.out.println("RECONSTRUCTED2:" + reconstructed);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    System.out.println("RECONSTRUCTED3:" + reconstructed);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    System.out.println(selectStr);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    System.out.println(selectStr);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    System.out.println(selectStr);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    System.out.println(selectStr);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    System.out.println("genQuery1: " + genQuery);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java:    System.out.println("genQuery2: " + genQuery2);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("@@ " + source + " ==> " + target + " paths =");
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:      System.out.println(++i + " " + jp.getEdges());
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("--Graph-Nodes=" + graph.size());
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:      System.out.println(tab.getName() + "::" + graph.get(tab));
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("testAutoJoinResolverauto join HQL:" + hql);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("testAutoJoinResolver@@Resolved join chain:[" + getAutoResolvedFromString(rewrittenQu
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("testAutoJoinResolverExpected1" + expectedClauses);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("testAutoJoinResolverActual1" + actualClauses);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("testAutoJoinResolverauto join HQL:" + hql);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("testAutoJoinResolver@@Resolved join chain:[" + getAutoResolvedFromString(rewrittenQu
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("testAutoJoinResolverExpected2" + expectedClauses);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("testAutoJoinResolverActual2" + actualClauses);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("testPartialJoinResolver Partial join hql: " + hql);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("@Resolved join clause " + joinClause);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("@@Set join type to " + hconf.get(CubeQueryConfUtil.JOIN_TYPE_KEY));
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("testJoinTypeConf@@Resolved join clause1 - " + getAutoResolvedFromString(ctx));
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("@@Set join type to " + hconf.get(CubeQueryConfUtil.JOIN_TYPE_KEY));
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("testJoinTypeConf@@Resolved join clause2 - " + getAutoResolvedFromString(ctx));
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("testPreserveTableAlias@@HQL:" + hql);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("testPreserveTableAlias@@Resolved join clause - " + getAutoResolvedFromString(ctx));
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("testDimOnlyQuery@@@HQL:" + hql);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("testDimOnlyQuery@@@Resolved join clause: " + getAutoResolvedFromString(ctx));
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("testDimOnlyQuery@@@HQL2:" + hql);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("##1 hql " + hql);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("##1 " + getAutoResolvedFromString(context));
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("##2 hql " + hql);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("##2 " + getAutoResolvedFromString(context));
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("##3 hql " + hql);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("##3 " + getAutoResolvedFromString(context));
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("testAutoJoinResolverauto join HQL:" + hql);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("testAutoJoinResolver@@Resolved join chain:[" + getAutoResolvedFromString(rewrittenQu
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("testDimOnlyJoinChainExpected1 : " + expectedClauses);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("testDimOnlyJoinChainActual1 : " + actualClauses);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("testAutoJoinResolverauto join HQL:" + hql);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("testAutoJoinResolver@@Resolved join chain:[" + getAutoResolvedFromString(rewrittenQu
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("testDimOnlyJoinChainExpected1 : " + expectedClauses);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("testDimOnlyJoinChainActual1 : " + actualClauses);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("testAutoJoinResolverauto join HQL:" + hql);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("testAutoJoinResolver@@Resolved join chain:[" + getAutoResolvedFromString(rewrittenQu
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("testDimOnlyJoinChainExpected1 : " + expectedClauses);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:    System.out.println("testDimOnlyJoinChainActual1 : " + actualClauses);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestMaxUpdateInterval.java:        System.out.println(pairs[i].toString());
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestORTimeRangeWriter.java:    System.out.println("Expected :" + StorageUtil.getWherePartClause("dt", "test", parts));
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestORTimeRangeWriter.java:    System.out.println("Expected :" + StorageUtil.getWherePartClause("dt", "test", parts));
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestORTimeRangeWriter.java:    System.out.println("Expected :" + StorageUtil.getWherePartClause("dt", "test", parts));
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestStorageUtil.java:    System.out.println("results:" + result);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestStorageUtil.java:    System.out.println("results:" + result);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestStorageUtil.java:    System.out.println("results:" + result);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestStorageUtil.java:    System.out.println("results:" + result);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestStorageUtil.java:    System.out.println("results:" + result);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestStorageUtil.java:    System.out.println("results:" + result);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestStorageUtil.java:    System.out.println("results:" + result);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeExtractor.java:    System.out.println("###");
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java:    System.out.println("HQL:" + hqlQuery);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java:    System.out.println("HQL:" + hqlQuery);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java:    System.out.println("HQL:" + hqlQuery);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java:    System.out.println("HQL:" + hqlQuery);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java:    System.out.println("HQL:" + hqlQuery);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java:    System.out.println("HQL:" + hqlQuery);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java:    System.out.println("HQL:" + hqlQuery);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java:    System.out.println("HQL:" + hqlQuery);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java:    System.out.println("HQL:" + hqlQuery);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java:    System.out.println("HQL:" + hqlQuery);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java:    System.out.println("HQL:" + hqlQuery);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java:    System.out.println("HQL:" + hqlQuery);
>     lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java:    System.out.println("HQL:" + hqlQuery);
>     lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java:    System.out.println("###HADOOP_PATH " + System.getProperty("hadoop.bin.path"));
>     lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java:    System.out.println("TestHiveDriver created");
>     lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java:    System.out.println("Hadoop Location: " + System.getProperty("hadoop.bin.path"));
>     lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java:    System.out.println("Hadoop Location: " + System.getProperty("hadoop.bin.path"));
>     lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java:      System.out.println("Progress:" + ctx.getDriverStatus().getProgressMessage());
>     lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java:      System.out.println("Error:" + ctx.getDriverStatus().getErrorMessage());
>     lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java:      System.out.println("Status:" + ctx.getDriverStatus().getStatusMessage());
>     lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java:          System.out.println("Actual:" + line);
>     lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java:      System.out.println("#W Waiting for query " + ctx.getQueryHandle() + " status: "
>     lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java:      System.out.println("Progress:" + ctx.getDriverStatus().getProgressMessage());
>     lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java:    System.out.println("Tables:" + plan.getTablesQueried());
>     lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java:    System.out.println("Parts:" + plan.getPartitions());
>     lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java:    System.out.println("TestRemoteHiveDriver created");
>     lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java:    System.out.println("@@@@ start_persistence_test");
>     lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java:      System.out.println("@@ Adding partition " + i);
>     lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java:    System.out.println("@@ partitions" + plan.getPartitions());
>     lens-driver-impala/src/test/java/org/apache/lens/driver/impala/it/ITImpalaDriver.java:      System.out.println("Row1" + row);
>     lens-driver-impala/src/test/java/org/apache/lens/driver/impala/it/ITImpalaDriver.java:      System.out.println("Row2" + row);
>     lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java:    System.out.println("Created table : " + table);
>     lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java:    System.out.println(joinTreeBeforeRewrite);
>     lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java:    System.out.println(joinTreeAfterRewrite);
>     lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java:    System.out.println(joinTreeBeforeRewrite);
>     lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java:    System.out.println(joinTreeAfterRewrite);
>     lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java:    System.out.println("default case: " + joinTreeAfterRewrite);
>     lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java:    System.out.println("Created table " + table);
>     lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJDBCFinal.java:    System.out.println("Driver configured!");
>     lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJDBCFinal.java:    System.out.println("Driver closed!");
>     lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJDBCFinal.java:        System.out.println(rowObjects);
>     lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJDBCFinal.java:        System.out.println(rowObjects);
>     lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java:      System.out.println("Error : " + ex);
>     lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java:    System.out.println("@@@ Test_execute_async:" + context.getQueryHandle());
>     lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java:        System.out.println("@@@@ Query is complete " + handle);
>     lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java:      System.out.println("Query: " + handle + " Status: " + context.getDriverStatus());
>     lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java:      System.out.println("Matched metadata");
>     lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java:        System.out.println("Matched exception");
>     lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java:      System.out.println("@@@@ QUERY " + (i + 1));
>     lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java:    System.out.println("@@@ Submitting valid query");
>     lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java:      System.out.println("@@@@ QUERY " + (i + 1));
>     lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java:    System.out.println("@@@ Submitting query after pool quota used");
>     lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java:    System.out.println("@@@ test_cancel:" + context.getQueryHandle());
>     lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java:      System.out.println("Query: " + handle + " Status: " + ctx.getDriverStatus());
>     lens-examples/src/main/java/org/apache/lens/examples/PopulateSampleMetastore.java:      System.out.println("Adding partition from:dim1-local-part.xml failed");
>     lens-examples/src/main/java/org/apache/lens/examples/PopulateSampleMetastore.java:      System.out.println("Added partition from:dim1-local-part.xml");
>     lens-examples/src/main/java/org/apache/lens/examples/PopulateSampleMetastore.java:      System.out.println("Adding partition from:dim2-local-part.xml failed");
>     lens-examples/src/main/java/org/apache/lens/examples/PopulateSampleMetastore.java:      System.out.println("Added partition from:dim2-local-part.xml");
>     lens-examples/src/main/java/org/apache/lens/examples/PopulateSampleMetastore.java:      System.out.println("Adding partition from:dim4-local-part.xml failed");
>     lens-examples/src/main/java/org/apache/lens/examples/PopulateSampleMetastore.java:      System.out.println("Added partition from:dim4-local-part.xml");
>     lens-examples/src/main/java/org/apache/lens/examples/PopulateSampleMetastore.java:      System.out.println("Created DB storages for dim_table3 and dim_table4");
>     lens-examples/src/main/java/org/apache/lens/examples/PopulateSampleMetastore.java:      System.out.println("Creating DB storage failed for dim_table3 and dim_table4");
>     lens-examples/src/main/java/org/apache/lens/examples/PopulateSampleMetastore.java:      System.out.println("Adding partition from:" + fileName + " failed");
>     lens-examples/src/main/java/org/apache/lens/examples/PopulateSampleMetastore.java:      System.out.println("Added partition from:" + fileName);
>     lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java:        System.out.println("Creating cube from:sample-cube.xml failed");
>     lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java:        System.out.println("Creating dimension from:sample-dimension.xml failed");
>     lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java:        System.out.println("Creating dimension from:sample-dimension2.xml failed");
>     lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java:        System.out.println("Creating dimension from:sample-db-only-dimension.xml failed");
>     lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java:        System.out.println("Creating storage from:" + fileName + " failed");
>     lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java:        System.out.println("Creating dim table from: dim_table.xml and dim1-storage-tables.xml failed");
>     lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java:        System.out.println("Creating dim table from: dim_table2.xml and dim2-storage-tables.xml failed");
>     lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java:        System.out.println("Creating dim table from: dim_table3.xml and dim3-storage-tables.xml failed");
>     lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java:        System.out.println("Creating dim table from: dim_table4.xml and dim4-storage-tables.xml failed");
>     lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java:        System.out.println("Creating fact table from: fact1.xml and fact1-storage-tables.xml failed");
>     lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java:        System.out.println("Creating fact table from: fact2.xml and fact2-storage-tables.xml failed");
>     lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java:        System.out.println("Creating fact table from: rawfact.xml and rawfact-storage-tables.xml failed");
>     lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java:      System.out.println("Created sample metastore!");
>     lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java:      System.out.println("Database:" + metastore.metaClient.getCurrentDatabase());;
>     lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java:      System.out.println("Storages:" + metastore.metaClient.getAllStorages());;
>     lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java:      System.out.println("Cubes:" + metastore.metaClient.getAllCubes());;
>     lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java:      System.out.println("Dimensions:" + metastore.metaClient.getAllDimensions());;
>     lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java:      System.out.println("Fact tables:" + metastore.metaClient.getAllFactTables());;
>     lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java:      System.out.println("Dimension tables:" + metastore.metaClient.getAllDimensionTables());
>     lens-examples/src/main/java/org/apache/lens/examples/SampleQueries.java:    System.out.println("Successful queries " + success + " out of " + total + "queries");
>     lens-examples/src/main/java/org/apache/lens/examples/SampleQueries.java:      System.out.println("Query:" + query);
>     lens-examples/src/main/java/org/apache/lens/examples/SampleQueries.java:      System.out.println("Status:" + queryClient.getQuery().getStatus());
>     lens-examples/src/main/java/org/apache/lens/examples/SampleQueries.java:      System.out.println("Total time in millis:"
>     lens-examples/src/main/java/org/apache/lens/examples/SampleQueries.java:      System.out.println("Driver run time in millis:"
>     lens-examples/src/main/java/org/apache/lens/examples/SampleQueries.java:          System.out.println("Result:");
>     lens-examples/src/main/java/org/apache/lens/examples/SampleQueries.java:              System.out.println(StringUtils.join(row.getValues(), "\t"));
>     lens-examples/src/main/java/org/apache/lens/examples/SampleQueries.java:            System.out.println("Result stored at " + persistentQueryResult.getPersistedURI());
>     lens-examples/src/main/java/org/apache/lens/examples/SampleQueries.java:      System.out.println("--------------------");
>     lens-ml-lib/src/main/java/org/apache/lens/ml/task/MLTask.java:    System.out.println(builder.toString());
>     lens-ml-lib/src/main/java/org/apache/lens/ml/task/MLTask.java:    System.out.println(builder.toString());
>     lens-ml-lib/src/main/java/org/apache/lens/rdd/LensRDDClient.java:      System.out.println("@@@@ COL " + rc.getName() + " TYPE " + toHiveType(rc.getType()));
>     lens-query-lib/src/main/java/org/apache/lens/lib/query/ZipFileFormatter.java:    System.out.println("Setup outputs done");
>     lens-query-lib/src/test/java/org/apache/lens/lib/query/TestFilePersistentFormatter.java:    System.out.println("Actual rows:" + actual);
>     lens-query-lib/src/test/java/org/apache/lens/lib/query/TestFilePersistentFormatter.java:    System.out.println("Actual rows:" + actual);
>     lens-server/src/main/java/org/apache/lens/server/LensServletContextListener.java:        System.out.println("Application BasePath:" + basePath);
>     lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java:    System.out.println("Remote hive server started!");
>     lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java:    System.out.println("Lens services started!");
>     lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java:    System.out.println("Lens services stopped!");
>     lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java:    System.out.println("Remote hive server stopped!");
>     lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java:    System.out.println("Final report");
>     lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java:    System.out.println("Lens services stopped!");
>     lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java:    System.out.println("Lens services restarted!");
>     lens-server/src/test/java/org/apache/lens/server/TestIndexResource.java:    System.out.println("target path:" + target.getUri());
>     lens-server/src/test/java/org/apache/lens/server/TestServerMode.java:        System.out.println("Create databse not allowed in mode:" + mode);
>     lens-server/src/test/java/org/apache/lens/server/TestServerMode.java:        System.out.println("Drop databse not allowed in mode:" + mode);
>     lens-server/src/test/java/org/apache/lens/server/TestServerMode.java:        System.out.println("Launching query not allowed in mode:" + mode);
>     lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java:    System.out.println("### Test session restart");
>     lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java:    System.out.println("Session params:" + sessionParams.getElements());
>     lens-server/src/test/java/org/apache/lens/server/TestStaticFileResource.java:    System.out.println("@@@@ " + target().path("index.html").getUri());
>     lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java:    System.out.println("ALL DBs:" + allDbs.getElements());
>     lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java:      System.out.println("Attributes:" + dim.getAttributes());
>     lens-server/src/test/java/org/apache/lens/server/query/TestEventService.java:    System.out.println("@@@ testQueryStatusLogger");
>     lens-server/src/test/java/org/apache/lens/server/query/TestEventService.java:        System.out.println("@@@@ Got Event: Type= " + event.getClass().getName() + " obj = " + event);
>     lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java:    System.out.println("@@ State = " + queryContext.getStatus().getStatus().name());
>     lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java:    System.out.println("%% " + failedQueries);
>     lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java:      System.out.println("%% query " + ctx.getQueryHandle() + " status:" + stat);
>     lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java:    System.out.println("%% " + metricsSvc.getTotalFailedQueries());
>     lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java:    // System.out.println("query JSON:" + responseJSON);
>     lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java:    System.out.println("query XML:" + queryXML);
>     lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java:    System.out.println("PERSISTED RESULT:" + presultset);
>     lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java:    System.out.println("Session params:" + sessionParams.getElements());
>     lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java:    System.out.println("Session params:" + sessionParams.getElements());
>     lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java:    System.out.println("Session params:" + sessionParams.getElements());
>     lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java:    System.out.println("Session params:" + sessionParams.getElements());
>     lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java:      System.out.println("sessionParams:" + sessionParams.getElements());
> 
> Laxman Ch wrote:
>     Agreed. We should have a separate jira. Do you mind to file one?
> 
> Himanshu Gahlaut wrote:
>     Was creating one. Here is the link: https://issues.apache.org/jira/browse/LENS-171

Thank you.


> On Dec. 27, 2014, 12:09 p.m., Laxman Ch wrote:
> > lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java, line 188
> > <https://reviews.apache.org/r/29422/diff/4/?file=801695#file801695line188>
> >
> >     nit again. can we have this inline with other variables. avoid setter and assign variable directly after get.
> 
> Himanshu Gahlaut wrote:
>     I would have chosen that approach, if the variables were getting assigned in Constructor. This would have also helped me to keep the variable final. Since the code is in an init method, I can't make the variables final and in such cases a preferred abstraction way of setting the variable leads to more reusable code. Thanks for bringing the attention here, this has given rise to another thought in me to make the method private.

feel free to differ with me.
- abstraction costing two level nested methods. think of introducting one method for every variable. doesn't add much value imo. 
- now this looks hybrid and inconsistent. n-1 variables are getting assigned in one way and one in other way.


> On Dec. 27, 2014, 12:09 p.m., Laxman Ch wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java, line 163
> > <https://reviews.apache.org/r/29422/diff/4/?file=801693#file801693line163>
> >
> >     Please clarify
> >     
> >     - getNonMsrNonAggSelExprsWithoutAlias is a subset of selectExprs. That means we are promoting a subset. What happens to the rest? No need to promote.
> >      
> >     - Does this scenario doesn't occur with group by aliases having space? Can we have a testcase for the same.
> 
> Himanshu Gahlaut wrote:
>     For point 1, the old logic was to not promote the rest, hence have kept the same. 
>     For your second point, it is a bit unclear to me but it is looking interesting. could you provide me a input user query and expected HQL query, so that i can be clear about this thought and also test it ?

not sure about HQL. we need to seek some hql expert's help here.
but i can provide one in rdbms world

select count(empno) "head count" from employee group by deptno;


- Laxman


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29422/#review66178
-----------------------------------------------------------


On Dec. 27, 2014, 10:55 a.m., Himanshu Gahlaut wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29422/
> -----------------------------------------------------------
> 
> (Updated Dec. 27, 2014, 10:55 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> (1) getExpressionWithoutAlias in GroupbyResolver.class is unable to handle aliases with spaces in them. Fixed the same.
> (2) Also improved log4j.properties of lens-cube to send logs to both console appender and test log files. 
> (3) Used Slf4j annotation in Test classes for getting a reference to Slf4j logger. Added required dependencies in lens-cube/pom.xml to facilitate the same.
> 
> 
> Diffs
> -----
> 
>   lens-cube/pom.xml 1bcb4dc 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java c2fef7e 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 8e41830 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java f515df1 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java ad4abcf 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryRewrite.java fd939e9 
>   lens-cube/src/test/resources/log4j.properties 9729de0 
> 
> Diff: https://reviews.apache.org/r/29422/diff/
> 
> 
> Testing
> -------
> 
> Added new unit test cases for the changes.
> All existing Unit Test Cases passed.
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [14.068s]
> [INFO] Lens .............................................. SUCCESS [5.717s]
> [INFO] Lens API .......................................... SUCCESS [9.369s]
> [INFO] Lens API for server and extensions ................ SUCCESS [8.624s]
> [INFO] Lens Cube ......................................... SUCCESS [7:10.440s]
> [INFO] Lens DB storage ................................... SUCCESS [23.631s]
> [INFO] Lens Query Library ................................ SUCCESS [9.386s]
> [INFO] Lens Hive Driver .................................. SUCCESS [3:34.922s]
> [INFO] Lens Driver for Cloudera Impala ................... SUCCESS [10.798s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [36.429s]
> [INFO] Lens Server ....................................... SUCCESS [14:29.334s]
> [INFO] Lens client ....................................... SUCCESS [45.711s]
> [INFO] Lens CLI .......................................... SUCCESS [3:10.102s]
> [INFO] Lens Examples ..................................... SUCCESS [3.064s]
> [INFO] Lens Distribution ................................. SUCCESS [11.315s]
> [INFO] Lens Client Distribution .......................... SUCCESS [7.496s]
> [INFO] Lens ML Lib ....................................... SUCCESS [2:32.231s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 34:03.600s
> [INFO] Finished at: Fri Dec 26 18:21:01 IST 2014
> [INFO] Final Memory: 100M/332M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Himanshu Gahlaut
> 
>

Re: Review Request 29422: LENS-151: Fix for promotion of select expression to group by failing when column aliases have spaces

Posted by Amareshwari Sriramadasu <am...@apache.org>.


> On Dec. 27, 2014, 12:09 p.m., Laxman Ch wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java, line 163
> > <https://reviews.apache.org/r/29422/diff/4/?file=801693#file801693line163>
> >
> >     Please clarify
> >     
> >     - getNonMsrNonAggSelExprsWithoutAlias is a subset of selectExprs. That means we are promoting a subset. What happens to the rest? No need to promote.
> >      
> >     - Does this scenario doesn't occur with group by aliases having space? Can we have a testcase for the same.
> 
> Himanshu Gahlaut wrote:
>     For point 1, the old logic was to not promote the rest, hence have kept the same. 
>     For your second point, it is a bit unclear to me but it is looking interesting. could you provide me a input user query and expected HQL query, so that i can be clear about this thought and also test it ?
> 
> Laxman Ch wrote:
>     not sure about HQL. we need to seek some hql expert's help here.
>     but i can provide one in rdbms world
>     
>     select count(empno) "head count" from employee group by deptno;
> 
> Himanshu Gahlaut wrote:
>     select count(empno) "head count" from employee group by deptno;
>     
>     This kind of query will not require empno to be promoted to group by because an aggregate is applied on empno. Any other query ?

getNonMsrNonAggSelExprsWithoutAlias is a subset of selectExprs. That means we are promoting a subset. What happens to the rest? No need to promote.
>> Yes

Does this scenario doesn't occur with group by aliases having space? Can we have a testcase for the same.
>> There cannot be aliases in group by clause


- Amareshwari


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29422/#review66178
-----------------------------------------------------------


On Dec. 28, 2014, 5:42 a.m., Himanshu Gahlaut wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29422/
> -----------------------------------------------------------
> 
> (Updated Dec. 28, 2014, 5:42 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> (1) getExpressionWithoutAlias in GroupbyResolver.class is unable to handle aliases with spaces in them. Fixed the same.
> (2) Also improved log4j.properties of lens-cube to send logs to both console appender and test log files. 
> (3) Used Slf4j annotation in Test classes for getting a reference to Slf4j logger. Added required dependencies in lens-cube/pom.xml to facilitate the same.
> 
> 
> Diffs
> -----
> 
>   lens-cube/pom.xml 1bcb4dc 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java c2fef7e 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 8e41830 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java f515df1 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java ad4abcf 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryRewrite.java fd939e9 
>   lens-cube/src/test/resources/log4j.properties 9729de0 
> 
> Diff: https://reviews.apache.org/r/29422/diff/
> 
> 
> Testing
> -------
> 
> Added new unit test cases for the changes.
> All existing Unit Test Cases passed.
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [14.068s]
> [INFO] Lens .............................................. SUCCESS [5.717s]
> [INFO] Lens API .......................................... SUCCESS [9.369s]
> [INFO] Lens API for server and extensions ................ SUCCESS [8.624s]
> [INFO] Lens Cube ......................................... SUCCESS [7:10.440s]
> [INFO] Lens DB storage ................................... SUCCESS [23.631s]
> [INFO] Lens Query Library ................................ SUCCESS [9.386s]
> [INFO] Lens Hive Driver .................................. SUCCESS [3:34.922s]
> [INFO] Lens Driver for Cloudera Impala ................... SUCCESS [10.798s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [36.429s]
> [INFO] Lens Server ....................................... SUCCESS [14:29.334s]
> [INFO] Lens client ....................................... SUCCESS [45.711s]
> [INFO] Lens CLI .......................................... SUCCESS [3:10.102s]
> [INFO] Lens Examples ..................................... SUCCESS [3.064s]
> [INFO] Lens Distribution ................................. SUCCESS [11.315s]
> [INFO] Lens Client Distribution .......................... SUCCESS [7.496s]
> [INFO] Lens ML Lib ....................................... SUCCESS [2:32.231s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 34:03.600s
> [INFO] Finished at: Fri Dec 26 18:21:01 IST 2014
> [INFO] Final Memory: 100M/332M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Himanshu Gahlaut
> 
>

Re: Review Request 29422: LENS-151: Fix for promotion of select expression to group by failing when column aliases have spaces

Posted by Himanshu Gahlaut <ga...@gmail.com>.


> On Dec. 27, 2014, 12:09 p.m., Laxman Ch wrote:
> > lens-cube/src/test/resources/log4j.properties, line 31
> > <https://reviews.apache.org/r/29422/diff/4/?file=801698#file801698line31>
> >
> >     I prefer %-5p only. More readable.

What is the difference between %p and %-5p ? p is for priority and output for priority  remains the same with or without -5.


- Himanshu


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29422/#review66178
-----------------------------------------------------------


On Dec. 27, 2014, 10:55 a.m., Himanshu Gahlaut wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29422/
> -----------------------------------------------------------
> 
> (Updated Dec. 27, 2014, 10:55 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> (1) getExpressionWithoutAlias in GroupbyResolver.class is unable to handle aliases with spaces in them. Fixed the same.
> (2) Also improved log4j.properties of lens-cube to send logs to both console appender and test log files. 
> (3) Used Slf4j annotation in Test classes for getting a reference to Slf4j logger. Added required dependencies in lens-cube/pom.xml to facilitate the same.
> 
> 
> Diffs
> -----
> 
>   lens-cube/pom.xml 1bcb4dc 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java c2fef7e 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 8e41830 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java f515df1 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java ad4abcf 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryRewrite.java fd939e9 
>   lens-cube/src/test/resources/log4j.properties 9729de0 
> 
> Diff: https://reviews.apache.org/r/29422/diff/
> 
> 
> Testing
> -------
> 
> Added new unit test cases for the changes.
> All existing Unit Test Cases passed.
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [14.068s]
> [INFO] Lens .............................................. SUCCESS [5.717s]
> [INFO] Lens API .......................................... SUCCESS [9.369s]
> [INFO] Lens API for server and extensions ................ SUCCESS [8.624s]
> [INFO] Lens Cube ......................................... SUCCESS [7:10.440s]
> [INFO] Lens DB storage ................................... SUCCESS [23.631s]
> [INFO] Lens Query Library ................................ SUCCESS [9.386s]
> [INFO] Lens Hive Driver .................................. SUCCESS [3:34.922s]
> [INFO] Lens Driver for Cloudera Impala ................... SUCCESS [10.798s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [36.429s]
> [INFO] Lens Server ....................................... SUCCESS [14:29.334s]
> [INFO] Lens client ....................................... SUCCESS [45.711s]
> [INFO] Lens CLI .......................................... SUCCESS [3:10.102s]
> [INFO] Lens Examples ..................................... SUCCESS [3.064s]
> [INFO] Lens Distribution ................................. SUCCESS [11.315s]
> [INFO] Lens Client Distribution .......................... SUCCESS [7.496s]
> [INFO] Lens ML Lib ....................................... SUCCESS [2:32.231s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 34:03.600s
> [INFO] Finished at: Fri Dec 26 18:21:01 IST 2014
> [INFO] Final Memory: 100M/332M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Himanshu Gahlaut
> 
>

Re: Review Request 29422: LENS-151: Fix for promotion of select expression to group by failing when column aliases have spaces

Posted by Himanshu Gahlaut <ga...@gmail.com>.


> On Dec. 27, 2014, 12:09 p.m., Laxman Ch wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java, line 163
> > <https://reviews.apache.org/r/29422/diff/4/?file=801693#file801693line163>
> >
> >     Please clarify
> >     
> >     - getNonMsrNonAggSelExprsWithoutAlias is a subset of selectExprs. That means we are promoting a subset. What happens to the rest? No need to promote.
> >      
> >     - Does this scenario doesn't occur with group by aliases having space? Can we have a testcase for the same.
> 
> Himanshu Gahlaut wrote:
>     For point 1, the old logic was to not promote the rest, hence have kept the same. 
>     For your second point, it is a bit unclear to me but it is looking interesting. could you provide me a input user query and expected HQL query, so that i can be clear about this thought and also test it ?
> 
> Laxman Ch wrote:
>     not sure about HQL. we need to seek some hql expert's help here.
>     but i can provide one in rdbms world
>     
>     select count(empno) "head count" from employee group by deptno;

select count(empno) "head count" from employee group by deptno;

This kind of query will not require empno to be promoted to group by because an aggregate is applied on empno. Any other query ?


- Himanshu


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29422/#review66178
-----------------------------------------------------------


On Dec. 27, 2014, 10:55 a.m., Himanshu Gahlaut wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29422/
> -----------------------------------------------------------
> 
> (Updated Dec. 27, 2014, 10:55 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> (1) getExpressionWithoutAlias in GroupbyResolver.class is unable to handle aliases with spaces in them. Fixed the same.
> (2) Also improved log4j.properties of lens-cube to send logs to both console appender and test log files. 
> (3) Used Slf4j annotation in Test classes for getting a reference to Slf4j logger. Added required dependencies in lens-cube/pom.xml to facilitate the same.
> 
> 
> Diffs
> -----
> 
>   lens-cube/pom.xml 1bcb4dc 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java c2fef7e 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 8e41830 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java f515df1 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java ad4abcf 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryRewrite.java fd939e9 
>   lens-cube/src/test/resources/log4j.properties 9729de0 
> 
> Diff: https://reviews.apache.org/r/29422/diff/
> 
> 
> Testing
> -------
> 
> Added new unit test cases for the changes.
> All existing Unit Test Cases passed.
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [14.068s]
> [INFO] Lens .............................................. SUCCESS [5.717s]
> [INFO] Lens API .......................................... SUCCESS [9.369s]
> [INFO] Lens API for server and extensions ................ SUCCESS [8.624s]
> [INFO] Lens Cube ......................................... SUCCESS [7:10.440s]
> [INFO] Lens DB storage ................................... SUCCESS [23.631s]
> [INFO] Lens Query Library ................................ SUCCESS [9.386s]
> [INFO] Lens Hive Driver .................................. SUCCESS [3:34.922s]
> [INFO] Lens Driver for Cloudera Impala ................... SUCCESS [10.798s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [36.429s]
> [INFO] Lens Server ....................................... SUCCESS [14:29.334s]
> [INFO] Lens client ....................................... SUCCESS [45.711s]
> [INFO] Lens CLI .......................................... SUCCESS [3:10.102s]
> [INFO] Lens Examples ..................................... SUCCESS [3.064s]
> [INFO] Lens Distribution ................................. SUCCESS [11.315s]
> [INFO] Lens Client Distribution .......................... SUCCESS [7.496s]
> [INFO] Lens ML Lib ....................................... SUCCESS [2:32.231s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 34:03.600s
> [INFO] Finished at: Fri Dec 26 18:21:01 IST 2014
> [INFO] Final Memory: 100M/332M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Himanshu Gahlaut
> 
>

Re: Review Request 29422: LENS-151: Fix for promotion of select expression to group by failing when column aliases have spaces

Posted by Himanshu Gahlaut <ga...@gmail.com>.


> On Dec. 27, 2014, 12:09 p.m., Laxman Ch wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java, line 163
> > <https://reviews.apache.org/r/29422/diff/4/?file=801693#file801693line163>
> >
> >     Please clarify
> >     
> >     - getNonMsrNonAggSelExprsWithoutAlias is a subset of selectExprs. That means we are promoting a subset. What happens to the rest? No need to promote.
> >      
> >     - Does this scenario doesn't occur with group by aliases having space? Can we have a testcase for the same.
> 
> Himanshu Gahlaut wrote:
>     For point 1, the old logic was to not promote the rest, hence have kept the same. 
>     For your second point, it is a bit unclear to me but it is looking interesting. could you provide me a input user query and expected HQL query, so that i can be clear about this thought and also test it ?
> 
> Laxman Ch wrote:
>     not sure about HQL. we need to seek some hql expert's help here.
>     but i can provide one in rdbms world
>     
>     select count(empno) "head count" from employee group by deptno;
> 
> Himanshu Gahlaut wrote:
>     select count(empno) "head count" from employee group by deptno;
>     
>     This kind of query will not require empno to be promoted to group by because an aggregate is applied on empno. Any other query ?
> 
> Amareshwari Sriramadasu wrote:
>     getNonMsrNonAggSelExprsWithoutAlias is a subset of selectExprs. That means we are promoting a subset. What happens to the rest? No need to promote.
>     >> Yes
>     
>     Does this scenario doesn't occur with group by aliases having space? Can we have a testcase for the same.
>     >> There cannot be aliases in group by clause

@Laxman, Has Amareshwari's reply clarified the doubt ?


- Himanshu


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29422/#review66178
-----------------------------------------------------------


On Dec. 28, 2014, 5:42 a.m., Himanshu Gahlaut wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29422/
> -----------------------------------------------------------
> 
> (Updated Dec. 28, 2014, 5:42 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> (1) getExpressionWithoutAlias in GroupbyResolver.class is unable to handle aliases with spaces in them. Fixed the same.
> (2) Also improved log4j.properties of lens-cube to send logs to both console appender and test log files. 
> (3) Used Slf4j annotation in Test classes for getting a reference to Slf4j logger. Added required dependencies in lens-cube/pom.xml to facilitate the same.
> 
> 
> Diffs
> -----
> 
>   lens-cube/pom.xml 1bcb4dc 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java c2fef7e 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 8e41830 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java f515df1 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java ad4abcf 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryRewrite.java fd939e9 
>   lens-cube/src/test/resources/log4j.properties 9729de0 
> 
> Diff: https://reviews.apache.org/r/29422/diff/
> 
> 
> Testing
> -------
> 
> Added new unit test cases for the changes.
> All existing Unit Test Cases passed.
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [14.068s]
> [INFO] Lens .............................................. SUCCESS [5.717s]
> [INFO] Lens API .......................................... SUCCESS [9.369s]
> [INFO] Lens API for server and extensions ................ SUCCESS [8.624s]
> [INFO] Lens Cube ......................................... SUCCESS [7:10.440s]
> [INFO] Lens DB storage ................................... SUCCESS [23.631s]
> [INFO] Lens Query Library ................................ SUCCESS [9.386s]
> [INFO] Lens Hive Driver .................................. SUCCESS [3:34.922s]
> [INFO] Lens Driver for Cloudera Impala ................... SUCCESS [10.798s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [36.429s]
> [INFO] Lens Server ....................................... SUCCESS [14:29.334s]
> [INFO] Lens client ....................................... SUCCESS [45.711s]
> [INFO] Lens CLI .......................................... SUCCESS [3:10.102s]
> [INFO] Lens Examples ..................................... SUCCESS [3.064s]
> [INFO] Lens Distribution ................................. SUCCESS [11.315s]
> [INFO] Lens Client Distribution .......................... SUCCESS [7.496s]
> [INFO] Lens ML Lib ....................................... SUCCESS [2:32.231s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 34:03.600s
> [INFO] Finished at: Fri Dec 26 18:21:01 IST 2014
> [INFO] Final Memory: 100M/332M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Himanshu Gahlaut
> 
>

Re: Review Request 29422: LENS-151: Fix for promotion of select expression to group by failing when column aliases have spaces

Posted by Laxman Ch <la...@huawei.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29422/#review66178
-----------------------------------------------------------



lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java
<https://reviews.apache.org/r/29422/#comment109520>

    Please clarify
    
    - getNonMsrNonAggSelExprsWithoutAlias is a subset of selectExprs. That means we are promoting a subset. What happens to the rest? No need to promote.
     
    - Does this scenario doesn't occur with group by aliases having space? Can we have a testcase for the same.



lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java
<https://reviews.apache.org/r/29422/#comment109517>

    nit. few more sysouts missed to port to log



lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java
<https://reviews.apache.org/r/29422/#comment109518>

    nit again. can we have this inline with other variables. avoid setter and assign variable directly after get.



lens-cube/src/test/resources/log4j.properties
<https://reviews.apache.org/r/29422/#comment109519>

    by default, warn or atleast error level would be better.



lens-cube/src/test/resources/log4j.properties
<https://reviews.apache.org/r/29422/#comment109516>

    I prefer %-5p only. More readable.


- Laxman Ch


On Dec. 27, 2014, 10:55 a.m., Himanshu Gahlaut wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29422/
> -----------------------------------------------------------
> 
> (Updated Dec. 27, 2014, 10:55 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> (1) getExpressionWithoutAlias in GroupbyResolver.class is unable to handle aliases with spaces in them. Fixed the same.
> (2) Also improved log4j.properties of lens-cube to send logs to both console appender and test log files. 
> (3) Used Slf4j annotation in Test classes for getting a reference to Slf4j logger. Added required dependencies in lens-cube/pom.xml to facilitate the same.
> 
> 
> Diffs
> -----
> 
>   lens-cube/pom.xml 1bcb4dc 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java c2fef7e 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 8e41830 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java f515df1 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java ad4abcf 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryRewrite.java fd939e9 
>   lens-cube/src/test/resources/log4j.properties 9729de0 
> 
> Diff: https://reviews.apache.org/r/29422/diff/
> 
> 
> Testing
> -------
> 
> Added new unit test cases for the changes.
> All existing Unit Test Cases passed.
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [14.068s]
> [INFO] Lens .............................................. SUCCESS [5.717s]
> [INFO] Lens API .......................................... SUCCESS [9.369s]
> [INFO] Lens API for server and extensions ................ SUCCESS [8.624s]
> [INFO] Lens Cube ......................................... SUCCESS [7:10.440s]
> [INFO] Lens DB storage ................................... SUCCESS [23.631s]
> [INFO] Lens Query Library ................................ SUCCESS [9.386s]
> [INFO] Lens Hive Driver .................................. SUCCESS [3:34.922s]
> [INFO] Lens Driver for Cloudera Impala ................... SUCCESS [10.798s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [36.429s]
> [INFO] Lens Server ....................................... SUCCESS [14:29.334s]
> [INFO] Lens client ....................................... SUCCESS [45.711s]
> [INFO] Lens CLI .......................................... SUCCESS [3:10.102s]
> [INFO] Lens Examples ..................................... SUCCESS [3.064s]
> [INFO] Lens Distribution ................................. SUCCESS [11.315s]
> [INFO] Lens Client Distribution .......................... SUCCESS [7.496s]
> [INFO] Lens ML Lib ....................................... SUCCESS [2:32.231s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 34:03.600s
> [INFO] Finished at: Fri Dec 26 18:21:01 IST 2014
> [INFO] Final Memory: 100M/332M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Himanshu Gahlaut
> 
>

Re: Review Request 29422: LENS-151: Fix for promotion of select expression to group by failing when column aliases have spaces

Posted by Amareshwari Sriramadasu <am...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29422/#review66225
-----------------------------------------------------------

Ship it!


Ship It!

- Amareshwari Sriramadasu


On Dec. 28, 2014, 5:42 a.m., Himanshu Gahlaut wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29422/
> -----------------------------------------------------------
> 
> (Updated Dec. 28, 2014, 5:42 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> (1) getExpressionWithoutAlias in GroupbyResolver.class is unable to handle aliases with spaces in them. Fixed the same.
> (2) Also improved log4j.properties of lens-cube to send logs to both console appender and test log files. 
> (3) Used Slf4j annotation in Test classes for getting a reference to Slf4j logger. Added required dependencies in lens-cube/pom.xml to facilitate the same.
> 
> 
> Diffs
> -----
> 
>   lens-cube/pom.xml 1bcb4dc 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java c2fef7e 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 8e41830 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java f515df1 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java ad4abcf 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryRewrite.java fd939e9 
>   lens-cube/src/test/resources/log4j.properties 9729de0 
> 
> Diff: https://reviews.apache.org/r/29422/diff/
> 
> 
> Testing
> -------
> 
> Added new unit test cases for the changes.
> All existing Unit Test Cases passed.
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [14.068s]
> [INFO] Lens .............................................. SUCCESS [5.717s]
> [INFO] Lens API .......................................... SUCCESS [9.369s]
> [INFO] Lens API for server and extensions ................ SUCCESS [8.624s]
> [INFO] Lens Cube ......................................... SUCCESS [7:10.440s]
> [INFO] Lens DB storage ................................... SUCCESS [23.631s]
> [INFO] Lens Query Library ................................ SUCCESS [9.386s]
> [INFO] Lens Hive Driver .................................. SUCCESS [3:34.922s]
> [INFO] Lens Driver for Cloudera Impala ................... SUCCESS [10.798s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [36.429s]
> [INFO] Lens Server ....................................... SUCCESS [14:29.334s]
> [INFO] Lens client ....................................... SUCCESS [45.711s]
> [INFO] Lens CLI .......................................... SUCCESS [3:10.102s]
> [INFO] Lens Examples ..................................... SUCCESS [3.064s]
> [INFO] Lens Distribution ................................. SUCCESS [11.315s]
> [INFO] Lens Client Distribution .......................... SUCCESS [7.496s]
> [INFO] Lens ML Lib ....................................... SUCCESS [2:32.231s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 34:03.600s
> [INFO] Finished at: Fri Dec 26 18:21:01 IST 2014
> [INFO] Final Memory: 100M/332M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Himanshu Gahlaut
> 
>

Re: Review Request 29422: LENS-151: Fix for promotion of select expression to group by failing when column aliases have spaces

Posted by Himanshu Gahlaut <ga...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29422/
-----------------------------------------------------------

(Updated Dec. 28, 2014, 5:42 a.m.)


Review request for lens.


Changes
-------

Addressing following resolved comments:
1) Amareshwari: Removing the check for selectExprNode with comment: "All children of SELECT AST Node will be SELECT EXPR AST Nodes".
2) Laxman: Changing log4j.propertis rootLogger logging LEVEL to ERROR and ConversionPattern to use %-5p.


Repository: lens


Description
-------

(1) getExpressionWithoutAlias in GroupbyResolver.class is unable to handle aliases with spaces in them. Fixed the same.
(2) Also improved log4j.properties of lens-cube to send logs to both console appender and test log files. 
(3) Used Slf4j annotation in Test classes for getting a reference to Slf4j logger. Added required dependencies in lens-cube/pom.xml to facilitate the same.


Diffs (updated)
-----

  lens-cube/pom.xml 1bcb4dc 
  lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java c2fef7e 
  lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 8e41830 
  lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java f515df1 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java ad4abcf 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryRewrite.java fd939e9 
  lens-cube/src/test/resources/log4j.properties 9729de0 

Diff: https://reviews.apache.org/r/29422/diff/


Testing
-------

Added new unit test cases for the changes.
All existing Unit Test Cases passed.
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Lens Checkstyle Rules ............................. SUCCESS [14.068s]
[INFO] Lens .............................................. SUCCESS [5.717s]
[INFO] Lens API .......................................... SUCCESS [9.369s]
[INFO] Lens API for server and extensions ................ SUCCESS [8.624s]
[INFO] Lens Cube ......................................... SUCCESS [7:10.440s]
[INFO] Lens DB storage ................................... SUCCESS [23.631s]
[INFO] Lens Query Library ................................ SUCCESS [9.386s]
[INFO] Lens Hive Driver .................................. SUCCESS [3:34.922s]
[INFO] Lens Driver for Cloudera Impala ................... SUCCESS [10.798s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [36.429s]
[INFO] Lens Server ....................................... SUCCESS [14:29.334s]
[INFO] Lens client ....................................... SUCCESS [45.711s]
[INFO] Lens CLI .......................................... SUCCESS [3:10.102s]
[INFO] Lens Examples ..................................... SUCCESS [3.064s]
[INFO] Lens Distribution ................................. SUCCESS [11.315s]
[INFO] Lens Client Distribution .......................... SUCCESS [7.496s]
[INFO] Lens ML Lib ....................................... SUCCESS [2:32.231s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 34:03.600s
[INFO] Finished at: Fri Dec 26 18:21:01 IST 2014
[INFO] Final Memory: 100M/332M
[INFO] ------------------------------------------------------------------------


Thanks,

Himanshu Gahlaut

Re: Review Request 29422: LENS-151: Fix for promotion of select expression to group by failing when column aliases have spaces

Posted by Himanshu Gahlaut <ga...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29422/
-----------------------------------------------------------

(Updated Dec. 27, 2014, 10:55 a.m.)


Review request for lens.


Changes
-------

Using more elegant Guava Optional, instead of introducing a new constant "INVALID_AST_NODE_TYPE = -999"


Repository: lens


Description
-------

(1) getExpressionWithoutAlias in GroupbyResolver.class is unable to handle aliases with spaces in them. Fixed the same.
(2) Also improved log4j.properties of lens-cube to send logs to both console appender and test log files. 
(3) Used Slf4j annotation in Test classes for getting a reference to Slf4j logger. Added required dependencies in lens-cube/pom.xml to facilitate the same.


Diffs (updated)
-----

  lens-cube/pom.xml 1bcb4dc 
  lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java c2fef7e 
  lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 8e41830 
  lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java f515df1 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java ad4abcf 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryRewrite.java fd939e9 
  lens-cube/src/test/resources/log4j.properties 9729de0 

Diff: https://reviews.apache.org/r/29422/diff/


Testing
-------

Added new unit test cases for the changes.
All existing Unit Test Cases passed.
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Lens Checkstyle Rules ............................. SUCCESS [14.068s]
[INFO] Lens .............................................. SUCCESS [5.717s]
[INFO] Lens API .......................................... SUCCESS [9.369s]
[INFO] Lens API for server and extensions ................ SUCCESS [8.624s]
[INFO] Lens Cube ......................................... SUCCESS [7:10.440s]
[INFO] Lens DB storage ................................... SUCCESS [23.631s]
[INFO] Lens Query Library ................................ SUCCESS [9.386s]
[INFO] Lens Hive Driver .................................. SUCCESS [3:34.922s]
[INFO] Lens Driver for Cloudera Impala ................... SUCCESS [10.798s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [36.429s]
[INFO] Lens Server ....................................... SUCCESS [14:29.334s]
[INFO] Lens client ....................................... SUCCESS [45.711s]
[INFO] Lens CLI .......................................... SUCCESS [3:10.102s]
[INFO] Lens Examples ..................................... SUCCESS [3.064s]
[INFO] Lens Distribution ................................. SUCCESS [11.315s]
[INFO] Lens Client Distribution .......................... SUCCESS [7.496s]
[INFO] Lens ML Lib ....................................... SUCCESS [2:32.231s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 34:03.600s
[INFO] Finished at: Fri Dec 26 18:21:01 IST 2014
[INFO] Final Memory: 100M/332M
[INFO] ------------------------------------------------------------------------


Thanks,

Himanshu Gahlaut

Re: Review Request 29422: LENS-151: Fix for promotion of select expression to group by failing when column aliases have spaces

Posted by Himanshu Gahlaut <ga...@gmail.com>.


> On Dec. 26, 2014, 3:46 p.m., Amareshwari Sriramadasu wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java, line 197
> > <https://reviews.apache.org/r/29422/diff/3/?file=801333#file801333line197>
> >
> >     There wont be any ASTNode passed here which is not select expr node, right? Is this if check required?
> >     
> >     Also the methods isSelectExprASTNode in HQLParser
> 
> Himanshu Gahlaut wrote:
>     If we are sure that a SELECT ASTNode can only have SELET_EXPR AST Nodes as children, then we can remove this check here. Is this declared in the contract of Hive Parser that SELECT AST Node will only have SELECT_EXPR as children ?
> 
> Amareshwari Sriramadasu wrote:
>     Here is the antlr grammar corresponding to select clause (copied from SelectClauseParser.g from hive code):
>     
>     selectClause
>     @init { gParent.pushMsg("select clause", state); }
>     @after { gParent.popMsg(state); }
>         :
>         KW_SELECT hintClause? (((KW_ALL | dist=KW_DISTINCT)? selectList)
>                               | (transform=KW_TRANSFORM selectTrfmClause))
>          -> {$transform == null && $dist == null}? ^(TOK_SELECT hintClause? selectList)
>          -> {$transform == null && $dist != null}? ^(TOK_SELECTDI hintClause? selectList)
>          -> ^(TOK_SELECT hintClause? ^(TOK_SELEXPR selectTrfmClause) )
>         |
>         trfmClause  ->^(TOK_SELECT ^(TOK_SELEXPR trfmClause))
>         ;
>     
>     selectList
>     @init { gParent.pushMsg("select list", state); }
>     @after { gParent.popMsg(state); }
>         :
>         selectItem ( COMMA  selectItem )* -> selectItem+
>         ;
>     
>     selectItem
>     @init { gParent.pushMsg("selection target", state); }
>     @after { gParent.popMsg(state); }
>         :
>         ( selectExpression
>           ((KW_AS? identifier) | (KW_AS LPAREN identifier (COMMA identifier)* RPAREN))?
>         ) -> ^(TOK_SELEXPR selectExpression identifier*)
>         ;
>     
>     You can add appropriate javadoc about the assumptions. We are not allowing hints and KW_ALL in cube HQL.  So, all children will be Select expr AST nodes.

Sure will make this change and put a comment for assumption.


> On Dec. 26, 2014, 3:46 p.m., Amareshwari Sriramadasu wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java, line 219
> > <https://reviews.apache.org/r/29422/diff/3/?file=801333#file801333line219>
> >
> >     Is there any node which is not SelectASTNode node?
> >     then is the if check required? Then the method 
> >     isSelectASTNode  in HQLParser required?
> 
> Himanshu Gahlaut wrote:
>     A method normally has following stages: 
>     
>     1) Precondition
>     2) Logic (Assumes precondtion is met)
>     3) Postconditions (cleanup)
>     4) Return
>     
>     The Logic of filterNonMsrNonAggSelectASTChildren assumes that a precondition is met by node input into the function. This check is to ensure the precondition. Currently the method is trying to give expected results and is returning an empty list when input node is not a select AST Node. If we remove this check, than we'll have to put following comment in javadoc of this method: "If input node is not a select ASTNode then return value is unexpected."
> 
> Amareshwari Sriramadasu wrote:
>     Sure. Since the method is private, I'm thinking putting the javadoc with respect to expected results to good enough, than to add more code.

As far as API contracts are concerned, viewing private and public method with the same eye is in general beneficial. The moment a developer decides to make this method public, there are more chances of him/her missing the java doc. This will lead to code which will be good for now but will be easier to go bad in future.


- Himanshu


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29422/#review66156
-----------------------------------------------------------


On Dec. 27, 2014, 10:55 a.m., Himanshu Gahlaut wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29422/
> -----------------------------------------------------------
> 
> (Updated Dec. 27, 2014, 10:55 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> (1) getExpressionWithoutAlias in GroupbyResolver.class is unable to handle aliases with spaces in them. Fixed the same.
> (2) Also improved log4j.properties of lens-cube to send logs to both console appender and test log files. 
> (3) Used Slf4j annotation in Test classes for getting a reference to Slf4j logger. Added required dependencies in lens-cube/pom.xml to facilitate the same.
> 
> 
> Diffs
> -----
> 
>   lens-cube/pom.xml 1bcb4dc 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java c2fef7e 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 8e41830 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java f515df1 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java ad4abcf 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryRewrite.java fd939e9 
>   lens-cube/src/test/resources/log4j.properties 9729de0 
> 
> Diff: https://reviews.apache.org/r/29422/diff/
> 
> 
> Testing
> -------
> 
> Added new unit test cases for the changes.
> All existing Unit Test Cases passed.
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [14.068s]
> [INFO] Lens .............................................. SUCCESS [5.717s]
> [INFO] Lens API .......................................... SUCCESS [9.369s]
> [INFO] Lens API for server and extensions ................ SUCCESS [8.624s]
> [INFO] Lens Cube ......................................... SUCCESS [7:10.440s]
> [INFO] Lens DB storage ................................... SUCCESS [23.631s]
> [INFO] Lens Query Library ................................ SUCCESS [9.386s]
> [INFO] Lens Hive Driver .................................. SUCCESS [3:34.922s]
> [INFO] Lens Driver for Cloudera Impala ................... SUCCESS [10.798s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [36.429s]
> [INFO] Lens Server ....................................... SUCCESS [14:29.334s]
> [INFO] Lens client ....................................... SUCCESS [45.711s]
> [INFO] Lens CLI .......................................... SUCCESS [3:10.102s]
> [INFO] Lens Examples ..................................... SUCCESS [3.064s]
> [INFO] Lens Distribution ................................. SUCCESS [11.315s]
> [INFO] Lens Client Distribution .......................... SUCCESS [7.496s]
> [INFO] Lens ML Lib ....................................... SUCCESS [2:32.231s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 34:03.600s
> [INFO] Finished at: Fri Dec 26 18:21:01 IST 2014
> [INFO] Final Memory: 100M/332M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Himanshu Gahlaut
> 
>

Re: Review Request 29422: LENS-151: Fix for promotion of select expression to group by failing when column aliases have spaces

Posted by Himanshu Gahlaut <ga...@gmail.com>.


> On Dec. 26, 2014, 3:46 p.m., Amareshwari Sriramadasu wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java, line 219
> > <https://reviews.apache.org/r/29422/diff/3/?file=801333#file801333line219>
> >
> >     Is there any node which is not SelectASTNode node?
> >     then is the if check required? Then the method 
> >     isSelectASTNode  in HQLParser required?

A method normally has following stages: 

1) Precondition
2) Logic (Assumes precondtion is met)
3) Postconditions (cleanup)
4) Return

The Logic of filterNonMsrNonAggSelectASTChildren assumes that a precondition is met by node input into the function. This check is to ensure the precondition. Currently the method is trying to give expected results and is returning an empty list when input node is not a select AST Node. If we remove this check, than we'll have to put following comment in javadoc of this method: "If input node is not a select ASTNode then return value is unexpected."


> On Dec. 26, 2014, 3:46 p.m., Amareshwari Sriramadasu wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java, line 197
> > <https://reviews.apache.org/r/29422/diff/3/?file=801333#file801333line197>
> >
> >     There wont be any ASTNode passed here which is not select expr node, right? Is this if check required?
> >     
> >     Also the methods isSelectExprASTNode in HQLParser

If we are sure that a SELECT ASTNode can only have SELET_EXPR AST Nodes as children, then we can remove this check here. Is this declared in the contract of Hive Parser that SELECT AST Node will only have SELECT_EXPR as children ?


- Himanshu


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29422/#review66156
-----------------------------------------------------------


On Dec. 26, 2014, 12:58 p.m., Himanshu Gahlaut wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29422/
> -----------------------------------------------------------
> 
> (Updated Dec. 26, 2014, 12:58 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> (1) getExpressionWithoutAlias in GroupbyResolver.class is unable to handle aliases with spaces in them. Fixed the same.
> (2) Also improved log4j.properties of lens-cube to send logs to both console appender and test log files. 
> (3) Used Slf4j annotation in Test classes for getting a reference to Slf4j logger. Added required dependencies in lens-cube/pom.xml to facilitate the same.
> 
> 
> Diffs
> -----
> 
>   lens-cube/pom.xml 1bcb4dc 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java c2fef7e 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 8e41830 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java f515df1 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java ad4abcf 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryRewrite.java fd939e9 
>   lens-cube/src/test/resources/log4j.properties 9729de0 
> 
> Diff: https://reviews.apache.org/r/29422/diff/
> 
> 
> Testing
> -------
> 
> Added new unit test cases for the changes.
> All existing Unit Test Cases passed.
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [14.068s]
> [INFO] Lens .............................................. SUCCESS [5.717s]
> [INFO] Lens API .......................................... SUCCESS [9.369s]
> [INFO] Lens API for server and extensions ................ SUCCESS [8.624s]
> [INFO] Lens Cube ......................................... SUCCESS [7:10.440s]
> [INFO] Lens DB storage ................................... SUCCESS [23.631s]
> [INFO] Lens Query Library ................................ SUCCESS [9.386s]
> [INFO] Lens Hive Driver .................................. SUCCESS [3:34.922s]
> [INFO] Lens Driver for Cloudera Impala ................... SUCCESS [10.798s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [36.429s]
> [INFO] Lens Server ....................................... SUCCESS [14:29.334s]
> [INFO] Lens client ....................................... SUCCESS [45.711s]
> [INFO] Lens CLI .......................................... SUCCESS [3:10.102s]
> [INFO] Lens Examples ..................................... SUCCESS [3.064s]
> [INFO] Lens Distribution ................................. SUCCESS [11.315s]
> [INFO] Lens Client Distribution .......................... SUCCESS [7.496s]
> [INFO] Lens ML Lib ....................................... SUCCESS [2:32.231s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 34:03.600s
> [INFO] Finished at: Fri Dec 26 18:21:01 IST 2014
> [INFO] Final Memory: 100M/332M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Himanshu Gahlaut
> 
>

Re: Review Request 29422: LENS-151: Fix for promotion of select expression to group by failing when column aliases have spaces

Posted by Amareshwari Sriramadasu <am...@apache.org>.


> On Dec. 26, 2014, 3:46 p.m., Amareshwari Sriramadasu wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java, line 197
> > <https://reviews.apache.org/r/29422/diff/3/?file=801333#file801333line197>
> >
> >     There wont be any ASTNode passed here which is not select expr node, right? Is this if check required?
> >     
> >     Also the methods isSelectExprASTNode in HQLParser
> 
> Himanshu Gahlaut wrote:
>     If we are sure that a SELECT ASTNode can only have SELET_EXPR AST Nodes as children, then we can remove this check here. Is this declared in the contract of Hive Parser that SELECT AST Node will only have SELECT_EXPR as children ?

Here is the antlr grammar corresponding to select clause (copied from SelectClauseParser.g from hive code):

selectClause
@init { gParent.pushMsg("select clause", state); }
@after { gParent.popMsg(state); }
    :
    KW_SELECT hintClause? (((KW_ALL | dist=KW_DISTINCT)? selectList)
                          | (transform=KW_TRANSFORM selectTrfmClause))
     -> {$transform == null && $dist == null}? ^(TOK_SELECT hintClause? selectList)
     -> {$transform == null && $dist != null}? ^(TOK_SELECTDI hintClause? selectList)
     -> ^(TOK_SELECT hintClause? ^(TOK_SELEXPR selectTrfmClause) )
    |
    trfmClause  ->^(TOK_SELECT ^(TOK_SELEXPR trfmClause))
    ;

selectList
@init { gParent.pushMsg("select list", state); }
@after { gParent.popMsg(state); }
    :
    selectItem ( COMMA  selectItem )* -> selectItem+
    ;

selectItem
@init { gParent.pushMsg("selection target", state); }
@after { gParent.popMsg(state); }
    :
    ( selectExpression
      ((KW_AS? identifier) | (KW_AS LPAREN identifier (COMMA identifier)* RPAREN))?
    ) -> ^(TOK_SELEXPR selectExpression identifier*)
    ;

You can add appropriate javadoc about the assumptions. We are not allowing hints and KW_ALL in cube HQL.  So, all children will be Select expr AST nodes.


> On Dec. 26, 2014, 3:46 p.m., Amareshwari Sriramadasu wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java, line 219
> > <https://reviews.apache.org/r/29422/diff/3/?file=801333#file801333line219>
> >
> >     Is there any node which is not SelectASTNode node?
> >     then is the if check required? Then the method 
> >     isSelectASTNode  in HQLParser required?
> 
> Himanshu Gahlaut wrote:
>     A method normally has following stages: 
>     
>     1) Precondition
>     2) Logic (Assumes precondtion is met)
>     3) Postconditions (cleanup)
>     4) Return
>     
>     The Logic of filterNonMsrNonAggSelectASTChildren assumes that a precondition is met by node input into the function. This check is to ensure the precondition. Currently the method is trying to give expected results and is returning an empty list when input node is not a select AST Node. If we remove this check, than we'll have to put following comment in javadoc of this method: "If input node is not a select ASTNode then return value is unexpected."

Sure. Since the method is private, I'm thinking putting the javadoc with respect to expected results to good enough, than to add more code.


- Amareshwari


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29422/#review66156
-----------------------------------------------------------


On Dec. 27, 2014, 10:55 a.m., Himanshu Gahlaut wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29422/
> -----------------------------------------------------------
> 
> (Updated Dec. 27, 2014, 10:55 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> (1) getExpressionWithoutAlias in GroupbyResolver.class is unable to handle aliases with spaces in them. Fixed the same.
> (2) Also improved log4j.properties of lens-cube to send logs to both console appender and test log files. 
> (3) Used Slf4j annotation in Test classes for getting a reference to Slf4j logger. Added required dependencies in lens-cube/pom.xml to facilitate the same.
> 
> 
> Diffs
> -----
> 
>   lens-cube/pom.xml 1bcb4dc 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java c2fef7e 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 8e41830 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java f515df1 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java ad4abcf 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryRewrite.java fd939e9 
>   lens-cube/src/test/resources/log4j.properties 9729de0 
> 
> Diff: https://reviews.apache.org/r/29422/diff/
> 
> 
> Testing
> -------
> 
> Added new unit test cases for the changes.
> All existing Unit Test Cases passed.
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [14.068s]
> [INFO] Lens .............................................. SUCCESS [5.717s]
> [INFO] Lens API .......................................... SUCCESS [9.369s]
> [INFO] Lens API for server and extensions ................ SUCCESS [8.624s]
> [INFO] Lens Cube ......................................... SUCCESS [7:10.440s]
> [INFO] Lens DB storage ................................... SUCCESS [23.631s]
> [INFO] Lens Query Library ................................ SUCCESS [9.386s]
> [INFO] Lens Hive Driver .................................. SUCCESS [3:34.922s]
> [INFO] Lens Driver for Cloudera Impala ................... SUCCESS [10.798s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [36.429s]
> [INFO] Lens Server ....................................... SUCCESS [14:29.334s]
> [INFO] Lens client ....................................... SUCCESS [45.711s]
> [INFO] Lens CLI .......................................... SUCCESS [3:10.102s]
> [INFO] Lens Examples ..................................... SUCCESS [3.064s]
> [INFO] Lens Distribution ................................. SUCCESS [11.315s]
> [INFO] Lens Client Distribution .......................... SUCCESS [7.496s]
> [INFO] Lens ML Lib ....................................... SUCCESS [2:32.231s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 34:03.600s
> [INFO] Finished at: Fri Dec 26 18:21:01 IST 2014
> [INFO] Final Memory: 100M/332M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Himanshu Gahlaut
> 
>

Re: Review Request 29422: LENS-151: Fix for promotion of select expression to group by failing when column aliases have spaces

Posted by Amareshwari Sriramadasu <am...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29422/#review66156
-----------------------------------------------------------



lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java
<https://reviews.apache.org/r/29422/#comment109498>

    There wont be any ASTNode passed here which is not select expr node, right? Is this if check required?
    
    Also the methods isSelectExprASTNode in HQLParser



lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java
<https://reviews.apache.org/r/29422/#comment109499>

    Is there any node which is not SelectASTNode node?
    then is the if check required? Then the method 
    isSelectASTNode  in HQLParser required?


- Amareshwari Sriramadasu


On Dec. 26, 2014, 12:58 p.m., Himanshu Gahlaut wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29422/
> -----------------------------------------------------------
> 
> (Updated Dec. 26, 2014, 12:58 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> (1) getExpressionWithoutAlias in GroupbyResolver.class is unable to handle aliases with spaces in them. Fixed the same.
> (2) Also improved log4j.properties of lens-cube to send logs to both console appender and test log files. 
> (3) Used Slf4j annotation in Test classes for getting a reference to Slf4j logger. Added required dependencies in lens-cube/pom.xml to facilitate the same.
> 
> 
> Diffs
> -----
> 
>   lens-cube/pom.xml 1bcb4dc 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java c2fef7e 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 8e41830 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java f515df1 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java ad4abcf 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryRewrite.java fd939e9 
>   lens-cube/src/test/resources/log4j.properties 9729de0 
> 
> Diff: https://reviews.apache.org/r/29422/diff/
> 
> 
> Testing
> -------
> 
> Added new unit test cases for the changes.
> All existing Unit Test Cases passed.
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [14.068s]
> [INFO] Lens .............................................. SUCCESS [5.717s]
> [INFO] Lens API .......................................... SUCCESS [9.369s]
> [INFO] Lens API for server and extensions ................ SUCCESS [8.624s]
> [INFO] Lens Cube ......................................... SUCCESS [7:10.440s]
> [INFO] Lens DB storage ................................... SUCCESS [23.631s]
> [INFO] Lens Query Library ................................ SUCCESS [9.386s]
> [INFO] Lens Hive Driver .................................. SUCCESS [3:34.922s]
> [INFO] Lens Driver for Cloudera Impala ................... SUCCESS [10.798s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [36.429s]
> [INFO] Lens Server ....................................... SUCCESS [14:29.334s]
> [INFO] Lens client ....................................... SUCCESS [45.711s]
> [INFO] Lens CLI .......................................... SUCCESS [3:10.102s]
> [INFO] Lens Examples ..................................... SUCCESS [3.064s]
> [INFO] Lens Distribution ................................. SUCCESS [11.315s]
> [INFO] Lens Client Distribution .......................... SUCCESS [7.496s]
> [INFO] Lens ML Lib ....................................... SUCCESS [2:32.231s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 34:03.600s
> [INFO] Finished at: Fri Dec 26 18:21:01 IST 2014
> [INFO] Final Memory: 100M/332M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Himanshu Gahlaut
> 
>

Re: Review Request 29422: LENS-151: Fix for promotion of select expression to group by failing when column aliases have spaces

Posted by Himanshu Gahlaut <ga...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29422/
-----------------------------------------------------------

(Updated Dec. 26, 2014, 12:58 p.m.)


Review request for lens.


Changes
-------

Pasting Result of Running Test Cases.


Repository: lens


Description
-------

(1) getExpressionWithoutAlias in GroupbyResolver.class is unable to handle aliases with spaces in them. Fixed the same.
(2) Also improved log4j.properties of lens-cube to send logs to both console appender and test log files. 
(3) Used Slf4j annotation in Test classes for getting a reference to Slf4j logger. Added required dependencies in lens-cube/pom.xml to facilitate the same.


Diffs
-----

  lens-cube/pom.xml 1bcb4dc 
  lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java c2fef7e 
  lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 8e41830 
  lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java f515df1 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java ad4abcf 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryRewrite.java fd939e9 
  lens-cube/src/test/resources/log4j.properties 9729de0 

Diff: https://reviews.apache.org/r/29422/diff/


Testing (updated)
-------

Added new unit test cases for the changes.
All existing Unit Test Cases passed.
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Lens Checkstyle Rules ............................. SUCCESS [14.068s]
[INFO] Lens .............................................. SUCCESS [5.717s]
[INFO] Lens API .......................................... SUCCESS [9.369s]
[INFO] Lens API for server and extensions ................ SUCCESS [8.624s]
[INFO] Lens Cube ......................................... SUCCESS [7:10.440s]
[INFO] Lens DB storage ................................... SUCCESS [23.631s]
[INFO] Lens Query Library ................................ SUCCESS [9.386s]
[INFO] Lens Hive Driver .................................. SUCCESS [3:34.922s]
[INFO] Lens Driver for Cloudera Impala ................... SUCCESS [10.798s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [36.429s]
[INFO] Lens Server ....................................... SUCCESS [14:29.334s]
[INFO] Lens client ....................................... SUCCESS [45.711s]
[INFO] Lens CLI .......................................... SUCCESS [3:10.102s]
[INFO] Lens Examples ..................................... SUCCESS [3.064s]
[INFO] Lens Distribution ................................. SUCCESS [11.315s]
[INFO] Lens Client Distribution .......................... SUCCESS [7.496s]
[INFO] Lens ML Lib ....................................... SUCCESS [2:32.231s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 34:03.600s
[INFO] Finished at: Fri Dec 26 18:21:01 IST 2014
[INFO] Final Memory: 100M/332M
[INFO] ------------------------------------------------------------------------


Thanks,

Himanshu Gahlaut

Re: Review Request 29422: LENS-151: Fix for promotion of select expression to group by failing when column aliases have spaces

Posted by Himanshu Gahlaut <ga...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29422/
-----------------------------------------------------------

(Updated Dec. 26, 2014, 12:49 p.m.)

Review request for lens.

Changes
-------

(1) Changed logic to retrieve select expressions without alias form AST instead of dropping alias suffix.
(2) Changed test logging level to WARN
(3) Added a unit test without "as" keyword between column and alias.

Repository: lens

Description
-------

(1) getExpressionWithoutAlias in GroupbyResolver.class is unable to handle aliases with spaces in them. Fixed the same.
(2) Also improved log4j.properties of lens-cube to send logs to both console appender and test log files.
(3) Used Slf4j annotation in Test classes for getting a reference to Slf4j logger. Added required dependencies in lens-cube/pom.xml to facilitate the same.

Diffs (updated)
-----

lens-cube/pom.xml 1bcb4dc
lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java c2fef7e
lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 8e41830
lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java f515df1
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java ad4abcf
lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryRewrite.java fd939e9
lens-cube/src/test/resources/log4j.properties 9729de0

Diff: https://reviews.apache.org/r/29422/diff/

Testing (updated)
-------

Added new unit test cases for the changes.
All existing Unit Test Cases passed.

Thanks,

Himanshu Gahlaut

Re: Review Request 29422: LENS-151: Fix for promotion of select expression to group by failing when column aliases have spaces

Posted by Amareshwari Sriramadasu <am...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29422/#review66121
-----------------------------------------------------------



lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java
<https://reviews.apache.org/r/29422/#comment109480>

    As is optional for specifying column alias in HQL. 
    
    We can do simply 
    select col `col in space` from table
    
    Can you take care of this case also?



lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java
<https://reviews.apache.org/r/29422/#comment109479>

    Can you include one more test without as keyword?



lens-cube/src/test/resources/log4j.properties
<https://reviews.apache.org/r/29422/#comment109478>

    Debug logging will be very huge with respect to metastore logs. We should use INFO or WARN in the default logging


- Amareshwari Sriramadasu


On Dec. 25, 2014, 8:02 p.m., Himanshu Gahlaut wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29422/
> -----------------------------------------------------------
> 
> (Updated Dec. 25, 2014, 8:02 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> (1) getExpressionWithoutAlias in GroupbyResolver.class is unable to handle aliases with spaces in them. Fixed the same.
> (2) Also improved log4j.properties of lens-cube to send logs to both console appender and test log files. 
> (3) Used Slf4j annotation in Test classes for getting a reference to Slf4j logger. Added required dependencies in lens-cube/pom.xml to facilitate the same.
> 
> 
> Diffs
> -----
> 
>   lens-cube/pom.xml 1bcb4dc 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java c2fef7e 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java f515df1 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java ad4abcf 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryRewrite.java fd939e9 
>   lens-cube/src/test/resources/log4j.properties 9729de0 
> 
> Diff: https://reviews.apache.org/r/29422/diff/
> 
> 
> Testing
> -------
> 
> Added a unit test case for the same.
> 
> 
> Thanks,
> 
> Himanshu Gahlaut
> 
>

Re: Review Request 29422: LENS-151: Fix for promotion of select expression to group by failing when column aliases have spaces

Posted by Himanshu Gahlaut <ga...@gmail.com>.


> On Dec. 26, 2014, 11:27 a.m., Rajat Khandelwal wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java, line 174
> > <https://reviews.apache.org/r/29422/diff/2/?file=800844#file800844line174>
> >
> >     is the case of mulltiple spaces getting covered here?

toInfixString function ensures to put only one space between as and opening backquote. Hence multiple spaces cannot appear here.


- Himanshu


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29422/#review66148
-----------------------------------------------------------


On Dec. 26, 2014, 12:49 p.m., Himanshu Gahlaut wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29422/
> -----------------------------------------------------------
> 
> (Updated Dec. 26, 2014, 12:49 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> (1) getExpressionWithoutAlias in GroupbyResolver.class is unable to handle aliases with spaces in them. Fixed the same.
> (2) Also improved log4j.properties of lens-cube to send logs to both console appender and test log files. 
> (3) Used Slf4j annotation in Test classes for getting a reference to Slf4j logger. Added required dependencies in lens-cube/pom.xml to facilitate the same.
> 
> 
> Diffs
> -----
> 
>   lens-cube/pom.xml 1bcb4dc 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java c2fef7e 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 8e41830 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java f515df1 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java ad4abcf 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryRewrite.java fd939e9 
>   lens-cube/src/test/resources/log4j.properties 9729de0 
> 
> Diff: https://reviews.apache.org/r/29422/diff/
> 
> 
> Testing
> -------
> 
> Added new unit test cases for the changes.
> All existing Unit Test Cases passed.
> 
> 
> Thanks,
> 
> Himanshu Gahlaut
> 
>

Re: Review Request 29422: LENS-151: Fix for promotion of select expression to group by failing when column aliases have spaces

Posted by Rajat Khandelwal <ra...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29422/#review66148
-----------------------------------------------------------



lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java
<https://reviews.apache.org/r/29422/#comment109494>

    is the case of mulltiple spaces getting covered here?



lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java
<https://reviews.apache.org/r/29422/#comment109495>

    +1


- Rajat Khandelwal


On Dec. 25, 2014, 8:02 p.m., Himanshu Gahlaut wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29422/
> -----------------------------------------------------------
> 
> (Updated Dec. 25, 2014, 8:02 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> (1) getExpressionWithoutAlias in GroupbyResolver.class is unable to handle aliases with spaces in them. Fixed the same.
> (2) Also improved log4j.properties of lens-cube to send logs to both console appender and test log files. 
> (3) Used Slf4j annotation in Test classes for getting a reference to Slf4j logger. Added required dependencies in lens-cube/pom.xml to facilitate the same.
> 
> 
> Diffs
> -----
> 
>   lens-cube/pom.xml 1bcb4dc 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java c2fef7e 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java f515df1 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java ad4abcf 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryRewrite.java fd939e9 
>   lens-cube/src/test/resources/log4j.properties 9729de0 
> 
> Diff: https://reviews.apache.org/r/29422/diff/
> 
> 
> Testing
> -------
> 
> Added a unit test case for the same.
> 
> 
> Thanks,
> 
> Himanshu Gahlaut
> 
>

Re: Review Request 29422: LENS-151: Fix for promotion of select expression to group by failing when column aliases have spaces

Posted by Himanshu Gahlaut <ga...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29422/
-----------------------------------------------------------

(Updated Dec. 25, 2014, 8:02 p.m.)


Review request for lens.


Changes
-------

(1) Created a lastHourTimeRange and used that in unit test case. (2) Used Different Levels for STDOUT and TEST FILE logging. WARN for STDOUT and DEBUG for TEST LOG FILE.


Repository: lens


Description
-------

(1) getExpressionWithoutAlias in GroupbyResolver.class is unable to handle aliases with spaces in them. Fixed the same.
(2) Also improved log4j.properties of lens-cube to send logs to both console appender and test log files. 
(3) Used Slf4j annotation in Test classes for getting a reference to Slf4j logger. Added required dependencies in lens-cube/pom.xml to facilitate the same.


Diffs (updated)
-----

  lens-cube/pom.xml 1bcb4dc 
  lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java c2fef7e 
  lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java f515df1 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java ad4abcf 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryRewrite.java fd939e9 
  lens-cube/src/test/resources/log4j.properties 9729de0 

Diff: https://reviews.apache.org/r/29422/diff/


Testing
-------

Added a unit test case for the same.


Thanks,

Himanshu Gahlaut

Re: Review Request 29422: LENS-151: Fix for promotion of select expression to group by failing when column aliases have spaces

Posted by Himanshu Gahlaut <ga...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29422/
-----------------------------------------------------------

(Updated Dec. 25, 2014, 5:40 p.m.)


Review request for lens.


Repository: lens


Description (updated)
-------

(1) getExpressionWithoutAlias in GroupbyResolver.class is unable to handle aliases with spaces in them. Fixed the same.
(2) Also improved log4j.properties of lens-cube to send logs to both console appender and test log files. 
(3) Used Slf4j annotation in Test classes for getting a reference to Slf4j logger. Added required dependencies in lens-cube/pom.xml to facilitate the same.


Diffs
-----

  lens-cube/pom.xml 1bcb4dc 
  lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java c2fef7e 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java ad4abcf 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryRewrite.java fd939e9 
  lens-cube/src/test/resources/log4j.properties 9729de0 

Diff: https://reviews.apache.org/r/29422/diff/


Testing
-------

Added a unit test case for the same.


Thanks,

Himanshu Gahlaut

Re: Review Request 29422: LENS-151: Fix for promotion of select expression to group by failing when column aliases have spaces

Posted by Himanshu Gahlaut <ga...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29422/
-----------------------------------------------------------

(Updated Dec. 25, 2014, 5:35 p.m.)


Review request for lens.


Repository: lens


Description
-------

getExpressionWithoutAlias in GroupbyResolver.class is unable to handle aliases with spaces in them. 


Diffs
-----

  lens-cube/pom.xml 1bcb4dc 
  lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java c2fef7e 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java ad4abcf 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryRewrite.java fd939e9 
  lens-cube/src/test/resources/log4j.properties 9729de0 

Diff: https://reviews.apache.org/r/29422/diff/


Testing
-------

Added a unit test case for the same.


Thanks,

Himanshu Gahlaut