You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by zentol <gi...@git.apache.org> on 2017/08/09 13:28:38 UTC
[GitHub] flink pull request #4505: [FLINK-7399] [checkstyle] Forbid imports from org....
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/4505
[FLINK-7399] [checkstyle] Forbid imports from org.codehaus.jackson
## What is the purpose of the change
Flink uses `com.fasterxml.jackson` but pulls in the codehaus version from various dependencies. This PR forbids using the codehaus version using checkstyle.
## Brief change log
*(for example:)*
- Add `org.codehaus.jackson` to the list of illegal packages of the `IllegalImport` module
## Verifying this change
1) Run `mvn checkstyle:check`, it should not fail.
2) Add some import from `org.codehaus.jackson`, running checkstyle should now fail,
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink 7399
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4505.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4505
----
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4505: [FLINK-7399] [checkstyle] Forbid imports from org....
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/4505
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4505: [FLINK-7399] [checkstyle] Forbid imports from org.codehau...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4505
merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---