[GitHub] [incubator-superset] villebro opened a new pull request #8510: Replace hardcoded default colors with defaults in setupColors.js

[GitBox <gi...@apache.org>]

villebro opened a new pull request #8510: Replace hardcoded default colors with defaults in setupColors.js
URL: https://github.com/apache/incubator-superset/pull/8510
 
 
   ### CATEGORY
   
   Choose one
   
   - [x] Bug Fix
   - [ ] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   Currently the default colors for both categorical and sequential schemes are hardcoded in `controls.js`, which means that changing the default values in `setupColors.js` don't have any effect on the default color scheme. This PR changes `controls.js` to use the default scheme as defined in `setupColors.js`, and also sets the default key for `sequentialSchemeRegistry` (previously only hard coded in `controls.js`).
   
   ### TEST PLAN
   Tested locally by changing the default key in `setupColors.js`, and verifying that the default colors in a test dashboard reflected the change. If needed I can look into adding tests for this.
   
   ### REVIEWERS
   @etr2460 @mistercrunch @graceguo-supercat 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org