Re: Dark title bar in NetBeans 12.3

[Mark Herkrath <he...@googlemail.com.INVALID>]

Hi Karl,

Thanks a lot for giving these insights and for providing a feasible way how to enable it with the existing NB 12.3 version already. It wasn’t clear to me that FlatLaf has a build-in way to set DefaultLookAndFeelDecorated already. Nice! I have tested it and it works just fine but the issues you have listed. At least to me, none of them are very meaningful though.

Chris got a point about the search bar, I thought the same. While it would be nice to have the extra space freed by the embedded menu bar, the menus, the title, and the search bar would take too much room for narrow NB window scenarios as well. I also guess that it’s not possible to place the search bar right aligned after the title as it’s currently due to API constrains. Is it Karl?

So as long as NetBeans doesn’t move the search feature into a dedicated dialog independent of the used L&F, I feel it would be better to not use the embed the menu bar.

Regards,
Mark


> On 26. Feb 2021, at 15:30, Christian Lenz <ch...@gmx.net> wrote:
> 
> Hey all,
> 
> please don‘t move the Searchbar into the toolbar without having the option to Change that. For me I don’t use and I don’t Need the toolbar, I hide it. So next to the menu is fine for me, but needs to be look a bit nicer. Or to make it hidden and make it in a Dialog like in IntelliJ search for everything. To just have it when I Need it.
> 
> 
> Cheers
> 
> Chris
> 
> Von: Karl Tauber
> Gesendet: Freitag, 26. Februar 2021 15:13
> An: dev@netbeans.apache.org
> Betreff: Re: Dark title bar in NetBeans 12.3
> 
> Hi Mark
> 
> you can enable this also on command line (or in etc/netbeans.conf) with:
>   -J-Dflatlaf.useWindowDecorations=true
> 
> and disable embedded menubar with:
>   -J-Dflatlaf.menuBarEmbedded=false
> 
> https://www.formdev.com/flatlaf/system-properties/
> 
> 
> BTW this is only available on Windows 10.
> 
> 
> Have not enabled this by default because it has downsides that I like to 
> fix first in FlatLaf. Some Windows 10 functionality is lost ATM:
> - no drop shadows around windows
> - snapping does not work, see: 
> https://support.microsoft.com/en-us/windows/snap-your-windows-885a9b1e-a983-a3b1-16cd-c531795e6241
> - no system window menu when clicking on app icon
> 
> 
> This will be fixed/implemented in one of the next FlatLaf versions.
> 
> Here is a PR that uses JNA to access Win32 API:
>    https://github.com/JFormDesigner/FlatLaf/pull/262
> 
> I'd like to replace JNA with JNI/C++ to avoid dependency on 3MB JNA jars.
> 
> If all goes well, this could be ready for FlatLaf 1.1 or 1.2 and then 
> land in NB 12.4...
> 
> 
> Looking at the screenshots, I think it would be great if we could move 
> the search box from the menubar into the toolbar area. Then the embedded 
> menubar would work fine and safe some vertical space.
> 
> 
> Would be also great to have some kind of "FlatLaf" tab in the Options 
> dialog to allow the user to enable/disable this kind of FlatLaf features.
> 
> Regards,
> Karl
> 
> 
> Am 26.02.2021 um 00:04 schrieb Mark Herkrath:
>> Hi all,
>> 
>> Now that NetBeans 12.3 is using a recent FlatLaf version, it would be possible to have a dark title bar under Windows 10. In beta 3, it’s still not enabled though. I always felt the Windows 10 default, light title bar with FlatLaf dark theme to be pretty distracting, especially in full screen mode. It’s also light if Windows itself is running in dark mode.
>> 
>> More information on the dark title bar with FlatLaf can be found here: https://github.com/JFormDesigner/FlatLaf/releases/tag/0.37 <https://github.com/JFormDesigner/FlatLaf/releases/tag/0.37>
>> 
>> I have tweaked my NB dev version accordingly. Please see screenshots at https://i.imgur.com/P0Xmp6T.png <https://i.imgur.com/P0Xmp6T.png> (I think it’s not possible to send images to here). My current version is not mergeable though, as it’s just a quick PoC. It’s just about calling
>> JFrame.setDefaultLookAndFeelDecorated(true);
>> JDialog.setDefaultLookAndFeelDecorated(true);
>> 
>> and setting
>> TitlePane.menuBarEmbedded=false
>> 
>> If desired, I could provide a merge request but I would need some questions to be answered first. Likely it is easier if someone with knowledge about NetBeans L&Fs would just add it.
>> 
>> Regards,
>> Mark
>> 
>> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@netbeans.apache.org
> For additional commands, e-mail: dev-help@netbeans.apache.org
> 
> For further information about the NetBeans mailing lists, visit:
> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
> 
> 
> 
>