You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Alexander Pivovarov <ap...@gmail.com> on 2015/06/26 04:19:57 UTC
Review Request 35902: HIVE-11103 Add banker's rounding BROUND UDF
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35902/
-----------------------------------------------------------
Review request for hive and Jason Dere.
Bugs: HIVE-11103
https://issues.apache.org/jira/browse/HIVE-11103
Repository: hive-git
Description
-------
HIVE-11103 Add banker's rounding BROUND UDF
Diffs
-----
ant/src/org/apache/hadoop/hive/ant/GenVectorCode.java 6485a2ac5f12dbdba7bdf4d17ba18ad054c6f73b
common/src/java/org/apache/hadoop/hive/common/type/HiveDecimal.java a8215f29aed3a0399ec274cc311a3c92e0cca55b
ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java fabc21e2092561cbf98c35a406e4ee40e71fe1de
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/BRoundWithNumDigitsDoubleToDouble.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/DecimalUtil.java ef800596deed612b525ed3371b196f275ad88e09
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/FuncBRoundWithNumDigitsDecimalToDecimal.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/FuncRoundWithNumDigitsDecimalToDecimal.java 9f3e8a3fcacb17990c6644a67cf587ae9948adad
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/MathExpr.java aef923e2c362a8d15b8dcc3467aef01a862c205c
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBRound.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFRound.java 963e4a87c417798f95bb1490a4275339a61e869c
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/RoundUtils.java 0b389a5783fa2cf6643919c411ee57a7ed873d84
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFBRound.java PRE-CREATION
ql/src/test/queries/clientpositive/udf_bround.q PRE-CREATION
ql/src/test/results/clientpositive/show_functions.q.out 5de4ffcd1ace477af026b83fb7bfb8068fc192b3
ql/src/test/results/clientpositive/udf_bround.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/35902/diff/
Testing
-------
Thanks,
Alexander Pivovarov
Re: Review Request 35902: HIVE-11103 Add banker's rounding BROUND UDF
Posted by Alexander Pivovarov <ap...@gmail.com>.
> On July 2, 2015, 9:10 p.m., Jason Dere wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/MathExpr.java, line 38
> > <https://reviews.apache.org/r/35902/diff/1/?file=992839#file992839line38>
> >
> > Can you add a JUnit test somewhere to test that the behavior of MathExpr.bround(x) == RoundUtils.bround(x, 0)?
added TestGenericUDFBRound.testMathExprBround
> On July 2, 2015, 9:10 p.m., Jason Dere wrote:
> > ant/src/org/apache/hadoop/hive/ant/GenVectorCode.java, line 756
> > <https://reviews.apache.org/r/35902/diff/1/?file=992832#file992832line756>
> >
> > If you're going to add a vectorized version of the function, can you add a q-file test to test the vectorized bround()?
added vector_bround.q
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35902/#review90283
-----------------------------------------------------------
On July 27, 2015, 6:12 a.m., Alexander Pivovarov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35902/
> -----------------------------------------------------------
>
> (Updated July 27, 2015, 6:12 a.m.)
>
>
> Review request for hive and Jason Dere.
>
>
> Bugs: HIVE-11103
> https://issues.apache.org/jira/browse/HIVE-11103
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-11103 Add banker's rounding BROUND UDF
>
>
> Diffs
> -----
>
> ant/src/org/apache/hadoop/hive/ant/GenVectorCode.java 6485a2ac5f12dbdba7bdf4d17ba18ad054c6f73b
> common/src/java/org/apache/hadoop/hive/common/type/HiveDecimal.java a8215f29aed3a0399ec274cc311a3c92e0cca55b
> ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java fabc21e2092561cbf98c35a406e4ee40e71fe1de
> ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/BRoundWithNumDigitsDoubleToDouble.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/DecimalUtil.java ef800596deed612b525ed3371b196f275ad88e09
> ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/FuncBRoundWithNumDigitsDecimalToDecimal.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/FuncRoundWithNumDigitsDecimalToDecimal.java 9f3e8a3fcacb17990c6644a67cf587ae9948adad
> ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/MathExpr.java aef923e2c362a8d15b8dcc3467aef01a862c205c
> ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBRound.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFRound.java 963e4a87c417798f95bb1490a4275339a61e869c
> ql/src/java/org/apache/hadoop/hive/ql/udf/generic/RoundUtils.java 0b389a5783fa2cf6643919c411ee57a7ed873d84
> ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFBRound.java PRE-CREATION
> ql/src/test/queries/clientpositive/udf_bround.q PRE-CREATION
> ql/src/test/queries/clientpositive/vector_bround.q PRE-CREATION
> ql/src/test/results/clientpositive/show_functions.q.out 5de4ffcd1ace477af026b83fb7bfb8068fc192b3
> ql/src/test/results/clientpositive/udf_bround.q.out PRE-CREATION
> ql/src/test/results/clientpositive/vector_bround.q.out PRE-CREATION
>
> Diff: https://reviews.apache.org/r/35902/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alexander Pivovarov
>
>
Re: Review Request 35902: HIVE-11103 Add banker's rounding BROUND UDF
Posted by Jason Dere <jd...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35902/#review90283
-----------------------------------------------------------
ant/src/org/apache/hadoop/hive/ant/GenVectorCode.java (line 756)
<https://reviews.apache.org/r/35902/#comment143291>
If you're going to add a vectorized version of the function, can you add a q-file test to test the vectorized bround()?
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/MathExpr.java (line 38)
<https://reviews.apache.org/r/35902/#comment143290>
Can you add a JUnit test somewhere to test that the behavior of MathExpr.bround(x) == RoundUtils.bround(x, 0)?
- Jason Dere
On June 26, 2015, 2:19 a.m., Alexander Pivovarov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35902/
> -----------------------------------------------------------
>
> (Updated June 26, 2015, 2:19 a.m.)
>
>
> Review request for hive and Jason Dere.
>
>
> Bugs: HIVE-11103
> https://issues.apache.org/jira/browse/HIVE-11103
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-11103 Add banker's rounding BROUND UDF
>
>
> Diffs
> -----
>
> ant/src/org/apache/hadoop/hive/ant/GenVectorCode.java 6485a2ac5f12dbdba7bdf4d17ba18ad054c6f73b
> common/src/java/org/apache/hadoop/hive/common/type/HiveDecimal.java a8215f29aed3a0399ec274cc311a3c92e0cca55b
> ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java fabc21e2092561cbf98c35a406e4ee40e71fe1de
> ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/BRoundWithNumDigitsDoubleToDouble.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/DecimalUtil.java ef800596deed612b525ed3371b196f275ad88e09
> ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/FuncBRoundWithNumDigitsDecimalToDecimal.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/FuncRoundWithNumDigitsDecimalToDecimal.java 9f3e8a3fcacb17990c6644a67cf587ae9948adad
> ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/MathExpr.java aef923e2c362a8d15b8dcc3467aef01a862c205c
> ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBRound.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFRound.java 963e4a87c417798f95bb1490a4275339a61e869c
> ql/src/java/org/apache/hadoop/hive/ql/udf/generic/RoundUtils.java 0b389a5783fa2cf6643919c411ee57a7ed873d84
> ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFBRound.java PRE-CREATION
> ql/src/test/queries/clientpositive/udf_bround.q PRE-CREATION
> ql/src/test/results/clientpositive/show_functions.q.out 5de4ffcd1ace477af026b83fb7bfb8068fc192b3
> ql/src/test/results/clientpositive/udf_bround.q.out PRE-CREATION
>
> Diff: https://reviews.apache.org/r/35902/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alexander Pivovarov
>
>
Re: Review Request 35902: HIVE-11103 Add banker's rounding BROUND UDF
Posted by Alexander Pivovarov <ap...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35902/
-----------------------------------------------------------
(Updated Aug. 10, 2015, 7:14 a.m.)
Review request for hive and Jason Dere.
Changes
-------
add non-default constructor to FuncRoundWithNumDigitsDecimalToDecimal
Bugs: HIVE-11103
https://issues.apache.org/jira/browse/HIVE-11103
Repository: hive-git
Description
-------
HIVE-11103 Add banker's rounding BROUND UDF
Diffs (updated)
-----
ant/src/org/apache/hadoop/hive/ant/GenVectorCode.java 54f3783d94a139c0ccee77dc91657cfe59f81ba9
ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java fb06d446a45cbf22c2e8b65e7cb28a9005049627
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/BRoundWithNumDigitsDoubleToDouble.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/DecimalUtil.java ef800596deed612b525ed3371b196f275ad88e09
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/FuncBRoundWithNumDigitsDecimalToDecimal.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/FuncRoundWithNumDigitsDecimalToDecimal.java 9f3e8a3fcacb17990c6644a67cf587ae9948adad
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/MathExpr.java aef923e2c362a8d15b8dcc3467aef01a862c205c
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java 82c3e5032f5bf81cde4b52c91f71e0525728812c
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBRound.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFRound.java 963e4a87c417798f95bb1490a4275339a61e869c
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/RoundUtils.java 0b389a5783fa2cf6643919c411ee57a7ed873d84
ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorizationContext.java 98a8c3eb61f97fdaa44fe11c81c884146bac1d45
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFBRound.java PRE-CREATION
ql/src/test/queries/clientpositive/udf_bround.q PRE-CREATION
ql/src/test/queries/clientpositive/vector_bround.q PRE-CREATION
ql/src/test/results/clientpositive/show_functions.q.out 5de4ffcd1ace477af026b83fb7bfb8068fc192b3
ql/src/test/results/clientpositive/udf_bround.q.out PRE-CREATION
ql/src/test/results/clientpositive/vector_bround.q.out PRE-CREATION
storage-api/src/java/org/apache/hadoop/hive/common/type/HiveDecimal.java 7d7fb2841bc985c62ecd1781bbde5380647b81ca
Diff: https://reviews.apache.org/r/35902/diff/
Testing
-------
Thanks,
Alexander Pivovarov
Re: Review Request 35902: HIVE-11103 Add banker's rounding BROUND UDF
Posted by Alexander Pivovarov <ap...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35902/
-----------------------------------------------------------
(Updated Aug. 10, 2015, 7:05 a.m.)
Review request for hive and Jason Dere.
Changes
-------
added non-default constructor to BRoundWithNumDigitsDoubleToDouble, added BRound to TestVectorizationContext, fixed vector_bround.q.out
Bugs: HIVE-11103
https://issues.apache.org/jira/browse/HIVE-11103
Repository: hive-git
Description
-------
HIVE-11103 Add banker's rounding BROUND UDF
Diffs (updated)
-----
ant/src/org/apache/hadoop/hive/ant/GenVectorCode.java 54f3783d94a139c0ccee77dc91657cfe59f81ba9
ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java fb06d446a45cbf22c2e8b65e7cb28a9005049627
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/BRoundWithNumDigitsDoubleToDouble.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/DecimalUtil.java ef800596deed612b525ed3371b196f275ad88e09
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/FuncBRoundWithNumDigitsDecimalToDecimal.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/FuncRoundWithNumDigitsDecimalToDecimal.java 9f3e8a3fcacb17990c6644a67cf587ae9948adad
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/MathExpr.java aef923e2c362a8d15b8dcc3467aef01a862c205c
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java 82c3e5032f5bf81cde4b52c91f71e0525728812c
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBRound.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFRound.java 963e4a87c417798f95bb1490a4275339a61e869c
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/RoundUtils.java 0b389a5783fa2cf6643919c411ee57a7ed873d84
ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorizationContext.java 98a8c3eb61f97fdaa44fe11c81c884146bac1d45
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFBRound.java PRE-CREATION
ql/src/test/queries/clientpositive/udf_bround.q PRE-CREATION
ql/src/test/queries/clientpositive/vector_bround.q PRE-CREATION
ql/src/test/results/clientpositive/show_functions.q.out 5de4ffcd1ace477af026b83fb7bfb8068fc192b3
ql/src/test/results/clientpositive/udf_bround.q.out PRE-CREATION
ql/src/test/results/clientpositive/vector_bround.q.out PRE-CREATION
storage-api/src/java/org/apache/hadoop/hive/common/type/HiveDecimal.java 7d7fb2841bc985c62ecd1781bbde5380647b81ca
Diff: https://reviews.apache.org/r/35902/diff/
Testing
-------
Thanks,
Alexander Pivovarov
Re: Review Request 35902: HIVE-11103 Add banker's rounding BROUND UDF
Posted by Jason Dere <jd...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35902/#review93405
-----------------------------------------------------------
ql/src/test/results/clientpositive/vector_bround.q.out (line 62)
<https://reviews.apache.org/r/35902/#comment147780>
This isn't showing "Execution mode: vectorized" which you should see in the explain plan for the other vectorized tests
- Jason Dere
On July 27, 2015, 6:12 a.m., Alexander Pivovarov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35902/
> -----------------------------------------------------------
>
> (Updated July 27, 2015, 6:12 a.m.)
>
>
> Review request for hive and Jason Dere.
>
>
> Bugs: HIVE-11103
> https://issues.apache.org/jira/browse/HIVE-11103
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-11103 Add banker's rounding BROUND UDF
>
>
> Diffs
> -----
>
> ant/src/org/apache/hadoop/hive/ant/GenVectorCode.java 6485a2ac5f12dbdba7bdf4d17ba18ad054c6f73b
> common/src/java/org/apache/hadoop/hive/common/type/HiveDecimal.java a8215f29aed3a0399ec274cc311a3c92e0cca55b
> ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java fabc21e2092561cbf98c35a406e4ee40e71fe1de
> ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/BRoundWithNumDigitsDoubleToDouble.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/DecimalUtil.java ef800596deed612b525ed3371b196f275ad88e09
> ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/FuncBRoundWithNumDigitsDecimalToDecimal.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/FuncRoundWithNumDigitsDecimalToDecimal.java 9f3e8a3fcacb17990c6644a67cf587ae9948adad
> ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/MathExpr.java aef923e2c362a8d15b8dcc3467aef01a862c205c
> ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBRound.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFRound.java 963e4a87c417798f95bb1490a4275339a61e869c
> ql/src/java/org/apache/hadoop/hive/ql/udf/generic/RoundUtils.java 0b389a5783fa2cf6643919c411ee57a7ed873d84
> ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFBRound.java PRE-CREATION
> ql/src/test/queries/clientpositive/udf_bround.q PRE-CREATION
> ql/src/test/queries/clientpositive/vector_bround.q PRE-CREATION
> ql/src/test/results/clientpositive/show_functions.q.out 5de4ffcd1ace477af026b83fb7bfb8068fc192b3
> ql/src/test/results/clientpositive/udf_bround.q.out PRE-CREATION
> ql/src/test/results/clientpositive/vector_bround.q.out PRE-CREATION
>
> Diff: https://reviews.apache.org/r/35902/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alexander Pivovarov
>
>
Re: Review Request 35902: HIVE-11103 Add banker's rounding BROUND UDF
Posted by Alexander Pivovarov <ap...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35902/
-----------------------------------------------------------
(Updated July 27, 2015, 6:12 a.m.)
Review request for hive and Jason Dere.
Changes
-------
added vector_bround.q, added testMathExprBround
Bugs: HIVE-11103
https://issues.apache.org/jira/browse/HIVE-11103
Repository: hive-git
Description
-------
HIVE-11103 Add banker's rounding BROUND UDF
Diffs (updated)
-----
ant/src/org/apache/hadoop/hive/ant/GenVectorCode.java 6485a2ac5f12dbdba7bdf4d17ba18ad054c6f73b
common/src/java/org/apache/hadoop/hive/common/type/HiveDecimal.java a8215f29aed3a0399ec274cc311a3c92e0cca55b
ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java fabc21e2092561cbf98c35a406e4ee40e71fe1de
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/BRoundWithNumDigitsDoubleToDouble.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/DecimalUtil.java ef800596deed612b525ed3371b196f275ad88e09
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/FuncBRoundWithNumDigitsDecimalToDecimal.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/FuncRoundWithNumDigitsDecimalToDecimal.java 9f3e8a3fcacb17990c6644a67cf587ae9948adad
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/MathExpr.java aef923e2c362a8d15b8dcc3467aef01a862c205c
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBRound.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFRound.java 963e4a87c417798f95bb1490a4275339a61e869c
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/RoundUtils.java 0b389a5783fa2cf6643919c411ee57a7ed873d84
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFBRound.java PRE-CREATION
ql/src/test/queries/clientpositive/udf_bround.q PRE-CREATION
ql/src/test/queries/clientpositive/vector_bround.q PRE-CREATION
ql/src/test/results/clientpositive/show_functions.q.out 5de4ffcd1ace477af026b83fb7bfb8068fc192b3
ql/src/test/results/clientpositive/udf_bround.q.out PRE-CREATION
ql/src/test/results/clientpositive/vector_bround.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/35902/diff/
Testing
-------
Thanks,
Alexander Pivovarov