You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bloodhound.apache.org by Apache Bloodhound <bl...@incubator.apache.org> on 2012/12/06 00:52:50 UTC

[Apache Bloodhound] #287: Hide theme engine administration panels

#287: Hide theme engine administration panels
-------------------------+---------------------
 Reporter:  rjollos      |      Owner:  rjollos
     Type:  enhancement  |     Status:  new
 Priority:  trivial      |  Milestone:
Component:  plugins      |    Version:
 Keywords:               |
-------------------------+---------------------
 The Theme engine administration panels don't seem to have a purpose in a
 typical installation of bloodhound, so I propose that we hide these in the
 standard installation.

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/287>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker

Re: [Apache Bloodhound] #287: Hide theme engine administration panels

Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#287: Hide theme engine administration panels
--------------------------+----------------------
  Reporter:  rjollos      |      Owner:  rjollos
      Type:  enhancement  |     Status:  accepted
  Priority:  trivial      |  Milestone:
 Component:  plugins      |    Version:
Resolution:               |   Keywords:
--------------------------+----------------------
Changes (by rjollos):

 * status:  new => accepted


-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/287#comment:2>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker

Re: [Apache Bloodhound] #287: Hide theme engine administration panels

Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#287: Hide theme engine administration panels
--------------------------+----------------------
  Reporter:  rjollos      |      Owner:  rjollos
      Type:  enhancement  |     Status:  accepted
  Priority:  trivial      |  Milestone:
 Component:  plugins      |    Version:
Resolution:               |   Keywords:
--------------------------+----------------------

Comment (by gjm):

 For the base install, the change looks completely reasonable as we don't
 need the ability to change between themes. When people want to add more
 themes, it becomes a different matter but there is nothing yet to stop an
 admin from re-enabling the relevant components.

 As for rules for disabling components, I don't see the advantage for this
 particular choice at this point.

 So, yeah.. I would say just commit it personally.

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/287#comment:5>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker

Re: [Apache Bloodhound] #287: Hide theme engine administration panels

Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#287: Hide theme engine administration panels
--------------------------+----------------------
  Reporter:  rjollos      |      Owner:  rjollos
      Type:  enhancement  |     Status:  accepted
  Priority:  trivial      |  Milestone:
 Component:  plugins      |    Version:
Resolution:               |   Keywords:
--------------------------+----------------------
Changes (by olemis):

 * cc: olemis+bh@… (added)


-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/287#comment:3>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker

Re: [Apache Bloodhound] #287: Hide theme engine administration panels

Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#287: Hide theme engine administration panels
--------------------------+---------------------
  Reporter:  rjollos      |      Owner:  rjollos
      Type:  enhancement  |     Status:  new
  Priority:  trivial      |  Milestone:
 Component:  plugins      |    Version:
Resolution:               |   Keywords:
--------------------------+---------------------

Comment (by rjollos):

 I'm looking to get a few + votes for [attachment:t287-r1415767-1.patch
 this change] before committing.

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/287#comment:1>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker

Re: [Apache Bloodhound] #287: Hide theme engine administration panels

Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#287: Hide theme engine administration panels
--------------------------+----------------------
  Reporter:  rjollos      |      Owner:  rjollos
      Type:  enhancement  |     Status:  accepted
  Priority:  trivial      |  Milestone:
 Component:  plugins      |    Version:
Resolution:               |   Keywords:
--------------------------+----------------------

Comment (by olemis):

 Replying to [comment:1 rjollos]:
 > I'm looking to get a few + votes for [attachment:t287-r1415767-1.patch
 this change] before committing.

 I'd rather prefer to add some rule(s) for disabled components . Better
 explicit than implicit .
 ;)

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/287#comment:4>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker

Re: [Apache Bloodhound] #287: Hide theme engine administration panels

Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#287: Hide theme engine administration panels
--------------------------+----------------------
  Reporter:  rjollos      |      Owner:  rjollos
      Type:  enhancement  |     Status:  accepted
  Priority:  trivial      |  Milestone:
 Component:  plugins      |    Version:
Resolution:               |   Keywords:
--------------------------+----------------------

Comment (by rjollos):

 My thinking is similar to comment:5. Let's hide things from the admin
 panel that we don't want to support at this point. Later on, we may choose
 to support themes, and can then add proper BH templates for the theme
 engine administration panels.

 I interpret rules as ''command line switches'' for `setup_bloodhound.py`.
 If that is how it was meant, I think a switch would serve little purpose
 for this case, but could be useful for other cases.

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/287#comment:6>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker

Re: [Apache Bloodhound] #287: Hide theme engine administration panels

Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#287: Hide theme engine administration panels
--------------------------+---------------------
  Reporter:  rjollos      |      Owner:  rjollos
      Type:  enhancement  |     Status:  closed
  Priority:  trivial      |  Milestone:
 Component:  plugins      |    Version:
Resolution:  fixed        |   Keywords:
--------------------------+---------------------
Changes (by rjollos):

 * status:  accepted => closed
 * resolution:   => fixed


Comment:

 Fixes in r1418213.

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/287#comment:7>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker