You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "cvictory (GitHub)" <gi...@apache.org> on 2018/12/14 06:44:04 UTC

[GitHub] [incubator-dubbo] cvictory opened pull request #2964: modify kryo serialization. fix #2881

## What is the purpose of the change

fix #2881

## Brief changelog

先提交讨论下方案可行性。之后再来完善单元测试和部分优化点，不要进行merge。（Submit the feasibility of the program under discussion first. Then improve the unit test and partial optimization points.）

original  (原来的结构) :
![image](https://user-images.githubusercontent.com/4089452/49987442-431a7580-ffae-11e8-923f-75e7353a8a3c.png)

now （修改之后）:
![image](https://user-images.githubusercontent.com/4089452/49987408-2aaa5b00-ffae-11e8-919e-19b45f6297e0.png)


## Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

- [x] Make sure there is a [GITHUB_issue](https://github.com/apache/incubator-dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [ ] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config not exist #XXX`. Each commit in the pull request should have a meaningful subject line and body.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/incubator-dubbo/tree/master/dubbo-test).
- [ ] Run `mvn clean install -DskipTests=false` & `mvn clean test-compile failsafe:integration-test` to make sure unit-test and integration-test pass.
- [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/incubator-dubbo/wiki/Software-donation-guide).


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2964 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] carryxyh commented on issue #2964: modify kryo serialization. fix #2881

Posted by "carryxyh (GitHub)" <gi...@apache.org>.
我认为这种修复方式是可以的。
我会发送一封邮件来获取更多的意见，这是一个比较大的改动，你认为呢？
另外，这个pr是否应该同样提交到master上？


I think this kind of modifications is ok.
I will send an email to get more comments. This is a big change. What do you think?
In addition, should this PR be submitted to the owner as well?

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2964 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] khanimteyaz commented on issue #2964: modify kryo serialization. fix #2881

Posted by "khanimteyaz (GitHub)" <gi...@apache.org>.
I have mostly looks into looping, considition and whether existing utils can be used or not. It looks fine to me.

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2964 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] dubbo-bot commented on issue #2964: modify kryo serialization. fix #2881

Posted by "dubbo-bot (GitHub)" <gi...@apache.org>.
Ping @cvictory . Conflict happens after merging a previous commit. Please rebase the branch against master and push it back again. Thanks a lot.

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2964 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] codecov-io commented on issue #2964: modify kryo serialization. fix #2881

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2964?src=pr&el=h1) Report
> Merging [#2964](https://codecov.io/gh/apache/incubator-dubbo/pull/2964?src=pr&el=desc) into [2.6.x](https://codecov.io/gh/apache/incubator-dubbo/commit/ac49a7d34ac6cfe5ff089d9823bdad1171409c00?src=pr&el=desc) will **decrease** coverage by `0.26%`.
> The diff coverage is `23.37%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo/pull/2964/graphs/tree.svg?width=650&token=VnEIkiFQT0&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dubbo/pull/2964?src=pr&el=tree)

```diff
@@             Coverage Diff              @@
##              2.6.x    #2964      +/-   ##
============================================
- Coverage     47.36%   47.09%   -0.27%     
- Complexity     4289     4290       +1     
============================================
  Files           552      553       +1     
  Lines         24381    24438      +57     
  Branches       4314     4328      +14     
============================================
- Hits          11547    11510      -37     
- Misses        11047    11133      +86     
- Partials       1787     1795       +8
```


| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/2964?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../main/java/com/alibaba/dubbo/common/Constants.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2964/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL0NvbnN0YW50cy5qYXZh) | `88.88% <ø> (ø)` | `1 <0> (ø)` | :arrow_down: |
| [...n/serialize/kryo/utils/ThreadLocalKryoFactory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2964/diff?src=pr&el=tree#diff-ZHViYm8tc2VyaWFsaXphdGlvbi9kdWJiby1zZXJpYWxpemF0aW9uLWtyeW8vc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb21tb24vc2VyaWFsaXplL2tyeW8vdXRpbHMvVGhyZWFkTG9jYWxLcnlvRmFjdG9yeS5qYXZh) | `80% <ø> (ø)` | `2 <0> (ø)` | :arrow_down: |
| [...mon/serialize/kryo/utils/PrototypeKryoFactory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2964/diff?src=pr&el=tree#diff-ZHViYm8tc2VyaWFsaXphdGlvbi9kdWJiby1zZXJpYWxpemF0aW9uLWtyeW8vc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb21tb24vc2VyaWFsaXplL2tyeW8vdXRpbHMvUHJvdG90eXBlS3J5b0ZhY3RvcnkuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [.../dubbo/common/serialize/kryo/KryoObjectOutput.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2964/diff?src=pr&el=tree#diff-ZHViYm8tc2VyaWFsaXphdGlvbi9kdWJiby1zZXJpYWxpemF0aW9uLWtyeW8vc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb21tb24vc2VyaWFsaXplL2tyeW8vS3J5b09iamVjdE91dHB1dC5qYXZh) | `80.55% <100%> (ø)` | `13 <1> (ø)` | :arrow_down: |
| [...a/dubbo/common/serialize/kryo/KryoObjectInput.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2964/diff?src=pr&el=tree#diff-ZHViYm8tc2VyaWFsaXphdGlvbi9kdWJiby1zZXJpYWxpemF0aW9uLWtyeW8vc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb21tb24vc2VyaWFsaXplL2tyeW8vS3J5b09iamVjdElucHV0LmphdmE=) | `81.81% <100%> (ø)` | `12 <1> (ø)` | :arrow_down: |
| [...dubbo/common/serialize/kryo/KryoSerialization.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2964/diff?src=pr&el=tree#diff-ZHViYm8tc2VyaWFsaXphdGlvbi9kdWJiby1zZXJpYWxpemF0aW9uLWtyeW8vc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb21tb24vc2VyaWFsaXplL2tyeW8vS3J5b1NlcmlhbGl6YXRpb24uamF2YQ==) | `60% <100%> (ø)` | `3 <2> (ø)` | :arrow_down: |
| [...mmon/serialize/kryo/utils/AbstractKryoFactory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2964/diff?src=pr&el=tree#diff-ZHViYm8tc2VyaWFsaXphdGlvbi9kdWJiby1zZXJpYWxpemF0aW9uLWtyeW8vc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb21tb24vc2VyaWFsaXplL2tyeW8vdXRpbHMvQWJzdHJhY3RLcnlvRmFjdG9yeS5qYXZh) | `65.67% <21.42%> (-12.11%)` | `6 <3> (+3)` | |
| [...ialize/kryo/utils/MultiThreadLocalKryoFactory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2964/diff?src=pr&el=tree#diff-ZHViYm8tc2VyaWFsaXphdGlvbi9kdWJiby1zZXJpYWxpemF0aW9uLWtyeW8vc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb21tb24vc2VyaWFsaXplL2tyeW8vdXRpbHMvTXVsdGlUaHJlYWRMb2NhbEtyeW9GYWN0b3J5LmphdmE=) | `25% <25%> (ø)` | `1 <1> (?)` | |
| [...n/serialize/support/SerializableClassRegistry.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2964/diff?src=pr&el=tree#diff-ZHViYm8tc2VyaWFsaXphdGlvbi9kdWJiby1zZXJpYWxpemF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL2NvbW1vbi9zZXJpYWxpemUvc3VwcG9ydC9TZXJpYWxpemFibGVDbGFzc1JlZ2lzdHJ5LmphdmE=) | `60% <40%> (-20%)` | `3 <0> (ø)` | |
| [...libaba/dubbo/rpc/protocol/dubbo/DubboProtocol.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2964/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9wcm90b2NvbC9kdWJiby9EdWJib1Byb3RvY29sLmphdmE=) | `54.5% <5.26%> (-6.46%)` | `32 <0> (-1)` | |
| ... and [19 more](https://codecov.io/gh/apache/incubator-dubbo/pull/2964/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2964?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2964?src=pr&el=footer). Last update [ac49a7d...4ba2bf8](https://codecov.io/gh/apache/incubator-dubbo/pull/2964?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2964 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] dubbo-bot commented on issue #2964: modify kryo serialization. fix #2881

Posted by "dubbo-bot (GitHub)" <gi...@apache.org>.
Ping @cvictory . Conflict happens after merging a previous commit. Please rebase the branch against master and push it back again. Thanks a lot.

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2964 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] cvictory commented on pull request #2964: modify kryo serialization. fix #2881

Posted by "cvictory (GitHub)" <gi...@apache.org>.
是的，原来的调用链路比较长。我这个也是一个修改的初稿，等方案完全确定，再来做些修改和完善单元测试。（上周休假了）

Yes, the original call link is longer. I am also a revised draft, and the plan is completely determined, and then I will make some modifications and improve the unit test. (I took a vacation last week)

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2964 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] codecov-io commented on issue #2964: modify kryo serialization. fix #2881

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2964?src=pr&el=h1) Report
> Merging [#2964](https://codecov.io/gh/apache/incubator-dubbo/pull/2964?src=pr&el=desc) into [2.6.x](https://codecov.io/gh/apache/incubator-dubbo/commit/ac49a7d34ac6cfe5ff089d9823bdad1171409c00?src=pr&el=desc) will **decrease** coverage by `0.26%`.
> The diff coverage is `23.37%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo/pull/2964/graphs/tree.svg?width=650&token=VnEIkiFQT0&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dubbo/pull/2964?src=pr&el=tree)

```diff
@@             Coverage Diff              @@
##              2.6.x    #2964      +/-   ##
============================================
- Coverage     47.36%   47.09%   -0.27%     
- Complexity     4289     4290       +1     
============================================
  Files           552      553       +1     
  Lines         24381    24438      +57     
  Branches       4314     4328      +14     
============================================
- Hits          11547    11510      -37     
- Misses        11047    11133      +86     
- Partials       1787     1795       +8
```


| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/2964?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../main/java/com/alibaba/dubbo/common/Constants.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2964/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL0NvbnN0YW50cy5qYXZh) | `88.88% <ø> (ø)` | `1 <0> (ø)` | :arrow_down: |
| [...n/serialize/kryo/utils/ThreadLocalKryoFactory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2964/diff?src=pr&el=tree#diff-ZHViYm8tc2VyaWFsaXphdGlvbi9kdWJiby1zZXJpYWxpemF0aW9uLWtyeW8vc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb21tb24vc2VyaWFsaXplL2tyeW8vdXRpbHMvVGhyZWFkTG9jYWxLcnlvRmFjdG9yeS5qYXZh) | `80% <ø> (ø)` | `2 <0> (ø)` | :arrow_down: |
| [...mon/serialize/kryo/utils/PrototypeKryoFactory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2964/diff?src=pr&el=tree#diff-ZHViYm8tc2VyaWFsaXphdGlvbi9kdWJiby1zZXJpYWxpemF0aW9uLWtyeW8vc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb21tb24vc2VyaWFsaXplL2tyeW8vdXRpbHMvUHJvdG90eXBlS3J5b0ZhY3RvcnkuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [.../dubbo/common/serialize/kryo/KryoObjectOutput.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2964/diff?src=pr&el=tree#diff-ZHViYm8tc2VyaWFsaXphdGlvbi9kdWJiby1zZXJpYWxpemF0aW9uLWtyeW8vc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb21tb24vc2VyaWFsaXplL2tyeW8vS3J5b09iamVjdE91dHB1dC5qYXZh) | `80.55% <100%> (ø)` | `13 <1> (ø)` | :arrow_down: |
| [...a/dubbo/common/serialize/kryo/KryoObjectInput.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2964/diff?src=pr&el=tree#diff-ZHViYm8tc2VyaWFsaXphdGlvbi9kdWJiby1zZXJpYWxpemF0aW9uLWtyeW8vc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb21tb24vc2VyaWFsaXplL2tyeW8vS3J5b09iamVjdElucHV0LmphdmE=) | `81.81% <100%> (ø)` | `12 <1> (ø)` | :arrow_down: |
| [...dubbo/common/serialize/kryo/KryoSerialization.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2964/diff?src=pr&el=tree#diff-ZHViYm8tc2VyaWFsaXphdGlvbi9kdWJiby1zZXJpYWxpemF0aW9uLWtyeW8vc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb21tb24vc2VyaWFsaXplL2tyeW8vS3J5b1NlcmlhbGl6YXRpb24uamF2YQ==) | `60% <100%> (ø)` | `3 <2> (ø)` | :arrow_down: |
| [...mmon/serialize/kryo/utils/AbstractKryoFactory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2964/diff?src=pr&el=tree#diff-ZHViYm8tc2VyaWFsaXphdGlvbi9kdWJiby1zZXJpYWxpemF0aW9uLWtyeW8vc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb21tb24vc2VyaWFsaXplL2tyeW8vdXRpbHMvQWJzdHJhY3RLcnlvRmFjdG9yeS5qYXZh) | `65.67% <21.42%> (-12.11%)` | `6 <3> (+3)` | |
| [...ialize/kryo/utils/MultiThreadLocalKryoFactory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2964/diff?src=pr&el=tree#diff-ZHViYm8tc2VyaWFsaXphdGlvbi9kdWJiby1zZXJpYWxpemF0aW9uLWtyeW8vc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb21tb24vc2VyaWFsaXplL2tyeW8vdXRpbHMvTXVsdGlUaHJlYWRMb2NhbEtyeW9GYWN0b3J5LmphdmE=) | `25% <25%> (ø)` | `1 <1> (?)` | |
| [...n/serialize/support/SerializableClassRegistry.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2964/diff?src=pr&el=tree#diff-ZHViYm8tc2VyaWFsaXphdGlvbi9kdWJiby1zZXJpYWxpemF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL2NvbW1vbi9zZXJpYWxpemUvc3VwcG9ydC9TZXJpYWxpemFibGVDbGFzc1JlZ2lzdHJ5LmphdmE=) | `60% <40%> (-20%)` | `3 <0> (ø)` | |
| [...libaba/dubbo/rpc/protocol/dubbo/DubboProtocol.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2964/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9wcm90b2NvbC9kdWJiby9EdWJib1Byb3RvY29sLmphdmE=) | `54.5% <5.26%> (-6.46%)` | `32 <0> (-1)` | |
| ... and [19 more](https://codecov.io/gh/apache/incubator-dubbo/pull/2964/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2964?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2964?src=pr&el=footer). Last update [ac49a7d...4ba2bf8](https://codecov.io/gh/apache/incubator-dubbo/pull/2964?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2964 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] dubbo-bot commented on issue #2964: modify kryo serialization. fix #2881

Posted by "dubbo-bot (GitHub)" <gi...@apache.org>.
Ping @cvictory . Conflict happens after merging a previous commit. Please rebase the branch against master and push it back again. Thanks a lot.

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2964 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] carryxyh commented on pull request #2964: modify kryo serialization. fix #2881

Posted by "carryxyh (GitHub)" <gi...@apache.org>.
Does the function of kryoUtils have a certain overlap with KryoFactory? Personally think that KryoUtils is a bit redundant. The current use of ThreadLocalKryoFactory in KryoUtils is also not flexible.


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2964 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] carryxyh commented on pull request #2964: modify kryo serialization. fix #2881

Posted by "carryxyh (GitHub)" <gi...@apache.org>.
Sorry, I forgot to send the email. I will send the email today. I think we can discuss it there.
:)

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2964 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] khanimteyaz commented on issue #2964: modify kryo serialization. fix #2881

Posted by "khanimteyaz (GitHub)" <gi...@apache.org>.
to me looks fine.

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2964 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] dubbo-bot commented on issue #2964: modify kryo serialization. fix #2881

Posted by "dubbo-bot (GitHub)" <gi...@apache.org>.
Ping @cvictory . Conflict happens after merging a previous commit. Please rebase the branch against master and push it back again. Thanks a lot.

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2964 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] dubbo-bot commented on issue #2964: modify kryo serialization. fix #2881

Posted by "dubbo-bot (GitHub)" <gi...@apache.org>.
Ping @cvictory . Conflict happens after merging a previous commit. Please rebase the branch against master and push it back again. Thanks a lot.

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2964 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] dubbo-bot commented on issue #2964: modify kryo serialization. fix #2881

Posted by "dubbo-bot (GitHub)" <gi...@apache.org>.
Ping @cvictory . Conflict happens after merging a previous commit. Please rebase the branch against master and push it back again. Thanks a lot.

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2964 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org