You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by GitBox <gi...@apache.org> on 2022/08/28 14:08:16 UTC
[GitHub] [incubator-uniffle] leixm commented on a diff in pull request #190: [Improvement][AQE] Avoid calling getShuffleResult multiple times
leixm commented on code in PR #190:
URL: https://github.com/apache/incubator-uniffle/pull/190#discussion_r956734325
##########
proto/src/main/proto/Rss.proto:
##########
@@ -135,6 +136,13 @@ message GetShuffleResultRequest {
int32 partitionId = 3;
}
+message GetShuffleResultForMultiPartRequest {
+ string appId = 1;
+ int32 shuffleId = 2;
+ int32 startPartition = 3;
Review Comment:
RssShuffleManager#getReader partition is continuous, GetShuffleResult partition is discontinuous, but it will not cause wrong results, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org