You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@struts.apache.org by "Stephen Ince (JIRA)" <ji...@apache.org> on 2010/02/22 11:50:38 UTC

[jira] Created: (WW-3393) css_xhtml theme is broken for IE8 and does not work correctly in other browsers

css_xhtml theme is broken for IE8 and does not work correctly in other browsers
-------------------------------------------------------------------------------

                 Key: WW-3393
                 URL: https://issues.apache.org/jira/browse/WW-3393
             Project: Struts 2
          Issue Type: Bug
          Components: XML Validators
    Affects Versions: 2.1.8.1
         Environment: IE8
            Reporter: Stephen Ince


css_xhtml theme does not work in IE8 and does not work correctly in all other browsers. The function findWWCtrlNode in template/css_xhtlm/validation.js is written incorrectly. It was using a "var in" for loop syntax, peplaced with a for loop count syntax.

problem
struts/css_xhtml/validation.js: function findWWCtrlNode needed to be rewritten.

function findWWCtrlNode(enclosingDiv) {
   var elems = enclosingDiv.getElementsByTagName("div");
   for(i = 0; i < elems.length; ++i ) {
       if (elems[i].className && elems[i].className.match(/(wwlbl|wwctrl)/))
           return elems[i];
   }

   elems = enclosingDiv.getElementsByTagName("span");
   for(i = 0; i < elems.length; ++i ) {
       if (elems[i].className && elems[i].className.match(/(wwlbl|wwctrl)/))
           return elems[i];
   }
   return enclosingDiv.getElementsByTagName("span")[0];
}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (WW-3393) css_xhtml theme is broken for IE8 and does not work correctly in other browsers

Posted by "Lukasz Lenart (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WW-3393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lukasz Lenart reassigned WW-3393:
---------------------------------

    Assignee: Lukasz Lenart

> css_xhtml theme is broken for IE8 and does not work correctly in other browsers
> -------------------------------------------------------------------------------
>
>                 Key: WW-3393
>                 URL: https://issues.apache.org/jira/browse/WW-3393
>             Project: Struts 2
>          Issue Type: Bug
>          Components: XML Validators
>    Affects Versions: 2.1.8.1
>         Environment: IE8
>            Reporter: Stephen Ince
>            Assignee: Lukasz Lenart
>
> css_xhtml theme does not work in IE8 and does not work correctly in all other browsers. The function findWWCtrlNode in template/css_xhtlm/validation.js is written incorrectly. It was using a "var in" for loop syntax, peplaced with a for loop count syntax.
> problem
> struts/css_xhtml/validation.js: function findWWCtrlNode needed to be rewritten.
> function findWWCtrlNode(enclosingDiv) {
>    var elems = enclosingDiv.getElementsByTagName("div");
>    for(i = 0; i < elems.length; ++i ) {
>        if (elems[i].className && elems[i].className.match(/(wwlbl|wwctrl)/))
>            return elems[i];
>    }
>    elems = enclosingDiv.getElementsByTagName("span");
>    for(i = 0; i < elems.length; ++i ) {
>        if (elems[i].className && elems[i].className.match(/(wwlbl|wwctrl)/))
>            return elems[i];
>    }
>    return enclosingDiv.getElementsByTagName("span")[0];
> }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (WW-3393) css_xhtml theme is broken for IE8 and does not work correctly in other browsers

Posted by "Lukasz Lenart (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WW-3393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lukasz Lenart resolved WW-3393.
-------------------------------

       Resolution: Fixed
    Fix Version/s: 2.2.0

Patch applied, thanks! Revision 912543.

> css_xhtml theme is broken for IE8 and does not work correctly in other browsers
> -------------------------------------------------------------------------------
>
>                 Key: WW-3393
>                 URL: https://issues.apache.org/jira/browse/WW-3393
>             Project: Struts 2
>          Issue Type: Bug
>          Components: XML Validators
>    Affects Versions: 2.1.8.1
>         Environment: IE8
>            Reporter: Stephen Ince
>            Assignee: Lukasz Lenart
>             Fix For: 2.2.0
>
>
> css_xhtml theme does not work in IE8 and does not work correctly in all other browsers. The function findWWCtrlNode in template/css_xhtlm/validation.js is written incorrectly. It was using a "var in" for loop syntax, peplaced with a for loop count syntax.
> problem
> struts/css_xhtml/validation.js: function findWWCtrlNode needed to be rewritten.
> function findWWCtrlNode(enclosingDiv) {
>    var elems = enclosingDiv.getElementsByTagName("div");
>    for(i = 0; i < elems.length; ++i ) {
>        if (elems[i].className && elems[i].className.match(/(wwlbl|wwctrl)/))
>            return elems[i];
>    }
>    elems = enclosingDiv.getElementsByTagName("span");
>    for(i = 0; i < elems.length; ++i ) {
>        if (elems[i].className && elems[i].className.match(/(wwlbl|wwctrl)/))
>            return elems[i];
>    }
>    return enclosingDiv.getElementsByTagName("span")[0];
> }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WW-3393) css_xhtml theme is broken for IE8 and does not work correctly in other browsers

Posted by "Ramkumar (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WW-3393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12853902#action_12853902 ] 

Ramkumar commented on WW-3393:
------------------------------

Yes, Thanks. 

I applied the patch and it is working

> css_xhtml theme is broken for IE8 and does not work correctly in other browsers
> -------------------------------------------------------------------------------
>
>                 Key: WW-3393
>                 URL: https://issues.apache.org/jira/browse/WW-3393
>             Project: Struts 2
>          Issue Type: Bug
>          Components: XML Validators
>    Affects Versions: 2.1.8.1
>         Environment: IE8
>            Reporter: Stephen Ince
>            Assignee: Lukasz Lenart
>             Fix For: 2.2.0
>
>
> css_xhtml theme does not work in IE8 and does not work correctly in all other browsers. The function findWWCtrlNode in template/css_xhtlm/validation.js is written incorrectly. It was using a "var in" for loop syntax, peplaced with a for loop count syntax.
> problem
> struts/css_xhtml/validation.js: function findWWCtrlNode needed to be rewritten.
> function findWWCtrlNode(enclosingDiv) {
>    var elems = enclosingDiv.getElementsByTagName("div");
>    for(i = 0; i < elems.length; ++i ) {
>        if (elems[i].className && elems[i].className.match(/(wwlbl|wwctrl)/))
>            return elems[i];
>    }
>    elems = enclosingDiv.getElementsByTagName("span");
>    for(i = 0; i < elems.length; ++i ) {
>        if (elems[i].className && elems[i].className.match(/(wwlbl|wwctrl)/))
>            return elems[i];
>    }
>    return enclosingDiv.getElementsByTagName("span")[0];
> }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.