[GitHub] [incubator-iotdb] jt2594838 commented on a change in pull request #1051: [IOTDB-526] Support some metadata queries

[GitBox <gi...@apache.org>]

jt2594838 commented on a change in pull request #1051: [IOTDB-526] Support some metadata queries
URL: https://github.com/apache/incubator-iotdb/pull/1051#discussion_r408678882
 
 

 ##########
 File path: cluster/src/main/java/org/apache/iotdb/cluster/query/ClusterPlanExecutor.java
 ##########
 @@ -121,38 +124,41 @@ public QueryDataSet processQuery(PhysicalPlan queryPlan, QueryContext context)
         synchronized (response) {
           try {
             if (client != null) {
-              client.getNodeList(null, schemaPattern, level, handler);
+              client.getNodeList(node, schemaPattern, level, handler);
               response.wait(connectionTimeoutInMS);
             }
           } catch (TException e) {
             logger.error("Error occurs when getting node lists in node {}.", node, e);
 
 Review comment:
   It will be more robust if, for each group, you will try querying each node in the group until one result is returned. So that even if one node is down, you can still get the result from its replicas.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services