You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/10/23 08:31:32 UTC
[GitHub] [dubbo] kylixs commented on a change in pull request #9083: [3.0] Improve startup processing of api usage, auto start module
kylixs commented on a change in pull request #9083:
URL: https://github.com/apache/dubbo/pull/9083#discussion_r734942684
##########
File path: dubbo-common/src/main/java/org/apache/dubbo/config/AbstractInterfaceConfig.java
##########
@@ -268,7 +269,8 @@ public static void appendRuntimeParameters(Map<String, String> map) {
protected void appendMetricsCompatible(Map<String, String> map) {
MetricsConfig metricsConfig = getConfigManager().getMetrics().orElse(null);
if (metricsConfig != null) {
- if (!metricsConfig.getProtocol().equals(PROTOCOL_PROMETHEUS)) {
+ if (metricsConfig.getProtocol() != null && !StringUtils.isEquals(metricsConfig.getProtocol(), PROTOCOL_PROMETHEUS)) {
Review comment:
`metricsConfig.getProtocol()` may be null and should not add null value to parameter map
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org