You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Steve Loughran (Created) (JIRA)" <ji...@apache.org> on 2011/10/27 18:42:32 UTC
[jira] [Created] (HADOOP-7777) Implement a base class for
DNSToSwitchMapping implementations that can offer extra topology
information
Implement a base class for DNSToSwitchMapping implementations that can offer extra topology information
-------------------------------------------------------------------------------------------------------
Key: HADOOP-7777
URL: https://issues.apache.org/jira/browse/HADOOP-7777
Project: Hadoop Common
Issue Type: Improvement
Components: util
Affects Versions: 0.23.0
Reporter: Steve Loughran
Assignee: Steve Loughran
HDFS-2492 has identified a need for DNSToSwitchMapping implementations to provide a bit more topology information (e.g. whether or not there are multiple switches). This could be done by writing an extended interface, querying its methods if present and coming up with a default action if there is no extended interface.
Alternatively, we have a base class that all the standard mappings implement, with a boolean isMultiRack() method; all the standard subclasses would extend this, as could any third party topology provider. The advantage of this approach is that it is easier to add new operations without going into a multi-interface mess.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7777) Implement a base class for
DNSToSwitchMapping implementations that can offer extra topology
information
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13157562#comment-13157562 ]
Hudson commented on HADOOP-7777:
--------------------------------
Integrated in Hadoop-Hdfs-trunk-Commit #1396 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1396/])
HADOOP-7777 a base class for DNSToSwitchMapping implementations
stevel : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1206515
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/AbstractDNSToSwitchMapping.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/CachedDNSToSwitchMapping.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/DNSToSwitchMapping.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/ScriptBasedMapping.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/net/StaticMapping.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/net/TestScriptBasedMapping.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/net/TestStaticMapping.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/net/TestSwitchMapping.java
> Implement a base class for DNSToSwitchMapping implementations that can offer extra topology information
> -------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-7777
> URL: https://issues.apache.org/jira/browse/HADOOP-7777
> Project: Hadoop Common
> Issue Type: Improvement
> Components: util
> Affects Versions: 0.23.0, 0.24.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Attachments: HADOOP-7777-switch.patch, HADOOP-7777-switch.patch, HADOOP-7777-switch.patch, HADOOP-7777-switch.patch, HADOOP-7777-switch.patch
>
>
> HDFS-2492 has identified a need for DNSToSwitchMapping implementations to provide a bit more topology information (e.g. whether or not there are multiple switches). This could be done by writing an extended interface, querying its methods if present and coming up with a default action if there is no extended interface.
> Alternatively, we have a base class that all the standard mappings implement, with a boolean isMultiRack() method; all the standard subclasses would extend this, as could any third party topology provider. The advantage of this approach is that it is easier to add new operations without going into a multi-interface mess.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7777) Implement a base class for
DNSToSwitchMapping implementations that can offer extra topology
information
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13152237#comment-13152237 ]
Hadoop QA commented on HADOOP-7777:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12504090/HADOOP-7777-switch.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 10 new or modified tests.
-1 javadoc. The javadoc tool appears to have generated 17 warning messages.
-1 javac. The applied patch generated 1040 javac compiler warnings (more than the trunk's current 1039 warnings).
-1 findbugs. The patch appears to introduce 7 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed unit tests in .
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/381//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/381//artifact/trunk/hadoop-common-project/patchprocess/newPatchFindbugsWarningshadoop-common.html
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/381//console
This message is automatically generated.
> Implement a base class for DNSToSwitchMapping implementations that can offer extra topology information
> -------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-7777
> URL: https://issues.apache.org/jira/browse/HADOOP-7777
> Project: Hadoop Common
> Issue Type: Improvement
> Components: util
> Affects Versions: 0.23.0, 0.24.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Attachments: HADOOP-7777-switch.patch, HADOOP-7777-switch.patch, HADOOP-7777-switch.patch, HADOOP-7777-switch.patch
>
>
> HDFS-2492 has identified a need for DNSToSwitchMapping implementations to provide a bit more topology information (e.g. whether or not there are multiple switches). This could be done by writing an extended interface, querying its methods if present and coming up with a default action if there is no extended interface.
> Alternatively, we have a base class that all the standard mappings implement, with a boolean isMultiRack() method; all the standard subclasses would extend this, as could any third party topology provider. The advantage of this approach is that it is easier to add new operations without going into a multi-interface mess.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7777) Implement a base class for
DNSToSwitchMapping implementations that can offer extra topology
information
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13167530#comment-13167530 ]
Hudson commented on HADOOP-7777:
--------------------------------
Integrated in Hadoop-Common-0.23-Commit #270 (See [https://builds.apache.org/job/Hadoop-Common-0.23-Commit/270/])
HADOOP-7878 Regression: HADOOP-7777 switch changes break HDFS tests when the isSingleSwitch() predicate is used
stevel : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1213264
Files :
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/net/StaticMapping.java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/net/TestStaticMapping.java
> Implement a base class for DNSToSwitchMapping implementations that can offer extra topology information
> -------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-7777
> URL: https://issues.apache.org/jira/browse/HADOOP-7777
> Project: Hadoop Common
> Issue Type: Improvement
> Components: util
> Affects Versions: 0.23.0, 0.24.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Fix For: 0.24.0, 0.23.1
>
> Attachments: HADOOP-7777-switch.patch, HADOOP-7777-switch.patch, HADOOP-7777-switch.patch, HADOOP-7777-switch.patch, HADOOP-7777-switch.patch
>
>
> HDFS-2492 has identified a need for DNSToSwitchMapping implementations to provide a bit more topology information (e.g. whether or not there are multiple switches). This could be done by writing an extended interface, querying its methods if present and coming up with a default action if there is no extended interface.
> Alternatively, we have a base class that all the standard mappings implement, with a boolean isMultiRack() method; all the standard subclasses would extend this, as could any third party topology provider. The advantage of this approach is that it is easier to add new operations without going into a multi-interface mess.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7777) Implement a base class for
DNSToSwitchMapping implementations that can offer extra topology
information
Posted by "Steve Loughran (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Steve Loughran updated HADOOP-7777:
-----------------------------------
Attachment: HADOOP-7777-switch.patch
fixed javadoc and accidental import that was generating the javac warning
> Implement a base class for DNSToSwitchMapping implementations that can offer extra topology information
> -------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-7777
> URL: https://issues.apache.org/jira/browse/HADOOP-7777
> Project: Hadoop Common
> Issue Type: Improvement
> Components: util
> Affects Versions: 0.23.0, 0.24.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Attachments: HADOOP-7777-switch.patch, HADOOP-7777-switch.patch, HADOOP-7777-switch.patch, HADOOP-7777-switch.patch, HADOOP-7777-switch.patch
>
>
> HDFS-2492 has identified a need for DNSToSwitchMapping implementations to provide a bit more topology information (e.g. whether or not there are multiple switches). This could be done by writing an extended interface, querying its methods if present and coming up with a default action if there is no extended interface.
> Alternatively, we have a base class that all the standard mappings implement, with a boolean isMultiRack() method; all the standard subclasses would extend this, as could any third party topology provider. The advantage of this approach is that it is easier to add new operations without going into a multi-interface mess.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7777) Implement a base class for
DNSToSwitchMapping implementations that can offer extra topology
information
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13157571#comment-13157571 ]
Hudson commented on HADOOP-7777:
--------------------------------
Integrated in Hadoop-Mapreduce-trunk-Commit #1346 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1346/])
HADOOP-7777 a base class for DNSToSwitchMapping implementations
stevel : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1206515
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/AbstractDNSToSwitchMapping.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/CachedDNSToSwitchMapping.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/DNSToSwitchMapping.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/ScriptBasedMapping.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/net/StaticMapping.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/net/TestScriptBasedMapping.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/net/TestStaticMapping.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/net/TestSwitchMapping.java
> Implement a base class for DNSToSwitchMapping implementations that can offer extra topology information
> -------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-7777
> URL: https://issues.apache.org/jira/browse/HADOOP-7777
> Project: Hadoop Common
> Issue Type: Improvement
> Components: util
> Affects Versions: 0.23.0, 0.24.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Attachments: HADOOP-7777-switch.patch, HADOOP-7777-switch.patch, HADOOP-7777-switch.patch, HADOOP-7777-switch.patch, HADOOP-7777-switch.patch
>
>
> HDFS-2492 has identified a need for DNSToSwitchMapping implementations to provide a bit more topology information (e.g. whether or not there are multiple switches). This could be done by writing an extended interface, querying its methods if present and coming up with a default action if there is no extended interface.
> Alternatively, we have a base class that all the standard mappings implement, with a boolean isMultiRack() method; all the standard subclasses would extend this, as could any third party topology provider. The advantage of this approach is that it is easier to add new operations without going into a multi-interface mess.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7777) Implement a base class for
DNSToSwitchMapping implementations that can offer extra topology
information
Posted by "Steve Loughran (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Steve Loughran updated HADOOP-7777:
-----------------------------------
Target Version/s: 0.23.0, 0.24.0 (was: 0.24.0, 0.23.0)
Status: Patch Available (was: Open)
> Implement a base class for DNSToSwitchMapping implementations that can offer extra topology information
> -------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-7777
> URL: https://issues.apache.org/jira/browse/HADOOP-7777
> Project: Hadoop Common
> Issue Type: Improvement
> Components: util
> Affects Versions: 0.23.0, 0.24.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Attachments: HADOOP-7777-switch.patch, HADOOP-7777-switch.patch, HADOOP-7777-switch.patch, HADOOP-7777-switch.patch, HADOOP-7777-switch.patch
>
>
> HDFS-2492 has identified a need for DNSToSwitchMapping implementations to provide a bit more topology information (e.g. whether or not there are multiple switches). This could be done by writing an extended interface, querying its methods if present and coming up with a default action if there is no extended interface.
> Alternatively, we have a base class that all the standard mappings implement, with a boolean isMultiRack() method; all the standard subclasses would extend this, as could any third party topology provider. The advantage of this approach is that it is easier to add new operations without going into a multi-interface mess.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7777) Implement a base class for
DNSToSwitchMapping implementations that can offer extra topology
information
Posted by "Steve Loughran (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Steve Loughran updated HADOOP-7777:
-----------------------------------
Target Version/s: 0.23.0, 0.24.0 (was: 0.24.0, 0.23.0)
Status: Open (was: Patch Available)
> Implement a base class for DNSToSwitchMapping implementations that can offer extra topology information
> -------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-7777
> URL: https://issues.apache.org/jira/browse/HADOOP-7777
> Project: Hadoop Common
> Issue Type: Improvement
> Components: util
> Affects Versions: 0.23.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Attachments: HADOOP-7777-switch.patch, HADOOP-7777-switch.patch
>
>
> HDFS-2492 has identified a need for DNSToSwitchMapping implementations to provide a bit more topology information (e.g. whether or not there are multiple switches). This could be done by writing an extended interface, querying its methods if present and coming up with a default action if there is no extended interface.
> Alternatively, we have a base class that all the standard mappings implement, with a boolean isMultiRack() method; all the standard subclasses would extend this, as could any third party topology provider. The advantage of this approach is that it is easier to add new operations without going into a multi-interface mess.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7777) Implement a base class for
DNSToSwitchMapping implementations that can offer extra topology
information
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13158855#comment-13158855 ]
Hudson commented on HADOOP-7777:
--------------------------------
Integrated in Hadoop-Mapreduce-trunk-Commit #1356 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1356/])
Apply HADOOP-7777 to 0.23.1
stevel : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1207629
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
> Implement a base class for DNSToSwitchMapping implementations that can offer extra topology information
> -------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-7777
> URL: https://issues.apache.org/jira/browse/HADOOP-7777
> Project: Hadoop Common
> Issue Type: Improvement
> Components: util
> Affects Versions: 0.23.0, 0.24.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Fix For: 0.24.0, 0.23.1
>
> Attachments: HADOOP-7777-switch.patch, HADOOP-7777-switch.patch, HADOOP-7777-switch.patch, HADOOP-7777-switch.patch, HADOOP-7777-switch.patch
>
>
> HDFS-2492 has identified a need for DNSToSwitchMapping implementations to provide a bit more topology information (e.g. whether or not there are multiple switches). This could be done by writing an extended interface, querying its methods if present and coming up with a default action if there is no extended interface.
> Alternatively, we have a base class that all the standard mappings implement, with a boolean isMultiRack() method; all the standard subclasses would extend this, as could any third party topology provider. The advantage of this approach is that it is easier to add new operations without going into a multi-interface mess.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7777) Implement a base class for
DNSToSwitchMapping implementations that can offer extra topology
information
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13159234#comment-13159234 ]
Hudson commented on HADOOP-7777:
--------------------------------
Integrated in Hadoop-Hdfs-trunk #879 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/879/])
Apply HADOOP-7777 to 0.23.1
stevel : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1207629
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
> Implement a base class for DNSToSwitchMapping implementations that can offer extra topology information
> -------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-7777
> URL: https://issues.apache.org/jira/browse/HADOOP-7777
> Project: Hadoop Common
> Issue Type: Improvement
> Components: util
> Affects Versions: 0.23.0, 0.24.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Fix For: 0.24.0, 0.23.1
>
> Attachments: HADOOP-7777-switch.patch, HADOOP-7777-switch.patch, HADOOP-7777-switch.patch, HADOOP-7777-switch.patch, HADOOP-7777-switch.patch
>
>
> HDFS-2492 has identified a need for DNSToSwitchMapping implementations to provide a bit more topology information (e.g. whether or not there are multiple switches). This could be done by writing an extended interface, querying its methods if present and coming up with a default action if there is no extended interface.
> Alternatively, we have a base class that all the standard mappings implement, with a boolean isMultiRack() method; all the standard subclasses would extend this, as could any third party topology provider. The advantage of this approach is that it is easier to add new operations without going into a multi-interface mess.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7777) Implement a base class for
DNSToSwitchMapping implementations that can offer extra topology
information
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13167535#comment-13167535 ]
Hudson commented on HADOOP-7777:
--------------------------------
Integrated in Hadoop-Common-trunk-Commit #1400 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1400/])
HADOOP-7878 Regression: HADOOP-7777 switch changes break HDFS tests when the isSingleSwitch() predicate is used
stevel : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1213263
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/net/StaticMapping.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/net/TestStaticMapping.java
> Implement a base class for DNSToSwitchMapping implementations that can offer extra topology information
> -------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-7777
> URL: https://issues.apache.org/jira/browse/HADOOP-7777
> Project: Hadoop Common
> Issue Type: Improvement
> Components: util
> Affects Versions: 0.23.0, 0.24.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Fix For: 0.24.0, 0.23.1
>
> Attachments: HADOOP-7777-switch.patch, HADOOP-7777-switch.patch, HADOOP-7777-switch.patch, HADOOP-7777-switch.patch, HADOOP-7777-switch.patch
>
>
> HDFS-2492 has identified a need for DNSToSwitchMapping implementations to provide a bit more topology information (e.g. whether or not there are multiple switches). This could be done by writing an extended interface, querying its methods if present and coming up with a default action if there is no extended interface.
> Alternatively, we have a base class that all the standard mappings implement, with a boolean isMultiRack() method; all the standard subclasses would extend this, as could any third party topology provider. The advantage of this approach is that it is easier to add new operations without going into a multi-interface mess.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7777) Implement a base class for
DNSToSwitchMapping implementations that can offer extra topology
information
Posted by "Steve Loughran (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13157563#comment-13157563 ]
Steve Loughran commented on HADOOP-7777:
----------------------------------------
added to trunk; backporting to 0.23.1, where there are some patch issues
> Implement a base class for DNSToSwitchMapping implementations that can offer extra topology information
> -------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-7777
> URL: https://issues.apache.org/jira/browse/HADOOP-7777
> Project: Hadoop Common
> Issue Type: Improvement
> Components: util
> Affects Versions: 0.23.0, 0.24.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Attachments: HADOOP-7777-switch.patch, HADOOP-7777-switch.patch, HADOOP-7777-switch.patch, HADOOP-7777-switch.patch, HADOOP-7777-switch.patch
>
>
> HDFS-2492 has identified a need for DNSToSwitchMapping implementations to provide a bit more topology information (e.g. whether or not there are multiple switches). This could be done by writing an extended interface, querying its methods if present and coming up with a default action if there is no extended interface.
> Alternatively, we have a base class that all the standard mappings implement, with a boolean isMultiRack() method; all the standard subclasses would extend this, as could any third party topology provider. The advantage of this approach is that it is easier to add new operations without going into a multi-interface mess.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7777) Implement a base class for
DNSToSwitchMapping implementations that can offer extra topology
information
Posted by "Steve Loughran (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13157561#comment-13157561 ]
Steve Loughran commented on HADOOP-7777:
----------------------------------------
+1 applying
> Implement a base class for DNSToSwitchMapping implementations that can offer extra topology information
> -------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-7777
> URL: https://issues.apache.org/jira/browse/HADOOP-7777
> Project: Hadoop Common
> Issue Type: Improvement
> Components: util
> Affects Versions: 0.23.0, 0.24.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Attachments: HADOOP-7777-switch.patch, HADOOP-7777-switch.patch, HADOOP-7777-switch.patch, HADOOP-7777-switch.patch, HADOOP-7777-switch.patch
>
>
> HDFS-2492 has identified a need for DNSToSwitchMapping implementations to provide a bit more topology information (e.g. whether or not there are multiple switches). This could be done by writing an extended interface, querying its methods if present and coming up with a default action if there is no extended interface.
> Alternatively, we have a base class that all the standard mappings implement, with a boolean isMultiRack() method; all the standard subclasses would extend this, as could any third party topology provider. The advantage of this approach is that it is easier to add new operations without going into a multi-interface mess.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7777) Implement a base class for
DNSToSwitchMapping implementations that can offer extra topology
information
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13153547#comment-13153547 ]
Hadoop QA commented on HADOOP-7777:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12504251/HADOOP-7777-switch.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 10 new or modified tests.
-1 javadoc. The javadoc tool appears to have generated 15 warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 7 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed unit tests in .
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/387//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/387//artifact/trunk/hadoop-common-project/patchprocess/newPatchFindbugsWarningshadoop-common.html
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/387//console
This message is automatically generated.
> Implement a base class for DNSToSwitchMapping implementations that can offer extra topology information
> -------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-7777
> URL: https://issues.apache.org/jira/browse/HADOOP-7777
> Project: Hadoop Common
> Issue Type: Improvement
> Components: util
> Affects Versions: 0.23.0, 0.24.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Attachments: HADOOP-7777-switch.patch, HADOOP-7777-switch.patch, HADOOP-7777-switch.patch, HADOOP-7777-switch.patch, HADOOP-7777-switch.patch
>
>
> HDFS-2492 has identified a need for DNSToSwitchMapping implementations to provide a bit more topology information (e.g. whether or not there are multiple switches). This could be done by writing an extended interface, querying its methods if present and coming up with a default action if there is no extended interface.
> Alternatively, we have a base class that all the standard mappings implement, with a boolean isMultiRack() method; all the standard subclasses would extend this, as could any third party topology provider. The advantage of this approach is that it is easier to add new operations without going into a multi-interface mess.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7777) Implement a base class for
DNSToSwitchMapping implementations that can offer extra topology
information
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13168359#comment-13168359 ]
Hudson commented on HADOOP-7777:
--------------------------------
Integrated in Hadoop-Mapreduce-0.23-Build #124 (See [https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/124/])
HADOOP-7878 Regression: HADOOP-7777 switch changes break HDFS tests when the isSingleSwitch() predicate is used
stevel : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1213264
Files :
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/net/StaticMapping.java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/net/TestStaticMapping.java
> Implement a base class for DNSToSwitchMapping implementations that can offer extra topology information
> -------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-7777
> URL: https://issues.apache.org/jira/browse/HADOOP-7777
> Project: Hadoop Common
> Issue Type: Improvement
> Components: util
> Affects Versions: 0.23.0, 0.24.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Fix For: 0.24.0, 0.23.1
>
> Attachments: HADOOP-7777-switch.patch, HADOOP-7777-switch.patch, HADOOP-7777-switch.patch, HADOOP-7777-switch.patch, HADOOP-7777-switch.patch
>
>
> HDFS-2492 has identified a need for DNSToSwitchMapping implementations to provide a bit more topology information (e.g. whether or not there are multiple switches). This could be done by writing an extended interface, querying its methods if present and coming up with a default action if there is no extended interface.
> Alternatively, we have a base class that all the standard mappings implement, with a boolean isMultiRack() method; all the standard subclasses would extend this, as could any third party topology provider. The advantage of this approach is that it is easier to add new operations without going into a multi-interface mess.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7777) Implement a base class for
DNSToSwitchMapping implementations that can offer extra topology
information
Posted by "Steve Loughran (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Steve Loughran updated HADOOP-7777:
-----------------------------------
Target Version/s: 0.23.0, 0.24.0 (was: 0.24.0, 0.23.0)
Status: Patch Available (was: Open)
resubmitting now the findbugs patch HADOOP-7778 went in
> Implement a base class for DNSToSwitchMapping implementations that can offer extra topology information
> -------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-7777
> URL: https://issues.apache.org/jira/browse/HADOOP-7777
> Project: Hadoop Common
> Issue Type: Improvement
> Components: util
> Affects Versions: 0.23.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Attachments: HADOOP-7777-switch.patch, HADOOP-7777-switch.patch
>
>
> HDFS-2492 has identified a need for DNSToSwitchMapping implementations to provide a bit more topology information (e.g. whether or not there are multiple switches). This could be done by writing an extended interface, querying its methods if present and coming up with a default action if there is no extended interface.
> Alternatively, we have a base class that all the standard mappings implement, with a boolean isMultiRack() method; all the standard subclasses would extend this, as could any third party topology provider. The advantage of this approach is that it is easier to add new operations without going into a multi-interface mess.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7777) Implement a base class for
DNSToSwitchMapping implementations that can offer extra topology
information
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13159243#comment-13159243 ]
Hudson commented on HADOOP-7777:
--------------------------------
Integrated in Hadoop-Mapreduce-0.23-Build #108 (See [https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/108/])
Apply HADOOP-7777 to 0.23.1
stevel : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1207628
Files :
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/AbstractDNSToSwitchMapping.java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/CachedDNSToSwitchMapping.java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/DNSToSwitchMapping.java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/ScriptBasedMapping.java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/net/StaticMapping.java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/net/TestScriptBasedMapping.java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/net/TestStaticMapping.java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/net/TestSwitchMapping.java
> Implement a base class for DNSToSwitchMapping implementations that can offer extra topology information
> -------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-7777
> URL: https://issues.apache.org/jira/browse/HADOOP-7777
> Project: Hadoop Common
> Issue Type: Improvement
> Components: util
> Affects Versions: 0.23.0, 0.24.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Fix For: 0.24.0, 0.23.1
>
> Attachments: HADOOP-7777-switch.patch, HADOOP-7777-switch.patch, HADOOP-7777-switch.patch, HADOOP-7777-switch.patch, HADOOP-7777-switch.patch
>
>
> HDFS-2492 has identified a need for DNSToSwitchMapping implementations to provide a bit more topology information (e.g. whether or not there are multiple switches). This could be done by writing an extended interface, querying its methods if present and coming up with a default action if there is no extended interface.
> Alternatively, we have a base class that all the standard mappings implement, with a boolean isMultiRack() method; all the standard subclasses would extend this, as could any third party topology provider. The advantage of this approach is that it is easier to add new operations without going into a multi-interface mess.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7777) Implement a base class for
DNSToSwitchMapping implementations that can offer extra topology
information
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13158822#comment-13158822 ]
Hudson commented on HADOOP-7777:
--------------------------------
Integrated in Hadoop-Common-0.23-Commit #223 (See [https://builds.apache.org/job/Hadoop-Common-0.23-Commit/223/])
Apply HADOOP-7777 to 0.23.1
stevel : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1207628
Files :
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/AbstractDNSToSwitchMapping.java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/CachedDNSToSwitchMapping.java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/DNSToSwitchMapping.java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/ScriptBasedMapping.java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/net/StaticMapping.java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/net/TestScriptBasedMapping.java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/net/TestStaticMapping.java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/net/TestSwitchMapping.java
> Implement a base class for DNSToSwitchMapping implementations that can offer extra topology information
> -------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-7777
> URL: https://issues.apache.org/jira/browse/HADOOP-7777
> Project: Hadoop Common
> Issue Type: Improvement
> Components: util
> Affects Versions: 0.23.0, 0.24.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Fix For: 0.24.0, 0.23.1
>
> Attachments: HADOOP-7777-switch.patch, HADOOP-7777-switch.patch, HADOOP-7777-switch.patch, HADOOP-7777-switch.patch, HADOOP-7777-switch.patch
>
>
> HDFS-2492 has identified a need for DNSToSwitchMapping implementations to provide a bit more topology information (e.g. whether or not there are multiple switches). This could be done by writing an extended interface, querying its methods if present and coming up with a default action if there is no extended interface.
> Alternatively, we have a base class that all the standard mappings implement, with a boolean isMultiRack() method; all the standard subclasses would extend this, as could any third party topology provider. The advantage of this approach is that it is easier to add new operations without going into a multi-interface mess.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7777) Implement a base class for
DNSToSwitchMapping implementations that can offer extra topology
information
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13168431#comment-13168431 ]
Hudson commented on HADOOP-7777:
--------------------------------
Integrated in Hadoop-Hdfs-trunk #893 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/893/])
HADOOP-7878 Regression: HADOOP-7777 switch changes break HDFS tests when the isSingleSwitch() predicate is used
stevel : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1213263
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/net/StaticMapping.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/net/TestStaticMapping.java
> Implement a base class for DNSToSwitchMapping implementations that can offer extra topology information
> -------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-7777
> URL: https://issues.apache.org/jira/browse/HADOOP-7777
> Project: Hadoop Common
> Issue Type: Improvement
> Components: util
> Affects Versions: 0.23.0, 0.24.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Fix For: 0.24.0, 0.23.1
>
> Attachments: HADOOP-7777-switch.patch, HADOOP-7777-switch.patch, HADOOP-7777-switch.patch, HADOOP-7777-switch.patch, HADOOP-7777-switch.patch
>
>
> HDFS-2492 has identified a need for DNSToSwitchMapping implementations to provide a bit more topology information (e.g. whether or not there are multiple switches). This could be done by writing an extended interface, querying its methods if present and coming up with a default action if there is no extended interface.
> Alternatively, we have a base class that all the standard mappings implement, with a boolean isMultiRack() method; all the standard subclasses would extend this, as could any third party topology provider. The advantage of this approach is that it is easier to add new operations without going into a multi-interface mess.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7777) Implement a base class for
DNSToSwitchMapping implementations that can offer extra topology
information
Posted by "Steve Loughran (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Steve Loughran updated HADOOP-7777:
-----------------------------------
Target Version/s: 0.23.0, 0.24.0 (was: 0.24.0, 0.23.0)
Affects Version/s: 0.24.0
Status: Patch Available (was: Open)
> Implement a base class for DNSToSwitchMapping implementations that can offer extra topology information
> -------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-7777
> URL: https://issues.apache.org/jira/browse/HADOOP-7777
> Project: Hadoop Common
> Issue Type: Improvement
> Components: util
> Affects Versions: 0.23.0, 0.24.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Attachments: HADOOP-7777-switch.patch, HADOOP-7777-switch.patch, HADOOP-7777-switch.patch
>
>
> HDFS-2492 has identified a need for DNSToSwitchMapping implementations to provide a bit more topology information (e.g. whether or not there are multiple switches). This could be done by writing an extended interface, querying its methods if present and coming up with a default action if there is no extended interface.
> Alternatively, we have a base class that all the standard mappings implement, with a boolean isMultiRack() method; all the standard subclasses would extend this, as could any third party topology provider. The advantage of this approach is that it is easier to add new operations without going into a multi-interface mess.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7777) Implement a base class for
DNSToSwitchMapping implementations that can offer extra topology
information
Posted by "Steve Loughran (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Steve Loughran updated HADOOP-7777:
-----------------------------------
Attachment: HADOOP-7777-switch.patch
Quick code review before resubmitting patch
# Removed {{extends Configurable}} on mapper classes whose base class does this already.
# Synchronized the {{isSingleSwitch()}} method in the {{StaticMapping}} class to ensure its return value is always current.
> Implement a base class for DNSToSwitchMapping implementations that can offer extra topology information
> -------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-7777
> URL: https://issues.apache.org/jira/browse/HADOOP-7777
> Project: Hadoop Common
> Issue Type: Improvement
> Components: util
> Affects Versions: 0.23.0, 0.24.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Attachments: HADOOP-7777-switch.patch, HADOOP-7777-switch.patch, HADOOP-7777-switch.patch
>
>
> HDFS-2492 has identified a need for DNSToSwitchMapping implementations to provide a bit more topology information (e.g. whether or not there are multiple switches). This could be done by writing an extended interface, querying its methods if present and coming up with a default action if there is no extended interface.
> Alternatively, we have a base class that all the standard mappings implement, with a boolean isMultiRack() method; all the standard subclasses would extend this, as could any third party topology provider. The advantage of this approach is that it is easier to add new operations without going into a multi-interface mess.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7777) Implement a base class for
DNSToSwitchMapping implementations that can offer extra topology
information
Posted by "Steve Loughran (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Steve Loughran updated HADOOP-7777:
-----------------------------------
Attachment: HADOOP-7777-switch.patch
> Implement a base class for DNSToSwitchMapping implementations that can offer extra topology information
> -------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-7777
> URL: https://issues.apache.org/jira/browse/HADOOP-7777
> Project: Hadoop Common
> Issue Type: Improvement
> Components: util
> Affects Versions: 0.23.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Attachments: HADOOP-7777-switch.patch
>
>
> HDFS-2492 has identified a need for DNSToSwitchMapping implementations to provide a bit more topology information (e.g. whether or not there are multiple switches). This could be done by writing an extended interface, querying its methods if present and coming up with a default action if there is no extended interface.
> Alternatively, we have a base class that all the standard mappings implement, with a boolean isMultiRack() method; all the standard subclasses would extend this, as could any third party topology provider. The advantage of this approach is that it is easier to add new operations without going into a multi-interface mess.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7777) Implement a base class for
DNSToSwitchMapping implementations that can offer extra topology
information
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13157900#comment-13157900 ]
Hudson commented on HADOOP-7777:
--------------------------------
Integrated in Hadoop-Mapreduce-trunk #910 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/910/])
HADOOP-7777 changes.txt
HADOOP-7777 a base class for DNSToSwitchMapping implementations
stevel : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1206520
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
stevel : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1206515
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/AbstractDNSToSwitchMapping.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/CachedDNSToSwitchMapping.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/DNSToSwitchMapping.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/ScriptBasedMapping.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/net/StaticMapping.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/net/TestScriptBasedMapping.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/net/TestStaticMapping.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/net/TestSwitchMapping.java
> Implement a base class for DNSToSwitchMapping implementations that can offer extra topology information
> -------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-7777
> URL: https://issues.apache.org/jira/browse/HADOOP-7777
> Project: Hadoop Common
> Issue Type: Improvement
> Components: util
> Affects Versions: 0.23.0, 0.24.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Attachments: HADOOP-7777-switch.patch, HADOOP-7777-switch.patch, HADOOP-7777-switch.patch, HADOOP-7777-switch.patch, HADOOP-7777-switch.patch
>
>
> HDFS-2492 has identified a need for DNSToSwitchMapping implementations to provide a bit more topology information (e.g. whether or not there are multiple switches). This could be done by writing an extended interface, querying its methods if present and coming up with a default action if there is no extended interface.
> Alternatively, we have a base class that all the standard mappings implement, with a boolean isMultiRack() method; all the standard subclasses would extend this, as could any third party topology provider. The advantage of this approach is that it is easier to add new operations without going into a multi-interface mess.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7777) Implement a base class for
DNSToSwitchMapping implementations that can offer extra topology
information
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13158820#comment-13158820 ]
Hudson commented on HADOOP-7777:
--------------------------------
Integrated in Hadoop-Hdfs-trunk-Commit #1406 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1406/])
Apply HADOOP-7777 to 0.23.1
stevel : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1207629
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
> Implement a base class for DNSToSwitchMapping implementations that can offer extra topology information
> -------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-7777
> URL: https://issues.apache.org/jira/browse/HADOOP-7777
> Project: Hadoop Common
> Issue Type: Improvement
> Components: util
> Affects Versions: 0.23.0, 0.24.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Fix For: 0.24.0, 0.23.1
>
> Attachments: HADOOP-7777-switch.patch, HADOOP-7777-switch.patch, HADOOP-7777-switch.patch, HADOOP-7777-switch.patch, HADOOP-7777-switch.patch
>
>
> HDFS-2492 has identified a need for DNSToSwitchMapping implementations to provide a bit more topology information (e.g. whether or not there are multiple switches). This could be done by writing an extended interface, querying its methods if present and coming up with a default action if there is no extended interface.
> Alternatively, we have a base class that all the standard mappings implement, with a boolean isMultiRack() method; all the standard subclasses would extend this, as could any third party topology provider. The advantage of this approach is that it is easier to add new operations without going into a multi-interface mess.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7777) Implement a base class for
DNSToSwitchMapping implementations that can offer extra topology
information
Posted by "Steve Loughran (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13153834#comment-13153834 ]
Steve Loughran commented on HADOOP-7777:
----------------------------------------
all the findbugs warnings are false alarms from protobuf-generated code, so unless anyone vetoes this, I am +1 for putting it into trunk and 0.23 as a precursor to fixing HDFS-2492
> Implement a base class for DNSToSwitchMapping implementations that can offer extra topology information
> -------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-7777
> URL: https://issues.apache.org/jira/browse/HADOOP-7777
> Project: Hadoop Common
> Issue Type: Improvement
> Components: util
> Affects Versions: 0.23.0, 0.24.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Attachments: HADOOP-7777-switch.patch, HADOOP-7777-switch.patch, HADOOP-7777-switch.patch, HADOOP-7777-switch.patch, HADOOP-7777-switch.patch
>
>
> HDFS-2492 has identified a need for DNSToSwitchMapping implementations to provide a bit more topology information (e.g. whether or not there are multiple switches). This could be done by writing an extended interface, querying its methods if present and coming up with a default action if there is no extended interface.
> Alternatively, we have a base class that all the standard mappings implement, with a boolean isMultiRack() method; all the standard subclasses would extend this, as could any third party topology provider. The advantage of this approach is that it is easier to add new operations without going into a multi-interface mess.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7777) Implement a base class for
DNSToSwitchMapping implementations that can offer extra topology
information
Posted by "Steve Loughran (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Steve Loughran updated HADOOP-7777:
-----------------------------------
Target Version/s: 0.23.0, 0.24.0 (was: 0.24.0, 0.23.0)
Status: Patch Available (was: Open)
> Implement a base class for DNSToSwitchMapping implementations that can offer extra topology information
> -------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-7777
> URL: https://issues.apache.org/jira/browse/HADOOP-7777
> Project: Hadoop Common
> Issue Type: Improvement
> Components: util
> Affects Versions: 0.23.0, 0.24.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Attachments: HADOOP-7777-switch.patch, HADOOP-7777-switch.patch, HADOOP-7777-switch.patch, HADOOP-7777-switch.patch
>
>
> HDFS-2492 has identified a need for DNSToSwitchMapping implementations to provide a bit more topology information (e.g. whether or not there are multiple switches). This could be done by writing an extended interface, querying its methods if present and coming up with a default action if there is no extended interface.
> Alternatively, we have a base class that all the standard mappings implement, with a boolean isMultiRack() method; all the standard subclasses would extend this, as could any third party topology provider. The advantage of this approach is that it is easier to add new operations without going into a multi-interface mess.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7777) Implement a base class for
DNSToSwitchMapping implementations that can offer extra topology
information
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13159262#comment-13159262 ]
Hudson commented on HADOOP-7777:
--------------------------------
Integrated in Hadoop-Mapreduce-trunk #912 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/912/])
Apply HADOOP-7777 to 0.23.1
stevel : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1207629
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
> Implement a base class for DNSToSwitchMapping implementations that can offer extra topology information
> -------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-7777
> URL: https://issues.apache.org/jira/browse/HADOOP-7777
> Project: Hadoop Common
> Issue Type: Improvement
> Components: util
> Affects Versions: 0.23.0, 0.24.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Fix For: 0.24.0, 0.23.1
>
> Attachments: HADOOP-7777-switch.patch, HADOOP-7777-switch.patch, HADOOP-7777-switch.patch, HADOOP-7777-switch.patch, HADOOP-7777-switch.patch
>
>
> HDFS-2492 has identified a need for DNSToSwitchMapping implementations to provide a bit more topology information (e.g. whether or not there are multiple switches). This could be done by writing an extended interface, querying its methods if present and coming up with a default action if there is no extended interface.
> Alternatively, we have a base class that all the standard mappings implement, with a boolean isMultiRack() method; all the standard subclasses would extend this, as could any third party topology provider. The advantage of this approach is that it is easier to add new operations without going into a multi-interface mess.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7777) Implement a base class for
DNSToSwitchMapping implementations that can offer extra topology
information
Posted by "Steve Loughran (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13139189#comment-13139189 ]
Steve Loughran commented on HADOOP-7777:
----------------------------------------
-I'll see if I can track down the warning.
-Note that this patch won't be ready to commit until I've got HDFS-2492 happy with it, which means some way of bridging the NN-instantiated mapper to the BlockManager. You can't ask the network topology about its rack count as that will change as it resolves more addresses.
> Implement a base class for DNSToSwitchMapping implementations that can offer extra topology information
> -------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-7777
> URL: https://issues.apache.org/jira/browse/HADOOP-7777
> Project: Hadoop Common
> Issue Type: Improvement
> Components: util
> Affects Versions: 0.23.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Attachments: HADOOP-7777-switch.patch, HADOOP-7777-switch.patch
>
>
> HDFS-2492 has identified a need for DNSToSwitchMapping implementations to provide a bit more topology information (e.g. whether or not there are multiple switches). This could be done by writing an extended interface, querying its methods if present and coming up with a default action if there is no extended interface.
> Alternatively, we have a base class that all the standard mappings implement, with a boolean isMultiRack() method; all the standard subclasses would extend this, as could any third party topology provider. The advantage of this approach is that it is easier to add new operations without going into a multi-interface mess.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7777) Implement a base class for
DNSToSwitchMapping implementations that can offer extra topology
information
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13157895#comment-13157895 ]
Hudson commented on HADOOP-7777:
--------------------------------
Integrated in Hadoop-Hdfs-trunk #876 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/876/])
HADOOP-7777 changes.txt
HADOOP-7777 a base class for DNSToSwitchMapping implementations
stevel : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1206520
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
stevel : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1206515
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/AbstractDNSToSwitchMapping.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/CachedDNSToSwitchMapping.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/DNSToSwitchMapping.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/ScriptBasedMapping.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/net/StaticMapping.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/net/TestScriptBasedMapping.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/net/TestStaticMapping.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/net/TestSwitchMapping.java
> Implement a base class for DNSToSwitchMapping implementations that can offer extra topology information
> -------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-7777
> URL: https://issues.apache.org/jira/browse/HADOOP-7777
> Project: Hadoop Common
> Issue Type: Improvement
> Components: util
> Affects Versions: 0.23.0, 0.24.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Attachments: HADOOP-7777-switch.patch, HADOOP-7777-switch.patch, HADOOP-7777-switch.patch, HADOOP-7777-switch.patch, HADOOP-7777-switch.patch
>
>
> HDFS-2492 has identified a need for DNSToSwitchMapping implementations to provide a bit more topology information (e.g. whether or not there are multiple switches). This could be done by writing an extended interface, querying its methods if present and coming up with a default action if there is no extended interface.
> Alternatively, we have a base class that all the standard mappings implement, with a boolean isMultiRack() method; all the standard subclasses would extend this, as could any third party topology provider. The advantage of this approach is that it is easier to add new operations without going into a multi-interface mess.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7777) Implement a base class for
DNSToSwitchMapping implementations that can offer extra topology
information
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13167528#comment-13167528 ]
Hudson commented on HADOOP-7777:
--------------------------------
Integrated in Hadoop-Hdfs-trunk-Commit #1474 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1474/])
HADOOP-7878 Regression: HADOOP-7777 switch changes break HDFS tests when the isSingleSwitch() predicate is used
stevel : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1213263
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/net/StaticMapping.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/net/TestStaticMapping.java
> Implement a base class for DNSToSwitchMapping implementations that can offer extra topology information
> -------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-7777
> URL: https://issues.apache.org/jira/browse/HADOOP-7777
> Project: Hadoop Common
> Issue Type: Improvement
> Components: util
> Affects Versions: 0.23.0, 0.24.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Fix For: 0.24.0, 0.23.1
>
> Attachments: HADOOP-7777-switch.patch, HADOOP-7777-switch.patch, HADOOP-7777-switch.patch, HADOOP-7777-switch.patch, HADOOP-7777-switch.patch
>
>
> HDFS-2492 has identified a need for DNSToSwitchMapping implementations to provide a bit more topology information (e.g. whether or not there are multiple switches). This could be done by writing an extended interface, querying its methods if present and coming up with a default action if there is no extended interface.
> Alternatively, we have a base class that all the standard mappings implement, with a boolean isMultiRack() method; all the standard subclasses would extend this, as could any third party topology provider. The advantage of this approach is that it is easier to add new operations without going into a multi-interface mess.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7777) Implement a base class for
DNSToSwitchMapping implementations that can offer extra topology
information
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13138659#comment-13138659 ]
Hadoop QA commented on HADOOP-7777:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12501341/HADOOP-7777-switch.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 10 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
-1 javac. The applied patch generated 1041 javac compiler warnings (more than the trunk's current 1040 warnings).
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed unit tests in .
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/338//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/338//console
This message is automatically generated.
> Implement a base class for DNSToSwitchMapping implementations that can offer extra topology information
> -------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-7777
> URL: https://issues.apache.org/jira/browse/HADOOP-7777
> Project: Hadoop Common
> Issue Type: Improvement
> Components: util
> Affects Versions: 0.23.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Attachments: HADOOP-7777-switch.patch, HADOOP-7777-switch.patch
>
>
> HDFS-2492 has identified a need for DNSToSwitchMapping implementations to provide a bit more topology information (e.g. whether or not there are multiple switches). This could be done by writing an extended interface, querying its methods if present and coming up with a default action if there is no extended interface.
> Alternatively, we have a base class that all the standard mappings implement, with a boolean isMultiRack() method; all the standard subclasses would extend this, as could any third party topology provider. The advantage of this approach is that it is easier to add new operations without going into a multi-interface mess.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7777) Implement a base class for
DNSToSwitchMapping implementations that can offer extra topology
information
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13158829#comment-13158829 ]
Hudson commented on HADOOP-7777:
--------------------------------
Integrated in Hadoop-Mapreduce-0.23-Commit #234 (See [https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/234/])
Apply HADOOP-7777 to 0.23.1
stevel : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1207628
Files :
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/AbstractDNSToSwitchMapping.java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/CachedDNSToSwitchMapping.java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/DNSToSwitchMapping.java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/ScriptBasedMapping.java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/net/StaticMapping.java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/net/TestScriptBasedMapping.java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/net/TestStaticMapping.java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/net/TestSwitchMapping.java
> Implement a base class for DNSToSwitchMapping implementations that can offer extra topology information
> -------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-7777
> URL: https://issues.apache.org/jira/browse/HADOOP-7777
> Project: Hadoop Common
> Issue Type: Improvement
> Components: util
> Affects Versions: 0.23.0, 0.24.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Fix For: 0.24.0, 0.23.1
>
> Attachments: HADOOP-7777-switch.patch, HADOOP-7777-switch.patch, HADOOP-7777-switch.patch, HADOOP-7777-switch.patch, HADOOP-7777-switch.patch
>
>
> HDFS-2492 has identified a need for DNSToSwitchMapping implementations to provide a bit more topology information (e.g. whether or not there are multiple switches). This could be done by writing an extended interface, querying its methods if present and coming up with a default action if there is no extended interface.
> Alternatively, we have a base class that all the standard mappings implement, with a boolean isMultiRack() method; all the standard subclasses would extend this, as could any third party topology provider. The advantage of this approach is that it is easier to add new operations without going into a multi-interface mess.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7777) Implement a base class for
DNSToSwitchMapping implementations that can offer extra topology
information
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13159223#comment-13159223 ]
Hudson commented on HADOOP-7777:
--------------------------------
Integrated in Hadoop-Hdfs-0.23-Build #92 (See [https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/92/])
Apply HADOOP-7777 to 0.23.1
stevel : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1207628
Files :
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/AbstractDNSToSwitchMapping.java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/CachedDNSToSwitchMapping.java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/DNSToSwitchMapping.java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/ScriptBasedMapping.java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/net/StaticMapping.java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/net/TestScriptBasedMapping.java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/net/TestStaticMapping.java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/net/TestSwitchMapping.java
> Implement a base class for DNSToSwitchMapping implementations that can offer extra topology information
> -------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-7777
> URL: https://issues.apache.org/jira/browse/HADOOP-7777
> Project: Hadoop Common
> Issue Type: Improvement
> Components: util
> Affects Versions: 0.23.0, 0.24.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Fix For: 0.24.0, 0.23.1
>
> Attachments: HADOOP-7777-switch.patch, HADOOP-7777-switch.patch, HADOOP-7777-switch.patch, HADOOP-7777-switch.patch, HADOOP-7777-switch.patch
>
>
> HDFS-2492 has identified a need for DNSToSwitchMapping implementations to provide a bit more topology information (e.g. whether or not there are multiple switches). This could be done by writing an extended interface, querying its methods if present and coming up with a default action if there is no extended interface.
> Alternatively, we have a base class that all the standard mappings implement, with a boolean isMultiRack() method; all the standard subclasses would extend this, as could any third party topology provider. The advantage of this approach is that it is easier to add new operations without going into a multi-interface mess.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7777) Implement a base class for
DNSToSwitchMapping implementations that can offer extra topology
information
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13157566#comment-13157566 ]
Hudson commented on HADOOP-7777:
--------------------------------
Integrated in Hadoop-Common-trunk-Commit #1323 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1323/])
HADOOP-7777 changes.txt
HADOOP-7777 a base class for DNSToSwitchMapping implementations
stevel : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1206520
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
stevel : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1206515
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/AbstractDNSToSwitchMapping.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/CachedDNSToSwitchMapping.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/DNSToSwitchMapping.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/ScriptBasedMapping.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/net/StaticMapping.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/net/TestScriptBasedMapping.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/net/TestStaticMapping.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/net/TestSwitchMapping.java
> Implement a base class for DNSToSwitchMapping implementations that can offer extra topology information
> -------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-7777
> URL: https://issues.apache.org/jira/browse/HADOOP-7777
> Project: Hadoop Common
> Issue Type: Improvement
> Components: util
> Affects Versions: 0.23.0, 0.24.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Attachments: HADOOP-7777-switch.patch, HADOOP-7777-switch.patch, HADOOP-7777-switch.patch, HADOOP-7777-switch.patch, HADOOP-7777-switch.patch
>
>
> HDFS-2492 has identified a need for DNSToSwitchMapping implementations to provide a bit more topology information (e.g. whether or not there are multiple switches). This could be done by writing an extended interface, querying its methods if present and coming up with a default action if there is no extended interface.
> Alternatively, we have a base class that all the standard mappings implement, with a boolean isMultiRack() method; all the standard subclasses would extend this, as could any third party topology provider. The advantage of this approach is that it is easier to add new operations without going into a multi-interface mess.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7777) Implement a base class for
DNSToSwitchMapping implementations that can offer extra topology
information
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13167561#comment-13167561 ]
Hudson commented on HADOOP-7777:
--------------------------------
Integrated in Hadoop-Mapreduce-0.23-Commit #280 (See [https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/280/])
HADOOP-7878 Regression: HADOOP-7777 switch changes break HDFS tests when the isSingleSwitch() predicate is used
stevel : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1213264
Files :
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/net/StaticMapping.java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/net/TestStaticMapping.java
> Implement a base class for DNSToSwitchMapping implementations that can offer extra topology information
> -------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-7777
> URL: https://issues.apache.org/jira/browse/HADOOP-7777
> Project: Hadoop Common
> Issue Type: Improvement
> Components: util
> Affects Versions: 0.23.0, 0.24.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Fix For: 0.24.0, 0.23.1
>
> Attachments: HADOOP-7777-switch.patch, HADOOP-7777-switch.patch, HADOOP-7777-switch.patch, HADOOP-7777-switch.patch, HADOOP-7777-switch.patch
>
>
> HDFS-2492 has identified a need for DNSToSwitchMapping implementations to provide a bit more topology information (e.g. whether or not there are multiple switches). This could be done by writing an extended interface, querying its methods if present and coming up with a default action if there is no extended interface.
> Alternatively, we have a base class that all the standard mappings implement, with a boolean isMultiRack() method; all the standard subclasses would extend this, as could any third party topology provider. The advantage of this approach is that it is easier to add new operations without going into a multi-interface mess.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7777) Implement a base class for
DNSToSwitchMapping implementations that can offer extra topology
information
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13157577#comment-13157577 ]
Hudson commented on HADOOP-7777:
--------------------------------
Integrated in Hadoop-Mapreduce-trunk-Commit #1347 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1347/])
HADOOP-7777 changes.txt
stevel : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1206520
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
> Implement a base class for DNSToSwitchMapping implementations that can offer extra topology information
> -------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-7777
> URL: https://issues.apache.org/jira/browse/HADOOP-7777
> Project: Hadoop Common
> Issue Type: Improvement
> Components: util
> Affects Versions: 0.23.0, 0.24.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Attachments: HADOOP-7777-switch.patch, HADOOP-7777-switch.patch, HADOOP-7777-switch.patch, HADOOP-7777-switch.patch, HADOOP-7777-switch.patch
>
>
> HDFS-2492 has identified a need for DNSToSwitchMapping implementations to provide a bit more topology information (e.g. whether or not there are multiple switches). This could be done by writing an extended interface, querying its methods if present and coming up with a default action if there is no extended interface.
> Alternatively, we have a base class that all the standard mappings implement, with a boolean isMultiRack() method; all the standard subclasses would extend this, as could any third party topology provider. The advantage of this approach is that it is easier to add new operations without going into a multi-interface mess.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7777) Implement a base class for
DNSToSwitchMapping implementations that can offer extra topology
information
Posted by "Steve Loughran (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Steve Loughran updated HADOOP-7777:
-----------------------------------
Attachment: HADOOP-7777-switch.patch
> Implement a base class for DNSToSwitchMapping implementations that can offer extra topology information
> -------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-7777
> URL: https://issues.apache.org/jira/browse/HADOOP-7777
> Project: Hadoop Common
> Issue Type: Improvement
> Components: util
> Affects Versions: 0.23.0, 0.24.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Attachments: HADOOP-7777-switch.patch, HADOOP-7777-switch.patch, HADOOP-7777-switch.patch, HADOOP-7777-switch.patch
>
>
> HDFS-2492 has identified a need for DNSToSwitchMapping implementations to provide a bit more topology information (e.g. whether or not there are multiple switches). This could be done by writing an extended interface, querying its methods if present and coming up with a default action if there is no extended interface.
> Alternatively, we have a base class that all the standard mappings implement, with a boolean isMultiRack() method; all the standard subclasses would extend this, as could any third party topology provider. The advantage of this approach is that it is easier to add new operations without going into a multi-interface mess.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7777) Implement a base class for
DNSToSwitchMapping implementations that can offer extra topology
information
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13168447#comment-13168447 ]
Hudson commented on HADOOP-7777:
--------------------------------
Integrated in Hadoop-Mapreduce-trunk #926 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/926/])
HADOOP-7878 Regression: HADOOP-7777 switch changes break HDFS tests when the isSingleSwitch() predicate is used
stevel : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1213263
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/net/StaticMapping.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/net/TestStaticMapping.java
> Implement a base class for DNSToSwitchMapping implementations that can offer extra topology information
> -------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-7777
> URL: https://issues.apache.org/jira/browse/HADOOP-7777
> Project: Hadoop Common
> Issue Type: Improvement
> Components: util
> Affects Versions: 0.23.0, 0.24.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Fix For: 0.24.0, 0.23.1
>
> Attachments: HADOOP-7777-switch.patch, HADOOP-7777-switch.patch, HADOOP-7777-switch.patch, HADOOP-7777-switch.patch, HADOOP-7777-switch.patch
>
>
> HDFS-2492 has identified a need for DNSToSwitchMapping implementations to provide a bit more topology information (e.g. whether or not there are multiple switches). This could be done by writing an extended interface, querying its methods if present and coming up with a default action if there is no extended interface.
> Alternatively, we have a base class that all the standard mappings implement, with a boolean isMultiRack() method; all the standard subclasses would extend this, as could any third party topology provider. The advantage of this approach is that it is easier to add new operations without going into a multi-interface mess.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7777) Implement a base class for
DNSToSwitchMapping implementations that can offer extra topology
information
Posted by "Steve Loughran (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Steve Loughran updated HADOOP-7777:
-----------------------------------
Target Version/s: 0.23.0, 0.24.0 (was: 0.24.0, 0.23.0)
Status: Open (was: Patch Available)
> Implement a base class for DNSToSwitchMapping implementations that can offer extra topology information
> -------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-7777
> URL: https://issues.apache.org/jira/browse/HADOOP-7777
> Project: Hadoop Common
> Issue Type: Improvement
> Components: util
> Affects Versions: 0.23.0, 0.24.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Attachments: HADOOP-7777-switch.patch, HADOOP-7777-switch.patch, HADOOP-7777-switch.patch, HADOOP-7777-switch.patch, HADOOP-7777-switch.patch
>
>
> HDFS-2492 has identified a need for DNSToSwitchMapping implementations to provide a bit more topology information (e.g. whether or not there are multiple switches). This could be done by writing an extended interface, querying its methods if present and coming up with a default action if there is no extended interface.
> Alternatively, we have a base class that all the standard mappings implement, with a boolean isMultiRack() method; all the standard subclasses would extend this, as could any third party topology provider. The advantage of this approach is that it is easier to add new operations without going into a multi-interface mess.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7777) Implement a base class for
DNSToSwitchMapping implementations that can offer extra topology
information
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13167526#comment-13167526 ]
Hudson commented on HADOOP-7777:
--------------------------------
Integrated in Hadoop-Hdfs-0.23-Commit #260 (See [https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/260/])
HADOOP-7878 Regression: HADOOP-7777 switch changes break HDFS tests when the isSingleSwitch() predicate is used
stevel : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1213264
Files :
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/net/StaticMapping.java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/net/TestStaticMapping.java
> Implement a base class for DNSToSwitchMapping implementations that can offer extra topology information
> -------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-7777
> URL: https://issues.apache.org/jira/browse/HADOOP-7777
> Project: Hadoop Common
> Issue Type: Improvement
> Components: util
> Affects Versions: 0.23.0, 0.24.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Fix For: 0.24.0, 0.23.1
>
> Attachments: HADOOP-7777-switch.patch, HADOOP-7777-switch.patch, HADOOP-7777-switch.patch, HADOOP-7777-switch.patch, HADOOP-7777-switch.patch
>
>
> HDFS-2492 has identified a need for DNSToSwitchMapping implementations to provide a bit more topology information (e.g. whether or not there are multiple switches). This could be done by writing an extended interface, querying its methods if present and coming up with a default action if there is no extended interface.
> Alternatively, we have a base class that all the standard mappings implement, with a boolean isMultiRack() method; all the standard subclasses would extend this, as could any third party topology provider. The advantage of this approach is that it is easier to add new operations without going into a multi-interface mess.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7777) Implement a base class for
DNSToSwitchMapping implementations that can offer extra topology
information
Posted by "Steve Loughran (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Steve Loughran updated HADOOP-7777:
-----------------------------------
Target Version/s: 0.23.0, 0.24.0 (was: 0.24.0, 0.23.0)
Status: Open (was: Patch Available)
> Implement a base class for DNSToSwitchMapping implementations that can offer extra topology information
> -------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-7777
> URL: https://issues.apache.org/jira/browse/HADOOP-7777
> Project: Hadoop Common
> Issue Type: Improvement
> Components: util
> Affects Versions: 0.23.0, 0.24.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Attachments: HADOOP-7777-switch.patch, HADOOP-7777-switch.patch, HADOOP-7777-switch.patch
>
>
> HDFS-2492 has identified a need for DNSToSwitchMapping implementations to provide a bit more topology information (e.g. whether or not there are multiple switches). This could be done by writing an extended interface, querying its methods if present and coming up with a default action if there is no extended interface.
> Alternatively, we have a base class that all the standard mappings implement, with a boolean isMultiRack() method; all the standard subclasses would extend this, as could any third party topology provider. The advantage of this approach is that it is easier to add new operations without going into a multi-interface mess.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7777) Implement a base class for
DNSToSwitchMapping implementations that can offer extra topology
information
Posted by "Steve Loughran (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Steve Loughran updated HADOOP-7777:
-----------------------------------
Attachment: HADOOP-7777-switch.patch
> Implement a base class for DNSToSwitchMapping implementations that can offer extra topology information
> -------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-7777
> URL: https://issues.apache.org/jira/browse/HADOOP-7777
> Project: Hadoop Common
> Issue Type: Improvement
> Components: util
> Affects Versions: 0.23.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Attachments: HADOOP-7777-switch.patch, HADOOP-7777-switch.patch
>
>
> HDFS-2492 has identified a need for DNSToSwitchMapping implementations to provide a bit more topology information (e.g. whether or not there are multiple switches). This could be done by writing an extended interface, querying its methods if present and coming up with a default action if there is no extended interface.
> Alternatively, we have a base class that all the standard mappings implement, with a boolean isMultiRack() method; all the standard subclasses would extend this, as could any third party topology provider. The advantage of this approach is that it is easier to add new operations without going into a multi-interface mess.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7777) Implement a base class for
DNSToSwitchMapping implementations that can offer extra topology
information
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13157570#comment-13157570 ]
Hudson commented on HADOOP-7777:
--------------------------------
Integrated in Hadoop-Hdfs-trunk-Commit #1397 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1397/])
HADOOP-7777 changes.txt
stevel : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1206520
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
> Implement a base class for DNSToSwitchMapping implementations that can offer extra topology information
> -------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-7777
> URL: https://issues.apache.org/jira/browse/HADOOP-7777
> Project: Hadoop Common
> Issue Type: Improvement
> Components: util
> Affects Versions: 0.23.0, 0.24.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Attachments: HADOOP-7777-switch.patch, HADOOP-7777-switch.patch, HADOOP-7777-switch.patch, HADOOP-7777-switch.patch, HADOOP-7777-switch.patch
>
>
> HDFS-2492 has identified a need for DNSToSwitchMapping implementations to provide a bit more topology information (e.g. whether or not there are multiple switches). This could be done by writing an extended interface, querying its methods if present and coming up with a default action if there is no extended interface.
> Alternatively, we have a base class that all the standard mappings implement, with a boolean isMultiRack() method; all the standard subclasses would extend this, as could any third party topology provider. The advantage of this approach is that it is easier to add new operations without going into a multi-interface mess.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7777) Implement a base class for
DNSToSwitchMapping implementations that can offer extra topology
information
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13158814#comment-13158814 ]
Hudson commented on HADOOP-7777:
--------------------------------
Integrated in Hadoop-Common-trunk-Commit #1332 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1332/])
Apply HADOOP-7777 to 0.23.1
stevel : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1207629
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
> Implement a base class for DNSToSwitchMapping implementations that can offer extra topology information
> -------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-7777
> URL: https://issues.apache.org/jira/browse/HADOOP-7777
> Project: Hadoop Common
> Issue Type: Improvement
> Components: util
> Affects Versions: 0.23.0, 0.24.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Fix For: 0.24.0, 0.23.1
>
> Attachments: HADOOP-7777-switch.patch, HADOOP-7777-switch.patch, HADOOP-7777-switch.patch, HADOOP-7777-switch.patch, HADOOP-7777-switch.patch
>
>
> HDFS-2492 has identified a need for DNSToSwitchMapping implementations to provide a bit more topology information (e.g. whether or not there are multiple switches). This could be done by writing an extended interface, querying its methods if present and coming up with a default action if there is no extended interface.
> Alternatively, we have a base class that all the standard mappings implement, with a boolean isMultiRack() method; all the standard subclasses would extend this, as could any third party topology provider. The advantage of this approach is that it is easier to add new operations without going into a multi-interface mess.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7777) Implement a base class for
DNSToSwitchMapping implementations that can offer extra topology
information
Posted by "Steve Loughran (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Steve Loughran updated HADOOP-7777:
-----------------------------------
Target Version/s: 0.23.0, 0.24.0 (was: 0.24.0, 0.23.0)
Status: Open (was: Patch Available)
> Implement a base class for DNSToSwitchMapping implementations that can offer extra topology information
> -------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-7777
> URL: https://issues.apache.org/jira/browse/HADOOP-7777
> Project: Hadoop Common
> Issue Type: Improvement
> Components: util
> Affects Versions: 0.23.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Attachments: HADOOP-7777-switch.patch, HADOOP-7777-switch.patch
>
>
> HDFS-2492 has identified a need for DNSToSwitchMapping implementations to provide a bit more topology information (e.g. whether or not there are multiple switches). This could be done by writing an extended interface, querying its methods if present and coming up with a default action if there is no extended interface.
> Alternatively, we have a base class that all the standard mappings implement, with a boolean isMultiRack() method; all the standard subclasses would extend this, as could any third party topology provider. The advantage of this approach is that it is easier to add new operations without going into a multi-interface mess.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7777) Implement a base class for
DNSToSwitchMapping implementations that can offer extra topology
information
Posted by "Steve Loughran (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Steve Loughran updated HADOOP-7777:
-----------------------------------
Target Version/s: 0.23.0, 0.24.0 (was: 0.24.0, 0.23.0)
Status: Patch Available (was: Open)
> Implement a base class for DNSToSwitchMapping implementations that can offer extra topology information
> -------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-7777
> URL: https://issues.apache.org/jira/browse/HADOOP-7777
> Project: Hadoop Common
> Issue Type: Improvement
> Components: util
> Affects Versions: 0.23.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Attachments: HADOOP-7777-switch.patch, HADOOP-7777-switch.patch
>
>
> HDFS-2492 has identified a need for DNSToSwitchMapping implementations to provide a bit more topology information (e.g. whether or not there are multiple switches). This could be done by writing an extended interface, querying its methods if present and coming up with a default action if there is no extended interface.
> Alternatively, we have a base class that all the standard mappings implement, with a boolean isMultiRack() method; all the standard subclasses would extend this, as could any third party topology provider. The advantage of this approach is that it is easier to add new operations without going into a multi-interface mess.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7777) Implement a base class for
DNSToSwitchMapping implementations that can offer extra topology
information
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13158828#comment-13158828 ]
Hudson commented on HADOOP-7777:
--------------------------------
Integrated in Hadoop-Hdfs-0.23-Commit #220 (See [https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/220/])
Apply HADOOP-7777 to 0.23.1
stevel : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1207628
Files :
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/AbstractDNSToSwitchMapping.java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/CachedDNSToSwitchMapping.java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/DNSToSwitchMapping.java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/ScriptBasedMapping.java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/net/StaticMapping.java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/net/TestScriptBasedMapping.java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/net/TestStaticMapping.java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/net/TestSwitchMapping.java
> Implement a base class for DNSToSwitchMapping implementations that can offer extra topology information
> -------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-7777
> URL: https://issues.apache.org/jira/browse/HADOOP-7777
> Project: Hadoop Common
> Issue Type: Improvement
> Components: util
> Affects Versions: 0.23.0, 0.24.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Fix For: 0.24.0, 0.23.1
>
> Attachments: HADOOP-7777-switch.patch, HADOOP-7777-switch.patch, HADOOP-7777-switch.patch, HADOOP-7777-switch.patch, HADOOP-7777-switch.patch
>
>
> HDFS-2492 has identified a need for DNSToSwitchMapping implementations to provide a bit more topology information (e.g. whether or not there are multiple switches). This could be done by writing an extended interface, querying its methods if present and coming up with a default action if there is no extended interface.
> Alternatively, we have a base class that all the standard mappings implement, with a boolean isMultiRack() method; all the standard subclasses would extend this, as could any third party topology provider. The advantage of this approach is that it is easier to add new operations without going into a multi-interface mess.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7777) Implement a base class for
DNSToSwitchMapping implementations that can offer extra topology
information
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13167563#comment-13167563 ]
Hudson commented on HADOOP-7777:
--------------------------------
Integrated in Hadoop-Mapreduce-trunk-Commit #1422 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1422/])
HADOOP-7878 Regression: HADOOP-7777 switch changes break HDFS tests when the isSingleSwitch() predicate is used
stevel : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1213263
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/net/StaticMapping.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/net/TestStaticMapping.java
> Implement a base class for DNSToSwitchMapping implementations that can offer extra topology information
> -------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-7777
> URL: https://issues.apache.org/jira/browse/HADOOP-7777
> Project: Hadoop Common
> Issue Type: Improvement
> Components: util
> Affects Versions: 0.23.0, 0.24.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Fix For: 0.24.0, 0.23.1
>
> Attachments: HADOOP-7777-switch.patch, HADOOP-7777-switch.patch, HADOOP-7777-switch.patch, HADOOP-7777-switch.patch, HADOOP-7777-switch.patch
>
>
> HDFS-2492 has identified a need for DNSToSwitchMapping implementations to provide a bit more topology information (e.g. whether or not there are multiple switches). This could be done by writing an extended interface, querying its methods if present and coming up with a default action if there is no extended interface.
> Alternatively, we have a base class that all the standard mappings implement, with a boolean isMultiRack() method; all the standard subclasses would extend this, as could any third party topology provider. The advantage of this approach is that it is easier to add new operations without going into a multi-interface mess.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7777) Implement a base class for
DNSToSwitchMapping implementations that can offer extra topology
information
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13168340#comment-13168340 ]
Hudson commented on HADOOP-7777:
--------------------------------
Integrated in Hadoop-Hdfs-0.23-Build #106 (See [https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/106/])
HADOOP-7878 Regression: HADOOP-7777 switch changes break HDFS tests when the isSingleSwitch() predicate is used
stevel : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1213264
Files :
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/net/StaticMapping.java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/net/TestStaticMapping.java
> Implement a base class for DNSToSwitchMapping implementations that can offer extra topology information
> -------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-7777
> URL: https://issues.apache.org/jira/browse/HADOOP-7777
> Project: Hadoop Common
> Issue Type: Improvement
> Components: util
> Affects Versions: 0.23.0, 0.24.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Fix For: 0.24.0, 0.23.1
>
> Attachments: HADOOP-7777-switch.patch, HADOOP-7777-switch.patch, HADOOP-7777-switch.patch, HADOOP-7777-switch.patch, HADOOP-7777-switch.patch
>
>
> HDFS-2492 has identified a need for DNSToSwitchMapping implementations to provide a bit more topology information (e.g. whether or not there are multiple switches). This could be done by writing an extended interface, querying its methods if present and coming up with a default action if there is no extended interface.
> Alternatively, we have a base class that all the standard mappings implement, with a boolean isMultiRack() method; all the standard subclasses would extend this, as could any third party topology provider. The advantage of this approach is that it is easier to add new operations without going into a multi-interface mess.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7777) Implement a base class for
DNSToSwitchMapping implementations that can offer extra topology
information
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13144720#comment-13144720 ]
Hadoop QA commented on HADOOP-7777:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12502596/HADOOP-7777-switch.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 10 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
-1 javac. The applied patch generated 1040 javac compiler warnings (more than the trunk's current 1039 warnings).
-1 findbugs. The patch appears to introduce 7 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed unit tests in .
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/360//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/360//artifact/trunk/hadoop-common-project/patchprocess/newPatchFindbugsWarningshadoop-common.html
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/360//console
This message is automatically generated.
> Implement a base class for DNSToSwitchMapping implementations that can offer extra topology information
> -------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-7777
> URL: https://issues.apache.org/jira/browse/HADOOP-7777
> Project: Hadoop Common
> Issue Type: Improvement
> Components: util
> Affects Versions: 0.23.0, 0.24.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Attachments: HADOOP-7777-switch.patch, HADOOP-7777-switch.patch, HADOOP-7777-switch.patch
>
>
> HDFS-2492 has identified a need for DNSToSwitchMapping implementations to provide a bit more topology information (e.g. whether or not there are multiple switches). This could be done by writing an extended interface, querying its methods if present and coming up with a default action if there is no extended interface.
> Alternatively, we have a base class that all the standard mappings implement, with a boolean isMultiRack() method; all the standard subclasses would extend this, as could any third party topology provider. The advantage of this approach is that it is easier to add new operations without going into a multi-interface mess.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7777) Implement a base class for
DNSToSwitchMapping implementations that can offer extra topology
information
Posted by "Steve Loughran (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Steve Loughran updated HADOOP-7777:
-----------------------------------
Resolution: Fixed
Fix Version/s: 0.23.1
0.24.0
Target Version/s: 0.23.0, 0.24.0 (was: 0.24.0, 0.23.0)
Status: Resolved (was: Patch Available)
> Implement a base class for DNSToSwitchMapping implementations that can offer extra topology information
> -------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-7777
> URL: https://issues.apache.org/jira/browse/HADOOP-7777
> Project: Hadoop Common
> Issue Type: Improvement
> Components: util
> Affects Versions: 0.23.0, 0.24.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Fix For: 0.24.0, 0.23.1
>
> Attachments: HADOOP-7777-switch.patch, HADOOP-7777-switch.patch, HADOOP-7777-switch.patch, HADOOP-7777-switch.patch, HADOOP-7777-switch.patch
>
>
> HDFS-2492 has identified a need for DNSToSwitchMapping implementations to provide a bit more topology information (e.g. whether or not there are multiple switches). This could be done by writing an extended interface, querying its methods if present and coming up with a default action if there is no extended interface.
> Alternatively, we have a base class that all the standard mappings implement, with a boolean isMultiRack() method; all the standard subclasses would extend this, as could any third party topology provider. The advantage of this approach is that it is easier to add new operations without going into a multi-interface mess.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7777) Implement a base class for
DNSToSwitchMapping implementations that can offer extra topology
information
Posted by "Steve Loughran (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13138645#comment-13138645 ]
Steve Loughran commented on HADOOP-7777:
----------------------------------------
This adds a new base class {{AbstractDNSToSwitchMapping}} to offer a common implementation class for the bundled DNS mappings, and a new predicate {{isSingleSwitch()}} which should be true if
a class believes that its topology is only on a single switch.
I initially tried to have the base class extend {{Configurable}} but that triggered calls to things like {{ScriptBasedMapping.setConf()}} from Configurable's constructor, which had lots of consequences as the subclasses weren't ready for that yet. I added the workarounds -checks for other fields being initialised- but this left the code brittle and made it harder to make any custom mappers subclasses of this. I reverted those changes and now the {{AbstractDNSToSwitchMapping}} class just implements {{Configurable}}.
This base class (and the sub classes) do what I wanted, namely indicate whether or not they are single switch or not, with the presumption being "multi-switch unless stated".
# {{ScriptBasedMapping}} is single rack if it has no script.
# {{CachedDNSToSwitchMapping}} relays its query to the raw mapping.
# {{StaticMapping}} says it is single rack if its map is empty (that is, all resolved nodes
will be reported as being in the default rack).
There's tests for all this, and in {{TestSwitchMapping}} verification that implementations of {{DNSToSwitchMapping}} are always considered multi-switch. The tests also see what happens when you pass down null configurations (the existing stuff mostly broke)
Once committed I can fix HDFS BlockManager to use the switch predicate to decide whether to assume multi-rack placement or not.
> Implement a base class for DNSToSwitchMapping implementations that can offer extra topology information
> -------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-7777
> URL: https://issues.apache.org/jira/browse/HADOOP-7777
> Project: Hadoop Common
> Issue Type: Improvement
> Components: util
> Affects Versions: 0.23.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Attachments: HADOOP-7777-switch.patch, HADOOP-7777-switch.patch
>
>
> HDFS-2492 has identified a need for DNSToSwitchMapping implementations to provide a bit more topology information (e.g. whether or not there are multiple switches). This could be done by writing an extended interface, querying its methods if present and coming up with a default action if there is no extended interface.
> Alternatively, we have a base class that all the standard mappings implement, with a boolean isMultiRack() method; all the standard subclasses would extend this, as could any third party topology provider. The advantage of this approach is that it is easier to add new operations without going into a multi-interface mess.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira