You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by David James <st...@gmail.com> on 2004/08/26 19:42:50 UTC
[PATCH] Behave correctly when users specify SWIG binary instead of SWIG directory as configure option
Occasionally, users will forget to read instructions. When they do,
it's helpful for us to be as forgiving as we can.
In our configure documentation, we ask users to specify
--with-swig=PATH. Currently, when users specify the path to "swig" as
the path to the SWIG binary, the build fails with an error message
that is difficult to understand. This patch makes SWIG build correctly
in that situation, and it therefore will make the Subversion build
process just a little bit more user-friendly.
===================================================================
--- build/ac-macros/swig.m4 (revision 10736)
+++ build/ac-macros/swig.m4 (working copy)
@@ -75,6 +75,7 @@
AC_PATH_PROG(SWIG, swig, none)
else
SWIG=$where/bin/swig
+ test -x $SWIG || SWIG=$where
fi
if test "$SWIG" != "none"; then
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Behave correctly when users specify SWIG binary instead of SWIG directory as configure option
Posted by David James <st...@gmail.com>.
> Committed something that serves the same purpose but is more complete
> about resolving the issue in r10868.
Hi Ben,
I looked over your patch and it's a big improvement over my original.
Thanks for your work.
Cheers,
David
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Behave correctly when users specify SWIG binary instead of SWIG directory as configure option
Posted by Ben Reser <be...@reser.org>.
On Thu, Aug 26, 2004 at 03:42:50PM -0400, David James wrote:
> Occasionally, users will forget to read instructions. When they do,
> it's helpful for us to be as forgiving as we can.
>
> In our configure documentation, we ask users to specify
> --with-swig=PATH. Currently, when users specify the path to "swig" as
> the path to the SWIG binary, the build fails with an error message
> that is difficult to understand. This patch makes SWIG build correctly
> in that situation, and it therefore will make the Subversion build
> process just a little bit more user-friendly.
>
> ===================================================================
> --- build/ac-macros/swig.m4 (revision 10736)
> +++ build/ac-macros/swig.m4 (working copy)
> @@ -75,6 +75,7 @@
> AC_PATH_PROG(SWIG, swig, none)
> else
> SWIG=$where/bin/swig
> + test -x $SWIG || SWIG=$where
> fi
>
> if test "$SWIG" != "none"; then
Committed something that serves the same purpose but is more complete
about resolving the issue in r10868.
--
Ben Reser <be...@reser.org>
http://ben.reser.org
"Conscience is the inner voice which warns us somebody may be looking."
- H.L. Mencken
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org