You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "jfrag1 (via GitHub)" <gi...@apache.org> on 2023/04/11 17:27:57 UTC
[GitHub] [superset] jfrag1 opened a new pull request, #23650: fix(migration): Only attempt to drop types if they exist
jfrag1 opened a new pull request, #23650:
URL: https://github.com/apache/superset/pull/23650
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
If the database is fully upgraded, then downgraded past this migration, re-upgrading will fail because the migration is trying to drop a type that does not exist.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #23650: fix(migration): Only attempt to drop types if they exist
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #23650:
URL: https://github.com/apache/superset/pull/23650#issuecomment-1503829924
## [Codecov](https://codecov.io/gh/apache/superset/pull/23650?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#23650](https://codecov.io/gh/apache/superset/pull/23650?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2fcad18) into [master](https://codecov.io/gh/apache/superset/commit/825006d90656f4955e71062803fbcb7ef7fb5659?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (825006d) will **decrease** coverage by `11.35%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 2fcad18 differs from pull request most recent head 190332f. Consider uploading reports for the commit 190332f to get more accurate results
```diff
@@ Coverage Diff @@
## master #23650 +/- ##
===========================================
- Coverage 67.93% 56.59% -11.35%
===========================================
Files 1918 1918
Lines 73891 73891
Branches 8058 8058
===========================================
- Hits 50199 41818 -8381
- Misses 21633 30014 +8381
Partials 2059 2059
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `53.16% <ø> (ø)` | |
| mysql | `?` | |
| postgres | `?` | |
| python | `59.49% <ø> (-23.54%)` | :arrow_down: |
| sqlite | `?` | |
| unit | `53.02% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 302 files with indirect coverage changes](https://codecov.io/gh/apache/superset/pull/23650/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] jfrag1 closed pull request #23650: fix(migration): Only attempt to drop types if they exist
Posted by "jfrag1 (via GitHub)" <gi...@apache.org>.
jfrag1 closed pull request #23650: fix(migration): Only attempt to drop types if they exist
URL: https://github.com/apache/superset/pull/23650
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] Antonio-RiveroMartnez merged pull request #23650: fix(migration): Only attempt to drop types if they exist
Posted by "Antonio-RiveroMartnez (via GitHub)" <gi...@apache.org>.
Antonio-RiveroMartnez merged PR #23650:
URL: https://github.com/apache/superset/pull/23650
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org