You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "youngkermit8-coder (via GitHub)" <gi...@apache.org> on 2026/08/11 17:08:03 UTC

[PR] [Studio][ISSUE #1943] Validate every DNS answer in the shared URL guard [rocketmq-dashboard]

youngkermit8-coder opened a new pull request, #1944:
URL: https://github.com/apache/rocketmq-dashboard/pull/1944

   ## Summary
   
   - resolve every DNS answer in the shared URL host guard
   - reject the host when any address violates the existing any-local, link-local, or loopback policy
   - preserve loopback support for local LLM gateways
   - add focused coverage for mixed-order DNS results and invalid address sets
   
   ## Root cause
   
   `UrlHostGuard.isAllowedHost` used `InetAddress.getByName`, which validates only one DNS answer. The HTTP client resolves the hostname independently, so a hostname with mixed public and link-local/cloud-metadata results could pass validation based on answer ordering and later connect to a blocked address.
   
   This is a follow-up to #1543/#1556. That change protects the separate data-source connection-test check; the newer shared guard used by data-source persistence, metrics queries, and LLM API bases still inspected one answer.
   
   ## Validation
   
   - Focused URL guard and affected service tests: 60 passed
   - Full backend suite: 1058 passed
   - Checkstyle: 0 violations
   - `git diff --check`: passed
   
   Closes #1943


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Studio][ISSUE #1943] Validate every DNS answer in the shared URL guard [rocketmq-dashboard]

Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins closed pull request #1944: [Studio][ISSUE #1943] Validate every DNS answer in the shared URL guard
URL: https://github.com/apache/rocketmq-dashboard/pull/1944


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Studio][ISSUE #1943] Validate every DNS answer in the shared URL guard [rocketmq-dashboard]

Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins commented on PR #1944:
URL: https://github.com/apache/rocketmq-dashboard/pull/1944#issuecomment-5279858358

   Superseded: main already validates every resolved DNS answer — UrlHostGuard now uses getAllByName + areAllowed (merged via #1556), plus multicast rejection (merged via #1856). Closing as covered; thanks for the tests\!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org