You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2020/03/07 13:23:36 UTC
[GitHub] [kylin] zhangayqian opened a new pull request #1148: KYLIN-4394
Update kylin dependency
zhangayqian opened a new pull request #1148: KYLIN-4394 Update kylin dependency
URL: https://github.com/apache/kylin/pull/1148
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] codecov-io edited a comment on issue #1148: KYLIN-4394
Update kylin dependency
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #1148: KYLIN-4394 Update kylin dependency
URL: https://github.com/apache/kylin/pull/1148#issuecomment-596998741
# [Codecov](https://codecov.io/gh/apache/kylin/pull/1148?src=pr&el=h1) Report
> Merging [#1148](https://codecov.io/gh/apache/kylin/pull/1148?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/ebc4c267b56833475881fb482b1467fbe8367df1&el=desc) will **increase** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/kylin/pull/1148?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1148 +/- ##
=========================================
Coverage 25.05% 25.06%
Complexity 6248 6248
=========================================
Files 1446 1446
Lines 88305 88305
Branches 12357 12357
=========================================
+ Hits 22128 22131 +3
+ Misses 64007 64004 -3
Partials 2170 2170
```
| [Impacted Files](https://codecov.io/gh/apache/kylin/pull/1148?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/1148/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh) | `71.12% <0.00%> (+0.91%)` | `7.00% <0.00%> (ø%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1148?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1148?src=pr&el=footer). Last update [ebc4c26...f10d885](https://codecov.io/gh/apache/kylin/pull/1148?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] coveralls edited a comment on issue #1148: KYLIN-4394
Update kylin dependency
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #1148: KYLIN-4394 Update kylin dependency
URL: https://github.com/apache/kylin/pull/1148#issuecomment-597002658
## Pull Request Test Coverage Report for [Build 5739](https://coveralls.io/builds/29266201)
* **11** of **55** **(20.0%)** changed or added relevant lines in **22** files are covered.
* **9** unchanged lines in **4** files lost coverage.
* Overall coverage decreased (**-0.006%**) to **27.513%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [core-cube/src/main/java/org/apache/kylin/cube/model/DimensionDesc.java](https://coveralls.io/builds/29266201/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fmodel%2FDimensionDesc.java#L145) | 0 | 1 | 0.0%
| [core-cube/src/main/java/org/apache/kylin/cube/model/RowKeyColDesc.java](https://coveralls.io/builds/29266201/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fmodel%2FRowKeyColDesc.java#L169) | 0 | 1 | 0.0%
| [core-cube/src/main/java/org/apache/kylin/cube/model/RowKeyDesc.java](https://coveralls.io/builds/29266201/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fmodel%2FRowKeyDesc.java#L103) | 0 | 1 | 0.0%
| [core-cube/src/main/java/org/apache/kylin/cube/util/CubingUtils.java](https://coveralls.io/builds/29266201/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Futil%2FCubingUtils.java#L91) | 0 | 1 | 0.0%
| [core-metadata/src/main/java/org/apache/kylin/source/SourcePartition.java](https://coveralls.io/builds/29266201/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fsource%2FSourcePartition.java#L89) | 0 | 1 | 0.0%
| [stream-core/src/main/java/org/apache/kylin/stream/core/query/IStreamingSearchResult.java](https://coveralls.io/builds/29266201/source?filename=stream-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fcore%2Fquery%2FIStreamingSearchResult.java#L38) | 0 | 1 | 0.0%
| [stream-core/src/main/java/org/apache/kylin/stream/core/query/SingleThreadResultCollector.java](https://coveralls.io/builds/29266201/source?filename=stream-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fcore%2Fquery%2FSingleThreadResultCollector.java#L35) | 1 | 2 | 50.0%
| [engine-mr/src/main/java/org/apache/kylin/engine/mr/steps/CalculateStatsFromBaseCuboidMapper.java](https://coveralls.io/builds/29266201/source?filename=engine-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fmr%2Fsteps%2FCalculateStatsFromBaseCuboidMapper.java#L149) | 0 | 2 | 0.0%
| [engine-mr/src/main/java/org/apache/kylin/engine/mr/steps/FactDistinctColumnsMapper.java](https://coveralls.io/builds/29266201/source?filename=engine-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fmr%2Fsteps%2FFactDistinctColumnsMapper.java#L362) | 0 | 2 | 0.0%
| [engine-spark/src/main/java/org/apache/kylin/engine/spark/KylinKryoRegistrator.java](https://coveralls.io/builds/29266201/source?filename=engine-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fspark%2FKylinKryoRegistrator.java#L91) | 0 | 2 | 0.0%
<!-- | **Total:** | **11** | **55** | **20.0%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [core-dictionary/src/main/java/org/apache/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://coveralls.io/builds/29266201/source?filename=core-dictionary%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fdict%2Flookup%2Fcache%2FRocksDBLookupTable.java#L62) | 1 | 81.08% |
| [storage-stream/src/main/java/org/apache/kylin/storage/stream/rpc/HttpStreamDataSearchClient.java](https://coveralls.io/builds/29266201/source?filename=storage-stream%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstorage%2Fstream%2Frpc%2FHttpStreamDataSearchClient.java#L82) | 1 | 0% |
| [core-job/src/main/java/org/apache/kylin/job/impl/threadpool/DefaultScheduler.java](https://coveralls.io/builds/29266201/source?filename=core-job%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fjob%2Fimpl%2Fthreadpool%2FDefaultScheduler.java#L194) | 2 | 80.23% |
| [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/29266201/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L439) | 5 | 77.81% |
<!-- | **Total:** | **9** | | -->
| Totals | [](https://coveralls.io/builds/29266201) |
| :-- | --: |
| Change from base [Build 5720](https://coveralls.io/builds/29194855): | -0.006% |
| Covered Lines: | 24295 |
| Relevant Lines: | 88305 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] codecov-io edited a comment on issue #1148: KYLIN-4394
Update kylin dependency
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #1148: KYLIN-4394 Update kylin dependency
URL: https://github.com/apache/kylin/pull/1148#issuecomment-596998741
# [Codecov](https://codecov.io/gh/apache/kylin/pull/1148?src=pr&el=h1) Report
> Merging [#1148](https://codecov.io/gh/apache/kylin/pull/1148?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/ebc4c267b56833475881fb482b1467fbe8367df1?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/kylin/pull/1148?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1148 +/- ##
============================================
+ Coverage 25.05% 25.06% +<.01%
Complexity 6248 6248
============================================
Files 1446 1446
Lines 88305 88305
Branches 12357 12357
============================================
+ Hits 22128 22131 +3
+ Misses 64007 64004 -3
Partials 2170 2170
```
| [Impacted Files](https://codecov.io/gh/apache/kylin/pull/1148?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/1148/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh) | `71.12% <0%> (+0.91%)` | `7% <0%> (ø)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1148?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1148?src=pr&el=footer). Last update [ebc4c26...f10d885](https://codecov.io/gh/apache/kylin/pull/1148?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] coveralls edited a comment on issue #1148: KYLIN-4394
Update kylin dependency
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #1148: KYLIN-4394 Update kylin dependency
URL: https://github.com/apache/kylin/pull/1148#issuecomment-597002658
## Pull Request Test Coverage Report for [Build 5737](https://coveralls.io/builds/29248997)
* **11** of **55** **(20.0%)** changed or added relevant lines in **22** files are covered.
* **9** unchanged lines in **4** files lost coverage.
* Overall coverage decreased (**-0.006%**) to **27.513%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [core-cube/src/main/java/org/apache/kylin/cube/model/DimensionDesc.java](https://coveralls.io/builds/29248997/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fmodel%2FDimensionDesc.java#L145) | 0 | 1 | 0.0%
| [core-cube/src/main/java/org/apache/kylin/cube/model/RowKeyColDesc.java](https://coveralls.io/builds/29248997/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fmodel%2FRowKeyColDesc.java#L169) | 0 | 1 | 0.0%
| [core-cube/src/main/java/org/apache/kylin/cube/model/RowKeyDesc.java](https://coveralls.io/builds/29248997/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fmodel%2FRowKeyDesc.java#L103) | 0 | 1 | 0.0%
| [core-cube/src/main/java/org/apache/kylin/cube/util/CubingUtils.java](https://coveralls.io/builds/29248997/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Futil%2FCubingUtils.java#L91) | 0 | 1 | 0.0%
| [core-metadata/src/main/java/org/apache/kylin/source/SourcePartition.java](https://coveralls.io/builds/29248997/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fsource%2FSourcePartition.java#L89) | 0 | 1 | 0.0%
| [stream-core/src/main/java/org/apache/kylin/stream/core/query/IStreamingSearchResult.java](https://coveralls.io/builds/29248997/source?filename=stream-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fcore%2Fquery%2FIStreamingSearchResult.java#L38) | 0 | 1 | 0.0%
| [stream-core/src/main/java/org/apache/kylin/stream/core/query/SingleThreadResultCollector.java](https://coveralls.io/builds/29248997/source?filename=stream-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fcore%2Fquery%2FSingleThreadResultCollector.java#L35) | 1 | 2 | 50.0%
| [engine-mr/src/main/java/org/apache/kylin/engine/mr/steps/CalculateStatsFromBaseCuboidMapper.java](https://coveralls.io/builds/29248997/source?filename=engine-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fmr%2Fsteps%2FCalculateStatsFromBaseCuboidMapper.java#L149) | 0 | 2 | 0.0%
| [engine-mr/src/main/java/org/apache/kylin/engine/mr/steps/FactDistinctColumnsMapper.java](https://coveralls.io/builds/29248997/source?filename=engine-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fmr%2Fsteps%2FFactDistinctColumnsMapper.java#L362) | 0 | 2 | 0.0%
| [engine-spark/src/main/java/org/apache/kylin/engine/spark/KylinKryoRegistrator.java](https://coveralls.io/builds/29248997/source?filename=engine-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fspark%2FKylinKryoRegistrator.java#L91) | 0 | 2 | 0.0%
<!-- | **Total:** | **11** | **55** | **20.0%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [core-dictionary/src/main/java/org/apache/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://coveralls.io/builds/29248997/source?filename=core-dictionary%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fdict%2Flookup%2Fcache%2FRocksDBLookupTable.java#L62) | 1 | 81.08% |
| [storage-stream/src/main/java/org/apache/kylin/storage/stream/rpc/HttpStreamDataSearchClient.java](https://coveralls.io/builds/29248997/source?filename=storage-stream%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstorage%2Fstream%2Frpc%2FHttpStreamDataSearchClient.java#L82) | 1 | 0% |
| [core-cube/src/main/java/org/apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://coveralls.io/builds/29248997/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fcuboid%2FTreeCuboidScheduler.java#L124) | 2 | 68.46% |
| [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/29248997/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L439) | 5 | 77.81% |
<!-- | **Total:** | **9** | | -->
| Totals | [](https://coveralls.io/builds/29248997) |
| :-- | --: |
| Change from base [Build 5720](https://coveralls.io/builds/29194855): | -0.006% |
| Covered Lines: | 24295 |
| Relevant Lines: | 88305 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] codecov-io edited a comment on issue #1148: KYLIN-4394
Update kylin dependency
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #1148: KYLIN-4394 Update kylin dependency
URL: https://github.com/apache/kylin/pull/1148#issuecomment-596998741
# [Codecov](https://codecov.io/gh/apache/kylin/pull/1148?src=pr&el=h1) Report
> Merging [#1148](https://codecov.io/gh/apache/kylin/pull/1148?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/6745acb9d6c2732261938aebabd801b9bcea3963&el=desc) will **not change** coverage by `%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/kylin/pull/1148?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1148 +/- ##
=========================================
Coverage 25.02% 25.02%
Complexity 6254 6254
=========================================
Files 1449 1449
Lines 88499 88499
Branches 12373 12373
=========================================
Hits 22148 22148
Misses 64177 64177
Partials 2174 2174
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1148?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1148?src=pr&el=footer). Last update [6745acb...f8224c1](https://codecov.io/gh/apache/kylin/pull/1148?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] codecov-io edited a comment on issue #1148: KYLIN-4394
Update kylin dependency
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #1148: KYLIN-4394 Update kylin dependency
URL: https://github.com/apache/kylin/pull/1148#issuecomment-596998741
# [Codecov](https://codecov.io/gh/apache/kylin/pull/1148?src=pr&el=h1) Report
> Merging [#1148](https://codecov.io/gh/apache/kylin/pull/1148?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/6745acb9d6c2732261938aebabd801b9bcea3963&el=desc) will **not change** coverage by `%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/kylin/pull/1148?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1148 +/- ##
=========================================
Coverage 25.02% 25.02%
Complexity 6254 6254
=========================================
Files 1449 1449
Lines 88499 88499
Branches 12373 12373
=========================================
Hits 22148 22148
Misses 64177 64177
Partials 2174 2174
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1148?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1148?src=pr&el=footer). Last update [6745acb...f8224c1](https://codecov.io/gh/apache/kylin/pull/1148?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] codecov-io edited a comment on issue #1148: KYLIN-4394
Update kylin dependency
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #1148: KYLIN-4394 Update kylin dependency
URL: https://github.com/apache/kylin/pull/1148#issuecomment-596998741
# [Codecov](https://codecov.io/gh/apache/kylin/pull/1148?src=pr&el=h1) Report
> Merging [#1148](https://codecov.io/gh/apache/kylin/pull/1148?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/ebc4c267b56833475881fb482b1467fbe8367df1&el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `11.11%`.
[](https://codecov.io/gh/apache/kylin/pull/1148?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1148 +/- ##
============================================
- Coverage 25.05% 25.04% -0.02%
+ Complexity 6248 6246 -2
============================================
Files 1446 1446
Lines 88305 88305
Branches 12357 12357
============================================
- Hits 22128 22117 -11
- Misses 64007 64014 +7
- Partials 2170 2174 +4
```
| [Impacted Files](https://codecov.io/gh/apache/kylin/pull/1148?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../cachemanager/InstrumentedEhCacheCacheManager.java](https://codecov.io/gh/apache/kylin/pull/1148/diff?src=pr&el=tree#diff-Y2FjaGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NhY2hlL2NhY2hlbWFuYWdlci9JbnN0cnVtZW50ZWRFaENhY2hlQ2FjaGVNYW5hZ2VyLmphdmE=) | `57.14% <ø> (ø)` | `5.00 <0.00> (ø)` | |
| [...ylin/cache/cachemanager/MemcachedCacheManager.java](https://codecov.io/gh/apache/kylin/pull/1148/diff?src=pr&el=tree#diff-Y2FjaGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NhY2hlL2NhY2hlbWFuYWdlci9NZW1jYWNoZWRDYWNoZU1hbmFnZXIuamF2YQ==) | `43.33% <ø> (ø)` | `7.00 <0.00> (ø)` | |
| [.../cachemanager/RemoteLocalFailOverCacheManager.java](https://codecov.io/gh/apache/kylin/pull/1148/diff?src=pr&el=tree#diff-Y2FjaGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NhY2hlL2NhY2hlbWFuYWdlci9SZW1vdGVMb2NhbEZhaWxPdmVyQ2FjaGVNYW5hZ2VyLmphdmE=) | `84.61% <ø> (ø)` | `7.00 <0.00> (ø)` | |
| [...g/apache/kylin/cache/memcached/MemcachedCache.java](https://codecov.io/gh/apache/kylin/pull/1148/diff?src=pr&el=tree#diff-Y2FjaGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NhY2hlL21lbWNhY2hlZC9NZW1jYWNoZWRDYWNoZS5qYXZh) | `47.20% <ø> (ø)` | `20.00 <0.00> (ø)` | |
| [.../kylin/cache/memcached/MemcachedChunkingCache.java](https://codecov.io/gh/apache/kylin/pull/1148/diff?src=pr&el=tree#diff-Y2FjaGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NhY2hlL21lbWNhY2hlZC9NZW1jYWNoZWRDaHVua2luZ0NhY2hlLmphdmE=) | `39.70% <ø> (-0.45%)` | `15.00 <0.00> (ø)` | |
| [...apache/kylin/cache/memcached/MemcachedMetrics.java](https://codecov.io/gh/apache/kylin/pull/1148/diff?src=pr&el=tree#diff-Y2FjaGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NhY2hlL21lbWNhY2hlZC9NZW1jYWNoZWRNZXRyaWNzLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...ache/kylin/common/BackwardCompatibilityConfig.java](https://codecov.io/gh/apache/kylin/pull/1148/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9CYWNrd2FyZENvbXBhdGliaWxpdHlDb25maWcuamF2YQ==) | `41.81% <ø> (ø)` | `15.00 <0.00> (ø)` | |
| [...main/java/org/apache/kylin/common/KylinConfig.java](https://codecov.io/gh/apache/kylin/pull/1148/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9LeWxpbkNvbmZpZy5qYXZh) | `40.37% <ø> (ø)` | `28.00 <0.00> (ø)` | |
| [.../java/org/apache/kylin/common/KylinConfigBase.java](https://codecov.io/gh/apache/kylin/pull/1148/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9LeWxpbkNvbmZpZ0Jhc2UuamF2YQ==) | `12.26% <ø> (ø)` | `44.00 <0.00> (ø)` | |
| [...ain/java/org/apache/kylin/common/KylinVersion.java](https://codecov.io/gh/apache/kylin/pull/1148/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9LeWxpblZlcnNpb24uamF2YQ==) | `35.06% <ø> (ø)` | `11.00 <0.00> (ø)` | |
| ... and [249 more](https://codecov.io/gh/apache/kylin/pull/1148/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1148?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1148?src=pr&el=footer). Last update [ebc4c26...eb53db5](https://codecov.io/gh/apache/kylin/pull/1148?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] codecov-io edited a comment on issue #1148: KYLIN-4394
Update kylin dependency
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #1148: KYLIN-4394 Update kylin dependency
URL: https://github.com/apache/kylin/pull/1148#issuecomment-596998741
# [Codecov](https://codecov.io/gh/apache/kylin/pull/1148?src=pr&el=h1) Report
> Merging [#1148](https://codecov.io/gh/apache/kylin/pull/1148?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/6745acb9d6c2732261938aebabd801b9bcea3963&el=desc) will **not change** coverage by `%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/kylin/pull/1148?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1148 +/- ##
=========================================
Coverage 25.02% 25.02%
Complexity 6254 6254
=========================================
Files 1449 1449
Lines 88499 88499
Branches 12373 12373
=========================================
Hits 22148 22148
Misses 64177 64177
Partials 2174 2174
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1148?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1148?src=pr&el=footer). Last update [6745acb...f8224c1](https://codecov.io/gh/apache/kylin/pull/1148?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] coveralls edited a comment on issue #1148: KYLIN-4394
Update kylin dependency
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #1148: KYLIN-4394 Update kylin dependency
URL: https://github.com/apache/kylin/pull/1148#issuecomment-597002658
## Pull Request Test Coverage Report for [Build 5755](https://coveralls.io/builds/29296062)
* **11** of **55** **(20.0%)** changed or added relevant lines in **22** files are covered.
* **1** unchanged line in **1** file lost coverage.
* Overall coverage decreased (**-0.001%**) to **27.513%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [core-cube/src/main/java/org/apache/kylin/cube/model/DimensionDesc.java](https://coveralls.io/builds/29296062/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fmodel%2FDimensionDesc.java#L145) | 0 | 1 | 0.0%
| [core-cube/src/main/java/org/apache/kylin/cube/model/RowKeyColDesc.java](https://coveralls.io/builds/29296062/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fmodel%2FRowKeyColDesc.java#L169) | 0 | 1 | 0.0%
| [core-cube/src/main/java/org/apache/kylin/cube/model/RowKeyDesc.java](https://coveralls.io/builds/29296062/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fmodel%2FRowKeyDesc.java#L103) | 0 | 1 | 0.0%
| [core-cube/src/main/java/org/apache/kylin/cube/util/CubingUtils.java](https://coveralls.io/builds/29296062/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Futil%2FCubingUtils.java#L91) | 0 | 1 | 0.0%
| [core-metadata/src/main/java/org/apache/kylin/source/SourcePartition.java](https://coveralls.io/builds/29296062/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fsource%2FSourcePartition.java#L89) | 0 | 1 | 0.0%
| [stream-core/src/main/java/org/apache/kylin/stream/core/query/IStreamingSearchResult.java](https://coveralls.io/builds/29296062/source?filename=stream-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fcore%2Fquery%2FIStreamingSearchResult.java#L38) | 0 | 1 | 0.0%
| [stream-core/src/main/java/org/apache/kylin/stream/core/query/SingleThreadResultCollector.java](https://coveralls.io/builds/29296062/source?filename=stream-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fcore%2Fquery%2FSingleThreadResultCollector.java#L35) | 1 | 2 | 50.0%
| [engine-mr/src/main/java/org/apache/kylin/engine/mr/steps/CalculateStatsFromBaseCuboidMapper.java](https://coveralls.io/builds/29296062/source?filename=engine-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fmr%2Fsteps%2FCalculateStatsFromBaseCuboidMapper.java#L149) | 0 | 2 | 0.0%
| [engine-mr/src/main/java/org/apache/kylin/engine/mr/steps/FactDistinctColumnsMapper.java](https://coveralls.io/builds/29296062/source?filename=engine-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fmr%2Fsteps%2FFactDistinctColumnsMapper.java#L362) | 0 | 2 | 0.0%
| [engine-spark/src/main/java/org/apache/kylin/engine/spark/KylinKryoRegistrator.java](https://coveralls.io/builds/29296062/source?filename=engine-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fspark%2FKylinKryoRegistrator.java#L91) | 0 | 2 | 0.0%
<!-- | **Total:** | **11** | **55** | **20.0%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [storage-stream/src/main/java/org/apache/kylin/storage/stream/rpc/HttpStreamDataSearchClient.java](https://coveralls.io/builds/29296062/source?filename=storage-stream%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstorage%2Fstream%2Frpc%2FHttpStreamDataSearchClient.java#L82) | 1 | 0% |
<!-- | **Total:** | **1** | | -->
| Totals | [](https://coveralls.io/builds/29296062) |
| :-- | --: |
| Change from base [Build 5753](https://coveralls.io/builds/29295116): | -0.001% |
| Covered Lines: | 24295 |
| Relevant Lines: | 88305 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] coveralls edited a comment on issue #1148: KYLIN-4394
Update kylin dependency
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #1148: KYLIN-4394 Update kylin dependency
URL: https://github.com/apache/kylin/pull/1148#issuecomment-597002658
## Pull Request Test Coverage Report for [Build 5740](https://coveralls.io/builds/29266791)
* **11** of **55** **(20.0%)** changed or added relevant lines in **22** files are covered.
* **11** unchanged lines in **5** files lost coverage.
* Overall coverage decreased (**-0.006%**) to **27.513%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [core-cube/src/main/java/org/apache/kylin/cube/model/DimensionDesc.java](https://coveralls.io/builds/29266791/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fmodel%2FDimensionDesc.java#L145) | 0 | 1 | 0.0%
| [core-cube/src/main/java/org/apache/kylin/cube/model/RowKeyColDesc.java](https://coveralls.io/builds/29266791/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fmodel%2FRowKeyColDesc.java#L169) | 0 | 1 | 0.0%
| [core-cube/src/main/java/org/apache/kylin/cube/model/RowKeyDesc.java](https://coveralls.io/builds/29266791/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fmodel%2FRowKeyDesc.java#L103) | 0 | 1 | 0.0%
| [core-cube/src/main/java/org/apache/kylin/cube/util/CubingUtils.java](https://coveralls.io/builds/29266791/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Futil%2FCubingUtils.java#L91) | 0 | 1 | 0.0%
| [core-metadata/src/main/java/org/apache/kylin/source/SourcePartition.java](https://coveralls.io/builds/29266791/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fsource%2FSourcePartition.java#L89) | 0 | 1 | 0.0%
| [stream-core/src/main/java/org/apache/kylin/stream/core/query/IStreamingSearchResult.java](https://coveralls.io/builds/29266791/source?filename=stream-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fcore%2Fquery%2FIStreamingSearchResult.java#L38) | 0 | 1 | 0.0%
| [stream-core/src/main/java/org/apache/kylin/stream/core/query/SingleThreadResultCollector.java](https://coveralls.io/builds/29266791/source?filename=stream-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fcore%2Fquery%2FSingleThreadResultCollector.java#L35) | 1 | 2 | 50.0%
| [engine-mr/src/main/java/org/apache/kylin/engine/mr/steps/CalculateStatsFromBaseCuboidMapper.java](https://coveralls.io/builds/29266791/source?filename=engine-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fmr%2Fsteps%2FCalculateStatsFromBaseCuboidMapper.java#L149) | 0 | 2 | 0.0%
| [engine-mr/src/main/java/org/apache/kylin/engine/mr/steps/FactDistinctColumnsMapper.java](https://coveralls.io/builds/29266791/source?filename=engine-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fmr%2Fsteps%2FFactDistinctColumnsMapper.java#L362) | 0 | 2 | 0.0%
| [engine-spark/src/main/java/org/apache/kylin/engine/spark/KylinKryoRegistrator.java](https://coveralls.io/builds/29266791/source?filename=engine-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fspark%2FKylinKryoRegistrator.java#L91) | 0 | 2 | 0.0%
<!-- | **Total:** | **11** | **55** | **20.0%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [core-dictionary/src/main/java/org/apache/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://coveralls.io/builds/29266791/source?filename=core-dictionary%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fdict%2Flookup%2Fcache%2FRocksDBLookupTable.java#L62) | 1 | 81.08% |
| [storage-stream/src/main/java/org/apache/kylin/storage/stream/rpc/HttpStreamDataSearchClient.java](https://coveralls.io/builds/29266791/source?filename=storage-stream%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstorage%2Fstream%2Frpc%2FHttpStreamDataSearchClient.java#L82) | 1 | 0% |
| [core-cube/src/main/java/org/apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://coveralls.io/builds/29266791/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fcuboid%2FTreeCuboidScheduler.java#L124) | 2 | 68.46% |
| [core-job/src/main/java/org/apache/kylin/job/impl/threadpool/DefaultScheduler.java](https://coveralls.io/builds/29266791/source?filename=core-job%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fjob%2Fimpl%2Fthreadpool%2FDefaultScheduler.java#L194) | 2 | 80.23% |
| [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/29266791/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L439) | 5 | 77.81% |
<!-- | **Total:** | **11** | | -->
| Totals | [](https://coveralls.io/builds/29266791) |
| :-- | --: |
| Change from base [Build 5720](https://coveralls.io/builds/29194855): | -0.006% |
| Covered Lines: | 24295 |
| Relevant Lines: | 88305 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] lgtm-com[bot] commented on issue #1148: KYLIN-4394 Update
kylin dependency
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on issue #1148: KYLIN-4394 Update kylin dependency
URL: https://github.com/apache/kylin/pull/1148#issuecomment-607089540
This pull request **introduces 2 alerts** when merging f8224c1e900a841e1b9ee3b6202e605c51e549a7 into 6745acb9d6c2732261938aebabd801b9bcea3963 - [view on LGTM.com](https://lgtm.com/projects/g/apache/kylin/rev/pr-87a35eb596297961116a3201cfbb8051631fc847)
**new alerts:**
* 2 for Dereferenced variable may be null
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] coveralls edited a comment on issue #1148: KYLIN-4394
Update kylin dependency
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #1148: KYLIN-4394 Update kylin dependency
URL: https://github.com/apache/kylin/pull/1148#issuecomment-597002658
## Pull Request Test Coverage Report for [Build 5741](https://coveralls.io/builds/29267508)
* **11** of **55** **(20.0%)** changed or added relevant lines in **22** files are covered.
* **4** unchanged lines in **3** files lost coverage.
* Overall coverage decreased (**-0.002%**) to **27.516%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [core-cube/src/main/java/org/apache/kylin/cube/model/DimensionDesc.java](https://coveralls.io/builds/29267508/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fmodel%2FDimensionDesc.java#L145) | 0 | 1 | 0.0%
| [core-cube/src/main/java/org/apache/kylin/cube/model/RowKeyColDesc.java](https://coveralls.io/builds/29267508/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fmodel%2FRowKeyColDesc.java#L169) | 0 | 1 | 0.0%
| [core-cube/src/main/java/org/apache/kylin/cube/model/RowKeyDesc.java](https://coveralls.io/builds/29267508/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fmodel%2FRowKeyDesc.java#L103) | 0 | 1 | 0.0%
| [core-cube/src/main/java/org/apache/kylin/cube/util/CubingUtils.java](https://coveralls.io/builds/29267508/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Futil%2FCubingUtils.java#L91) | 0 | 1 | 0.0%
| [core-metadata/src/main/java/org/apache/kylin/source/SourcePartition.java](https://coveralls.io/builds/29267508/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fsource%2FSourcePartition.java#L89) | 0 | 1 | 0.0%
| [stream-core/src/main/java/org/apache/kylin/stream/core/query/IStreamingSearchResult.java](https://coveralls.io/builds/29267508/source?filename=stream-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fcore%2Fquery%2FIStreamingSearchResult.java#L38) | 0 | 1 | 0.0%
| [stream-core/src/main/java/org/apache/kylin/stream/core/query/SingleThreadResultCollector.java](https://coveralls.io/builds/29267508/source?filename=stream-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fcore%2Fquery%2FSingleThreadResultCollector.java#L35) | 1 | 2 | 50.0%
| [engine-mr/src/main/java/org/apache/kylin/engine/mr/steps/CalculateStatsFromBaseCuboidMapper.java](https://coveralls.io/builds/29267508/source?filename=engine-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fmr%2Fsteps%2FCalculateStatsFromBaseCuboidMapper.java#L149) | 0 | 2 | 0.0%
| [engine-mr/src/main/java/org/apache/kylin/engine/mr/steps/FactDistinctColumnsMapper.java](https://coveralls.io/builds/29267508/source?filename=engine-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fmr%2Fsteps%2FFactDistinctColumnsMapper.java#L362) | 0 | 2 | 0.0%
| [engine-spark/src/main/java/org/apache/kylin/engine/spark/KylinKryoRegistrator.java](https://coveralls.io/builds/29267508/source?filename=engine-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fspark%2FKylinKryoRegistrator.java#L91) | 0 | 2 | 0.0%
<!-- | **Total:** | **11** | **55** | **20.0%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [core-dictionary/src/main/java/org/apache/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://coveralls.io/builds/29267508/source?filename=core-dictionary%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fdict%2Flookup%2Fcache%2FRocksDBLookupTable.java#L62) | 1 | 81.08% |
| [storage-stream/src/main/java/org/apache/kylin/storage/stream/rpc/HttpStreamDataSearchClient.java](https://coveralls.io/builds/29267508/source?filename=storage-stream%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstorage%2Fstream%2Frpc%2FHttpStreamDataSearchClient.java#L82) | 1 | 0% |
| [core-cube/src/main/java/org/apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://coveralls.io/builds/29267508/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fcuboid%2FTreeCuboidScheduler.java#L124) | 2 | 68.46% |
<!-- | **Total:** | **4** | | -->
| Totals | [](https://coveralls.io/builds/29267508) |
| :-- | --: |
| Change from base [Build 5720](https://coveralls.io/builds/29194855): | -0.002% |
| Covered Lines: | 24298 |
| Relevant Lines: | 88305 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] codecov-io edited a comment on issue #1148: KYLIN-4394
Update kylin dependency
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #1148: KYLIN-4394 Update kylin dependency
URL: https://github.com/apache/kylin/pull/1148#issuecomment-596998741
# [Codecov](https://codecov.io/gh/apache/kylin/pull/1148?src=pr&el=h1) Report
> Merging [#1148](https://codecov.io/gh/apache/kylin/pull/1148?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/6745acb9d6c2732261938aebabd801b9bcea3963&el=desc) will **not change** coverage by `%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/kylin/pull/1148?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1148 +/- ##
=========================================
Coverage 25.02% 25.02%
Complexity 6253 6253
=========================================
Files 1449 1449
Lines 88499 88499
Branches 12373 12373
=========================================
Hits 22146 22146
Misses 64178 64178
Partials 2175 2175
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1148?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1148?src=pr&el=footer). Last update [6745acb...f8224c1](https://codecov.io/gh/apache/kylin/pull/1148?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] codecov-io edited a comment on issue #1148: KYLIN-4394
Update kylin dependency
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #1148: KYLIN-4394 Update kylin dependency
URL: https://github.com/apache/kylin/pull/1148#issuecomment-596998741
# [Codecov](https://codecov.io/gh/apache/kylin/pull/1148?src=pr&el=h1) Report
> Merging [#1148](https://codecov.io/gh/apache/kylin/pull/1148?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/6745acb9d6c2732261938aebabd801b9bcea3963&el=desc) will **decrease** coverage by `0.00%`.
> The diff coverage is `11.11%`.
[](https://codecov.io/gh/apache/kylin/pull/1148?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1148 +/- ##
============================================
- Coverage 25.01% 25.01% -0.01%
- Complexity 6251 6254 +3
============================================
Files 1449 1449
Lines 88499 88499
Branches 12373 12373
============================================
- Hits 22139 22137 -2
- Misses 64183 64186 +3
+ Partials 2177 2176 -1
```
| [Impacted Files](https://codecov.io/gh/apache/kylin/pull/1148?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../cachemanager/InstrumentedEhCacheCacheManager.java](https://codecov.io/gh/apache/kylin/pull/1148/diff?src=pr&el=tree#diff-Y2FjaGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NhY2hlL2NhY2hlbWFuYWdlci9JbnN0cnVtZW50ZWRFaENhY2hlQ2FjaGVNYW5hZ2VyLmphdmE=) | `57.14% <ø> (ø)` | `5.00 <0.00> (ø)` | |
| [...ylin/cache/cachemanager/MemcachedCacheManager.java](https://codecov.io/gh/apache/kylin/pull/1148/diff?src=pr&el=tree#diff-Y2FjaGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NhY2hlL2NhY2hlbWFuYWdlci9NZW1jYWNoZWRDYWNoZU1hbmFnZXIuamF2YQ==) | `43.33% <ø> (ø)` | `7.00 <0.00> (ø)` | |
| [.../cachemanager/RemoteLocalFailOverCacheManager.java](https://codecov.io/gh/apache/kylin/pull/1148/diff?src=pr&el=tree#diff-Y2FjaGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NhY2hlL2NhY2hlbWFuYWdlci9SZW1vdGVMb2NhbEZhaWxPdmVyQ2FjaGVNYW5hZ2VyLmphdmE=) | `84.61% <ø> (ø)` | `7.00 <0.00> (ø)` | |
| [...g/apache/kylin/cache/memcached/MemcachedCache.java](https://codecov.io/gh/apache/kylin/pull/1148/diff?src=pr&el=tree#diff-Y2FjaGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NhY2hlL21lbWNhY2hlZC9NZW1jYWNoZWRDYWNoZS5qYXZh) | `47.20% <ø> (ø)` | `20.00 <0.00> (ø)` | |
| [.../kylin/cache/memcached/MemcachedChunkingCache.java](https://codecov.io/gh/apache/kylin/pull/1148/diff?src=pr&el=tree#diff-Y2FjaGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NhY2hlL21lbWNhY2hlZC9NZW1jYWNoZWRDaHVua2luZ0NhY2hlLmphdmE=) | `39.70% <ø> (-0.45%)` | `15.00 <0.00> (ø)` | |
| [...apache/kylin/cache/memcached/MemcachedMetrics.java](https://codecov.io/gh/apache/kylin/pull/1148/diff?src=pr&el=tree#diff-Y2FjaGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NhY2hlL21lbWNhY2hlZC9NZW1jYWNoZWRNZXRyaWNzLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...ache/kylin/common/BackwardCompatibilityConfig.java](https://codecov.io/gh/apache/kylin/pull/1148/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9CYWNrd2FyZENvbXBhdGliaWxpdHlDb25maWcuamF2YQ==) | `41.81% <ø> (ø)` | `15.00 <0.00> (ø)` | |
| [...main/java/org/apache/kylin/common/KylinConfig.java](https://codecov.io/gh/apache/kylin/pull/1148/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9LeWxpbkNvbmZpZy5qYXZh) | `40.37% <ø> (ø)` | `28.00 <0.00> (ø)` | |
| [.../java/org/apache/kylin/common/KylinConfigBase.java](https://codecov.io/gh/apache/kylin/pull/1148/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9LeWxpbkNvbmZpZ0Jhc2UuamF2YQ==) | `12.26% <ø> (ø)` | `44.00 <0.00> (ø)` | |
| [...ain/java/org/apache/kylin/common/KylinVersion.java](https://codecov.io/gh/apache/kylin/pull/1148/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9LeWxpblZlcnNpb24uamF2YQ==) | `35.06% <ø> (ø)` | `11.00 <0.00> (ø)` | |
| ... and [250 more](https://codecov.io/gh/apache/kylin/pull/1148/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1148?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1148?src=pr&el=footer). Last update [6745acb...f8224c1](https://codecov.io/gh/apache/kylin/pull/1148?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] coveralls commented on issue #1148: KYLIN-4394 Update kylin
dependency
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #1148: KYLIN-4394 Update kylin dependency
URL: https://github.com/apache/kylin/pull/1148#issuecomment-597002658
## Pull Request Test Coverage Report for [Build 5734](https://coveralls.io/builds/29245070)
* **11** of **55** **(20.0%)** changed or added relevant lines in **22** files are covered.
* **5** unchanged lines in **3** files lost coverage.
* Overall coverage decreased (**-0.006%**) to **27.513%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [core-cube/src/main/java/org/apache/kylin/cube/model/DimensionDesc.java](https://coveralls.io/builds/29245070/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fmodel%2FDimensionDesc.java#L145) | 0 | 1 | 0.0%
| [core-cube/src/main/java/org/apache/kylin/cube/model/RowKeyColDesc.java](https://coveralls.io/builds/29245070/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fmodel%2FRowKeyColDesc.java#L169) | 0 | 1 | 0.0%
| [core-cube/src/main/java/org/apache/kylin/cube/model/RowKeyDesc.java](https://coveralls.io/builds/29245070/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fmodel%2FRowKeyDesc.java#L103) | 0 | 1 | 0.0%
| [core-cube/src/main/java/org/apache/kylin/cube/util/CubingUtils.java](https://coveralls.io/builds/29245070/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Futil%2FCubingUtils.java#L91) | 0 | 1 | 0.0%
| [core-metadata/src/main/java/org/apache/kylin/source/SourcePartition.java](https://coveralls.io/builds/29245070/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fsource%2FSourcePartition.java#L89) | 0 | 1 | 0.0%
| [stream-core/src/main/java/org/apache/kylin/stream/core/query/IStreamingSearchResult.java](https://coveralls.io/builds/29245070/source?filename=stream-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fcore%2Fquery%2FIStreamingSearchResult.java#L38) | 0 | 1 | 0.0%
| [stream-core/src/main/java/org/apache/kylin/stream/core/query/SingleThreadResultCollector.java](https://coveralls.io/builds/29245070/source?filename=stream-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fcore%2Fquery%2FSingleThreadResultCollector.java#L35) | 1 | 2 | 50.0%
| [engine-mr/src/main/java/org/apache/kylin/engine/mr/steps/CalculateStatsFromBaseCuboidMapper.java](https://coveralls.io/builds/29245070/source?filename=engine-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fmr%2Fsteps%2FCalculateStatsFromBaseCuboidMapper.java#L149) | 0 | 2 | 0.0%
| [engine-mr/src/main/java/org/apache/kylin/engine/mr/steps/FactDistinctColumnsMapper.java](https://coveralls.io/builds/29245070/source?filename=engine-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fmr%2Fsteps%2FFactDistinctColumnsMapper.java#L362) | 0 | 2 | 0.0%
| [engine-spark/src/main/java/org/apache/kylin/engine/spark/KylinKryoRegistrator.java](https://coveralls.io/builds/29245070/source?filename=engine-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fspark%2FKylinKryoRegistrator.java#L91) | 0 | 2 | 0.0%
<!-- | **Total:** | **11** | **55** | **20.0%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [storage-stream/src/main/java/org/apache/kylin/storage/stream/rpc/HttpStreamDataSearchClient.java](https://coveralls.io/builds/29245070/source?filename=storage-stream%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstorage%2Fstream%2Frpc%2FHttpStreamDataSearchClient.java#L82) | 1 | 0% |
| [core-cube/src/main/java/org/apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://coveralls.io/builds/29245070/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fcuboid%2FTreeCuboidScheduler.java#L124) | 2 | 68.46% |
| [core-job/src/main/java/org/apache/kylin/job/impl/threadpool/DefaultScheduler.java](https://coveralls.io/builds/29245070/source?filename=core-job%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fjob%2Fimpl%2Fthreadpool%2FDefaultScheduler.java#L194) | 2 | 80.23% |
<!-- | **Total:** | **5** | | -->
| Totals | [](https://coveralls.io/builds/29245070) |
| :-- | --: |
| Change from base [Build 5720](https://coveralls.io/builds/29194855): | -0.006% |
| Covered Lines: | 24295 |
| Relevant Lines: | 88305 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] codecov-io edited a comment on issue #1148: KYLIN-4394
Update kylin dependency
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #1148: KYLIN-4394 Update kylin dependency
URL: https://github.com/apache/kylin/pull/1148#issuecomment-596998741
# [Codecov](https://codecov.io/gh/apache/kylin/pull/1148?src=pr&el=h1) Report
> Merging [#1148](https://codecov.io/gh/apache/kylin/pull/1148?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/ebc4c267b56833475881fb482b1467fbe8367df1&el=desc) will **increase** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/kylin/pull/1148?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1148 +/- ##
=========================================
Coverage 25.05% 25.06%
Complexity 6248 6248
=========================================
Files 1446 1446
Lines 88305 88305
Branches 12357 12357
=========================================
+ Hits 22128 22131 +3
+ Misses 64007 64004 -3
Partials 2170 2170
```
| [Impacted Files](https://codecov.io/gh/apache/kylin/pull/1148?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/1148/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh) | `71.12% <0.00%> (+0.91%)` | `7.00% <0.00%> (ø%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1148?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1148?src=pr&el=footer). Last update [ebc4c26...f10d885](https://codecov.io/gh/apache/kylin/pull/1148?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] codecov-io edited a comment on issue #1148: KYLIN-4394
Update kylin dependency
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #1148: KYLIN-4394 Update kylin dependency
URL: https://github.com/apache/kylin/pull/1148#issuecomment-596998741
# [Codecov](https://codecov.io/gh/apache/kylin/pull/1148?src=pr&el=h1) Report
> Merging [#1148](https://codecov.io/gh/apache/kylin/pull/1148?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/ebc4c267b56833475881fb482b1467fbe8367df1?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/kylin/pull/1148?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1148 +/- ##
============================================
+ Coverage 25.05% 25.06% +<.01%
Complexity 6248 6248
============================================
Files 1446 1446
Lines 88305 88305
Branches 12357 12357
============================================
+ Hits 22128 22131 +3
+ Misses 64007 64004 -3
Partials 2170 2170
```
| [Impacted Files](https://codecov.io/gh/apache/kylin/pull/1148?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/1148/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh) | `71.12% <0%> (+0.91%)` | `7% <0%> (ø)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1148?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1148?src=pr&el=footer). Last update [ebc4c26...f10d885](https://codecov.io/gh/apache/kylin/pull/1148?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] codecov-io edited a comment on issue #1148: KYLIN-4394
Update kylin dependency
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #1148: KYLIN-4394 Update kylin dependency
URL: https://github.com/apache/kylin/pull/1148#issuecomment-596998741
# [Codecov](https://codecov.io/gh/apache/kylin/pull/1148?src=pr&el=h1) Report
> Merging [#1148](https://codecov.io/gh/apache/kylin/pull/1148?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/ebc4c267b56833475881fb482b1467fbe8367df1?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `11.11%`.
[](https://codecov.io/gh/apache/kylin/pull/1148?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1148 +/- ##
============================================
- Coverage 25.05% 25.04% -0.01%
+ Complexity 6248 6247 -1
============================================
Files 1446 1446
Lines 88305 88305
Branches 12357 12357
============================================
- Hits 22128 22120 -8
- Misses 64007 64013 +6
- Partials 2170 2172 +2
```
| [Impacted Files](https://codecov.io/gh/apache/kylin/pull/1148?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...org/apache/kylin/storage/gtrecord/PeekingImpl.java](https://codecov.io/gh/apache/kylin/pull/1148/diff?src=pr&el=tree#diff-Y29yZS1zdG9yYWdlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9zdG9yYWdlL2d0cmVjb3JkL1BlZWtpbmdJbXBsLmphdmE=) | `76.47% <ø> (ø)` | `7 <0> (ø)` | :arrow_down: |
| [.../apache/kylin/metadata/model/DataModelManager.java](https://codecov.io/gh/apache/kylin/pull/1148/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWV0YWRhdGEvbW9kZWwvRGF0YU1vZGVsTWFuYWdlci5qYXZh) | `30.7% <ø> (ø)` | `11 <0> (ø)` | :arrow_down: |
| [...org/apache/kylin/gridtable/GTAggregateScanner.java](https://codecov.io/gh/apache/kylin/pull/1148/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9ncmlkdGFibGUvR1RBZ2dyZWdhdGVTY2FubmVyLmphdmE=) | `33.66% <ø> (ø)` | `12 <0> (ø)` | :arrow_down: |
| [...a/org/apache/kylin/common/util/ValueIterators.java](https://codecov.io/gh/apache/kylin/pull/1148/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi91dGlsL1ZhbHVlSXRlcmF0b3JzLmphdmE=) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...va/org/apache/kylin/common/QueryContextFacade.java](https://codecov.io/gh/apache/kylin/pull/1148/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9RdWVyeUNvbnRleHRGYWNhZGUuamF2YQ==) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...pache/kylin/source/datagen/ModelDataGenerator.java](https://codecov.io/gh/apache/kylin/pull/1148/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc291cmNlL2RhdGFnZW4vTW9kZWxEYXRhR2VuZXJhdG9yLmphdmE=) | `89.3% <ø> (ø)` | `53 <0> (ø)` | :arrow_down: |
| [...a/org/apache/kylin/common/util/HiveCmdBuilder.java](https://codecov.io/gh/apache/kylin/pull/1148/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi91dGlsL0hpdmVDbWRCdWlsZGVyLmphdmE=) | `82.05% <ø> (ø)` | `14 <0> (ø)` | :arrow_down: |
| [...n/java/org/apache/kylin/job/dao/ExecutableDao.java](https://codecov.io/gh/apache/kylin/pull/1148/diff?src=pr&el=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9kYW8vRXhlY3V0YWJsZURhby5qYXZh) | `26.47% <ø> (ø)` | `24 <0> (ø)` | :arrow_down: |
| [...ache/kylin/common/BackwardCompatibilityConfig.java](https://codecov.io/gh/apache/kylin/pull/1148/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9CYWNrd2FyZENvbXBhdGliaWxpdHlDb25maWcuamF2YQ==) | `41.81% <ø> (ø)` | `15 <0> (ø)` | :arrow_down: |
| [...ache/kylin/common/util/MemoryBudgetController.java](https://codecov.io/gh/apache/kylin/pull/1148/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi91dGlsL01lbW9yeUJ1ZGdldENvbnRyb2xsZXIuamF2YQ==) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| ... and [248 more](https://codecov.io/gh/apache/kylin/pull/1148/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1148?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1148?src=pr&el=footer). Last update [ebc4c26...3b6d475](https://codecov.io/gh/apache/kylin/pull/1148?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] codecov-io edited a comment on issue #1148: KYLIN-4394
Update kylin dependency
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #1148: KYLIN-4394 Update kylin dependency
URL: https://github.com/apache/kylin/pull/1148#issuecomment-596998741
# [Codecov](https://codecov.io/gh/apache/kylin/pull/1148?src=pr&el=h1) Report
> Merging [#1148](https://codecov.io/gh/apache/kylin/pull/1148?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/ebc4c267b56833475881fb482b1467fbe8367df1?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `11.11%`.
[](https://codecov.io/gh/apache/kylin/pull/1148?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1148 +/- ##
============================================
- Coverage 25.05% 25.04% -0.01%
+ Complexity 6248 6247 -1
============================================
Files 1446 1446
Lines 88305 88305
Branches 12357 12357
============================================
- Hits 22128 22120 -8
- Misses 64007 64013 +6
- Partials 2170 2172 +2
```
| [Impacted Files](https://codecov.io/gh/apache/kylin/pull/1148?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...org/apache/kylin/storage/gtrecord/PeekingImpl.java](https://codecov.io/gh/apache/kylin/pull/1148/diff?src=pr&el=tree#diff-Y29yZS1zdG9yYWdlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9zdG9yYWdlL2d0cmVjb3JkL1BlZWtpbmdJbXBsLmphdmE=) | `76.47% <ø> (ø)` | `7 <0> (ø)` | :arrow_down: |
| [.../apache/kylin/metadata/model/DataModelManager.java](https://codecov.io/gh/apache/kylin/pull/1148/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWV0YWRhdGEvbW9kZWwvRGF0YU1vZGVsTWFuYWdlci5qYXZh) | `30.7% <ø> (ø)` | `11 <0> (ø)` | :arrow_down: |
| [...org/apache/kylin/gridtable/GTAggregateScanner.java](https://codecov.io/gh/apache/kylin/pull/1148/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9ncmlkdGFibGUvR1RBZ2dyZWdhdGVTY2FubmVyLmphdmE=) | `33.66% <ø> (ø)` | `12 <0> (ø)` | :arrow_down: |
| [...a/org/apache/kylin/common/util/ValueIterators.java](https://codecov.io/gh/apache/kylin/pull/1148/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi91dGlsL1ZhbHVlSXRlcmF0b3JzLmphdmE=) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...va/org/apache/kylin/common/QueryContextFacade.java](https://codecov.io/gh/apache/kylin/pull/1148/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9RdWVyeUNvbnRleHRGYWNhZGUuamF2YQ==) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...pache/kylin/source/datagen/ModelDataGenerator.java](https://codecov.io/gh/apache/kylin/pull/1148/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc291cmNlL2RhdGFnZW4vTW9kZWxEYXRhR2VuZXJhdG9yLmphdmE=) | `89.3% <ø> (ø)` | `53 <0> (ø)` | :arrow_down: |
| [...a/org/apache/kylin/common/util/HiveCmdBuilder.java](https://codecov.io/gh/apache/kylin/pull/1148/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi91dGlsL0hpdmVDbWRCdWlsZGVyLmphdmE=) | `82.05% <ø> (ø)` | `14 <0> (ø)` | :arrow_down: |
| [...n/java/org/apache/kylin/job/dao/ExecutableDao.java](https://codecov.io/gh/apache/kylin/pull/1148/diff?src=pr&el=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9kYW8vRXhlY3V0YWJsZURhby5qYXZh) | `26.47% <ø> (ø)` | `24 <0> (ø)` | :arrow_down: |
| [...ache/kylin/common/BackwardCompatibilityConfig.java](https://codecov.io/gh/apache/kylin/pull/1148/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9CYWNrd2FyZENvbXBhdGliaWxpdHlDb25maWcuamF2YQ==) | `41.81% <ø> (ø)` | `15 <0> (ø)` | :arrow_down: |
| [...ache/kylin/common/util/MemoryBudgetController.java](https://codecov.io/gh/apache/kylin/pull/1148/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi91dGlsL01lbW9yeUJ1ZGdldENvbnRyb2xsZXIuamF2YQ==) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| ... and [248 more](https://codecov.io/gh/apache/kylin/pull/1148/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1148?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1148?src=pr&el=footer). Last update [ebc4c26...97860da](https://codecov.io/gh/apache/kylin/pull/1148?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] codecov-io edited a comment on issue #1148: KYLIN-4394
Update kylin dependency
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #1148: KYLIN-4394 Update kylin dependency
URL: https://github.com/apache/kylin/pull/1148#issuecomment-596998741
# [Codecov](https://codecov.io/gh/apache/kylin/pull/1148?src=pr&el=h1) Report
> Merging [#1148](https://codecov.io/gh/apache/kylin/pull/1148?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/ebc4c267b56833475881fb482b1467fbe8367df1&el=desc) will **increase** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/kylin/pull/1148?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1148 +/- ##
=========================================
Coverage 25.05% 25.06%
Complexity 6248 6248
=========================================
Files 1446 1446
Lines 88305 88305
Branches 12357 12357
=========================================
+ Hits 22128 22131 +3
+ Misses 64007 64004 -3
Partials 2170 2170
```
| [Impacted Files](https://codecov.io/gh/apache/kylin/pull/1148?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/1148/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh) | `71.12% <0.00%> (+0.91%)` | `7.00% <0.00%> (ø%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1148?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1148?src=pr&el=footer). Last update [ebc4c26...f10d885](https://codecov.io/gh/apache/kylin/pull/1148?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] codecov-io edited a comment on issue #1148: KYLIN-4394
Update kylin dependency
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #1148: KYLIN-4394 Update kylin dependency
URL: https://github.com/apache/kylin/pull/1148#issuecomment-596998741
# [Codecov](https://codecov.io/gh/apache/kylin/pull/1148?src=pr&el=h1) Report
> Merging [#1148](https://codecov.io/gh/apache/kylin/pull/1148?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/ebc4c267b56833475881fb482b1467fbe8367df1?src=pr&el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `11.11%`.
[](https://codecov.io/gh/apache/kylin/pull/1148?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1148 +/- ##
============================================
- Coverage 25.05% 25.04% -0.02%
+ Complexity 6248 6247 -1
============================================
Files 1446 1446
Lines 88305 88305
Branches 12357 12357
============================================
- Hits 22128 22119 -9
- Misses 64007 64013 +6
- Partials 2170 2173 +3
```
| [Impacted Files](https://codecov.io/gh/apache/kylin/pull/1148?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...org/apache/kylin/storage/gtrecord/PeekingImpl.java](https://codecov.io/gh/apache/kylin/pull/1148/diff?src=pr&el=tree#diff-Y29yZS1zdG9yYWdlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9zdG9yYWdlL2d0cmVjb3JkL1BlZWtpbmdJbXBsLmphdmE=) | `76.47% <ø> (ø)` | `7 <0> (ø)` | :arrow_down: |
| [.../apache/kylin/metadata/model/DataModelManager.java](https://codecov.io/gh/apache/kylin/pull/1148/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWV0YWRhdGEvbW9kZWwvRGF0YU1vZGVsTWFuYWdlci5qYXZh) | `30.7% <ø> (ø)` | `11 <0> (ø)` | :arrow_down: |
| [...org/apache/kylin/gridtable/GTAggregateScanner.java](https://codecov.io/gh/apache/kylin/pull/1148/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9ncmlkdGFibGUvR1RBZ2dyZWdhdGVTY2FubmVyLmphdmE=) | `33.66% <ø> (ø)` | `12 <0> (ø)` | :arrow_down: |
| [...a/org/apache/kylin/common/util/ValueIterators.java](https://codecov.io/gh/apache/kylin/pull/1148/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi91dGlsL1ZhbHVlSXRlcmF0b3JzLmphdmE=) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...va/org/apache/kylin/common/QueryContextFacade.java](https://codecov.io/gh/apache/kylin/pull/1148/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9RdWVyeUNvbnRleHRGYWNhZGUuamF2YQ==) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...pache/kylin/source/datagen/ModelDataGenerator.java](https://codecov.io/gh/apache/kylin/pull/1148/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc291cmNlL2RhdGFnZW4vTW9kZWxEYXRhR2VuZXJhdG9yLmphdmE=) | `89.3% <ø> (ø)` | `53 <0> (ø)` | :arrow_down: |
| [...a/org/apache/kylin/common/util/HiveCmdBuilder.java](https://codecov.io/gh/apache/kylin/pull/1148/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi91dGlsL0hpdmVDbWRCdWlsZGVyLmphdmE=) | `82.05% <ø> (ø)` | `14 <0> (ø)` | :arrow_down: |
| [...n/java/org/apache/kylin/job/dao/ExecutableDao.java](https://codecov.io/gh/apache/kylin/pull/1148/diff?src=pr&el=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9kYW8vRXhlY3V0YWJsZURhby5qYXZh) | `26.47% <ø> (ø)` | `24 <0> (ø)` | :arrow_down: |
| [...ache/kylin/common/BackwardCompatibilityConfig.java](https://codecov.io/gh/apache/kylin/pull/1148/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9CYWNrd2FyZENvbXBhdGliaWxpdHlDb25maWcuamF2YQ==) | `41.81% <ø> (ø)` | `15 <0> (ø)` | :arrow_down: |
| [...ache/kylin/common/util/MemoryBudgetController.java](https://codecov.io/gh/apache/kylin/pull/1148/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi91dGlsL01lbW9yeUJ1ZGdldENvbnRyb2xsZXIuamF2YQ==) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| ... and [248 more](https://codecov.io/gh/apache/kylin/pull/1148/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1148?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1148?src=pr&el=footer). Last update [ebc4c26...a6a12e4](https://codecov.io/gh/apache/kylin/pull/1148?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] coveralls edited a comment on issue #1148: KYLIN-4394
Update kylin dependency
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #1148: KYLIN-4394 Update kylin dependency
URL: https://github.com/apache/kylin/pull/1148#issuecomment-597002658
## Pull Request Test Coverage Report for [Build 5760](https://coveralls.io/builds/29303906)
* **11** of **55** **(20.0%)** changed or added relevant lines in **22** files are covered.
* **5** unchanged lines in **3** files lost coverage.
* Overall coverage decreased (**-0.003%**) to **27.51%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [core-cube/src/main/java/org/apache/kylin/cube/model/DimensionDesc.java](https://coveralls.io/builds/29303906/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fmodel%2FDimensionDesc.java#L145) | 0 | 1 | 0.0%
| [core-cube/src/main/java/org/apache/kylin/cube/model/RowKeyColDesc.java](https://coveralls.io/builds/29303906/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fmodel%2FRowKeyColDesc.java#L169) | 0 | 1 | 0.0%
| [core-cube/src/main/java/org/apache/kylin/cube/model/RowKeyDesc.java](https://coveralls.io/builds/29303906/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fmodel%2FRowKeyDesc.java#L103) | 0 | 1 | 0.0%
| [core-cube/src/main/java/org/apache/kylin/cube/util/CubingUtils.java](https://coveralls.io/builds/29303906/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Futil%2FCubingUtils.java#L91) | 0 | 1 | 0.0%
| [core-metadata/src/main/java/org/apache/kylin/source/SourcePartition.java](https://coveralls.io/builds/29303906/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fsource%2FSourcePartition.java#L89) | 0 | 1 | 0.0%
| [stream-core/src/main/java/org/apache/kylin/stream/core/query/IStreamingSearchResult.java](https://coveralls.io/builds/29303906/source?filename=stream-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fcore%2Fquery%2FIStreamingSearchResult.java#L38) | 0 | 1 | 0.0%
| [stream-core/src/main/java/org/apache/kylin/stream/core/query/SingleThreadResultCollector.java](https://coveralls.io/builds/29303906/source?filename=stream-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fcore%2Fquery%2FSingleThreadResultCollector.java#L35) | 1 | 2 | 50.0%
| [engine-mr/src/main/java/org/apache/kylin/engine/mr/steps/CalculateStatsFromBaseCuboidMapper.java](https://coveralls.io/builds/29303906/source?filename=engine-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fmr%2Fsteps%2FCalculateStatsFromBaseCuboidMapper.java#L149) | 0 | 2 | 0.0%
| [engine-mr/src/main/java/org/apache/kylin/engine/mr/steps/FactDistinctColumnsMapper.java](https://coveralls.io/builds/29303906/source?filename=engine-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fmr%2Fsteps%2FFactDistinctColumnsMapper.java#L362) | 0 | 2 | 0.0%
| [engine-spark/src/main/java/org/apache/kylin/engine/spark/KylinKryoRegistrator.java](https://coveralls.io/builds/29303906/source?filename=engine-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fspark%2FKylinKryoRegistrator.java#L91) | 0 | 2 | 0.0%
<!-- | **Total:** | **11** | **55** | **20.0%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [storage-stream/src/main/java/org/apache/kylin/storage/stream/rpc/HttpStreamDataSearchClient.java](https://coveralls.io/builds/29303906/source?filename=storage-stream%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstorage%2Fstream%2Frpc%2FHttpStreamDataSearchClient.java#L82) | 1 | 0% |
| [core-cube/src/main/java/org/apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://coveralls.io/builds/29303906/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fcuboid%2FTreeCuboidScheduler.java#L124) | 2 | 68.46% |
| [core-job/src/main/java/org/apache/kylin/job/impl/threadpool/DefaultScheduler.java](https://coveralls.io/builds/29303906/source?filename=core-job%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fjob%2Fimpl%2Fthreadpool%2FDefaultScheduler.java#L194) | 2 | 80.23% |
<!-- | **Total:** | **5** | | -->
| Totals | [](https://coveralls.io/builds/29303906) |
| :-- | --: |
| Change from base [Build 5753](https://coveralls.io/builds/29295116): | -0.003% |
| Covered Lines: | 24293 |
| Relevant Lines: | 88305 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] codecov-io commented on issue #1148: KYLIN-4394 Update
kylin dependency
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #1148: KYLIN-4394 Update kylin dependency
URL: https://github.com/apache/kylin/pull/1148#issuecomment-596998741
# [Codecov](https://codecov.io/gh/apache/kylin/pull/1148?src=pr&el=h1) Report
> Merging [#1148](https://codecov.io/gh/apache/kylin/pull/1148?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/ebc4c267b56833475881fb482b1467fbe8367df1?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `11.11%`.
[](https://codecov.io/gh/apache/kylin/pull/1148?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1148 +/- ##
============================================
- Coverage 25.05% 25.04% -0.01%
Complexity 6248 6248
============================================
Files 1446 1446
Lines 88305 88305
Branches 12357 12357
============================================
- Hits 22128 22120 -8
- Misses 64007 64013 +6
- Partials 2170 2172 +2
```
| [Impacted Files](https://codecov.io/gh/apache/kylin/pull/1148?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...org/apache/kylin/storage/gtrecord/PeekingImpl.java](https://codecov.io/gh/apache/kylin/pull/1148/diff?src=pr&el=tree#diff-Y29yZS1zdG9yYWdlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9zdG9yYWdlL2d0cmVjb3JkL1BlZWtpbmdJbXBsLmphdmE=) | `76.47% <ø> (ø)` | `7 <0> (ø)` | :arrow_down: |
| [.../apache/kylin/metadata/model/DataModelManager.java](https://codecov.io/gh/apache/kylin/pull/1148/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWV0YWRhdGEvbW9kZWwvRGF0YU1vZGVsTWFuYWdlci5qYXZh) | `30.7% <ø> (ø)` | `11 <0> (ø)` | :arrow_down: |
| [...org/apache/kylin/gridtable/GTAggregateScanner.java](https://codecov.io/gh/apache/kylin/pull/1148/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9ncmlkdGFibGUvR1RBZ2dyZWdhdGVTY2FubmVyLmphdmE=) | `33.66% <ø> (ø)` | `12 <0> (ø)` | :arrow_down: |
| [...a/org/apache/kylin/common/util/ValueIterators.java](https://codecov.io/gh/apache/kylin/pull/1148/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi91dGlsL1ZhbHVlSXRlcmF0b3JzLmphdmE=) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...va/org/apache/kylin/common/QueryContextFacade.java](https://codecov.io/gh/apache/kylin/pull/1148/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9RdWVyeUNvbnRleHRGYWNhZGUuamF2YQ==) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...pache/kylin/source/datagen/ModelDataGenerator.java](https://codecov.io/gh/apache/kylin/pull/1148/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc291cmNlL2RhdGFnZW4vTW9kZWxEYXRhR2VuZXJhdG9yLmphdmE=) | `89.3% <ø> (ø)` | `53 <0> (ø)` | :arrow_down: |
| [...a/org/apache/kylin/common/util/HiveCmdBuilder.java](https://codecov.io/gh/apache/kylin/pull/1148/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi91dGlsL0hpdmVDbWRCdWlsZGVyLmphdmE=) | `82.05% <ø> (ø)` | `14 <0> (ø)` | :arrow_down: |
| [...n/java/org/apache/kylin/job/dao/ExecutableDao.java](https://codecov.io/gh/apache/kylin/pull/1148/diff?src=pr&el=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9kYW8vRXhlY3V0YWJsZURhby5qYXZh) | `26.47% <ø> (ø)` | `24 <0> (ø)` | :arrow_down: |
| [...ache/kylin/common/BackwardCompatibilityConfig.java](https://codecov.io/gh/apache/kylin/pull/1148/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9CYWNrd2FyZENvbXBhdGliaWxpdHlDb25maWcuamF2YQ==) | `41.81% <ø> (ø)` | `15 <0> (ø)` | :arrow_down: |
| [...ache/kylin/common/util/MemoryBudgetController.java](https://codecov.io/gh/apache/kylin/pull/1148/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi91dGlsL01lbW9yeUJ1ZGdldENvbnRyb2xsZXIuamF2YQ==) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| ... and [248 more](https://codecov.io/gh/apache/kylin/pull/1148/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1148?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1148?src=pr&el=footer). Last update [ebc4c26...2770430](https://codecov.io/gh/apache/kylin/pull/1148?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] lgtm-com[bot] commented on issue #1148: KYLIN-4394 Update
kylin dependency
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on issue #1148: KYLIN-4394 Update kylin dependency
URL: https://github.com/apache/kylin/pull/1148#issuecomment-598296626
This pull request **introduces 2 alerts** when merging f10d88595c217256c245b37003c8e21393dc5a62 into b61d4989a842c06f993e9a3df75262c764972589 - [view on LGTM.com](https://lgtm.com/projects/g/apache/kylin/rev/pr-0b7addda2472ec8efe8c76d7b9d2b215f37a0587)
**new alerts:**
* 2 for Dereferenced variable may be null
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] coveralls edited a comment on issue #1148: KYLIN-4394
Update kylin dependency
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #1148: KYLIN-4394 Update kylin dependency
URL: https://github.com/apache/kylin/pull/1148#issuecomment-597002658
## Pull Request Test Coverage Report for [Build 5801](https://coveralls.io/builds/29761678)
* **11** of **55** **(20.0%)** changed or added relevant lines in **22** files are covered.
* **8** unchanged lines in **3** files lost coverage.
* Overall coverage decreased (**-0.003%**) to **27.476%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [core-cube/src/main/java/org/apache/kylin/cube/model/DimensionDesc.java](https://coveralls.io/builds/29761678/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fmodel%2FDimensionDesc.java#L145) | 0 | 1 | 0.0%
| [core-cube/src/main/java/org/apache/kylin/cube/model/RowKeyColDesc.java](https://coveralls.io/builds/29761678/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fmodel%2FRowKeyColDesc.java#L169) | 0 | 1 | 0.0%
| [core-cube/src/main/java/org/apache/kylin/cube/model/RowKeyDesc.java](https://coveralls.io/builds/29761678/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fmodel%2FRowKeyDesc.java#L103) | 0 | 1 | 0.0%
| [core-cube/src/main/java/org/apache/kylin/cube/util/CubingUtils.java](https://coveralls.io/builds/29761678/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Futil%2FCubingUtils.java#L90) | 0 | 1 | 0.0%
| [core-metadata/src/main/java/org/apache/kylin/source/SourcePartition.java](https://coveralls.io/builds/29761678/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fsource%2FSourcePartition.java#L89) | 0 | 1 | 0.0%
| [stream-core/src/main/java/org/apache/kylin/stream/core/query/IStreamingSearchResult.java](https://coveralls.io/builds/29761678/source?filename=stream-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fcore%2Fquery%2FIStreamingSearchResult.java#L38) | 0 | 1 | 0.0%
| [stream-core/src/main/java/org/apache/kylin/stream/core/query/SingleThreadResultCollector.java](https://coveralls.io/builds/29761678/source?filename=stream-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fcore%2Fquery%2FSingleThreadResultCollector.java#L35) | 1 | 2 | 50.0%
| [engine-mr/src/main/java/org/apache/kylin/engine/mr/steps/CalculateStatsFromBaseCuboidMapper.java](https://coveralls.io/builds/29761678/source?filename=engine-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fmr%2Fsteps%2FCalculateStatsFromBaseCuboidMapper.java#L148) | 0 | 2 | 0.0%
| [engine-mr/src/main/java/org/apache/kylin/engine/mr/steps/FactDistinctColumnsMapper.java](https://coveralls.io/builds/29761678/source?filename=engine-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fmr%2Fsteps%2FFactDistinctColumnsMapper.java#L361) | 0 | 2 | 0.0%
| [engine-spark/src/main/java/org/apache/kylin/engine/spark/KylinKryoRegistrator.java](https://coveralls.io/builds/29761678/source?filename=engine-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fspark%2FKylinKryoRegistrator.java#L91) | 0 | 2 | 0.0%
<!-- | **Total:** | **11** | **55** | **20.0%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [storage-stream/src/main/java/org/apache/kylin/storage/stream/rpc/HttpStreamDataSearchClient.java](https://coveralls.io/builds/29761678/source?filename=storage-stream%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstorage%2Fstream%2Frpc%2FHttpStreamDataSearchClient.java#L82) | 1 | 0% |
| [stream-core/src/main/java/org/apache/kylin/stream/core/storage/columnar/ColumnarStoreCache.java](https://coveralls.io/builds/29761678/source?filename=stream-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fcore%2Fstorage%2Fcolumnar%2FColumnarStoreCache.java#L80) | 2 | 57.95% |
| [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/29761678/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L439) | 5 | 77.81% |
<!-- | **Total:** | **8** | | -->
| Totals | [](https://coveralls.io/builds/29761678) |
| :-- | --: |
| Change from base [Build 5800](https://coveralls.io/builds/29743165): | -0.003% |
| Covered Lines: | 24316 |
| Relevant Lines: | 88499 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services