You are viewing a plain text version of this content. The canonical link for it is here.
Posted to log4j-dev@logging.apache.org by Christian Grobmeier <gr...@gmail.com> on 2013/05/04 12:14:28 UTC
[VOTE] Release apache-log4j-extras-1.2 RC1
Dear all,
this is a vote for a new Apache Companions package.
Please note: it's the first release since 2010. It's far from routine.
Changes:
- all companions have been merged into the extras companion
- pom does inherit from parent pom
- testoutput now goes to /target
- ant build has been removed
- makes now use of Maven 3
The website can be found here:
* http://people.apache.org/~grobmeier/log4j-companions/
Note: I might need to update the path for the download.
Artifacts for Maven:
* https://repository.apache.org/content/repositories/orgapachelogging-175/
They can be downloaded with:
wget -e robots=off --cut-dirs=3 -r -p -np --no-check-certificate
https://repository.apache.org/content/repositories/orgapachelogging-175/
Artifacts for the website and for the ASF dist svn:
* http://people.apache.org/~grobmeier/log4j-companions-artefacts/
SVN tag:
* http://svn.apache.org/repos/asf/logging/log4j/companions/extras/tags/apache-log4j-extras-1.2/
Please cast your vote:
[ ] +1
[ ] -1, because...
Vote will be open for the usual 72 hours at least.
Thanks,
Christian
---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org
Re: [VOTE] Release apache-log4j-extras-1.2 RC1
Posted by Christian Grobmeier <gr...@gmail.com>.
I have just compare all files I found duplicated.
These two have additional functionality:
FormattingInfo.java
PatternParser.java
Its just minor things, like adding of padding. I copied the features
over to log4j. If I remove these classes right now, extras would
depend on a snapshot which is not good. My idea was to rename these
two classes and mark them deprecated. Still breaking is you urgently
need these features but they are most likely not used often and I
would take this risk.
Comments?
The other files could be deleted. In some cases the docs were
different, I have them in my log4j-trunk and will commit it too.
UnrecognizedElementHandler
EnhancedPatternLayout
LogSF
LogXF
LogMF
BridgePatternConverter.java
BridgePatternParser.java
CachedDateFormat.java
ClassNamePatternConverter.java
DatePatternConverter.java --> lost unnecessary cast to string
FileDatePatternConverter.java
FileLocationPatternConverter.java
FullLocationPatternConverter.java
IntegerPatternConverter.java
LevelPatternConverter.java
LineLocationPatternConverter.java
LineSeparatorPatternConverter.java
LiteralPatternConverter.java
LogEvent.java
LoggerPatternConverter.java
LoggingEventPatternConverter.java
MessagePatternConverter.java
MethodLocationPatternConverter.java
NDCPatternConverter.java
NameAbbreviator.java
NamePatternConverter.java
PatternConverter.java
PropertiesPatternConverter.java
RelativeTimePatternConverter.java
SequenceNumberPatternConverter.java
ThreadPatternConverter.java
ThrowableInformationPatternConverter.java
MDCKeySetExtractor.java
UtilLoggingLevel.java
Cheers
Christian
On Sat, May 4, 2013 at 2:32 PM, Jess Holle <je...@ptc.com> wrote:
> On 5/4/2013 7:02 AM, Christian Grobmeier wrote:
>>
>> Thank you for reminding me. I did a quick check, then I saw its
>> actually worse. I found a couple of classes which we need to look into
>> before can make this release. Not even that they are duplicated, I
>> found one class which has a different implementation. :-(
>
> Wow! I'd have assumed that the classes were just copied over from some
> log4j 1.2.x version or another. Perhaps they were and then someone felt
> like improving upon them and didn't understand their ancestry.
>
>> That said, I would like to require companions 1.2 at least 1.2.16 if
>> not 1.2.17. Jess, would this work for you?
>
> I'm absolutely fine with requiring 1.2.17.
>
> --
> Jess Holle
>
--
http://www.grobmeier.de
https://www.timeandbill.de
---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org
Re: [VOTE] Release apache-log4j-extras-1.2 RC1
Posted by Christian Grobmeier <gr...@gmail.com>.
OK, lets do it like that.
On Mon, May 13, 2013 at 4:43 PM, Gary Gregory <ga...@gmail.com> wrote:
> 1.2.17.1?
>
> Gary
>
>
> On Mon, May 13, 2013 at 6:24 AM, Christian Grobmeier <gr...@gmail.com>
> wrote:
>>
>> Then how would we number bugfixes for extras then? (unlikely, but what if)
>>
>> On Sat, May 4, 2013 at 6:15 PM, Jess Holle <je...@ptc.com> wrote:
>> > That'd work too.
>> >
>> >
>> > On 5/4/2013 8:53 AM, Gary Gregory wrote:
>> >>
>> >> Why not number the extras module the same as the version of log4j it
>> >> requires?
>> >>
>> >> Gary
>> >>
>> >> On May 4, 2013, at 8:33, Jess Holle <je...@ptc.com> wrote:
>> >>
>> >>> On 5/4/2013 7:02 AM, Christian Grobmeier wrote:
>> >>>>
>> >>>> Thank you for reminding me. I did a quick check, then I saw its
>> >>>> actually worse. I found a couple of classes which we need to look
>> >>>> into
>> >>>> before can make this release. Not even that they are duplicated, I
>> >>>> found one class which has a different implementation. :-(
>> >>>
>> >>> Wow! I'd have assumed that the classes were just copied over from
>> >>> some
>> >>> log4j 1.2.x version or another. Perhaps they were and then someone
>> >>> felt
>> >>> like improving upon them and didn't understand their ancestry.
>> >>>>
>> >>>> That said, I would like to require companions 1.2 at least 1.2.16 if
>> >>>> not 1.2.17. Jess, would this work for you?
>> >>>
>> >>> I'm absolutely fine with requiring 1.2.17.
>> >>>
>> >>> --
>> >>> Jess Holle
>> >>>
>> >>>
>> >>> ---------------------------------------------------------------------
>> >>> To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
>> >>> For additional commands, e-mail: log4j-dev-help@logging.apache.org
>> >>>
>> >> ---------------------------------------------------------------------
>> >> To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
>> >> For additional commands, e-mail: log4j-dev-help@logging.apache.org
>> >>
>> >>
>> >
>>
>>
>>
>> --
>> http://www.grobmeier.de
>> https://www.timeandbill.de
>
>
>
>
> --
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> Java Persistence with Hibernate, Second Edition
> JUnit in Action, Second Edition
> Spring Batch in Action
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
--
http://www.grobmeier.de
https://www.timeandbill.de
---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org
Re: [VOTE] Release apache-log4j-extras-1.2 RC1
Posted by Gary Gregory <ga...@gmail.com>.
1.2.17.1?
Gary
On Mon, May 13, 2013 at 6:24 AM, Christian Grobmeier <gr...@gmail.com>wrote:
> Then how would we number bugfixes for extras then? (unlikely, but what if)
>
> On Sat, May 4, 2013 at 6:15 PM, Jess Holle <je...@ptc.com> wrote:
> > That'd work too.
> >
> >
> > On 5/4/2013 8:53 AM, Gary Gregory wrote:
> >>
> >> Why not number the extras module the same as the version of log4j it
> >> requires?
> >>
> >> Gary
> >>
> >> On May 4, 2013, at 8:33, Jess Holle <je...@ptc.com> wrote:
> >>
> >>> On 5/4/2013 7:02 AM, Christian Grobmeier wrote:
> >>>>
> >>>> Thank you for reminding me. I did a quick check, then I saw its
> >>>> actually worse. I found a couple of classes which we need to look into
> >>>> before can make this release. Not even that they are duplicated, I
> >>>> found one class which has a different implementation. :-(
> >>>
> >>> Wow! I'd have assumed that the classes were just copied over from some
> >>> log4j 1.2.x version or another. Perhaps they were and then someone
> felt
> >>> like improving upon them and didn't understand their ancestry.
> >>>>
> >>>> That said, I would like to require companions 1.2 at least 1.2.16 if
> >>>> not 1.2.17. Jess, would this work for you?
> >>>
> >>> I'm absolutely fine with requiring 1.2.17.
> >>>
> >>> --
> >>> Jess Holle
> >>>
> >>>
> >>> ---------------------------------------------------------------------
> >>> To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
> >>> For additional commands, e-mail: log4j-dev-help@logging.apache.org
> >>>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
> >> For additional commands, e-mail: log4j-dev-help@logging.apache.org
> >>
> >>
> >
>
>
>
> --
> http://www.grobmeier.de
> https://www.timeandbill.de
>
--
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
Re: [VOTE] Release apache-log4j-extras-1.2 RC1
Posted by Christian Grobmeier <gr...@gmail.com>.
Then how would we number bugfixes for extras then? (unlikely, but what if)
On Sat, May 4, 2013 at 6:15 PM, Jess Holle <je...@ptc.com> wrote:
> That'd work too.
>
>
> On 5/4/2013 8:53 AM, Gary Gregory wrote:
>>
>> Why not number the extras module the same as the version of log4j it
>> requires?
>>
>> Gary
>>
>> On May 4, 2013, at 8:33, Jess Holle <je...@ptc.com> wrote:
>>
>>> On 5/4/2013 7:02 AM, Christian Grobmeier wrote:
>>>>
>>>> Thank you for reminding me. I did a quick check, then I saw its
>>>> actually worse. I found a couple of classes which we need to look into
>>>> before can make this release. Not even that they are duplicated, I
>>>> found one class which has a different implementation. :-(
>>>
>>> Wow! I'd have assumed that the classes were just copied over from some
>>> log4j 1.2.x version or another. Perhaps they were and then someone felt
>>> like improving upon them and didn't understand their ancestry.
>>>>
>>>> That said, I would like to require companions 1.2 at least 1.2.16 if
>>>> not 1.2.17. Jess, would this work for you?
>>>
>>> I'm absolutely fine with requiring 1.2.17.
>>>
>>> --
>>> Jess Holle
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
>>> For additional commands, e-mail: log4j-dev-help@logging.apache.org
>>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
>> For additional commands, e-mail: log4j-dev-help@logging.apache.org
>>
>>
>
--
http://www.grobmeier.de
https://www.timeandbill.de
---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org
Re: [VOTE] Release apache-log4j-extras-1.2 RC1
Posted by Jess Holle <je...@ptc.com>.
That'd work too.
On 5/4/2013 8:53 AM, Gary Gregory wrote:
> Why not number the extras module the same as the version of log4j it requires?
>
> Gary
>
> On May 4, 2013, at 8:33, Jess Holle <je...@ptc.com> wrote:
>
>> On 5/4/2013 7:02 AM, Christian Grobmeier wrote:
>>> Thank you for reminding me. I did a quick check, then I saw its
>>> actually worse. I found a couple of classes which we need to look into
>>> before can make this release. Not even that they are duplicated, I
>>> found one class which has a different implementation. :-(
>> Wow! I'd have assumed that the classes were just copied over from some log4j 1.2.x version or another. Perhaps they were and then someone felt like improving upon them and didn't understand their ancestry.
>>> That said, I would like to require companions 1.2 at least 1.2.16 if
>>> not 1.2.17. Jess, would this work for you?
>> I'm absolutely fine with requiring 1.2.17.
>>
>> --
>> Jess Holle
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
>> For additional commands, e-mail: log4j-dev-help@logging.apache.org
>>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
> For additional commands, e-mail: log4j-dev-help@logging.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org
Re: [VOTE] Release apache-log4j-extras-1.2 RC1
Posted by Gary Gregory <ga...@gmail.com>.
Why not number the extras module the same as the version of log4j it requires?
Gary
On May 4, 2013, at 8:33, Jess Holle <je...@ptc.com> wrote:
> On 5/4/2013 7:02 AM, Christian Grobmeier wrote:
>> Thank you for reminding me. I did a quick check, then I saw its
>> actually worse. I found a couple of classes which we need to look into
>> before can make this release. Not even that they are duplicated, I
>> found one class which has a different implementation. :-(
> Wow! I'd have assumed that the classes were just copied over from some log4j 1.2.x version or another. Perhaps they were and then someone felt like improving upon them and didn't understand their ancestry.
>> That said, I would like to require companions 1.2 at least 1.2.16 if
>> not 1.2.17. Jess, would this work for you?
> I'm absolutely fine with requiring 1.2.17.
>
> --
> Jess Holle
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
> For additional commands, e-mail: log4j-dev-help@logging.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org
Re: [VOTE] Release apache-log4j-extras-1.2 RC1
Posted by Jess Holle <je...@ptc.com>.
On 5/4/2013 7:02 AM, Christian Grobmeier wrote:
> Thank you for reminding me. I did a quick check, then I saw its
> actually worse. I found a couple of classes which we need to look into
> before can make this release. Not even that they are duplicated, I
> found one class which has a different implementation. :-(
Wow! I'd have assumed that the classes were just copied over from some
log4j 1.2.x version or another. Perhaps they were and then someone felt
like improving upon them and didn't understand their ancestry.
> That said, I would like to require companions 1.2 at least 1.2.16 if
> not 1.2.17. Jess, would this work for you?
I'm absolutely fine with requiring 1.2.17.
--
Jess Holle
---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org
Re: [VOTE] Release apache-log4j-extras-1.2 RC1
Posted by Christian Grobmeier <gr...@gmail.com>.
Thank you for reminding me. I did a quick check, then I saw its
actually worse. I found a couple of classes which we need to look into
before can make this release. Not even that they are duplicated, I
found one class which has a different implementation. :-(
That said, I would like to require companions 1.2 at least 1.2.16 if
not 1.2.17. Jess, would this work for you?
These are the classes I found duplicated:
UnrecognizedElementHandler -> same
XSLTLayout -> different implementation
EnhancedPatternLayout -> looks similar at least
LogSF -> looks similar at least
LogXF -> looks similar at least
LogMF -> looks similar at least
BridgePatternConverter.java
BridgePatternParser.java
CachedDateFormat.java
ClassNamePatternConverter.java
DatePatternConverter.java
FileDatePatternConverter.java
FileLocationPatternConverter.java
FormattingInfo.java
FullLocationPatternConverter.java
IntegerPatternConverter.java
LevelPatternConverter.java
LineLocationPatternConverter.java
LineSeparatorPatternConverter.java
LiteralPatternConverter.java
LogEvent.java
LoggerPatternConverter.java
LoggingEventPatternConverter.java
MessagePatternConverter.java
MethodLocationPatternConverter.java
NDCPatternConverter.java
NameAbbreviator.java
NamePatternConverter.java
PatternConverter.java
PatternParser.java
PropertiesPatternConverter.java
RelativeTimePatternConverter.java
SequenceNumberPatternConverter.java
ThreadPatternConverter.java
ThrowableInformationPatternConverter.java
MDCKeySetExtractor.java
UtilLoggingLevel.java
On Sat, May 4, 2013 at 1:47 PM, Jess Holle <je...@ptc.com> wrote:
> apache-log4j-extras-1.2.jar contains redundant copies of many of the log4j
> classes.
>
> This was an issue in log4j-extras 1.1 as well, so this is not new. See the
> "Serious log4j-extras issue" thread from Dec. 7th, 2012.
>
> As per that thread, I've had some rather nasty experiences with this in the
> past -- where I've needed to patch classes in log4j (to avoid concurrency
> and deadlock issues) and done so, only to find after the code was in
> production that a new version of log4j-extras also included the same
> classes, ended up first in classloader order and thus overrode all my
> patches. I eventually ended up hacking a short Ant script to produce a new
> jar excluding any entry outside META-INF that exists in the latest
> log4j.jar.
>
> log4j-extras 1.2 really should resolve this issue. I suspect that will mean
> that log4j-extras 1.2 will need to articulate a specific minimum log4j 1.2.x
> version that provides all the classes (and methods) it needs, as I suspect
> that log4j-extras includes log4j classes to try to work with older log4j
> versions. Including redundant classes is not really a solution, though, as
> it causes issues like that noted above.
>
> --
> Jess Holle
>
>
> On 5/4/2013 5:14 AM, Christian Grobmeier wrote:
>
> Dear all,
>
> this is a vote for a new Apache Companions package.
>
> Please note: it's the first release since 2010. It's far from routine.
>
> Changes:
> - all companions have been merged into the extras companion
> - pom does inherit from parent pom
> - testoutput now goes to /target
> - ant build has been removed
> - makes now use of Maven 3
>
> The website can be found here:
>
> * http://people.apache.org/~grobmeier/log4j-companions/
>
> Note: I might need to update the path for the download.
>
> Artifacts for Maven:
>
> * https://repository.apache.org/content/repositories/orgapachelogging-175/
>
> They can be downloaded with:
>
> wget -e robots=off --cut-dirs=3 -r -p -np --no-check-certificate
> https://repository.apache.org/content/repositories/orgapachelogging-175/
>
> Artifacts for the website and for the ASF dist svn:
>
> * http://people.apache.org/~grobmeier/log4j-companions-artefacts/
>
> SVN tag:
>
> *
> http://svn.apache.org/repos/asf/logging/log4j/companions/extras/tags/apache-log4j-extras-1.2/
>
> Please cast your vote:
>
> [ ] +1
> [ ] -1, because...
>
> Vote will be open for the usual 72 hours at least.
>
> Thanks,
> Christian
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
> For additional commands, e-mail: log4j-dev-help@logging.apache.org
>
>
>
--
http://www.grobmeier.de
https://www.timeandbill.de
---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org
Re: [VOTE] Release apache-log4j-extras-1.2 RC1
Posted by Jess Holle <je...@ptc.com>.
apache-log4j-extras-1.2.jar contains redundant copies of many of the
log4j classes.
This was an issue in log4j-extras 1.1 as well, so this is not new. See
the "Serious log4j-extras issue" thread from Dec. 7th, 2012.
As per that thread, I've had some rather nasty experiences with this in
the past -- where I've needed to patch classes in log4j (to avoid
concurrency and deadlock issues) and done so, only to find after the
code was in production that a new version of log4j-extras also included
the same classes, ended up first in classloader order and thus overrode
all my patches. I eventually ended up hacking a short Ant script to
produce a new jar excluding any entry outside META-INF that exists in
the latest log4j.jar.
log4j-extras 1.2 really should resolve this issue. I /suspect /that
will mean that log4j-extras 1.2 will need to articulate a specific
minimum log4j 1.2.x version that provides all the classes (and methods)
it needs, as I /suspect /that log4j-extras includes log4j classes to try
to work with older log4j versions. Including redundant classes is not
really a solution, though, as it causes issues like that noted above.
--
Jess Holle
On 5/4/2013 5:14 AM, Christian Grobmeier wrote:
> Dear all,
>
> this is a vote for a new Apache Companions package.
>
> Please note: it's the first release since 2010. It's far from routine.
>
> Changes:
> - all companions have been merged into the extras companion
> - pom does inherit from parent pom
> - testoutput now goes to /target
> - ant build has been removed
> - makes now use of Maven 3
>
> The website can be found here:
>
> * http://people.apache.org/~grobmeier/log4j-companions/
>
> Note: I might need to update the path for the download.
>
> Artifacts for Maven:
>
> * https://repository.apache.org/content/repositories/orgapachelogging-175/
>
> They can be downloaded with:
>
> wget -e robots=off --cut-dirs=3 -r -p -np --no-check-certificate
> https://repository.apache.org/content/repositories/orgapachelogging-175/
>
> Artifacts for the website and for the ASF dist svn:
>
> * http://people.apache.org/~grobmeier/log4j-companions-artefacts/
>
> SVN tag:
>
> * http://svn.apache.org/repos/asf/logging/log4j/companions/extras/tags/apache-log4j-extras-1.2/
>
> Please cast your vote:
>
> [ ] +1
> [ ] -1, because...
>
> Vote will be open for the usual 72 hours at least.
>
> Thanks,
> Christian
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
> For additional commands, e-mail: log4j-dev-help@logging.apache.org
>
>