You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Mike Percy (Code Review)" <ge...@cloudera.org> on 2016/11/10 23:43:53 UTC
[kudu-CR] scoped cleanup: Use std::function instead of template
Hello Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/5043
to review the following change.
Change subject: scoped_cleanup: Use std::function instead of template
......................................................................
scoped_cleanup: Use std::function instead of template
This makes it easier to incorporate ScopedCleanup objects into closures
and bound functions, since there are no messy template parameters to
specify when declaring the member or argument variable.
Change-Id: I95235645d626c3c408136df5c4a5a726d767ce84
---
M src/kudu/util/CMakeLists.txt
A src/kudu/util/scoped_cleanup.cc
M src/kudu/util/scoped_cleanup.h
3 files changed, 31 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/43/5043/1
--
To view, visit http://gerrit.cloudera.org:8080/5043
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I95235645d626c3c408136df5c4a5a726d767ce84
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] scoped cleanup: Use std::function instead of template
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: scoped_cleanup: Use std::function instead of template
......................................................................
Patch Set 1: Code-Review-1
--
To view, visit http://gerrit.cloudera.org:8080/5043
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I95235645d626c3c408136df5c4a5a726d767ce84
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] scoped cleanup: Use std::function instead of template
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: scoped_cleanup: Use std::function instead of template
......................................................................
Patch Set 1:
I don't think this is a good idea, because it defeats inlining
--
To view, visit http://gerrit.cloudera.org:8080/5043
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I95235645d626c3c408136df5c4a5a726d767ce84
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] scoped cleanup: Use std::function instead of template
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has abandoned this change.
Change subject: scoped_cleanup: Use std::function instead of template
......................................................................
Abandoned
OK, abandoning
--
To view, visit http://gerrit.cloudera.org:8080/5043
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: abandon
Gerrit-Change-Id: I95235645d626c3c408136df5c4a5a726d767ce84
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>