You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by mikezaccardo <gi...@git.apache.org> on 2015/12/04 06:40:48 UTC
[GitHub] incubator-brooklyn pull request: [DISCUSSION] Sequential Entity St...
GitHub user mikezaccardo opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/1088
[DISCUSSION] Sequential Entity Stop Order
This adds a `stop.sequence.position` config value which enables YAML blueprint authors to explicitly specify a stop order. This can prevent the problem of entities hanging infinitely on stop when they attempt to resolve dependent values of already-stopped entities.
Discussion points:
-Does this seem like a valid approach overall?
-Is the config value named intuitively?
Areas of improvement:
-Validation of config values (ensure values start at 1 and proceed sequentially)
-Allow multiple entities to share a value (e.g. 1, 2, 2, 3, 4 -- the 2s would stop in parallel)
IGNORE commit `Add all.members.up sensor to DynamicCluster` -- this was needed for testing.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mikezaccardo/incubator-brooklyn fix/sequential-members-stop
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/1088.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1088
----
commit 42bf3fa337dc4c7395a617b36015e59c3f828d2a
Author: Mike Zaccardo <mi...@cloudsoftcorp.com>
Date: 2015-11-23T16:23:28Z
Add all.members.up sensor to DynamicCluster
commit f440a9842d46190e3ab2ca3679604093a4e71c06
Author: Mike Zaccardo <mi...@cloudsoftcorp.com>
Date: 2015-12-04T05:32:59Z
Add customizable, sequential entity stop order
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: [DISCUSSION] Sequential Entity St...
Posted by mikezaccardo <gi...@git.apache.org>.
Github user mikezaccardo closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/1088
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: [DISCUSSION] Sequential Entity St...
Posted by googlielmo <gi...@git.apache.org>.
Github user googlielmo commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1088#issuecomment-161917586
Excellent idea Mike!
For the sake of discussion, what happens if you don't provide a value? Is that an implicit 1?
Generally speaking, I'd prefer to introduce a partial ordering with a "stops-after" property, so that you can specify that entity B "stops-after" entity A.
WDYT?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---