You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Madhan Neethiraj <ma...@apache.org> on 2018/01/10 01:10:29 UTC
Review Request 65058: ATLAS-2169: delete request fails when
hard-delete is configured
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65058/
-----------------------------------------------------------
Review request for atlas.
Bugs: ATLAS-2169
https://issues.apache.org/jira/browse/ATLAS-2169
Repository: atlas
Description
-------
While processing entity-changes, AtlasEntityChangeNotifier attempts to retreive entity details from entity's guid. This call fails for delete operations when Atlas is configured for hard-delete, as the vertex is already deleted.
Updated the change notifier to avoid entity-retreival for delete operations.
Diffs
-----
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityChangeNotifier.java f04f9d0e
typesystem/src/main/java/org/apache/atlas/typesystem/persistence/ReferenceableInstance.java be2634d6
Diff: https://reviews.apache.org/r/65058/diff/1/
Testing
-------
Verified that Atlas processes entity-deletes successfully and the failure seen earlier is no more seen.
Thanks,
Madhan Neethiraj
Re: Review Request 65058: ATLAS-2169: delete request fails when
hard-delete is configured
Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65058/#review195118
-----------------------------------------------------------
Ship it!
Ship It!
- Sarath Subramanian
On Jan. 9, 2018, 5:10 p.m., Madhan Neethiraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65058/
> -----------------------------------------------------------
>
> (Updated Jan. 9, 2018, 5:10 p.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-2169
> https://issues.apache.org/jira/browse/ATLAS-2169
>
>
> Repository: atlas
>
>
> Description
> -------
>
> While processing entity-changes, AtlasEntityChangeNotifier attempts to retreive entity details from entity's guid. This call fails for delete operations when Atlas is configured for hard-delete, as the vertex is already deleted.
>
> Updated the change notifier to avoid entity-retreival for delete operations.
>
>
> Diffs
> -----
>
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityChangeNotifier.java f04f9d0e
> typesystem/src/main/java/org/apache/atlas/typesystem/persistence/ReferenceableInstance.java be2634d6
>
>
> Diff: https://reviews.apache.org/r/65058/diff/1/
>
>
> Testing
> -------
>
> Verified that Atlas processes entity-deletes successfully and the failure seen earlier is no more seen.
>
>
> Thanks,
>
> Madhan Neethiraj
>
>