You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@groovy.apache.org by su...@apache.org on 2020/04/11 11:48:54 UTC

[groovy] 03/03: Trivial refactoring: Iteration can be replaced with bulk 'Collection.addAll' call

This is an automated email from the ASF dual-hosted git repository.

sunlan pushed a commit to branch GROOVY_3_0_X
in repository https://gitbox.apache.org/repos/asf/groovy.git

commit 1f612e176f6147ee3d717f1474f7bf93e7b8f6f9
Author: Daniel Sun <su...@apache.org>
AuthorDate: Sat Apr 11 19:19:41 2020 +0800

    Trivial refactoring: Iteration can be replaced with bulk 'Collection.addAll' call
    
    (cherry picked from commit f1f88a303e86a97b2125ec8de8acce6c9b231bf9)
---
 src/main/java/org/codehaus/groovy/ast/expr/TupleExpression.java | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/main/java/org/codehaus/groovy/ast/expr/TupleExpression.java b/src/main/java/org/codehaus/groovy/ast/expr/TupleExpression.java
index 62c5d0b..317d82f 100644
--- a/src/main/java/org/codehaus/groovy/ast/expr/TupleExpression.java
+++ b/src/main/java/org/codehaus/groovy/ast/expr/TupleExpression.java
@@ -21,6 +21,7 @@ package org.codehaus.groovy.ast.expr;
 import org.codehaus.groovy.ast.GroovyCodeVisitor;
 
 import java.util.ArrayList;
+import java.util.Arrays;
 import java.util.Collections;
 import java.util.Iterator;
 import java.util.List;
@@ -61,7 +62,7 @@ public class TupleExpression extends Expression implements Iterable<Expression>
 
     public TupleExpression(final Expression[] expressionArray) {
         this(expressionArray.length);
-        for (Expression e : expressionArray) expressions.add(e);
+        expressions.addAll(Arrays.asList(expressionArray));
     }
 
     public TupleExpression addExpression(final Expression expression) {