[GitHub] villebro opened a new pull request #4994: Force lowercase column names for Snowflake and Oracle

[GitBox <gi...@apache.org>]

villebro opened a new pull request #4994: Force lowercase column names for Snowflake and Oracle
URL: https://github.com/apache/incubator-superset/pull/4994
 
 
   When calling `cursor.description` using the Oracle and Snowflake SQL Alchemy connectors, column names are returned in all uppercase. This causes problems when these column names are used to match column names in DataFrames that have been constructed from a `ResultProxy`, which for these connectors have lowercase column names. An example of this is Pandas' `read_sql_query` function, which is used eg. for timeseries graphs.
   
   This PR should fix #4662, #4770 and #953. A more elegant and long-term sustainable fix would be replacing all `cursor.execute()`-based select queries with `connection.execute()`calls. This should be fairly simple and would probably tidy up the code a fair bit, unless there is an explicit reason for using the low level API.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org