You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@thrift.apache.org by "Christopher Tubbs (JIRA)" <ji...@apache.org> on 2017/12/22 04:05:00 UTC

[jira] [Commented] (THRIFT-4380) Compiler incorrect generates code which treats a Java enum as a binary type

    [ https://issues.apache.org/jira/browse/THRIFT-4380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16300935#comment-16300935 ] 

Christopher Tubbs commented on THRIFT-4380:
-------------------------------------------

It looks like this issue was fixed by THRIFT-4136 and THRIFT-4177.

> Compiler incorrect generates code which treats a Java enum as a binary type
> ---------------------------------------------------------------------------
>
>                 Key: THRIFT-4380
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4380
>             Project: Thrift
>          Issue Type: Bug
>          Components: Java - Compiler
>    Affects Versions: 0.10.0
>            Reporter: Christopher Tubbs
>
> ./compiler/cpp/src/thrift/generate/t_java_generator.cc around line 4661 seems to incorrectly wrap an enum with TBaseHelper.copyBinary. This caused a build failure when building the java tutorial on s390x.
> Cannot reproduce this bug on x86_64, only on s390x so far. Could use the assistance of an upstream Thrift developer to take a look at the C++ code to examine for correctness. It looks like it's trying to cast enums to a base type, and then check if it's a binary type.
> Please see external tracker: https://bugzilla.redhat.com/show_bug.cgi?id=1507518



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)