[GitHub] [shardingsphere] azexcy opened a new pull request, #25983: Fix replication slot not remove when drop database at openGauss

["azexcy (via GitHub)" <gi...@apache.org>]

azexcy opened a new pull request, #25983:
URL: https://github.com/apache/shardingsphere/pull/25983

   Fixes #ISSUSE_ID.
   
   Changes proposed in this pull request:
     - Fix replication slot not remove when drop database at openGauss
     - Reduced data replay after reconnect
     - Make sure stop job before drop, reduce error log
   
   ---
   
   Before committing this PR, I'm sure that I have checked the following options:
   - [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
   - [ ] I have self-reviewed the commit code.
   - [ ] I have (or in comment I request) added corresponding labels for the pull request.
   - [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
   - [ ] I have made corresponding changes to the documentation.
   - [ ] I have added corresponding unit tests for my changes.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] sandynz commented on a diff in pull request #25983: Fix replication slot not remove when drop database at openGauss

["sandynz (via GitHub)" <gi...@apache.org>]

sandynz commented on code in PR #25983:
URL: https://github.com/apache/shardingsphere/pull/25983#discussion_r1212752139


##########
kernel/data-pipeline/dialect/opengauss/src/main/java/org/apache/shardingsphere/data/pipeline/opengauss/ingest/OpenGaussWALDumper.java:
##########
@@ -59,7 +59,7 @@ public final class OpenGaussWALDumper extends AbstractLifecycleExecutor implemen
     
     private final DumperConfiguration dumperConfig;
     
-    private final WALPosition walPosition;
+    private WALPosition walPosition;

Review Comment:
   Could we use AtomicReference?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] sandynz merged pull request #25983: Fix replication slot not remove when drop database at openGauss

["sandynz (via GitHub)" <gi...@apache.org>]

sandynz merged PR #25983:
URL: https://github.com/apache/shardingsphere/pull/25983


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org