You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/09/08 04:29:09 UTC

[GitHub] [skywalking] wu-sheng commented on a change in pull request #5454: Parse TLS mode from ALS

wu-sheng commented on a change in pull request #5454:
URL: https://github.com/apache/skywalking/pull/5454#discussion_r484643333



##########
File path: oap-server/server-bootstrap/src/main/resources/oal/core.oal
##########
@@ -69,6 +69,12 @@ database_access_sla = from(DatabaseAccess.*).percent(status == true);
 database_access_cpm = from(DatabaseAccess.*).cpm();
 database_access_percentile = from(DatabaseAccess.latency).percentile(10);
 
+// Example of TLS related metric. Detected point was not distinguished, that means mTLS requests from both sides will be
+// counted in.
+//////////
+// service_relation_mtls_cpm = from(ServiceRelation.*).filter(tlsMode == "mTLS").cpm();
+// service_instance_relation_mtls_cpm = from(ServiceInstanceRelation.*).filter(tlsMode == "mTLS").cpm();

Review comment:
       We don't visualize tls in the current UI. Please remove them.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org