You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@deltacloud.apache.org by Michal Fojtik <mf...@redhat.com> on 2012/07/27 14:28:42 UTC
RHEV-M driver unit tests, EC2 fronted tests and 1.8 fixes
Hi,
The problem under 1.8 seems missing 'require "rubygems"' on top
of 'test_helper.rb'. Adding that solved this problem.
I applied David patches on top of my patches + added the EC2 front-end
patches.
Everything seems to play nicely together though now it is more than 20
patches ;-) (I know I promised not send patch-bombs anymore).
To make it more easy to review, I compressed them into tar archive you
found attached to this email.
David: Can we just commit what we have now, even it is not ideal in terms of
recording credentials and then fix it later?
-- Michal
Michal Fojtik
http://deltacloud.org
mfojtik@redhat.com
On Jul 27, 2012, at 12:55 AM, David Lutterkort wrote:
> On Thu, 2012-07-26 at 16:20 +0200, mfojtik@redhat.com wrote:
>> From: Michal Fojtik <mf...@redhat.com>
>>
>>
>> Signed-off-by: Michal fojtik <mf...@redhat.com>
>> ---
>> server/tests/ec2/common.rb | 19 +++++++
>> server/tests/ec2/query_parser_test.rb | 97 +++++++++++++++++++++++++++++++++
>> server/tests/ec2/server_test.rb | 44 +++++++++++++++
>> 3 files changed, 160 insertions(+)
>> create mode 100644 server/tests/ec2/common.rb
>> create mode 100644 server/tests/ec2/query_parser_test.rb
>> create mode 100644 server/tests/ec2/server_test.rb
>
> Both 'rake test' and 'bundle exec rake test' give me
>
> ./tests/test_helper.rb:2:in `require': no such file to load -- rack/test (LoadError)
> from ./tests/test_helper.rb:2
> rake aborted!
> Command failed with status (1): [/usr/bin/ruby -I"lib" -r./tests/test_helpe...]
>
> Tasks: TOP => test
> (See full trace by running task with --trace)
>
>
> David
>
>
Re: RHEV-M driver unit tests, EC2 fronted tests and 1.8 fixes
Posted by Michal Fojtik <mf...@redhat.com>.
Hi,
Of course I forgot to attach the tar :-)
Re: RHEV-M driver unit tests, EC2 fronted tests and 1.8 fixes
Posted by Ronelle Landy <rl...@redhat.com>.
>
> Hi,
>
> I re-recorded all fixtures for EC2 using Ruby 1.8:
>
> firefly ~/code/core/server $ rvm list
>
> => ruby-1.8.7-p370 [ i686 ]
> * ruby-1.9.3-p125 [ x86_64 ]
>
> firefly ~/code/core/server $ rake test:drivers:ec2
> Run options: --seed 24923
>
> # Running tests:
>
> /Users/mfojtik/.rvm/gems/ruby-1.8.7-p370/gems/aws-2.5.6/lib/awsbase/awsbase.rb:66:
> warning: already initialized constant AMAZON_PROBLEMS
> /Users/mfojtik/.rvm/gems/ruby-1.8.7-p370/gems/aws-2.5.6/lib/awsbase/awsbase.rb:86:
> warning: already initialized constant DEFAULT_SIGNATURE_VERSION
> ....................
>
> Finished tests in 0.000000s, inf tests/s, inf assertions/s.
>
> 20 tests, 159 assertions, 0 failures, 0 errors, 0 skips
>
ACK - EC2 test work for QE ...
Finished tests in 0.000000s, inf tests/s, inf assertions/s.
20 tests, 159 assertions, 0 failures, 0 errors, 0 skips
>
> Now both Ruby 1.9 and 1.8 works for me without VCR failures.
>
> Can you try a new patch set I attached on Fedora? Also attaching
> my bundler lockfile, just for sure:
>
> http://omicron.mifo.sk/patches.tar.gz
> http://omicron.mifo.sk/Gemfile.lock
>
> -- Michal
>
>
> Michal Fojtik
> http://deltacloud.org
> mfojtik@redhat.com
>
>
>
> On Jul 27, 2012, at 11:19 PM, Ronelle Landy <rl...@redhat.com>
> wrote:
>
> >> From: "David Lutterkort" <lu...@redhat.com>
> >> To: dev@deltacloud.apache.org
> >> Sent: Friday, July 27, 2012 5:04:06 PM
> >> Subject: Re: RHEV-M driver unit tests, EC2 fronted tests and 1.8
> >> fixes
> >>
> >> On Fri, 2012-07-27 at 14:28 +0200, Michal Fojtik wrote:
> >>> Hi,
> >>>
> >>> The problem under 1.8 seems missing 'require "rubygems"' on top
> >>> of 'test_helper.rb'. Adding that solved this problem.
> >>>
> >>> I applied David patches on top of my patches + added the EC2
> >>> front-end
> >>> patches.
> >>>
> >>> Everything seems to play nicely together though now it is more
> >>> than
> >>> 20
> >>> patches ;-) (I know I promised not send patch-bombs anymore).
> >>>
> >>> To make it more easy to review, I compressed them into tar
> >>> archive
> >>> you
> >>> found attached to this email.
> >>>
> >>> David: Can we just commit what we have now, even it is not ideal
> >>> in
> >>> terms of
> >>> recording credentials and then fix it later?
> >>
> >> I'd love to commit the patches, but for me 'rake test' fails with
> >> a
> >> whole bunch of VCR failures in the EC2 tests. I've uploaded a log
> >> of
> >> 'rake test'[1] and attach my Gemfile.lock
> >
> > I also tried the tests on RHEL 6.2 box (ruby 1.8.7) using >> bundle
> > && bundle exec rake test
> > I see the same ec2 test failures.
> >
> >>
> >> These patches get an ACK from me if rerecording the VCR data does
> >> indeed
> >> fix the failures - if that's all you need to do, feel free to
> >> commit
> >> them.
> >>
> >> David
> >>
> >> [1] http://people.apache.org/~lutter/rake-test.txt
> >>
> >>
> >>
> >>
>
>
Re: RHEV-M driver unit tests, EC2 fronted tests and 1.8 fixes
Posted by Michal Fojtik <mf...@redhat.com>.
Hi,
I re-recorded all fixtures for EC2 using Ruby 1.8:
firefly ~/code/core/server $ rvm list
=> ruby-1.8.7-p370 [ i686 ]
* ruby-1.9.3-p125 [ x86_64 ]
firefly ~/code/core/server $ rake test:drivers:ec2
Run options: --seed 24923
# Running tests:
/Users/mfojtik/.rvm/gems/ruby-1.8.7-p370/gems/aws-2.5.6/lib/awsbase/awsbase.rb:66: warning: already initialized constant AMAZON_PROBLEMS
/Users/mfojtik/.rvm/gems/ruby-1.8.7-p370/gems/aws-2.5.6/lib/awsbase/awsbase.rb:86: warning: already initialized constant DEFAULT_SIGNATURE_VERSION
....................
Finished tests in 0.000000s, inf tests/s, inf assertions/s.
20 tests, 159 assertions, 0 failures, 0 errors, 0 skips
Now both Ruby 1.9 and 1.8 works for me without VCR failures.
Can you try a new patch set I attached on Fedora? Also attaching
my bundler lockfile, just for sure:
http://omicron.mifo.sk/patches.tar.gz
http://omicron.mifo.sk/Gemfile.lock
-- Michal
Michal Fojtik
http://deltacloud.org
mfojtik@redhat.com
On Jul 27, 2012, at 11:19 PM, Ronelle Landy <rl...@redhat.com> wrote:
>> From: "David Lutterkort" <lu...@redhat.com>
>> To: dev@deltacloud.apache.org
>> Sent: Friday, July 27, 2012 5:04:06 PM
>> Subject: Re: RHEV-M driver unit tests, EC2 fronted tests and 1.8 fixes
>>
>> On Fri, 2012-07-27 at 14:28 +0200, Michal Fojtik wrote:
>>> Hi,
>>>
>>> The problem under 1.8 seems missing 'require "rubygems"' on top
>>> of 'test_helper.rb'. Adding that solved this problem.
>>>
>>> I applied David patches on top of my patches + added the EC2
>>> front-end
>>> patches.
>>>
>>> Everything seems to play nicely together though now it is more than
>>> 20
>>> patches ;-) (I know I promised not send patch-bombs anymore).
>>>
>>> To make it more easy to review, I compressed them into tar archive
>>> you
>>> found attached to this email.
>>>
>>> David: Can we just commit what we have now, even it is not ideal in
>>> terms of
>>> recording credentials and then fix it later?
>>
>> I'd love to commit the patches, but for me 'rake test' fails with a
>> whole bunch of VCR failures in the EC2 tests. I've uploaded a log of
>> 'rake test'[1] and attach my Gemfile.lock
>
> I also tried the tests on RHEL 6.2 box (ruby 1.8.7) using >> bundle && bundle exec rake test
> I see the same ec2 test failures.
>
>>
>> These patches get an ACK from me if rerecording the VCR data does
>> indeed
>> fix the failures - if that's all you need to do, feel free to commit
>> them.
>>
>> David
>>
>> [1] http://people.apache.org/~lutter/rake-test.txt
>>
>>
>>
>>
Re: RHEV-M driver unit tests, EC2 fronted tests and 1.8 fixes
Posted by Ronelle Landy <rl...@redhat.com>.
> From: "David Lutterkort" <lu...@redhat.com>
> To: dev@deltacloud.apache.org
> Sent: Friday, July 27, 2012 5:04:06 PM
> Subject: Re: RHEV-M driver unit tests, EC2 fronted tests and 1.8 fixes
>
> On Fri, 2012-07-27 at 14:28 +0200, Michal Fojtik wrote:
> > Hi,
> >
> > The problem under 1.8 seems missing 'require "rubygems"' on top
> > of 'test_helper.rb'. Adding that solved this problem.
> >
> > I applied David patches on top of my patches + added the EC2
> > front-end
> > patches.
> >
> > Everything seems to play nicely together though now it is more than
> > 20
> > patches ;-) (I know I promised not send patch-bombs anymore).
> >
> > To make it more easy to review, I compressed them into tar archive
> > you
> > found attached to this email.
> >
> > David: Can we just commit what we have now, even it is not ideal in
> > terms of
> > recording credentials and then fix it later?
>
> I'd love to commit the patches, but for me 'rake test' fails with a
> whole bunch of VCR failures in the EC2 tests. I've uploaded a log of
> 'rake test'[1] and attach my Gemfile.lock
I also tried the tests on RHEL 6.2 box (ruby 1.8.7) using >> bundle && bundle exec rake test
I see the same ec2 test failures.
>
> These patches get an ACK from me if rerecording the VCR data does
> indeed
> fix the failures - if that's all you need to do, feel free to commit
> them.
>
> David
>
> [1] http://people.apache.org/~lutter/rake-test.txt
>
>
>
>
Re: RHEV-M driver unit tests, EC2 fronted tests and 1.8 fixes
Posted by David Lutterkort <lu...@redhat.com>.
On Fri, 2012-07-27 at 14:28 +0200, Michal Fojtik wrote:
> Hi,
>
> The problem under 1.8 seems missing 'require "rubygems"' on top
> of 'test_helper.rb'. Adding that solved this problem.
>
> I applied David patches on top of my patches + added the EC2 front-end
> patches.
>
> Everything seems to play nicely together though now it is more than 20
> patches ;-) (I know I promised not send patch-bombs anymore).
>
> To make it more easy to review, I compressed them into tar archive you
> found attached to this email.
>
> David: Can we just commit what we have now, even it is not ideal in terms of
> recording credentials and then fix it later?
I'd love to commit the patches, but for me 'rake test' fails with a
whole bunch of VCR failures in the EC2 tests. I've uploaded a log of
'rake test'[1] and attach my Gemfile.lock
These patches get an ACK from me if rerecording the VCR data does indeed
fix the failures - if that's all you need to do, feel free to commit
them.
David
[1] http://people.apache.org/~lutter/rake-test.txt