You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2022/03/17 17:04:44 UTC

[GitHub] [pinot] Jackie-Jiang commented on a change in pull request #8329: Refactor Pinot http utils into HttpClient

Jackie-Jiang commented on a change in pull request #8329:
URL: https://github.com/apache/pinot/pull/8329#discussion_r829288558



##########
File path: pinot-common/src/main/java/org/apache/pinot/common/utils/TlsUtils.java
##########
@@ -255,6 +257,14 @@ public static URL makeKeyStoreUrl(String storePath)
     return inputUri.toURL();
   }
 
+  public static SSLContext getSslContext() {
+    return _sslContext != null ? _sslContext : SSLContexts.createDefault();

Review comment:
       Also CC @richardstartin to give suggestions on how to set static variables




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org