[GitHub] nitt10prashant opened a new pull request #2080: Changing vlan to None since network offering being used has Specify Vlan set to No

[gi...@git.apache.org]

nitt10prashant opened a new pull request #2080: Changing vlan to None since network offering being used has Specify Vlan set to No
URL: https://github.com/apache/cloudstack/pull/2080
 
 
   Default isolated network offering with SourceNat service has Specify Vlan parameter set to No. When specify vlan is "No" we can't pass vlan number for network creation api. Three tests are passing vlan id. Hence setting it to None.
   
   Test results:
   
   Validate that Admin should be able to create network for himslef ... === TestName: test_01_createNetwork_admin | Status : SUCCESS ===
   
   ok
   
   Validate that Admin should be able to create network for users in his domain ... === TestName: test_02_createNetwork_admin_foruserinsamedomain | Status : SUCCESS ===
   
   ok
   
   Validate that Admin should be able to create network for users in his sub domain ... === TestName: test_03_createNetwork_admin_foruserinotherdomain | Status : SUCCESS ===
   
   ok
   
   Ran 3 tests in 440.959s
   
   OK
   
   this will close PR   https://github.com/apache/cloudstack/pull/1571
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services