You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "shibd (via GitHub)" <gi...@apache.org> on 2023/05/11 14:37:06 UTC

[GitHub] [pulsar-site] shibd opened a new pull request, #571: Add client memory limits docs.

shibd opened a new pull request, #571:
URL: https://github.com/apache/pulsar-site/pull/571

   ### Preview
   
   <img width="1177" alt="image" src="https://github.com/apache/pulsar-site/assets/33416836/d55b2ff1-53a8-499e-bce0-394e3f4f6b36">
   
   <img width="1098" alt="image" src="https://github.com/apache/pulsar-site/assets/33416836/e71a9eff-886e-4716-b44f-ee5606bf4456">
   
   
   ### Documentation
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   - [x] `doc` <!-- Your PR contains doc changes. Please attach the local preview screenshots (run `./preview.sh` at root path) to your PR description, or else your PR might not get merged. -->
   - [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
   - [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
   - [ ] `doc-complete` <!-- Docs have been already added -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar-site] Anonymitaet commented on pull request #571: Add client memory limits docs.

Posted by "Anonymitaet (via GitHub)" <gi...@apache.org>.
Anonymitaet commented on PR #571:
URL: https://github.com/apache/pulsar-site/pull/571#issuecomment-1547052876

   > > Can you attach the related code PR in the doc PR description (as commented in [#565 (comment)](https://github.com/apache/pulsar-site/pull/565#issuecomment-1541064214))? So that reviewers will have more context, which can speed up the review process.
   > 
   > oh, Sorry. Maybe we can change PR template?
   > 
   > ### Preview
   > ### Relation PR
   > ### Documentation
   > * [ ]  `doc`
   > * [ ]  `doc-required`
   > * [ ]  `doc-not-needed`
   > * [ ]  `doc-complete`
   
   Sure, done in https://github.com/apache/pulsar-site/pull/572


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar-site] Anonymitaet merged pull request #571: Add client memory limits docs.

Posted by "Anonymitaet (via GitHub)" <gi...@apache.org>.
Anonymitaet merged PR #571:
URL: https://github.com/apache/pulsar-site/pull/571


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar-site] shibd commented on pull request #571: Add client memory limits docs.

Posted by "shibd (via GitHub)" <gi...@apache.org>.
shibd commented on PR #571:
URL: https://github.com/apache/pulsar-site/pull/571#issuecomment-1545006140

   > Can you attach the related code PR in the doc PR description (as commented in https://github.com/apache/pulsar-site/pull/565#issuecomment-1541064214)? So that reviewers will have more context, which can speed up the review process.
   
   oh, Sorry. Maybe we can change template?
   
   ### Preview
   
   
   
   ### Relation PR
   
   
   ### Documentation
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   - [ ] `doc` <!-- Your PR contains doc changes. Please attach the local preview screenshots (run `./preview.sh` at root path) to your PR description, or else your PR might not get merged. -->
   - [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
   - [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
   - [ ] `doc-complete` <!-- Docs have been already added -->
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar-site] shibd commented on a diff in pull request #571: Add client memory limits docs.

Posted by "shibd (via GitHub)" <gi...@apache.org>.
shibd commented on code in PR #571:
URL: https://github.com/apache/pulsar-site/pull/571#discussion_r1191842257


##########
docs/client-libraries-clients.md:
##########
@@ -51,4 +51,36 @@ The following example creates a Python client using multiple advertised listener
 
   </TabItem>
 </Tabs>
+````
+
+## Set memory limits
+
+You can uses memory limits param to control client overall memory usage,
+the producers and consumers under this client will compete for the memory assigned. See [PIP 74: Pulsar client memory limits](https://github.com/apache/pulsar/wiki/PIP-74%3A-Pulsar-client-memory-limits)

Review Comment:
   I think nothing.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar-site] Anonymitaet commented on a diff in pull request #571: Add client memory limits docs.

Posted by "Anonymitaet (via GitHub)" <gi...@apache.org>.
Anonymitaet commented on code in PR #571:
URL: https://github.com/apache/pulsar-site/pull/571#discussion_r1191788445


##########
docs/client-libraries-clients.md:
##########
@@ -51,4 +51,36 @@ The following example creates a Python client using multiple advertised listener
 
   </TabItem>
 </Tabs>
+````
+
+## Set memory limits
+
+You can uses memory limits param to control client overall memory usage,

Review Comment:
   ```suggestion
   You can use memory limits parameters to control the total client memory usage,
   ```



##########
docs/client-libraries-clients.md:
##########
@@ -51,4 +51,36 @@ The following example creates a Python client using multiple advertised listener
 
   </TabItem>
 </Tabs>
+````
+
+## Set memory limits
+
+You can uses memory limits param to control client overall memory usage,
+the producers and consumers under this client will compete for the memory assigned. See [PIP 74: Pulsar client memory limits](https://github.com/apache/pulsar/wiki/PIP-74%3A-Pulsar-client-memory-limits)

Review Comment:
   ```suggestion
   the producers and consumers under this client will compete for the memory assigned. For implementation details, see [PIP 74: Pulsar client memory limits](https://github.com/apache/pulsar/wiki/PIP-74%3A-Pulsar-client-memory-limits).
   ```



##########
docs/client-libraries-clients.md:
##########
@@ -51,4 +51,36 @@ The following example creates a Python client using multiple advertised listener
 
   </TabItem>
 </Tabs>
+````
+
+## Set memory limits
+
+You can uses memory limits param to control client overall memory usage,
+the producers and consumers under this client will compete for the memory assigned. See [PIP 74: Pulsar client memory limits](https://github.com/apache/pulsar/wiki/PIP-74%3A-Pulsar-client-memory-limits)

Review Comment:
   Do we have any considerations/limitations that need to remind users?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar-site] Anonymitaet commented on pull request #571: Add client memory limits docs.

Posted by "Anonymitaet (via GitHub)" <gi...@apache.org>.
Anonymitaet commented on PR #571:
URL: https://github.com/apache/pulsar-site/pull/571#issuecomment-1544944609

   This PR adds doc for https://github.com/apache/pulsar-client-go/pull/991#issuecomment-1512391159


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org