You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@wicket.apache.org by "Andrea Del Bene (JIRA)" <ji...@apache.org> on 2014/08/27 14:03:58 UTC

[jira] [Commented] (WICKET-5683) PreviousButton isEnabled() should bo logical conjunction of getWizardModel().isPreviousAvailable() and super.isEnabled()

    [ https://issues.apache.org/jira/browse/WICKET-5683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14112177#comment-14112177 ] 

Andrea Del Bene commented on WICKET-5683:
-----------------------------------------

I agree :)

> PreviousButton isEnabled() should bo logical conjunction of getWizardModel().isPreviousAvailable() and super.isEnabled()
> ------------------------------------------------------------------------------------------------------------------------
>
>                 Key: WICKET-5683
>                 URL: https://issues.apache.org/jira/browse/WICKET-5683
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket-extensions
>            Reporter: Mikael Björertz
>            Assignee: Andrea Del Bene
>              Labels: navigation, wizard
>   Original Estimate: 5m
>  Remaining Estimate: 5m
>
> The implementation of isEnabled in PreviousButton breaks the implicit contract of setEnabled(false) -> isEnabled() returning false.
> Implementation should be 
> return super.isEnabled() && getWizardModel().isPreviousAvailable();



--
This message was sent by Atlassian JIRA
(v6.2#6252)