You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by "cmcfarlen (via GitHub)" <gi...@apache.org> on 2024/05/15 16:14:58 UTC

[I] Event handles with VC_EVENT_ERROR but not VC_EVENT_EOS [trafficserver]

cmcfarlen opened a new issue, #11358:
URL: https://github.com/apache/trafficserver/issues/11358

   While reviewing #11346, I went through and found other places where the EOS event was not handled but ERROR was:
   
   ```
   src/iocore/net/QUICNextProtocolAccept.cc|44 col 8| case VC_EVENT_ERROR:
   src/proxy/http/HttpSM.cc|1232 col 8| case VC_EVENT_ERROR:
   src/proxy/http/HttpSM.cc|1808 col 8| case VC_EVENT_ERROR:
   src/proxy/Transform.cc|634 col 10| case VC_EVENT_ERROR:
   src/proxy/Transform.cc|793 col 10| case VC_EVENT_ERROR:
   ```
   
   I wonder, should we add EOS to these switch statements as well?
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficserver.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Event handles with VC_EVENT_ERROR but not VC_EVENT_EOS [trafficserver]

Posted by "bryancall (via GitHub)" <gi...@apache.org>.
bryancall closed issue #11358: Event handles with VC_EVENT_ERROR but not VC_EVENT_EOS
URL: https://github.com/apache/trafficserver/issues/11358


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Event handles with VC_EVENT_ERROR but not VC_EVENT_EOS [trafficserver]

Posted by "maskit (via GitHub)" <gi...@apache.org>.
maskit commented on issue #11358:
URL: https://github.com/apache/trafficserver/issues/11358#issuecomment-2112980938

   I'm not sure whether QUICNextProtocolAccept.cc receives EOS, but we can add it.
   
   Is the list complete? I wonder why SSLNextProtocolAccept.cc isn't on the list.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Event handles with VC_EVENT_ERROR but not VC_EVENT_EOS [trafficserver]

Posted by "cmcfarlen (via GitHub)" <gi...@apache.org>.
cmcfarlen commented on issue #11358:
URL: https://github.com/apache/trafficserver/issues/11358#issuecomment-2121289071

   Its likely not complete, just me staring at the code


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org