You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by "Alonexc (via GitHub)" <gi...@apache.org> on 2023/03/10 01:51:59 UTC
[GitHub] [incubator-eventmesh] Alonexc opened a new issue, #3397: [Enhancement] Make field a static final constant or non-public
Alonexc opened a new issue, #3397:
URL: https://github.com/apache/incubator-eventmesh/issues/3397
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/eventmesh/issues?q=is%3Aissue) and found no similar issues.
### Enhancement Request
![image](https://user-images.githubusercontent.com/91315508/224202339-dc2ca594-3cd2-4e60-b294-90611bfde3de.png)
located at:
eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/tcp/client/session/push/DownStreamMsgContext.java
### Describe the solution you'd like
![image](https://user-images.githubusercontent.com/91315508/224202396-3051674f-9ac8-44c9-9f0b-aa0ca9198bbe.png)
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [eventmesh] garimellasrisudha commented on issue #3397: [Enhancement] Make field a static final constant or non-public
Posted by "garimellasrisudha (via GitHub)" <gi...@apache.org>.
garimellasrisudha commented on issue #3397:
URL: https://github.com/apache/eventmesh/issues/3397#issuecomment-1504571283
Hi Alonexc,
I raised Pull request for the change.
https://github.com/apache/eventmesh/pull/3701
let me know if any changes required
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [I] [Enhancement] Make field a static final constant or non-public (eventmesh)
Posted by "xwm1992 (via GitHub)" <gi...@apache.org>.
xwm1992 closed issue #3397: [Enhancement] Make field a static final constant or non-public
URL: https://github.com/apache/eventmesh/issues/3397
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
[GitHub] [eventmesh] garimellasrisudha commented on issue #3397: [Enhancement] Make field a static final constant or non-public
Posted by "garimellasrisudha (via GitHub)" <gi...@apache.org>.
garimellasrisudha commented on issue #3397:
URL: https://github.com/apache/eventmesh/issues/3397#issuecomment-1501410332
Hi Alonexc,
is it available ?
if yes could you assign it to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
[GitHub] [eventmesh] Alonexc commented on issue #3397: [Enhancement] Make field a static final constant or non-public
Posted by "Alonexc (via GitHub)" <gi...@apache.org>.
Alonexc commented on issue #3397:
URL: https://github.com/apache/eventmesh/issues/3397#issuecomment-1504839346
@garimellasrisudha It has been commented under the pr you submitted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
[GitHub] [eventmesh] garimellasrisudha commented on issue #3397: [Enhancement] Make field a static final constant or non-public
Posted by "garimellasrisudha (via GitHub)" <gi...@apache.org>.
garimellasrisudha commented on issue #3397:
URL: https://github.com/apache/eventmesh/issues/3397#issuecomment-1502834270
thank you Alonexc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
[GitHub] [eventmesh] Alonexc commented on issue #3397: [Enhancement] Make field a static final constant or non-public
Posted by "Alonexc (via GitHub)" <gi...@apache.org>.
Alonexc commented on issue #3397:
URL: https://github.com/apache/eventmesh/issues/3397#issuecomment-1501484670
@garimellasrisudha Of course, you can submit a pr first, welcome to the eventmesh community.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
[GitHub] [eventmesh] garimellasrisudha commented on issue #3397: [Enhancement] Make field a static final constant or non-public
Posted by "garimellasrisudha (via GitHub)" <gi...@apache.org>.
garimellasrisudha commented on issue #3397:
URL: https://github.com/apache/eventmesh/issues/3397#issuecomment-1509734247
Hi Alonexc ,
Made remaining fields also final ,Could you review and let me know.
Apart from that i tried linking the issue with pull request but, I guess this story i not assigned to me, that's why i am unable to link .
https://github.com/apache/eventmesh/pull/3738
Thanks sudha
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org