You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ms...@apache.org on 2018/02/21 17:02:00 UTC
svn commit: r1824988 - in
/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdfparser:
BaseParser.java COSParser.java
Author: msahyoun
Date: Wed Feb 21 17:02:00 2018
New Revision: 1824988
URL: http://svn.apache.org/viewvc?rev=1824988&view=rev
Log:
PDFBOX-4118: retain exception in log message; use LOG.debug for ignored exceptions
Modified:
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdfparser/BaseParser.java
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdfparser/COSParser.java
Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdfparser/BaseParser.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdfparser/BaseParser.java?rev=1824988&r1=1824987&r2=1824988&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdfparser/BaseParser.java (original)
+++ pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdfparser/BaseParser.java Wed Feb 21 17:02:00 2018
@@ -784,6 +784,7 @@ public abstract class BaseParser
}
catch (CharacterCodingException e)
{
+ LOG.debug("Character could not be decoded using Charsets.UTF_8 - returning false", e);
return false;
}
}
Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdfparser/COSParser.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdfparser/COSParser.java?rev=1824988&r1=1824987&r2=1824988&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdfparser/COSParser.java (original)
+++ pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdfparser/COSParser.java Wed Feb 21 17:02:00 2018
@@ -1312,6 +1312,7 @@ public class COSParser extends BaseParse
catch (IOException exception)
{
// there wasn't an object of a xref stream
+ LOG.debug("No Xref stream at given location " + startXRefOffset, exception);
source.seek(startXRefOffset);
}
}
@@ -1425,6 +1426,7 @@ public class COSParser extends BaseParse
catch (IOException exception)
{
// Swallow the exception, obviously there isn't any valid object number
+ LOG.debug("No valid object at given location " + offset + " - ignoring", exception);
}
finally
{
@@ -1670,6 +1672,7 @@ public class COSParser extends BaseParse
}
catch (IOException exception)
{
+ LOG.debug("An exception occured during brute force search for trailer - ignoring", exception);
continue;
}
}
@@ -1783,6 +1786,7 @@ public class COSParser extends BaseParse
catch (IOException exception)
{
// save the EOF marker as the following data is most likely some garbage
+ LOG.debug("An exception occured during brute force for last EOF - ignoring", exception);
lastEOFMarker = tempMarker;
}
}
@@ -1914,7 +1918,7 @@ public class COSParser extends BaseParse
catch (IOException exception)
{
LOG.debug(
- "Skipped corrupt stream: (" + stmObjNumber + " 0 at offset " + offset);
+ "Skipped corrupt stream: (" + stmObjNumber + " 0 at offset " + offset, exception);
continue;
}
finally
@@ -2173,7 +2177,7 @@ public class COSParser extends BaseParse
}
catch (IOException exception)
{
- LOG.debug("Skipped object " + key + ", either it's corrupt or not a dictionary");
+ LOG.debug("Skipped object " + key + ", either it's corrupt or not a dictionary", exception);
}
}
return dictionary;