[GitHub] [kafka] ijuma commented on a change in pull request #10471: KAFKA-12597: remove deprecated zookeeper option in ReassignPartitionsCommand

[GitBox <gi...@apache.org>]

ijuma commented on a change in pull request #10471:
URL: https://github.com/apache/kafka/pull/10471#discussion_r643139325



##########
File path: core/src/test/scala/integration/kafka/admin/ReassignPartitionsIntegrationTest.scala
##########
@@ -151,7 +148,7 @@ class ReassignPartitionsIntegrationTest extends ZooKeeperTestHarness {
       """{"topic":"bar","partition":0,"replicas":[3,2,0],"log_dirs":["any","any","any"]}""" +
       """]}"""
     // Execute the assignment
-    runExecuteAssignment(zkClient, assignment, -1L)
+    runExecuteAssignment(cluster.adminClient, false, assignment, -1L, -1L)

Review comment:
       Looks like the test name doesn't match what we're testing now.

##########
File path: core/src/test/scala/integration/kafka/admin/ReassignPartitionsIntegrationTest.scala
##########
@@ -128,11 +126,10 @@ class ReassignPartitionsIntegrationTest extends ZooKeeperTestHarness {
         PartitionReassignmentState(Seq(3, 2, 0), Seq(3, 2, 0), true)
     )
 
-    // When using --zookeeper, we aren't able to see the new-style assignment

Review comment:
       Since we are removing this comment, should we be using new style assignment?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org