You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2021/01/23 14:49:15 UTC

[GitHub] [fineract] vorburger commented on a change in pull request #1584: Add init-container to check MYSQL server deployment (FINERACT-1300)

vorburger commented on a change in pull request #1584:
URL: https://github.com/apache/fineract/pull/1584#discussion_r563161178



##########
File path: kubernetes/fineractmysql-deployment.yml
##########
@@ -96,11 +96,7 @@ spec:
                   key: password
           livenessProbe:
             exec:
-              command:
-                - mysqladmin
-                - ping
-                - -h
-                - localhost
+              command: ["sh","-c","mysqladmin ping -h localhost -uroot -p${MYSQL_ROOT_PASSWORD}"]

Review comment:
       NB this change here was already in #1583 (for FINERACT-1294), so this diff should disappear on a rebase.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org