You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@trafodion.apache.org by su...@apache.org on 2017/02/02 17:45:39 UTC
[1/3] incubator-trafodion git commit: [TRAFODION-2470] Fixed one
cause of 6004 warnings
Repository: incubator-trafodion
Updated Branches:
refs/heads/master 0de966049 -> 905620c9e
[TRAFODION-2470] Fixed one cause of 6004 warnings
Project: http://git-wip-us.apache.org/repos/asf/incubator-trafodion/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-trafodion/commit/24e93d85
Tree: http://git-wip-us.apache.org/repos/asf/incubator-trafodion/tree/24e93d85
Diff: http://git-wip-us.apache.org/repos/asf/incubator-trafodion/diff/24e93d85
Branch: refs/heads/master
Commit: 24e93d859ccd03b9a1892aef2e63bf7606f39675
Parents: 06d26c4
Author: Dave Birdsall <db...@apache.org>
Authored: Thu Feb 2 00:47:55 2017 +0000
Committer: Dave Birdsall <db...@apache.org>
Committed: Thu Feb 2 00:47:55 2017 +0000
----------------------------------------------------------------------
core/sql/parser/SqlParserAux.cpp | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-trafodion/blob/24e93d85/core/sql/parser/SqlParserAux.cpp
----------------------------------------------------------------------
diff --git a/core/sql/parser/SqlParserAux.cpp b/core/sql/parser/SqlParserAux.cpp
index 922a144..b61bd30 100644
--- a/core/sql/parser/SqlParserAux.cpp
+++ b/core/sql/parser/SqlParserAux.cpp
@@ -863,8 +863,7 @@ ItemExpr *literalOfNumericPassingScale(NAString *strptr, char sign,
} else if (strSize <= 19) {
datatype = (createSignedDatatype ? REC_BIN64_SIGNED : REC_BIN64_UNSIGNED);
length = sizeof(Int64);
- } else if (strSize == 20) {
- createSignedDatatype = FALSE;
+ } else if ((strSize == 20) && (!createSignedDatatype)) {
datatype = REC_BIN64_UNSIGNED;
length = sizeof(Int64);
}
[3/3] incubator-trafodion git commit: Merge [TRAFODION-2470] PR-943
Fixed one cause of 6004 warnings
Posted by su...@apache.org.
Merge [TRAFODION-2470] PR-943 Fixed one cause of 6004 warnings
Project: http://git-wip-us.apache.org/repos/asf/incubator-trafodion/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-trafodion/commit/905620c9
Tree: http://git-wip-us.apache.org/repos/asf/incubator-trafodion/tree/905620c9
Diff: http://git-wip-us.apache.org/repos/asf/incubator-trafodion/diff/905620c9
Branch: refs/heads/master
Commit: 905620c9ecf24a0979e25100908aaccaef80f9c0
Parents: 0de9660 bd8b308
Author: Suresh Subbiah <su...@apache.org>
Authored: Thu Feb 2 17:45:06 2017 +0000
Committer: Suresh Subbiah <su...@apache.org>
Committed: Thu Feb 2 17:45:06 2017 +0000
----------------------------------------------------------------------
core/sql/parser/SqlParserAux.cpp | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
----------------------------------------------------------------------
[2/3] incubator-trafodion git commit: Rework based on Hans' comment
Posted by su...@apache.org.
Rework based on Hans' comment
Project: http://git-wip-us.apache.org/repos/asf/incubator-trafodion/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-trafodion/commit/bd8b3080
Tree: http://git-wip-us.apache.org/repos/asf/incubator-trafodion/tree/bd8b3080
Diff: http://git-wip-us.apache.org/repos/asf/incubator-trafodion/diff/bd8b3080
Branch: refs/heads/master
Commit: bd8b30803fb33f5714b4e496dfe47c838160cfa6
Parents: 24e93d8
Author: Dave Birdsall <db...@apache.org>
Authored: Thu Feb 2 17:03:28 2017 +0000
Committer: Dave Birdsall <db...@apache.org>
Committed: Thu Feb 2 17:03:28 2017 +0000
----------------------------------------------------------------------
core/sql/parser/SqlParserAux.cpp | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-trafodion/blob/bd8b3080/core/sql/parser/SqlParserAux.cpp
----------------------------------------------------------------------
diff --git a/core/sql/parser/SqlParserAux.cpp b/core/sql/parser/SqlParserAux.cpp
index b61bd30..1be2f05 100644
--- a/core/sql/parser/SqlParserAux.cpp
+++ b/core/sql/parser/SqlParserAux.cpp
@@ -847,6 +847,8 @@ ItemExpr *literalOfNumericPassingScale(NAString *strptr, char sign,
NABoolean createTinyLiteral =
((CmpCommon::getDefault(TRAF_CREATE_TINYINT_LITERAL)) == DF_ON);
+ NABoolean createLargeintUnsignedLiteral =
+ ((CmpCommon::getDefault(TRAF_LARGEINT_UNSIGNED_IO)) == DF_ON);
char numericVal[8];
short datatype = -1;
@@ -861,9 +863,9 @@ ItemExpr *literalOfNumericPassingScale(NAString *strptr, char sign,
datatype = (createSignedDatatype ? REC_BIN32_SIGNED : REC_BIN32_UNSIGNED);
length = sizeof(Lng32);
} else if (strSize <= 19) {
- datatype = (createSignedDatatype ? REC_BIN64_SIGNED : REC_BIN64_UNSIGNED);
+ datatype = (createSignedDatatype || !createLargeintUnsignedLiteral ? REC_BIN64_SIGNED : REC_BIN64_UNSIGNED);
length = sizeof(Int64);
- } else if ((strSize == 20) && (!createSignedDatatype)) {
+ } else if ((strSize == 20) && (!createSignedDatatype) && (createLargeintUnsignedLiteral)) {
datatype = REC_BIN64_UNSIGNED;
length = sizeof(Int64);
}