You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/07/20 05:57:09 UTC
[GitHub] [pulsar] aahmed-se opened a new pull request #7603: Gihub CI EXP
aahmed-se opened a new pull request #7603:
URL: https://github.com/apache/pulsar/pull/7603
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] merlimat merged pull request #7603: Migrate github actions to use container images
Posted by GitBox <gi...@apache.org>.
merlimat merged pull request #7603:
URL: https://github.com/apache/pulsar/pull/7603
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] merlimat commented on a change in pull request #7603: Migrate github actions to use container images
Posted by GitBox <gi...@apache.org>.
merlimat commented on a change in pull request #7603:
URL: https://github.com/apache/pulsar/pull/7603#discussion_r458832948
##########
File path: .github/workflows/ci-unit-broker-broker-gp1.yaml
##########
@@ -40,39 +42,11 @@ jobs:
fetch-depth: 0
ref: ${{ github.event.pull_request.head.sha }}
- - name: Cache local Maven repository
Review comment:
Why removing cache? We can still use it to cache maven deps
##########
File path: .github/workflows/ci-unit-broker-broker-gp1.yaml
##########
@@ -40,39 +42,11 @@ jobs:
fetch-depth: 0
ref: ${{ github.event.pull_request.head.sha }}
- - name: Cache local Maven repository
- uses: actions/cache@v2
- with:
- path: ~/.m2/repository
- key: ${{ runner.os }}-maven-${{ hashFiles('**/pom.xml') }}
- restore-keys: |
- ${{ runner.os }}-maven-
-
- - name: Check if this pull request only changes documentation
- id: docs
- uses: apache/pulsar-test-infra/diff-only@master
- with:
- args: site2 .github deployment .asf.yaml .ci ct.yaml
-
- - name: Set up JDK 1.8
- uses: actions/setup-java@v1
- if: steps.docs.outputs.changed_only == 'no'
- with:
- java-version: 1.8
-
- - name: Set up Maven
- uses: apache/pulsar-test-infra/setup-maven@master
- if: steps.docs.outputs.changed_only == 'no'
- with:
- maven-version: 3.6.1
-
- - name: run unit tests install by skip tests
- if: steps.docs.outputs.changed_only == 'no'
- run: mvn clean install -DskipTests -pl pulsar-broker-auth-sasl -am
-
- - name: run unit tests pulsar auth sasl
- if: steps.docs.outputs.changed_only == 'no'
- run: mvn test -DfailIfNoTests=false -pl pulsar-broker-auth-sasl
+ - name: run unit tests for pulsar-broker
+ run: |
+ mvn -B -q -ntp install -pl pulsar-broker -am -DskipTests
Review comment:
This would be fetching snapshot dependencies for other modules and it will fail to compile whenever a commit is also touching more than just `pulsar-broker`. Rather why not just do install with `-Pcore-modules`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] merlimat commented on a change in pull request #7603: (WIP) Gihub CI EXP
Posted by GitBox <gi...@apache.org>.
merlimat commented on a change in pull request #7603:
URL: https://github.com/apache/pulsar/pull/7603#discussion_r458329477
##########
File path: .github/workflows/ci-license.yaml
##########
@@ -40,27 +42,7 @@ jobs:
fetch-depth: 0
ref: ${{ github.event.pull_request.head.sha }}
- - name: Cache local Maven repository
- uses: actions/cache@v2
- with:
- path: ~/.m2/repository
- key: ${{ runner.os }}-maven-${{ hashFiles('**/pom.xml') }}
- restore-keys: |
- ${{ runner.os }}-maven-
-
- - name: Set up JDK 1.8
- uses: actions/setup-java@v1
- with:
- java-version: 1.8
-
- # license check fails with 3.6.2 so we have to downgrade
- - name: Set up Maven
- uses: apache/pulsar-test-infra/setup-maven@master
- with:
- maven-version: 3.6.1
-
- - name: build and check license
- run: mvn -B -ntp -DskipTests license:check install
-
- name: license check
- run: src/check-binary-license ./distribution/server/target/apache-pulsar-*-bin.tar.gz
+ run: |
+ mvn -B -ntp license:check install -DskipTests
Review comment:
-Pcore-modules
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aahmed-se commented on a change in pull request #7603: (WIP) Gihub CI EXP
Posted by GitBox <gi...@apache.org>.
aahmed-se commented on a change in pull request #7603:
URL: https://github.com/apache/pulsar/pull/7603#discussion_r458462533
##########
File path: .github/workflows/ci-license.yaml
##########
@@ -40,27 +42,7 @@ jobs:
fetch-depth: 0
ref: ${{ github.event.pull_request.head.sha }}
- - name: Cache local Maven repository
- uses: actions/cache@v2
- with:
- path: ~/.m2/repository
- key: ${{ runner.os }}-maven-${{ hashFiles('**/pom.xml') }}
- restore-keys: |
- ${{ runner.os }}-maven-
-
- - name: Set up JDK 1.8
- uses: actions/setup-java@v1
- with:
- java-version: 1.8
-
- # license check fails with 3.6.2 so we have to downgrade
- - name: Set up Maven
- uses: apache/pulsar-test-infra/setup-maven@master
- with:
- maven-version: 3.6.1
-
- - name: build and check license
- run: mvn -B -ntp -DskipTests license:check install
-
- name: license check
- run: src/check-binary-license ./distribution/server/target/apache-pulsar-*-bin.tar.gz
+ run: |
+ mvn -B -ntp license:check install -DskipTests
Review comment:
license check applies to all modules so we can't filter
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org