You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/01/25 06:20:51 UTC

[GitHub] [kafka] dengziming commented on pull request #11677: KAFKA-13410 Add KRaft metadata.version for KIP-778

dengziming commented on pull request #11677:
URL: https://github.com/apache/kafka/pull/11677#issuecomment-1020850019


   I have some questions concerning the `VersionRange` entity. In zk-related classes we use FinalizedVersionRange and SupportedVersionRange whereas in kraft-related code we use VersionRange, when I tried to covert UpdateFeatureTest to support kraft based on this PR, I found it's very fuzzy since the constructors of `FinalizedVersionRange` and `SupportedVersionRange` is complicated.
   So can we use a unified class and remove others to make it more simple, for example, use `VersionRange` to denote`SupportedVersionRange` and use a short to denote `FinalizedVersionRange`.
   I'm not sure whether this is viable,  @cmccabe @kowshik , what's your opinion?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org