You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jmeter.apache.org by "ttaolu (via GitHub)" <gi...@apache.org> on 2023/03/22 08:11:03 UTC
[GitHub] [jmeter] ttaolu opened a new pull request, #5795: charset use getter for TcpClientImpl
ttaolu opened a new pull request, #5795:
URL: https://github.com/apache/jmeter/pull/5795
in one test plan several sampler's charset can change by pre-processors in groovy:
if(sampler.firstSample) {
sampler.initSampling()
sampler.firstSample = false
}
sampler.protocolHandler.charset = samplerSpecificCharset // by sampler.name
## Description
<!--- Provide a general summary of your changes in the Title above -->
<!--- Describe your changes in detail here -->
## Motivation and Context
<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->
## How Has This Been Tested?
<!--- Please describe in detail how you tested your changes. -->
<!--- Include details of your testing environment, tests ran to see how -->
<!--- your change affects other areas of the code, etc. -->
## Screenshots (if appropriate):
## Types of changes
<!--- What types of changes does your code introduce? Delete as appropriate -->
- Bug fix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)
- Breaking change (fix or feature that would cause existing functionality to not work as expected)
## Checklist:
<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->
<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->
- [ ] My code follows the [code style][style-guide] of this project.
- [ ] I have updated the documentation accordingly.
[style-guide]: https://wiki.apache.org/jmeter/CodeStyleGuidelines
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jmeter] FSchumacher commented on pull request #5795: charset use getter for TcpClientImpl
Posted by "FSchumacher (via GitHub)" <gi...@apache.org>.
FSchumacher commented on PR #5795:
URL: https://github.com/apache/jmeter/pull/5795#issuecomment-1483815019
I am not sure, what you really want here.
What do you want to achieve?
Why?
(As a plus)
What have you tried so far?
What should have happened?
What happened?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jmeter] vlsi commented on pull request #5795: Dynamic charset for TcpSampler
Posted by "vlsi (via GitHub)" <gi...@apache.org>.
vlsi commented on PR #5795:
URL: https://github.com/apache/jmeter/pull/5795#issuecomment-1594426571
Here's the build failure message:
```
Execution failed for task ':src:protocol:tcp:autostyleJavaCheck'.
> The following files have format violations:
src/main/java/org/apache/jmeter/protocol/tcp/sampler/TCPClientImpl.java
@@ -24,7 +24,6 @@
import java.io.UnsupportedEncodingException;
import java.nio.charset.Charset;
-import org.apache.commons.lang3.StringUtils;
import org.apache.jmeter.samplers.SampleResult;
import org.apache.jmeter.util.JMeterUtils;
import org.slf4j.Logger;
You might want to adjust -PmaxCheckMessageLines=50
-PmaxFilesToList=10
-PminLinesPerFile=4
to see more violations
Run './gradlew autostyleApply' to fix the violations.
```
It basically says you have an unused import which we would like to remove.
If you execute `./gradlew autostyleApply`, it would apply the relevant changes.
At the same time, it would be great if you could rebase your branch on top of a more recent master branch since CI and testing has been improved recently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jmeter] ttaolu commented on pull request #5795: Dynamic charset for TcpSampler
Posted by "ttaolu (via GitHub)" <gi...@apache.org>.
ttaolu commented on PR #5795:
URL: https://github.com/apache/jmeter/pull/5795#issuecomment-1488132857
Why CI / Windows (JDK 17) (pull_request) Failing ?
- macOS
- Windows
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jmeter] FSchumacher commented on pull request #5795: charset use getter for TcpClientImpl
Posted by "FSchumacher (via GitHub)" <gi...@apache.org>.
FSchumacher commented on PR #5795:
URL: https://github.com/apache/jmeter/pull/5795#issuecomment-1483871869
Did you close the PR on purpose?
Reading the code, I assume, that you want to make the used charset in tcp sampler configurable at runtime instead of start time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jmeter] ttaolu closed pull request #5795: charset use getter for TcpClientImpl
Posted by "ttaolu (via GitHub)" <gi...@apache.org>.
ttaolu closed pull request #5795: charset use getter for TcpClientImpl
URL: https://github.com/apache/jmeter/pull/5795
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jmeter] ttaolu commented on pull request #5795: charset use getter for TcpClientImpl
Posted by "ttaolu (via GitHub)" <gi...@apache.org>.
ttaolu commented on PR #5795:
URL: https://github.com/apache/jmeter/pull/5795#issuecomment-1484031241
Yes, it is expected that the charset can be dynamically adjusted instead of being determined at the beginning of the run,
the code has not been run or tested, may not be suitable for PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org