You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "wangyum (via GitHub)" <gi...@apache.org> on 2023/05/29 06:03:35 UTC
[GitHub] [spark] wangyum opened a new pull request, #41359: [SPARK-43859][SQL] Override toString in LateralColumnAliasReference
wangyum opened a new pull request, #41359:
URL: https://github.com/apache/spark/pull/41359
### What changes were proposed in this pull request?
This PR makes it override `toString` in `LateralColumnAliasReference`.
### Why are the changes needed?
Improve the readability of logical plans.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Manual test:
```sql
select id + 1 as a1, a1 + 2 as a3 from range(10);
```
Before this PR:
```
Project [(id#2L + 1) AS a1#0, (lateralAliasReference('a1, a1, 'a1) + 2) AS a3#1]
+- Range (0, 10, step=1, splits=None)
```
After this PR:
```
Project [(id#2L + 1) AS a1#0, (lateralAliasReference(a1) + 2) AS a3#1]
+- Range (0, 10, step=1, splits=None)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum commented on pull request #41359: [SPARK-43859][SQL] Override toString in LateralColumnAliasReference
Posted by "wangyum (via GitHub)" <gi...@apache.org>.
wangyum commented on PR #41359:
URL: https://github.com/apache/spark/pull/41359#issuecomment-1567675631
@anchovYu @cloud-fan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum commented on pull request #41359: [SPARK-43859][SQL] Override toString in LateralColumnAliasReference
Posted by "wangyum (via GitHub)" <gi...@apache.org>.
wangyum commented on PR #41359:
URL: https://github.com/apache/spark/pull/41359#issuecomment-1569508593
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum closed pull request #41359: [SPARK-43859][SQL] Override toString in LateralColumnAliasReference
Posted by "wangyum (via GitHub)" <gi...@apache.org>.
wangyum closed pull request #41359: [SPARK-43859][SQL] Override toString in LateralColumnAliasReference
URL: https://github.com/apache/spark/pull/41359
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org