[GitHub] [spark] gengliangwang commented on a diff in pull request #39139: [WIP][SPARK-41431][CORE][SQL][UI] Protobuf serializer for SQLExecutionUIData

[GitBox <gi...@apache.org>]

gengliangwang commented on code in PR #39139:
URL: https://github.com/apache/spark/pull/39139#discussion_r1055268951


##########
core/src/main/protobuf/org/apache/spark/status/protobuf/store_types.proto:
##########
@@ -239,4 +239,25 @@ message RDDStorageInfo {
 
 message RDDStorageInfoWrapper {
   RDDStorageInfo info = 1;
-}
\ No newline at end of file
+}
+
+message SQLPlanMetric {

Review Comment:
   It is ok to define it in `core` module. There is "SQL" concept in core module anyway. 
   Can we skip shading protobuf in SQL module in this way?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org