You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Mike Percy (Code Review)" <ge...@cloudera.org> on 2016/12/11 16:37:51 UTC
[kudu-CR] push to asf.py: Use check output() from kudu util
Hello Jean-Daniel Cryans,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/5469
to review the following change.
Change subject: push_to_asf.py: Use check_output() from kudu_util
......................................................................
push_to_asf.py: Use check_output() from kudu_util
This makes the script compatible with older versions of python again.
Change-Id: I75570c408f63bc5a0a4023e9d50b888c43eca16e
---
M build-support/push_to_asf.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/69/5469/1
--
To view, visit http://gerrit.cloudera.org:8080/5469
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I75570c408f63bc5a0a4023e9d50b888c43eca16e
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
[kudu-CR] push to asf.py: Use check output() from kudu util
Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has posted comments on this change.
Change subject: push_to_asf.py: Use check_output() from kudu_util
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5469
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I75570c408f63bc5a0a4023e9d50b888c43eca16e
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] push to asf.py: Use check output() from kudu util
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has submitted this change and it was merged.
Change subject: push_to_asf.py: Use check_output() from kudu_util
......................................................................
push_to_asf.py: Use check_output() from kudu_util
This makes the script compatible with older versions of python again.
Change-Id: I75570c408f63bc5a0a4023e9d50b888c43eca16e
Reviewed-on: http://gerrit.cloudera.org:8080/5469
Reviewed-by: Jean-Daniel Cryans <jd...@apache.org>
Tested-by: Kudu Jenkins
---
M build-support/push_to_asf.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jean-Daniel Cryans: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/5469
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I75570c408f63bc5a0a4023e9d50b888c43eca16e
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>