You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "CRZbulabula (via GitHub)" <gi...@apache.org> on 2025/06/23 05:21:44 UTC
[PR] [AINode] Update the class fields of IoTDB dataset [iotdb]
CRZbulabula opened a new pull request, #15799:
URL: https://github.com/apache/iotdb/pull/15799
The `seq_len`, `input_token_len` and `output_token_len` are required by each model, hence we clear up the class fields of dataset in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [AINode] Update the class fields of IoTDB dataset [iotdb]
Posted by "ycycse (via GitHub)" <gi...@apache.org>.
ycycse commented on code in PR #15799:
URL: https://github.com/apache/iotdb/pull/15799#discussion_r2163578820
##########
iotdb-core/ainode/ainode/core/ingress/iotdb.py:
##########
@@ -84,9 +84,9 @@ def __init__(
zone_id=time_zone,
)
self.session.open(False)
+ self.use_rate = use_rate
+ self.offset_rate = offset_rate
Review Comment:
I think these two names are ambiguous.
* If we only define the training set by its size, how can we get the validation set, considering the DataLoader shuffles the indices randomly.
* And why we need randow offset in one window, we already get the window randomly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [AINode] Update the class fields of IoTDB dataset [iotdb]
Posted by "CRZbulabula (via GitHub)" <gi...@apache.org>.
CRZbulabula commented on code in PR #15799:
URL: https://github.com/apache/iotdb/pull/15799#discussion_r2165807234
##########
iotdb-core/ainode/ainode/core/ingress/iotdb.py:
##########
@@ -84,9 +84,9 @@ def __init__(
zone_id=time_zone,
)
self.session.open(False)
+ self.use_rate = use_rate
+ self.offset_rate = offset_rate
Review Comment:
I agree with ur opportunity, yet my implementation is the easiest way, let's endure this bad code for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [AINode] Update the class fields of IoTDB dataset [iotdb]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #15799:
URL: https://github.com/apache/iotdb/pull/15799#issuecomment-3003381649
## [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=15799) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=15799&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=15799&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_iotdb&pullRequest=15799&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=15799&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=15799&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=15799)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [AINode] Update the class fields of IoTDB dataset [iotdb]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #15799:
URL: https://github.com/apache/iotdb/pull/15799#issuecomment-2995074566
## [Codecov](https://app.codecov.io/gh/apache/iotdb/pull/15799?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 39.13%. Comparing base [(`f706aac`)](https://app.codecov.io/gh/apache/iotdb/commit/f706aacccafa8c47877d9397a0db37b814defd79?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`724dae5`)](https://app.codecov.io/gh/apache/iotdb/commit/724dae53b008702e9ea9f44a9e1645eed6bc0476?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 3 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #15799 +/- ##
============================================
+ Coverage 39.12% 39.13% +0.01%
Complexity 198 198
============================================
Files 4837 4837
Lines 314559 314559
Branches 39477 39477
============================================
+ Hits 123068 123114 +46
+ Misses 191491 191445 -46
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/iotdb/pull/15799?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [AINode] Update the class fields of IoTDB dataset [iotdb]
Posted by "CRZbulabula (via GitHub)" <gi...@apache.org>.
CRZbulabula commented on code in PR #15799:
URL: https://github.com/apache/iotdb/pull/15799#discussion_r2162872075
##########
iotdb-core/ainode/ainode/core/ingress/iotdb.py:
##########
@@ -56,18 +56,19 @@ class IoTDBTreeModelDataset(BasicDatabaseForecastDataset):
def __init__(
self,
model_id: str,
- input_len: int,
- out_len: int,
+ seq_len: int,
+ input_token_len: int,
+ output_token_len: int,
data_schema_list: list,
ip: str = "127.0.0.1",
port: int = 6667,
username: str = "root",
password: str = "root",
time_zone: str = "UTC+8",
- start_split: float = 0,
- end_split: float = 1,
+ # start_split: float = 0,
+ # end_split: float = 1.0,
Review Comment:
These parameters are inconvinient, thus I refactor the input of this class, PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [AINode] Update the class fields of IoTDB dataset [iotdb]
Posted by "CRZbulabula (via GitHub)" <gi...@apache.org>.
CRZbulabula merged PR #15799:
URL: https://github.com/apache/iotdb/pull/15799
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [AINode] Update the class fields of IoTDB dataset [iotdb]
Posted by "ycycse (via GitHub)" <gi...@apache.org>.
ycycse commented on code in PR #15799:
URL: https://github.com/apache/iotdb/pull/15799#discussion_r2160969072
##########
iotdb-core/ainode/ainode/core/ingress/iotdb.py:
##########
@@ -56,18 +56,19 @@ class IoTDBTreeModelDataset(BasicDatabaseForecastDataset):
def __init__(
self,
model_id: str,
- input_len: int,
- out_len: int,
+ seq_len: int,
+ input_token_len: int,
+ output_token_len: int,
data_schema_list: list,
ip: str = "127.0.0.1",
port: int = 6667,
username: str = "root",
password: str = "root",
time_zone: str = "UTC+8",
- start_split: float = 0,
- end_split: float = 1,
+ # start_split: float = 0,
+ # end_split: float = 1.0,
Review Comment:
I think we could just remove this. Data split in the future can be implemented by a more general way(like sampler)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [AINode] Update the class fields of IoTDB dataset [iotdb]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #15799:
URL: https://github.com/apache/iotdb/pull/15799#issuecomment-2994975458
## [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=15799) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=15799&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=15799&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_iotdb&pullRequest=15799&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=15799&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=15799&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=15799)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [AINode] Update the class fields of IoTDB dataset [iotdb]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #15799:
URL: https://github.com/apache/iotdb/pull/15799#issuecomment-2998654298
## [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=15799) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=15799&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=15799&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_iotdb&pullRequest=15799&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=15799&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=15799&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=15799)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org