[GitHub] [incubator-openwhisk] rabbah commented on a change in pull request #4450: Fix test cases to also work with nodejs:10 as default nodejs runtime.

[GitBox <gi...@apache.org>]

rabbah commented on a change in pull request #4450: Fix test cases to also work with nodejs:10 as default nodejs runtime.
URL: https://github.com/apache/incubator-openwhisk/pull/4450#discussion_r276208576
 
 

 ##########
 File path: tests/src/test/scala/invokerShoot/ShootInvokerTests.scala
 ##########
 @@ -172,6 +172,7 @@ class ShootInvokerTests extends TestHelpers with WskTestHelpers with JsHelpers w
 
   it should "add new parameters and annotations while copying an action" in withAssetCleaner(wskprops) {
     (wp, assetHelper) =>
+      val runtime = "nodejs:10"
 
 Review comment:
   just make this `nodejs:default` and we'll change the default in the runtimes.json.
   otherwise we'll be doing this again when node 10 goes out of style.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services