You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Jarek Cecho <ja...@apache.org> on 2013/05/08 04:00:06 UTC

Review Request: SQOOP-1036 Sqoop2: JobClient.getCounters can return NULL

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10995/
-----------------------------------------------------------

Review request for Sqoop.


Description
-------

I've added proper if(is null) statement.


This addresses bug SQOOP-1036.
    https://issues.apache.org/jira/browse/SQOOP-1036


Diffs
-----

  submission/mapreduce/src/main/java/org/apache/sqoop/submission/mapreduce/MapreduceSubmissionEngine.java 6607885ac609f49a0dd67440de64b6f18d4910f6 

Diff: https://reviews.apache.org/r/10995/diff/


Testing
-------

Unit and Integration tests seems to be passing.


Thanks,

Jarek Cecho


Re: Review Request: SQOOP-1036 Sqoop2: JobClient.getCounters can return NULL

Posted by Kathleen Ting <ka...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10995/#review20449
-----------------------------------------------------------

Ship it!


Ship It!

- Kathleen Ting


On May 8, 2013, 2 a.m., Jarek Cecho wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10995/
> -----------------------------------------------------------
> 
> (Updated May 8, 2013, 2 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Description
> -------
> 
> I've added proper if(is null) statement.
> 
> 
> This addresses bug SQOOP-1036.
>     https://issues.apache.org/jira/browse/SQOOP-1036
> 
> 
> Diffs
> -----
> 
>   submission/mapreduce/src/main/java/org/apache/sqoop/submission/mapreduce/MapreduceSubmissionEngine.java 6607885ac609f49a0dd67440de64b6f18d4910f6 
> 
> Diff: https://reviews.apache.org/r/10995/diff/
> 
> 
> Testing
> -------
> 
> Unit and Integration tests seems to be passing.
> 
> 
> Thanks,
> 
> Jarek Cecho
> 
>


Re: Review Request: SQOOP-1036 Sqoop2: JobClient.getCounters can return NULL

Posted by Hari Shreedharan <hs...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10995/#review20324
-----------------------------------------------------------

Ship it!


Ship It!

- Hari Shreedharan


On May 8, 2013, 2 a.m., Jarek Cecho wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10995/
> -----------------------------------------------------------
> 
> (Updated May 8, 2013, 2 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Description
> -------
> 
> I've added proper if(is null) statement.
> 
> 
> This addresses bug SQOOP-1036.
>     https://issues.apache.org/jira/browse/SQOOP-1036
> 
> 
> Diffs
> -----
> 
>   submission/mapreduce/src/main/java/org/apache/sqoop/submission/mapreduce/MapreduceSubmissionEngine.java 6607885ac609f49a0dd67440de64b6f18d4910f6 
> 
> Diff: https://reviews.apache.org/r/10995/diff/
> 
> 
> Testing
> -------
> 
> Unit and Integration tests seems to be passing.
> 
> 
> Thanks,
> 
> Jarek Cecho
> 
>