You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Bikramjeet Vig (Code Review)" <ge...@cloudera.org> on 2019/08/24 00:13:41 UTC

[Impala-ASF-CR] IMPALA-8858: Add observability of the query load on executor groups

Hello Andrew Sherman, Lars Volker, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/14103

to look at the new patch set (#4).

Change subject: IMPALA-8858: Add observability of the query load on executor groups
......................................................................

IMPALA-8858: Add observability of the query load on executor groups

With this patch, all healthy executor groups will have a metric added
that display the number of queries (admitted by the local coordinator)
running on them. The metric for a group is added when a it is healthy
and removed when its either not healthy or no longer exists. It gets
updated when either the cluster membership changes or a query gets
admitted or released by the admission controller.

Testing:
Added a custom cluster test and a BE metric test.

Change-Id: I58cde8699c33af8b87273437e9d8bf6371a34539
---
M be/src/scheduling/admission-controller.cc
M be/src/scheduling/admission-controller.h
M be/src/scheduling/cluster-membership-mgr.cc
M be/src/scheduling/cluster-membership-mgr.h
M be/src/util/metrics-test.cc
M be/src/util/metrics.h
M common/thrift/metrics.json
M tests/custom_cluster/test_executor_groups.py
8 files changed, 244 insertions(+), 29 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/03/14103/4
-- 
To view, visit http://gerrit.cloudera.org:8080/14103
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I58cde8699c33af8b87273437e9d8bf6371a34539
Gerrit-Change-Number: 14103
Gerrit-PatchSet: 4
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>